these are suggested artists for you. Can you relate?
2019-05-31 15155, 2019
pristine__
If you feel this is going in right dir, I will continue and write a detailed HTML .
2019-05-31 15111, 2019
rdswift
<ruaok> how do I go about selecting the artist_credit.name for ac1 ? I think you need to select the ac1 from a different instance of the artist_credit table, linked on the arr.artist_credit_1 value.
As you commented on api PR `You'll want to copy src/server/app.js and see what you need to keep in that file to have an express server running. You will also want to copy /routes.js and keep only your new endpoints.` Then how will we run the project, are you sure with this structure? LB has only one app file file and running at different server.
2019-05-31 15138, 2019
akhilesh
Mr_Monkey: ^
2019-05-31 15122, 2019
akhilesh
It may also requires changes in package.json
2019-05-31 15116, 2019
akhilesh
like introducing commands `start api-server`.
2019-05-31 15147, 2019
Mr_Monkey
We'll run adifferent command to run the API (something like `node lib/api/app.js` instead of `/server/app.js`) .
2019-05-31 15147, 2019
Mr_Monkey
You could try to create two different use cases in server/app.js, but I think it will me more complicated and less legible that way
2019-05-31 15125, 2019
Mr_Monkey
I think a simple change in package.json scripts to add something like `"start-api": "node ./lib/api/app.js"` would be sufficient
akhilesh: Are you sure `npm run build` doesn't still build the api files? `"build-server-js": "babel src --out-dir lib"` is one of the subtasks that are called, and should convert anything in src, including src/api
2019-05-31 15102, 2019
Mr_Monkey
And should export lib/src/api out the other end
2019-05-31 15119, 2019
akhilesh
ohh no, not tried until.
2019-05-31 15104, 2019
Mr_Monkey
Making the api a separate express server only changes how we run it (ie calling `node lib/src/api/app.js`, but does not change the rest of the workflow, build, configuration files, etc.
2019-05-31 15151, 2019
akhilesh
ok, I is working.
2019-05-31 15135, 2019
akhilesh
Mr_Monkey: Now if we run `npm run start-api` it works fine but changes are not reflecting in `lib` folder, is it require any more changes to build the project automatically ?
2019-05-31 15159, 2019
Mr_Monkey
akhilesh: the NPM docs say "Additionally, arbitrary scripts can be executed by running npm run-script <stage>. Pre and post commands with matching names will be run for those as well (e.g. premyscript, myscript, postmyscript)"
2019-05-31 15145, 2019
Mr_Monkey
So you should be able to create a `"prestart-api": "npm run build"` script
2019-05-31 15158, 2019
Mr_Monkey
akhilesh: Try that and see if it works
2019-05-31 15109, 2019
akhilesh
ok
2019-05-31 15117, 2019
Mr_Monkey
akhilesh: Actually, make it call "npm run prestart" instead.
2019-05-31 15149, 2019
akhilesh
Mr_Monkey: I made ` "start-api": "npm run build && cross-env SSR=true node ./lib/api/app.js",` it work, but it builds whole project.
2019-05-31 15129, 2019
akhilesh
in pack.json
2019-05-31 15142, 2019
akhilesh
and run `npm run start-api`
2019-05-31 15149, 2019
rdswift
ruaok, here is what I was thinking about to go along with your artist affinity by genre that you did with the common artists on VA albums. This is based on common artists played by users. https://gist.github.com/rdswift/6124f1db7c0633968…
2019-05-31 15105, 2019
Mr_Monkey
akhilesh: Yes, that's true. Well, you could make a ` "build-api-js": "babel src/api --out-dir lib"` script and make "prestart-api" run that
2019-05-31 15154, 2019
rdswift
It is pretty rough, but hopefully conveys the concept.
2019-05-31 15101, 2019
akhilesh
Mr_Monkey: thanks, It is working well.
2019-05-31 15130, 2019
Mr_Monkey
Great :)
2019-05-31 15139, 2019
Mr_Monkey
I think you'll also want to modify the build-server-js npm script to ignore src/api. Something like `"babel src --ignore src/api --out-dir lib"`
Then modify your Mocha Tests API launch option to call preLaunchTask "build-api-with-sourcemaps"
2019-05-31 15115, 2019
Mr_Monkey
akhilesh: Also you won't need the `"SSR":true` environment variable in Mocha Tests API, you can remove it
2019-05-31 15138, 2019
akhilesh
ok
2019-05-31 15133, 2019
reosarevok
Cyna: just searching for form_row_name_with_guesscase found it for me?
2019-05-31 15150, 2019
ZaphodBeeblebrox is now known as CatQuest
2019-05-31 15104, 2019
akhilesh
Mr_Monkey: when I run test on empty test_db first time, it works fine. Just after, on run the test again it is giving some insert related error, please see the logs, >
