0:26 AM
CatQuest
2019-06-16 16718, 2019
0:27 AM
CatQuest
(thing I could think of; haveing a medium with tracks and then *removing* them, but it still also works)
2019-06-16 16711, 2019
0:28 AM
SothoTalKer
removing tracks would be a destructive edit, no?
2019-06-16 16748, 2019
0:33 AM
CatQuest
aw man i hate that
2019-06-16 16756, 2019
0:33 AM
CatQuest
... but you're probably right
2019-06-16 16735, 2019
0:34 AM
SothoTalKer
you could remove all tracks and then tick the "unknown tracklist" checkbox, i guess
2019-06-16 16750, 2019
0:34 AM
SothoTalKer
i'm too dumb to login to test anyway :p
2019-06-16 16704, 2019
0:35 AM
CatQuest
just use "mb" aspassport
2019-06-16 16708, 2019
0:35 AM
CatQuest
erh word
2019-06-16 16717, 2019
0:35 AM
SothoTalKer
naughty
2019-06-16 16744, 2019
0:35 AM
CatQuest
all passwwords are reset to "mb" on test
2019-06-16 16754, 2019
0:35 AM
CatQuest
to aid testing
2019-06-16 16703, 2019
0:36 AM
CatQuest
it's not naughty
2019-06-16 16731, 2019
0:38 AM
D4RK-PH0ENiX has quit
2019-06-16 16707, 2019
0:39 AM
SothoTalKer
so yeah, it works :)
2019-06-16 16712, 2019
0:56 AM
D4RK-PH0ENiX joined the channel
2019-06-16 16731, 2019
3:02 AM
SothoTalKer
reosarevok: when is barcode and catalog numbers for mediums coming? ;)
2019-06-16 16714, 2019
6:16 AM
pristine__
2019-06-16 16734, 2019
6:16 AM
pristine__
ruaok: Can you relate?
2019-06-16 16748, 2019
6:16 AM
pristine__
I am pretty happy with my results :)
2019-06-16 16718, 2019
6:31 AM
zas
2019-06-16 16738, 2019
6:34 AM
zas
2019-06-16 16740, 2019
6:38 AM
zas
very high load (up to 40) happened between 13:50 and 16:00 UTC yesterday and 23:00 and 02:40 last night
2019-06-16 16750, 2019
8:17 AM
Cyna
2019-06-16 16758, 2019
8:33 AM
iliekcomputers
pristine__: the top artists, those are from collaborative filtering?
2019-06-16 16710, 2019
8:36 AM
pristine__
iliekcomputers: no
2019-06-16 16753, 2019
8:36 AM
pristine__
Just the top 20 artists of feb 19.
2019-06-16 16700, 2019
8:37 AM
iliekcomputers
Ah
2019-06-16 16702, 2019
8:38 AM
iliekcomputers
Do you plan to run it with the entire data, or is just a recent month intentional?
2019-06-16 16755, 2019
8:38 AM
iliekcomputers
Also, we have data for May in the cluster now too, I'd be more curious to run it on that.
2019-06-16 16733, 2019
8:46 AM
pristine__
There is no plan as now since we are not sure how often we will be training the model and generating recommendations.
2019-06-16 16700, 2019
8:47 AM
pristine__
I can run it with the data of month May and provide you with the results.
2019-06-16 16701, 2019
9:05 AM
Gazooo has quit
2019-06-16 16755, 2019
9:06 AM
Gazooo joined the channel
2019-06-16 16712, 2019
9:35 AM
reosarevok
SothoTalKer: thanks for volunteering!
2019-06-16 16707, 2019
10:00 AM
reosarevok
SothoTalKer: the report thing sounds reasonable, actually :)
2019-06-16 16711, 2019
10:00 AM
reosarevok
Thanks!
2019-06-16 16719, 2019
10:00 AM
reosarevok
The medium thing, thanks for volunteering :p
2019-06-16 16732, 2019
10:04 AM
flamingspinach has quit
2019-06-16 16733, 2019
10:15 AM
flamingspinach joined the channel
2019-06-16 16712, 2019
10:17 AM
pristine__
2019-06-16 16741, 2019
10:17 AM
pristine__
iliekcomputers: ^
2019-06-16 16751, 2019
10:17 AM
pristine__
for May.
2019-06-16 16714, 2019
10:34 AM
Freso
SothoTalKer reosarevok, I’d say the report should be in addition to, not instead of. Unless you’re making it so that you can no longer add entirely media‐less releases.
2019-06-16 16730, 2019
10:34 AM
reosarevok
Yeah, I thought in addition to :)
2019-06-16 16735, 2019
10:34 AM
reosarevok
But we should have one
2019-06-16 16701, 2019
10:35 AM
Freso
Yep.
2019-06-16 16719, 2019
10:35 AM
Freso
Did you ever look at my genre stat ticket?
2019-06-16 16741, 2019
10:35 AM
Freso
It’s still not linked to anything anyway.
2019-06-16 16705, 2019
10:36 AM
Lotheric
genre stat !!
2019-06-16 16709, 2019
10:36 AM
Lotheric
+1
2019-06-16 16711, 2019
10:36 AM
Lotheric
:)
2019-06-16 16720, 2019
10:36 AM
Lotheric
good idea
2019-06-16 16722, 2019
10:37 AM
Freso
2019-06-16 16723, 2019
10:37 AM
BrainzBot
MBS-10225: Add statistics for genre data
2019-06-16 16759, 2019
10:37 AM
Lotheric
voted
2019-06-16 16714, 2019
10:38 AM
Lotheric
I'm very curious to see stats on genres :)
2019-06-16 16746, 2019
10:39 AM
Freso
Yep. Me too.
2019-06-16 16707, 2019
10:41 AM
SothoTalKer
Freso, reosarevok: do we still need that option? I mean when it is implemented you can just tick both boxes "i don't know the medium type" & "i don't know the tracklist":
2019-06-16 16716, 2019
10:41 AM
SothoTalKer
2019-06-16 16757, 2019
10:41 AM
Freso
SothoTalKer: Seems better to leave it out entirely, esp. if you don’t know the amount of media.
2019-06-16 16724, 2019
10:42 AM
Freso
If you claim that a release has 1 medium though you don’t know the type or tracklist of, but it really has 4 media…
2019-06-16 16729, 2019
10:44 AM
SothoTalKer
the checkbox should probably be renamed then, that also the mediums are unknown "The tracklist for this release is currently unknown."
2019-06-16 16759, 2019
10:45 AM
SothoTalKer
like "mediums & tracklist are unknown"
2019-06-16 16714, 2019
10:46 AM
yvanzo
zas: found unusual entries in mb ws logs.
2019-06-16 16727, 2019
10:46 AM
SothoTalKer
(i hope it's not me)
2019-06-16 16721, 2019
10:49 AM
ruaok
yvanzo: zas is busy today. what sorts of weird entries?
2019-06-16 16744, 2019
10:50 AM
yvanzo
ruaok: yup, just replied to him about debug progress :)
2019-06-16 16759, 2019
10:53 AM
yvanzo
2019-06-16 16709, 2019
11:00 AM
reosarevok
SothoTalKer: that's a fair point, could change it to something like "We have no information about this release's media and tracklist"
2019-06-16 16715, 2019
11:00 AM
reosarevok
Freso: what do you think? :)
2019-06-16 16736, 2019
11:15 AM
D4RK-PH0ENiX has quit
2019-06-16 16710, 2019
11:17 AM
yvanzo
Cyna: 'state' should probably not be part of 'Props' in FormRowNameWithGuessCase.js
2019-06-16 16746, 2019
11:17 AM
yvanzo
See root/static/scripts/account/components/EditProfileForm.js for example
2019-06-16 16727, 2019
11:30 AM
D4RK-PH0ENiX joined the channel
2019-06-16 16746, 2019
11:32 AM
BrainzGit
2019-06-16 16747, 2019
11:32 AM
BrainzBot
2019-06-16 16736, 2019
11:34 AM
D4RK-PH0ENiX has quit
2019-06-16 16756, 2019
11:37 AM
D4RK-PH0ENiX joined the channel
2019-06-16 16729, 2019
11:40 AM
Cyna
if I want to have the input field value change, I have to pass in state
2019-06-16 16759, 2019
11:42 AM
Cyna
I'm using hooks withs const so the only way I can get the state is by passing it through props
2019-06-16 16709, 2019
11:50 AM
SothoTalKer
reosarevok: good enough for me, i guess :)
2019-06-16 16737, 2019
12:04 PM
yvanzo
CatQuest: found 2 typos: 'saluang' and 'violin family' descriptions have </br> instead of <br/>
2019-06-16 16735, 2019
12:06 PM
SothoTalKer
is it <br/> or <br />?
2019-06-16 16728, 2019
12:10 PM
yvanzo
either way, but </br> is invalid (closing a tag that has not been opened)
2019-06-16 16708, 2019
12:15 PM
SothoTalKer
i prefer <p></p> anyway :D
2019-06-16 16752, 2019
12:18 PM
BrainzGit
2019-06-16 16754, 2019
12:18 PM
BrainzBot
2019-06-16 16731, 2019
12:22 PM
SothoTalKer
reosarevok: you could get it merged to beta aswell, i guess? :x
2019-06-16 16719, 2019
12:31 PM
yvanzo
reosarevok: should the two above be marked as regressions?
2019-06-16 16711, 2019
12:32 PM
yvanzo
SothoTalKer: definitely going to beta today or tomorrow :)
2019-06-16 16735, 2019
12:32 PM
SothoTalKer
yay
2019-06-16 16729, 2019
12:36 PM
reosarevok
yvanzo: probably :)
2019-06-16 16739, 2019
12:36 PM
reosarevok
SothoTalKer: not from my phone I can't :)
2019-06-16 16711, 2019
12:37 PM
SothoTalKer
oh
2019-06-16 16712, 2019
12:52 PM
yvanzo
not from my phone either, it's broken (warranty expired about 1 month ago) :P
2019-06-16 16715, 2019
17:37 PM
Cyna
bitmap: Can you help me with the state issue... yvanzo said I shouldn't be passing state as Props
2019-06-16 16733, 2019
17:38 PM
Cyna
2019-06-16 16723, 2019
17:45 PM
yvanzo
Cyna: That might be legit after all but it is unclear which component this 'state' relates to.
2019-06-16 16715, 2019
17:46 PM
Cyna
state comes only from editForm.js
2019-06-16 16746, 2019
17:46 PM
yvanzo
Is there any type definition for this 'state'?
2019-06-16 16752, 2019
17:46 PM
Cyna
Yes
2019-06-16 16716, 2019
17:47 PM
Cyna
Its in the Props part of wherever it is used
2019-06-16 16700, 2019
17:48 PM
Cyna
for example, formRowNameWithGuesscase component
2019-06-16 16745, 2019
17:48 PM
Cyna
2019-06-16 16754, 2019
17:49 PM
Cyna
Its causing issue on editForm because FormRowSelect accepts value as both string or number. while the state property that is passed in is either of string or number but not both
2019-06-16 16730, 2019
18:13 PM
yvanzo
Cyna: A temporary workaround could be to enforce annoted type for target.value in onChange parameter given to FormRowSelect calls in EditForm.js
2019-06-16 16717, 2019
18:15 PM
Cyna
any idea how do I do it... seems confusing to me
2019-06-16 16743, 2019
18:19 PM
yvanzo
with : any
2019-06-16 16702, 2019
18:21 PM
yvanzo
((target.value: any): integer)
2019-06-16 16719, 2019
18:21 PM
yvanzo
((target.value: any): number)
2019-06-16 16705, 2019
18:28 PM
Cyna
```onChange={(e) => {
2019-06-16 16706, 2019
18:28 PM
Cyna
const target = e.target;
2019-06-16 16706, 2019
18:28 PM
Cyna
if (target instanceof HTMLInputElement) {
2019-06-16 16706, 2019
18:28 PM
Cyna
return setState({
2019-06-16 16706, 2019
18:28 PM
Cyna
...state,
2019-06-16 16706, 2019
18:28 PM
Cyna
locale: {
2019-06-16 16706, 2019
18:28 PM
Cyna
...state.locale,
2019-06-16 16707, 2019
18:28 PM
Cyna
value: ((target.value: any): number),
2019-06-16 16707, 2019
18:28 PM
Cyna
},
2019-06-16 16708, 2019
18:28 PM
Cyna
});
2019-06-16 16708, 2019
18:28 PM
Cyna
}
2019-06-16 16709, 2019
18:28 PM
Cyna
return undefined;
2019-06-16 16709, 2019
18:33 PM
yvanzo
Cyna: yup, should do. A definitive fix would be to improve FormRowSelect with parameterized type
2019-06-16 16729, 2019
19:04 PM
yvanzo
2019-06-16 16701, 2019
19:05 PM
Gazooo has quit
2019-06-16 16753, 2019
19:06 PM
Gazooo joined the channel
2019-06-16 16706, 2019
19:47 PM
Freso
reosarevok: Late but: SGTM.
2019-06-16 16729, 2019
19:49 PM
Freso
SothoTalKer: `<br/>` vs. `<br />` is mostly a legacy thing. Any browser from the last 5 (if not more) years should handle either fine. When XHTML was first introduced, many browsers would not understand `<br/>` but would understand `<br />`, so `<br />` was the recommended way for most compatibility. I guess it’s still recommended if you need to support IE 3 or whatever. :)
2019-06-16 16714, 2019
19:50 PM
Freso
Probably more like 10 or more years.
2019-06-16 16744, 2019
19:50 PM
Freso
XHTML is from 2000, so ~15 or so years or more recent is probably a good estimate. :p
2019-06-16 16740, 2019
20:25 PM
CatQuest
not even *my* browser is *that* old :D
2019-06-16 16754, 2019
20:59 PM
Lotheric_ joined the channel
2019-06-16 16716, 2019
21:00 PM
Lotheric has quit
2019-06-16 16739, 2019
22:12 PM
Lotheric_ is now known as Lotheric
2019-06-16 16755, 2019
23:42 PM
D4RK-PH0ENiX has quit
