but if both were merged to master, github should “hide” those commits which are already in master
2019-06-18 16901, 2019
amCap1712
i too wondered that
2019-06-18 16905, 2019
gr0uch0mars
nothing really important, but it might make the work easier
2019-06-18 16911, 2019
amCap1712
yup
2019-06-18 16939, 2019
gr0uch0mars
anyway, good feature. I run it but I still have to check that it works as expected
2019-06-18 16907, 2019
amCap1712
in future if i have an unmerged feature and start working on another one, should i branch from it or the master
2019-06-18 16911, 2019
yvanzo
zas: done
2019-06-18 16956, 2019
pristine__
ruaok: artists which have actor names included would have 0 similar artists, no?
2019-06-18 16944, 2019
gr0uch0mars
it depends: if Second feature depends on First one, you might branch from First. But try to avoid it as to keep PRs as simple as possible (and adding a Description with what you wanted to achieve would help, too)
2019-06-18 16906, 2019
ruaok
often yes. but they can appear on a different compilation with the same artist credit and the count could be more than 0.
2019-06-18 16906, 2019
amCap1712
ok i'll keep that in mind
2019-06-18 16923, 2019
amCap1712
i think zbar would work well for barcode
2019-06-18 16951, 2019
amCap1712
i'll start work on it one preferences pr is merged
2019-06-18 16901, 2019
pristine__
Umm....Okay. i will stick to eliminating te lines which have 0 similar artists
2019-06-18 16914, 2019
ruaok
great
2019-06-18 16915, 2019
pristine__
the ones*
2019-06-18 16930, 2019
gr0uch0mars
good, I'll review right now then. So you can start pristine
2019-06-18 16955, 2019
pristine__
And should find out the reason why pink floyd shows up so many times. And many other artists too
2019-06-18 16907, 2019
pristine__
An even distribution would be better.
2019-06-18 16902, 2019
yvanzo
zas: still have to update database triggers, and to rebuild some indexes: artist, cdstub, label, release
I think 7.7 is better at caching, it seems cpu load decreased a bit while more (caching) memory is used. Also document caches hit rates seems to have improved. We'll see in next days if it confirms though.
I have to run a few errands, afk for one hour or so.
2019-06-18 16937, 2019
Freso
ruaok: Did you consider using a relative compilation appearance instead of absolute? E.g., {number of appearances together}/{sum of compilations that either artist appear on}?
2019-06-18 16916, 2019
ruaok
yes. the scaling of the result is intentionally not done in an effort to not reduce the detail (range) of the data on purpose.
2019-06-18 16938, 2019
ruaok
the consumer (in this case pristine) should decide how to do that.
2019-06-18 16933, 2019
Freso
Does the consumer have access to the {sum of compilations that either artist appear on} if they want to try using a relative weight?
2019-06-18 16924, 2019
ruaok
that would need to be computed still.
2019-06-18 16902, 2019
gr0uch0mars
amCap1712: I've reviewed with a comment for you to think about
2019-06-18 16912, 2019
pac23 joined the channel
2019-06-18 16926, 2019
amCap1712
gr0uch0mars: i saw it
2019-06-18 16949, 2019
amCap1712
i think that is acually not actually an issue
2019-06-18 16918, 2019
amCap1712
when a user logs in from the browser, it is asked whether to remember it or not
2019-06-18 16911, 2019
amCap1712
and also the login is in browser, we cannot control the cookies of browser
2019-06-18 16901, 2019
amCap1712
however for safety purposes we could add a warning to logout from browser as well. what do you think on this gr0uch0mars
2019-06-18 16955, 2019
gr0uch0mars
no no, it might have been perfectly the browser. In that case we could think about how to alert the user about that (in case someone tries something like what I did)
2019-06-18 16916, 2019
gr0uch0mars
But I don't think it's prioritary. Usually people will login with their account only
2019-06-18 16938, 2019
amCap1712
ok gr0uch0mars
2019-06-18 16922, 2019
ruaok
lol. iliekcomputers are you going to present that paper that you submitted? accepted 4 days before the conference?
2019-06-18 16932, 2019
moinmoi has quit
2019-06-18 16939, 2019
Wizzup has quit
2019-06-18 16920, 2019
Wizzup joined the channel
2019-06-18 16919, 2019
yvanzo
done reindexing artist, label, cdstub, and release (other search indexes did not change)
2019-06-18 16906, 2019
moinmoi joined the channel
2019-06-18 16953, 2019
aidanlw17
hi alastairp, after we discussed yesterday I decided it would be easiest to just put all the work in one PR for now - that way you can view it and try running it yourself without jumping between PRs, and I can just continue adding to the branch?
2019-06-18 16955, 2019
ruaok
aidanlw17: the problem with that is that it may be hard to follow such a large PR.
2019-06-18 16912, 2019
ruaok
I would urge you to find ways to submit smaller PRs and as frequently as you can.
2019-06-18 16923, 2019
yvanzo
Mineo: Can you please add me to maintainers of sir.readthedocs.io so I can update it?
2019-06-18 16927, 2019
ruaok
letting things ball up only creates problems down the road.
2019-06-18 16941, 2019
aidanlw17
ruaok: noted, I split it up if that will be easier for us to follow and work with.
2019-06-18 16949, 2019
aidanlw17
*I will
2019-06-18 16915, 2019
ruaok
yes.
2019-06-18 16934, 2019
ruaok
and if you get a smaller PR accepted and merged before the mid-terms, you have *something* to show for your efforts.
2019-06-18 16950, 2019
aidanlw17
Okay! so it's important that there is finished work submitted prior to our first evaluation
2019-06-18 16928, 2019
ruaok
I'd say so yes. otherwise we still don't know if you're a bullshit artist. 😝
2019-06-18 16952, 2019
ruaok
not that we have anything against BS artists, we have a few here as well. Right, reosarevok ?
2019-06-18 16941, 2019
aidanlw17
Fair enough 😅 lol I swear I'm not a BS artist, I'll make some smaller PRs to prove it
2019-06-18 16916, 2019
ruaok
good plan. we'll leave the BS to the professionals.
2019-06-18 16927, 2019
aidanlw17
exactly!
2019-06-18 16932, 2019
reosarevok
I guess by now I am a BS professional, but I wouldn't call myself an artist to be fair
