#metabrainz

yay!

This week I mainly worked on splitting up some of my work with annoy similarity into smaller pull requests

And added some better functionality for building, loading, and saving the indices that we make

Which will make it easier for us to keep track of them etc. I also added functionality to delete them

And worked on the API endpoints to query them in different ways for when we have built the indices on AcousticBrainz.org

Those things were my main focus.

Also made some small changes and did some testing for AB-404

AB-404: Provide an API endpoint where users can select only the features that they want returned https://tickets.metabrainz.org/browse/AB-404

Excited about the talk about the summit ruaok!!

Fin!

Alright!

Still no one else have announced they want to give a review.

Sorry I was late, everyone.

No worries. You made it just in time. :)

And no more items on the agenda.

So that’s it for tonight!

Thanks Freso!

Thanks for your reviews and your time everyone!

</BANG>

Thank you!

!m everyone

You're doing good work, everyone!

back to midsommar! :)

^

Thanks!

thanks Freso :)

(Both of the two statements above "^".)

bitmap: could you check the preview, when you have time ?. They work in edit too

Only problem is with the boolean props, rest I think is okay

yup, will check soon

ærre slutt?

KassOtsimine: 19:32:34 <Freso> </BANG>

takk Freso ^__^

tsk don't jump the gun n, I saw it, was just a leading to say thanks ;p

sorry I had nothing important to say

and for being KassOtsimine again

metabrainz/picard#4697 (master - 4b116ac : Philipp Wolfer): The build has errored.

Change view : https://github.com/metabrainz/picard/compare/99...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

me goes off to play BotW :D

ruaok: did you think about the incremental dumps schedule?

twice a week is sane and matches what MB does. I like it.

Cyna: looks like a good start, besides changes to the boolean attributes on /edit showing up as empty cells. it also shows Alias: [removed] which is wrong, and I think the artist links should have target="_blank" so changes aren't lost if someone clicks on them

(if you load /edit without making any changes, it already shows an edit with Alias: [removed], whereas it should just say you haven't made any changes or something like in the release editor)

if one of the dates is set to something like "1991-01" in the DB and I add 01 to the day input, it shows the change like "End date: (empty) ????-??-01" instead of "End date: 1991-01 1991-01-01"

if I reload the page, change the year to 1992 and then back to 1991 (so that no change is made), it still shows a change like "End date: (empty) 1991"

ruaok: yep, sounds good to me too

ferbncode: spellew: https://github.com/metabrainz/brainzutils-pytho...

pristine__: there were a couple of unneeded files merged from your pr, i removed them,(https://github.com/metabrainz/listenbrain...

iliekcomputers: I’m not sure if you’re on top of this already, but: https://tickets.metabrainz.org/browse/LB-457

LB-457: last.fm import fails with CORS problems

bitmap: I'll shift the work related to selenium at the end and conversions and any react related edits in the starting weeks... This is majorly because of my unfamiliarity with selenium

Is it a good idea ?

Project bookbrainz-data-js build #1150: passed in 1 min 33 sec: https://travis-ci.org/bookbrainz/bookbrainz-dat...

iliekcomputers: https://gist.github.com/mayhem/9df9125ec392c17b...

fixing the recording_json table caused some error -- this is why we haven't been writing listens... for days it seems.

I'm too tired to sort this out, so I am turning off the spotify reader for now.

my script forgot to reset the sequence on the new table.

so I just did that and all seems well now.

spotify reader seems to be working again.

the 404 error happens sporadically now

iliekcomputers: there are 3 users who actively recording listens now. is it possible to write a script to restart the connections that have stopped? I'd hate for everyone to have to come back and relink their accounts.

This should be set to true for it to record listens

would it be possible for you to write a script/query to do that?

Setting it to true for my user to make sure that it works first would be a good idea

ruaok: yes

have at it -- or I will look at in the morning. I should be in bed.

Sure, no worries. I'll look.

this was a pretty bad outage for us. we lost days msb data. :(

at least listens appear to be there, which is nice.

ok, bad.

nn.

hmm. got another email. my spotify link is broken.

404?

the 404 errors appear to be sporadic. before we re-enable listens, we need to not disconnect a connection because the spotify api returns 404.

yeah.

look at the log snippet I cc'ed you on.

seems sporadic, so we should not let a 404 disconnect the service.

so, we need to fix that before re-enabling the listening, otherwise we spam our users.

pr coming up

[listenbrainz-server] paramsingh opened pull request #589 (master…dont-die-on-404): Don't stop getting user listens on 404s https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] paramsingh merged pull request #589 (production…dont-die-on-404): Don't stop getting user listens on 404s https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] paramsingh opened pull request #590 (production…restart-spotify-imports): Add script to restart spotify imports for users https://github.com/metabrainz/listenbrainz-serv...