17:28 PM
KassOtsimine
yay!
2019-06-24 17502, 2019
17:29 PM
aidanlw17
:))
2019-06-24 17525, 2019
17:29 PM
aidanlw17
This week I mainly worked on splitting up some of my work with annoy similarity into smaller pull requests
2019-06-24 17544, 2019
17:29 PM
aidanlw17
And added some better functionality for building, loading, and saving the indices that we make
2019-06-24 17503, 2019
17:30 PM
aidanlw17
Which will make it easier for us to keep track of them etc. I also added functionality to delete them
2019-06-24 17539, 2019
17:30 PM
aidanlw17
And worked on the API endpoints to query them in different ways for when we have built the indices on
AcousticBrainz.org
2019-06-24 17559, 2019
17:30 PM
aidanlw17
Those things were my main focus.
2019-06-24 17516, 2019
17:31 PM
aidanlw17
Also made some small changes and did some testing for AB-404
2019-06-24 17517, 2019
17:31 PM
BrainzBot
2019-06-24 17543, 2019
17:31 PM
aidanlw17
Excited about the talk about the summit ruaok!!
2019-06-24 17547, 2019
17:31 PM
aidanlw17
Fin!
2019-06-24 17553, 2019
17:31 PM
Freso
Alright!
2019-06-24 17500, 2019
17:32 PM
Freso
Still no one else have announced they want to give a review.
2019-06-24 17504, 2019
17:32 PM
aidanlw17
Sorry I was late, everyone.
2019-06-24 17511, 2019
17:32 PM
Freso
No worries. You made it just in time. :)
2019-06-24 17518, 2019
17:32 PM
Freso
And no more items on the agenda.
2019-06-24 17523, 2019
17:32 PM
Freso
So that’s it for tonight!
2019-06-24 17529, 2019
17:32 PM
iliekcomputers
Thanks Freso!
2019-06-24 17531, 2019
17:32 PM
Freso
Thanks for your reviews and your time everyone!
2019-06-24 17534, 2019
17:32 PM
Freso
</BANG>
2019-06-24 17535, 2019
17:32 PM
aidanlw17
Thank you!
2019-06-24 17539, 2019
17:32 PM
Mr_Monkey
!m everyone
2019-06-24 17539, 2019
17:32 PM
BrainzBot
You're doing good work, everyone!
2019-06-24 17541, 2019
17:32 PM
ruaok
back to midsommar! :)
2019-06-24 17546, 2019
17:32 PM
Freso
^
2019-06-24 17550, 2019
17:32 PM
spellew
Thanks!
2019-06-24 17551, 2019
17:32 PM
pristine__
thanks Freso :)
2019-06-24 17559, 2019
17:32 PM
Freso
(Both of the two statements above "^".)
2019-06-24 17500, 2019
17:35 PM
Cyna
bitmap: could you check the preview, when you have time ?. They work in edit too
2019-06-24 17517, 2019
17:35 PM
Cyna
Only problem is with the boolean props, rest I think is okay
2019-06-24 17524, 2019
17:35 PM
bitmap
yup, will check soon
2019-06-24 17514, 2019
17:36 PM
KassOtsimine
ærre slutt?
2019-06-24 17528, 2019
17:36 PM
Freso
KassOtsimine: 19:32:34 <Freso> </BANG>
2019-06-24 17546, 2019
17:36 PM
KassOtsimine
takk Freso ^__^
2019-06-24 17513, 2019
17:37 PM
KassOtsimine
tsk don't jump the gun n, I saw it, was just a leading to say thanks ;p
2019-06-24 17510, 2019
17:38 PM
KassOtsimine
sorry I had nothing important to say
2019-06-24 17526, 2019
17:38 PM
KassOtsimine
and for being KassOtsimine again
2019-06-24 17523, 2019
17:42 PM
travis-ci joined the channel
2019-06-24 17523, 2019
17:42 PM
travis-ci
metabrainz/picard#4697 (master - 4b116ac : Philipp Wolfer): The build has errored.
2019-06-24 17523, 2019
17:42 PM
travis-ci
2019-06-24 17523, 2019
17:42 PM
travis-ci
2019-06-24 17523, 2019
17:42 PM
travis-ci has left the channel
2019-06-24 17537, 2019
17:42 PM
KassOtsimine
me goes off to play BotW :D
2019-06-24 17557, 2019
17:45 PM
iliekcomputers
ruaok: did you think about the incremental dumps schedule?
2019-06-24 17546, 2019
17:55 PM
ruaok
twice a week is sane and matches what MB does. I like it.
2019-06-24 17522, 2019
18:09 PM
bitmap
Cyna: looks like a good start, besides changes to the boolean attributes on /edit showing up as empty cells. it also shows Alias: [removed] which is wrong, and I think the artist links should have target="_blank" so changes aren't lost if someone clicks on them
2019-06-24 17540, 2019
18:11 PM
bitmap
(if you load /edit without making any changes, it already shows an edit with Alias: [removed], whereas it should just say you haven't made any changes or something like in the release editor)
2019-06-24 17506, 2019
18:15 PM
bitmap
if one of the dates is set to something like "1991-01" in the DB and I add 01 to the day input, it shows the change like "End date: (empty) ????-??-01" instead of "End date: 1991-01 1991-01-01"
2019-06-24 17521, 2019
18:16 PM
bitmap
if I reload the page, change the year to 1992 and then back to 1991 (so that no change is made), it still shows a change like "End date: (empty) 1991"
2019-06-24 17509, 2019
18:47 PM
iliekcomputers
ruaok: yep, sounds good to me too
2019-06-24 17517, 2019
18:47 PM
iliekcomputers
2019-06-24 17536, 2019
19:00 PM
yokel has quit
2019-06-24 17500, 2019
19:01 PM
yokel joined the channel
2019-06-24 17538, 2019
19:15 PM
iliekcomputers
2019-06-24 17548, 2019
20:23 PM
Freso
2019-06-24 17549, 2019
20:23 PM
BrainzBot
LB-457: last.fm import fails with CORS problems
2019-06-24 17524, 2019
20:57 PM
CatQuest has quit
2019-06-24 17544, 2019
20:57 PM
CatQuest joined the channel
2019-06-24 17544, 2019
20:57 PM
CatQuest has quit
2019-06-24 17544, 2019
20:57 PM
CatQuest joined the channel
2019-06-24 17501, 2019
21:08 PM
brett-soric joined the channel
2019-06-24 17514, 2019
21:18 PM
yokel has quit
2019-06-24 17546, 2019
21:18 PM
yokel joined the channel
2019-06-24 17508, 2019
21:25 PM
Cyna
bitmap: I'll shift the work related to selenium at the end and conversions and any react related edits in the starting weeks... This is majorly because of my unfamiliarity with selenium
2019-06-24 17532, 2019
21:25 PM
Cyna
Is it a good idea ?
2019-06-24 17556, 2019
21:54 PM
brett-soric has left the channel
2019-06-24 17538, 2019
22:45 PM
travis-ci joined the channel
2019-06-24 17538, 2019
22:45 PM
travis-ci
2019-06-24 17538, 2019
22:45 PM
travis-ci has left the channel
2019-06-24 17536, 2019
23:04 PM
ruaok
2019-06-24 17518, 2019
23:05 PM
ruaok
fixing the recording_json table caused some error -- this is why we haven't been writing listens... for days it seems.
2019-06-24 17541, 2019
23:05 PM
ruaok
I'm too tired to sort this out, so I am turning off the spotify reader for now.
2019-06-24 17556, 2019
23:15 PM
ruaok
my script forgot to reset the sequence on the new table.
2019-06-24 17503, 2019
23:16 PM
ruaok
so I just did that and all seems well now.
2019-06-24 17514, 2019
23:16 PM
ruaok
spotify reader seems to be working again.
2019-06-24 17515, 2019
23:17 PM
ruaok
the 404 error happens sporadically now
2019-06-24 17548, 2019
23:22 PM
ruaok
iliekcomputers: there are 3 users who actively recording listens now. is it possible to write a script to restart the connections that have stopped? I'd hate for everyone to have to come back and relink their accounts.
2019-06-24 17528, 2019
23:24 PM
iliekcomputers
2019-06-24 17503, 2019
23:25 PM
iliekcomputers
This should be set to true for it to record listens
2019-06-24 17555, 2019
23:25 PM
ruaok
would it be possible for you to write a script/query to do that?
2019-06-24 17556, 2019
23:25 PM
iliekcomputers
Setting it to true for my user to make sure that it works first would be a good idea
2019-06-24 17523, 2019
23:26 PM
iliekcomputers
ruaok: yes
2019-06-24 17535, 2019
23:26 PM
ruaok
have at it -- or I will look at in the morning. I should be in bed.
2019-06-24 17554, 2019
23:26 PM
iliekcomputers
Sure, no worries. I'll look.
2019-06-24 17518, 2019
23:28 PM
ruaok
this was a pretty bad outage for us. we lost days msb data. :(
2019-06-24 17532, 2019
23:28 PM
ruaok
at least listens appear to be there, which is nice.
2019-06-24 17534, 2019
23:28 PM
ruaok
ok, bad.
2019-06-24 17535, 2019
23:28 PM
ruaok
nn.
2019-06-24 17550, 2019
23:30 PM
ruaok
hmm. got another email. my spotify link is broken.
2019-06-24 17520, 2019
23:31 PM
iliekcomputers
404?
2019-06-24 17534, 2019
23:31 PM
ruaok
the 404 errors appear to be sporadic. before we re-enable listens, we need to not disconnect a connection because the spotify api returns 404.
2019-06-24 17546, 2019
23:31 PM
ruaok
yeah.
2019-06-24 17558, 2019
23:31 PM
ruaok
look at the log snippet I cc'ed you on.
2019-06-24 17518, 2019
23:32 PM
ruaok
seems sporadic, so we should not let a 404 disconnect the service.
2019-06-24 17538, 2019
23:32 PM
ruaok
so, we need to fix that before re-enabling the listening, otherwise we spam our users.
2019-06-24 17537, 2019
23:38 PM
iliekcomputers
pr coming up
2019-06-24 17526, 2019
23:39 PM
BrainzGit
2019-06-24 17524, 2019
23:45 PM
BrainzGit
2019-06-24 17556, 2019
23:59 PM
BrainzGit
