It computes the entire list whereas it used not to compute it in most cases.
2019-07-24 20505, 2019
bitmap
right, but I'm not sure computing the list is an expensive operation
2019-07-24 20516, 2019
bitmap
the list will be very small in most cases
2019-07-24 20523, 2019
yvanzo
I attempted to rewrite it to avoid that, but it doesn't work yet and doesn't look pretty either.
2019-07-24 20558, 2019
pristine__
alastairp: what you say makes sense. But a thought crossed my mind, do we need to replace days here. My goal is to collect dataframes of last X months from the present month, so even if it is 30-07-2019, a month before it will be 30-06-2019. Date doesn't matter here, no?
2019-07-24 20536, 2019
reosarevok
FWIW, in the real life cases where I tested it, the recursion didn't seem to make it particularly slow or anything
2019-07-24 20533, 2019
Wizzup joined the channel
2019-07-24 20537, 2019
reosarevok
As I mentioned, the chances it needs to hit more than two loops are small
2019-07-24 20548, 2019
bitmap
I mean, realistically it could hit a few levels of recursion at most
2019-07-24 20517, 2019
yvanzo
Yup, but it seems just unsafe to have a recursion based on user input.
2019-07-24 20544, 2019
reosarevok
I mean, what's the worst that can happen?
2019-07-24 20510, 2019
reosarevok
At most it can run for a few hundred times, if someone does try to troll by adding redirects to every wikipedia language on one WD item
2019-07-24 20538, 2019
reosarevok
And that seems like a trolling so weird, not even dseomn would bother :p
2019-07-24 20523, 2019
bitmap
it's still bound by what languages are actually available though
2019-07-24 20543, 2019
yvanzo
reosarevok: made some comments on the 1st PR, probably just minor changes
2019-07-24 20558, 2019
reosarevok
Ok, will check
2019-07-24 20529, 2019
yvanzo
I will try to make my own version work and push it (for the latest PR)
2019-07-24 20516, 2019
bitmap
how will you avoid calculating the list?
2019-07-24 20535, 2019
yvanzo
bitmap: blacklisting unwanted languages
2019-07-24 20525, 2019
reosarevok
Want to quickly look through a couple tiny PRs from the newer batches too?
2019-07-24 20526, 2019
alastairp
pristine__: right, if you're interested in collection information related to some number of months, you probably don't need the date in any of your queries
2019-07-24 20533, 2019
reosarevok
(I'm also happy to look at more old ones if you're not in a hurry)
2019-07-24 20534, 2019
bitmap
don't you have to calculate unwanted languages then?
2019-07-24 20547, 2019
alastairp
are you interested in knowing "statistics in the last 30 days until today" or "statistics for June"?
2019-07-24 20502, 2019
yvanzo
bitmap: not all of these, just the ones we checked
(no need to check them all now or anything, just might be easy pickings before beta
2019-07-24 20511, 2019
reosarevok
)
2019-07-24 20535, 2019
BrainzGit joined the channel
2019-07-24 20535, 2019
yvanzo
reosarevok: listing all of your PRs don't help with prioritizing :P
2019-07-24 20500, 2019
reosarevok
That's not all, that's short ones with one approval :p
2019-07-24 20550, 2019
yvanzo
will review these and check URL cleanup tickets then
2019-07-24 20508, 2019
reosarevok
Thanks!
2019-07-24 20525, 2019
yvanzo
(about itunes, the only way out without a style decision would be to disable auto-select for itunes/apple music URLs)
2019-07-24 20501, 2019
reosarevok
I know
2019-07-24 20509, 2019
reosarevok
Give me one more release cycle to figure out wtf
2019-07-24 20543, 2019
reosarevok
The links can be automatically cleaned up anyway AFAICT
2019-07-24 20505, 2019
SothoTalKer
itunes ftw
2019-07-24 20552, 2019
bitmap
sounds like we have enough work for now anyway :)
2019-07-24 20503, 2019
reosarevok
Sure
2019-07-24 20507, 2019
reosarevok
yvanzo: updated the doc PR
2019-07-24 20507, 2019
bitmap
we could go through more old PRs on friday if you'd like
2019-07-24 20521, 2019
reosarevok
I'm at Wikimedia Eesti Summer Days on Friday
2019-07-24 20521, 2019
yvanzo
yay! ty
2019-07-24 20523, 2019
reosarevok
So maybe not? :)
2019-07-24 20536, 2019
bitmap
oh okay
2019-07-24 20539, 2019
reosarevok
(but if you can look at some of mine without me and complain, I'll deal with them once I'm back!)
2019-07-24 20517, 2019
yvanzo
I will try to push a new beta this week after having reviewed/merged what can be.
2019-07-24 20542, 2019
reosarevok
If you both approve something of mine, feel free to merge without waiting for me
2019-07-24 20516, 2019
reosarevok
(during Fri - Sun)
2019-07-24 20521, 2019
D4RK-PH0ENiX has quit
2019-07-24 20552, 2019
spellew
ferbncode: Is there anything I should be doing while waiting for pull requests to be reviewed?
2019-07-24 20526, 2019
D4RK-PH0ENiX joined the channel
2019-07-24 20536, 2019
D4RK-PH0ENiX has quit
2019-07-24 20550, 2019
D4RK-PH0ENiX joined the channel
2019-07-24 20543, 2019
ferbncode
spellew: iliekcomputers would help us merge the approved PRs by tomorrow and then we can start with the new tasks. Till then, could you also attach a screenshot of how the artist review page looks like? (If you have it locally). I checked the code and will add the review tomorrow
2019-07-24 20554, 2019
spellew
ferbncode: Sure thing
2019-07-24 20552, 2019
ferbncode
Thanks! :)
2019-07-24 20551, 2019
dseomn
reosarevok: you're right that *I* wouldn't do that, but I do know a couple people who might ;)
