I tested the first part of aidanlw17's SoC work on bono, using a subset of the acousticbrainz database, it looks good so far. I'll coordinate with iliekcomputers this week to get him an account on bono for the full dump
2019-08-05 21727, 2019
alastairp
and as yvanzo said, I sat down and fought with the multiprocessing module and helped to fix some stuff in sir
2019-08-05 21727, 2019
alastairp
Mr_Monkey: ?
2019-08-05 21743, 2019
ruaok
he seems to be off playing in the trees..
2019-08-05 21749, 2019
Freso
Let’s skip to ruaok until Monkey shows a life sign.
2019-08-05 21750, 2019
alastairp
ruaok: then
2019-08-05 21752, 2019
Freso
ruaok, go?
2019-08-05 21759, 2019
ruaok
heh, fair.
2019-08-05 21722, 2019
CatQuest
Mr_Monkey: 🍌🍌🍌
2019-08-05 21727, 2019
ruaok
last week I was bouncing around in the UK and NL. I got to see the concorde protoype, which was fun.
2019-08-05 21758, 2019
ruaok
work wise was pretty slow. still dealing with tickets for summits and such. emails. background nonsense.
2019-08-05 21715, 2019
ruaok
and of course reviewing pristine__'s PR. pretty chill overall.
2019-08-05 21717, 2019
ruaok
pristine__: go!
2019-08-05 21725, 2019
reosarevok
Or not
2019-08-05 21742, 2019
ruaok
reosarevok: go
2019-08-05 21751, 2019
CatQuest
:D
2019-08-05 21715, 2019
reosarevok
I looked at voting reports a bit more, then went to a festival and didn't take my laptop so I did nothing so far after that
2019-08-05 21726, 2019
reosarevok
Watched a lot of Netflix on the tablet instead
2019-08-05 21729, 2019
reosarevok
#productive
2019-08-05 21745, 2019
reosarevok
This week I'll hopefully get shot done
2019-08-05 21754, 2019
reosarevok
Eh. Shit, not shot, I'm not American
2019-08-05 21758, 2019
reosarevok
CatQuest: go
2019-08-05 21701, 2019
pristine__
Hi. Sorry.
2019-08-05 21705, 2019
CatQuest
Meow! `😺`
2019-08-05 21705, 2019
pristine__
Slow connection
2019-08-05 21713, 2019
CatQuest
My cast has come of! yaay!
2019-08-05 21719, 2019
CatQuest
so I've been (slowly) walking about and training back my leg - still not 100% but getting there.
2019-08-05 21722, 2019
reosarevok
You're an outcast now???
2019-08-05 21729, 2019
CatQuest
hahaha
2019-08-05 21741, 2019
CatQuest
In other news the 8th volume of Chiptunes = Win has come out... aaaaand :drum-whirl:
2019-08-05 21741, 2019
CatQuest
This time I had submitted some artwork to their contest!
(I could not say anything about this before now, as that was stipulated part of the competition
2019-08-05 21701, 2019
CatQuest
(well the showing the artwork part. I could have mention stuff, but I'm a very show-and-tell not just-tell person :D))
2019-08-05 21713, 2019
CatQuest
Summer is also officially (probably) Over here in Norway so expect to see more instruments from me in the near future!
2019-08-05 21726, 2019
CatQuest
that's it for me `😸`
2019-08-05 21726, 2019
CatQuest
findus!
2019-08-05 21726, 2019
CatQuest
next can be amCap1712 ?
2019-08-05 21730, 2019
pristine__
May I?
2019-08-05 21741, 2019
CatQuest
or pristine__ ok?
2019-08-05 21745, 2019
pristine__
Thanks :)
2019-08-05 21749, 2019
pristine__
Hi everyone
2019-08-05 21713, 2019
pristine__
Last week was good. After deciding the schema
2019-08-05 21726, 2019
pristine__
We moved on to work on dates.
2019-08-05 21745, 2019
pristine__
( I learnt a hell lot things from ruaok regarding dates )
2019-08-05 21756, 2019
pristine__
I thing that PR will be merged soon
2019-08-05 21704, 2019
ruaok
date good practices are really important. :)
2019-08-05 21704, 2019
reosarevok
... said no one ever before
2019-08-05 21716, 2019
CatQuest
:D
2019-08-05 21718, 2019
ruaok
reosarevok: go back to shotting up. :D
2019-08-05 21722, 2019
reosarevok
Eh. Re learning from ruaok, not it being important
2019-08-05 21734, 2019
pristine__
Other than that, worked on preparing a schema for storing model metadata
2019-08-05 21710, 2019
pristine__
Which i think is imp, because we will delete the actual models once the count exceeds the threshold
2019-08-05 21717, 2019
pristine__
Good week.
2019-08-05 21723, 2019
pristine__
fin!
2019-08-05 21728, 2019
CatQuest
imps? first gremlins now imps oh no
2019-08-05 21731, 2019
pristine__
amCap1712: go!
2019-08-05 21732, 2019
Freso
Or… akhilesh, go!
2019-08-05 21719, 2019
akhilesh
Hello everyone!
2019-08-05 21740, 2019
CatQuest
hi
2019-08-05 21744, 2019
akhilesh
This week is little productive for BB-API.
2019-08-05 21707, 2019
akhilesh
Finalize Swagger documentation for lookup endpoints.
2019-08-05 21728, 2019
akhilesh
Refactoring some changes in PR, finally PR merged with the great help of Mr_Monkey.
2019-08-05 21742, 2019
akhilesh
New PR opened for Tests for browse requests.
2019-08-05 21714, 2019
akhilesh
That's all.
2019-08-05 21716, 2019
akhilesh
Fin
2019-08-05 21720, 2019
Freso
(People still up: Freso, spellew, Cyna, Mr_Monkey(?), amCap1712(?) – anyone else that wants to go, please let me know explicitly ASAP!)
2019-08-05 21734, 2019
akhilesh
Freso: go?
2019-08-05 21738, 2019
Freso
🙋
2019-08-05 21727, 2019
Freso
I cleaned up some wiki pages relating to our old MusicBrainz sandboxes that have been defunct for a while.
2019-08-05 21747, 2019
Freso
Other than that the usual: being around and about and dealing with reports and flags.
2019-08-05 21751, 2019
Freso
fin!
2019-08-05 21754, 2019
Freso
spellew: Go?
2019-08-05 21701, 2019
yvanzo
!m Freso
2019-08-05 21701, 2019
BrainzBot
You're doing good work, Freso!
2019-08-05 21707, 2019
spellew
Hi
2019-08-05 21732, 2019
spellew
This past week, my pull request for brainzutils was merged and my pull request for adding artist support to critiquebrainz was approved.
2019-08-05 21745, 2019
Freso
(Other than spellew, only Cyna is left on my list—and maybe Mr_Monkey and/or amCap1712 if they show up—so this is last call for anyone else who are thinking they’d like to present their work over the last week. :))
2019-08-05 21710, 2019
spellew
I'll be working on getting my pull requests for the other entities approved this week, which will involve creating HTML layouts for the new entities.
2019-08-05 21714, 2019
spellew
Fin.
2019-08-05 21723, 2019
spellew
Cyna: Do you want to go next?
2019-08-05 21732, 2019
Cyna
Hi
2019-08-05 21714, 2019
Cyna
I've been working with the Place entity forms and edit details for MB over the previous week
2019-08-05 21754, 2019
Cyna
This week I've been working on edit details for all other entity types in MB
2019-08-05 21707, 2019
Cyna
Hope to complete it by tomorrow
2019-08-05 21718, 2019
Cyna
Fin
2019-08-05 21729, 2019
Freso
No Mr_Monkey and no amCap1712 have shown up.
2019-08-05 21740, 2019
Freso
And no one else have spoken up.
2019-08-05 21747, 2019
Freso
So I guess this is it for Reviews today!
2019-08-05 21758, 2019
Freso
Thanks to everyone who gave review!
2019-08-05 21712, 2019
Freso
No other items on today’s agenda either, so this additionally concludes the meeting.
I'm not sure which bit 20:23 refers to since it doesn't seem to match the original source file. but there are only a few lines where you access a .name property, so just check each one and see what's undefined
2019-08-05 21705, 2019
Cyna
bitmap: all the property seems to be accounted for
2019-08-05 21748, 2019
Cyna
only ac.name doesnt exist but I'll added a ternary operator there
2019-08-05 21718, 2019
Cyna
the error is cant read 'name' of undefined
2019-08-05 21747, 2019
Cyna
so it means the parent is undefined, which in this case is not true
2019-08-05 21758, 2019
Cyna
all the access are defined
2019-08-05 21740, 2019
bitmap
well, at least one of them isn't, otherwise it wouldn't throw an error :)
2019-08-05 21733, 2019
bitmap
ac.name should be the fully-rendered text of the artist credit; I don't think a ternary is a good idea there
2019-08-05 21712, 2019
bitmap
there's a reduceArtistCredit function you can import to calculate ac.name
2019-08-05 21701, 2019
bitmap
the reason ac.name worked in the TT template is because it was calling the 'name' method directly on the ac instance. here you don't have that
