14:17 PM
Lotheric joined the channel
2019-10-17 29041, 2019
14:20 PM
yvanzo
reosarevok: happier to have an user as chaban in the loop, thanks :)
2019-10-17 29020, 2019
14:30 PM
BrainzGit
2019-10-17 29021, 2019
14:30 PM
BrainzBot
2019-10-17 29057, 2019
14:32 PM
paurieraf has quit
2019-10-17 29054, 2019
14:47 PM
ruaok
reosarevok: magic, I am guessing. if ISNI is any sort of indication how these things go.
2019-10-17 29021, 2019
14:49 PM
reosarevok
Was afraid that'd be the case
2019-10-17 29044, 2019
16:01 PM
Lotheric
I knew ppl would complain hehe
2019-10-17 29000, 2019
16:02 PM
reosarevok
I knew too, but I just kinda didn't realize I had made it much worse than it needed to be
2019-10-17 29014, 2019
16:02 PM
reosarevok
So now they'll still complain, but at least not about stuff that didn't need changing :p
2019-10-17 29003, 2019
16:05 PM
Lotheric
I haven't tried editing with the hotfix yet
2019-10-17 29023, 2019
16:07 PM
reosarevok
Now it's all like before, only you'll click Previous a few times when you want Enter Edit
2019-10-17 29031, 2019
16:07 PM
reosarevok
But hey, at least Previous is less risky than Cancel :p
2019-10-17 29020, 2019
16:10 PM
Lotheric
going to try it now :D
2019-10-17 29047, 2019
16:13 PM
pristine__
Name node is in safe mode
2019-10-17 29052, 2019
16:13 PM
pristine__
restarting leader
2019-10-17 29008, 2019
16:15 PM
yvanzo
reosarevok, bitmap: should we create a new git tag v-2019-10-17-hotfixes and mention it in the blog post?
2019-10-17 29007, 2019
16:16 PM
bitmap
it might be worthwhile for the slow query fix since that affects the ws
2019-10-17 29021, 2019
16:16 PM
bitmap
(if it was just the RE button thing I'd say no :))
2019-10-17 29028, 2019
16:16 PM
yvanzo
2019-10-17 29021, 2019
16:17 PM
yvanzo
(RE button doesn’t matter for mirror, it has no editing mode)
2019-10-17 29010, 2019
16:22 PM
reosarevok
2019-10-17 29047, 2019
16:22 PM
reosarevok
(I'd say if we're doing it, it'd make sense to also reject deletion at least with area-area rels)
2019-10-17 29046, 2019
16:23 PM
bitmap
removing the rels is an auto-edit for location editors right?
2019-10-17 29055, 2019
16:23 PM
reosarevok
I suspect not
2019-10-17 29059, 2019
16:23 PM
reosarevok
But I haven't tried
2019-10-17 29004, 2019
16:24 PM
reosarevok
(I mean, other than URL rels)
2019-10-17 29015, 2019
16:24 PM
reosarevok
That said, if something does have rels, chances are it should be merged anyway, not removed
2019-10-17 29017, 2019
16:25 PM
bitmap
right, I mean it doesn't seem very likely an area should be outright removed in many cases
2019-10-17 29038, 2019
16:25 PM
bitmap
so checking for any rel makes sense to me
2019-10-17 29045, 2019
16:25 PM
reosarevok
Yeah, probably only if the user messed up
2019-10-17 29019, 2019
16:26 PM
reosarevok
Heh, so we have
2019-10-17 29021, 2019
16:26 PM
reosarevok
2019-10-17 29008, 2019
16:27 PM
reosarevok
Wonder if I shouldn't just replace the whole list of checks for an is_empty check
2019-10-17 29024, 2019
16:27 PM
reosarevok
(well, that plus the one for the country table
2019-10-17 29025, 2019
16:27 PM
reosarevok
)
2019-10-17 29044, 2019
16:29 PM
bitmap
maybe? if it checks everything we want :)
2019-10-17 29026, 2019
16:33 PM
yvanzo
(updated blog post and musicbrainz-docker with latest mbs git tag)
2019-10-17 29054, 2019
16:34 PM
bitmap
thanks!
2019-10-17 29022, 2019
16:37 PM
nav2002_ has quit
2019-10-17 29048, 2019
17:07 PM
bitmap
2019-10-17 29049, 2019
17:07 PM
BrainzBot
2019-10-17 29044, 2019
17:09 PM
bitmap
that lets us reuse the sidebar component and avoids having to manage rowspans for every release, which was really really hard
2019-10-17 29026, 2019
17:11 PM
reosarevok
I think that makes sense
2019-10-17 29035, 2019
17:11 PM
reosarevok
Can you still make it so you can somehow choose which one to order by?
2019-10-17 29002, 2019
17:12 PM
bitmap
we could make the Date / Country things separate links for sorting when we have that, I guess. not sure how obvious it'll be
2019-10-17 29040, 2019
17:13 PM
BrainzGit
2019-10-17 29025, 2019
17:14 PM
bitmap
also I think keeping them in table form doesn't make much semantic sense either, since it implies a date/country pair is directly associated with a label/catno pair in the same row :P
2019-10-17 29043, 2019
17:17 PM
bitmap
(I'd probably merge the label/catno ones too for that reason)
2019-10-17 29006, 2019
17:20 PM
bitmap
this made more sense when I tested it with VoiceOver too
2019-10-17 29019, 2019
17:22 PM
reosarevok
As long as we have an arrow by Date and one by Country, it should probably work
2019-10-17 29045, 2019
17:22 PM
bitmap
yea, true
2019-10-17 29001, 2019
17:23 PM
reosarevok
And we already have that
2019-10-17 29006, 2019
17:23 PM
reosarevok
(release collections)
2019-10-17 29036, 2019
17:24 PM
bitmap
thanks, I figured it was somewhere but only tested the RG index so far
2019-10-17 29039, 2019
17:30 PM
reosarevok
All sortable stuff is in collection pages only rn
2019-10-17 29043, 2019
17:30 PM
reosarevok
Not sure *why* tbh
2019-10-17 29052, 2019
17:30 PM
reosarevok
If we already have it, what stops us putting it elsewhere?
2019-10-17 29038, 2019
17:31 PM
paurieraf joined the channel
2019-10-17 29005, 2019
17:34 PM
bitmap
just that if it's a paginated list it needs support on the server
2019-10-17 29015, 2019
17:36 PM
reosarevok
Aren't collections all a paginated list?
2019-10-17 29025, 2019
17:36 PM
reosarevok
I mean, it's literally the same React component
2019-10-17 29031, 2019
17:36 PM
bitmap
they are
2019-10-17 29058, 2019
17:36 PM
reosarevok
Do the other pages require more processing power because they're usually longer lists, or? :)
2019-10-17 29054, 2019
17:37 PM
BrainzGit
2019-10-17 29055, 2019
17:37 PM
BrainzBot
2019-10-17 29004, 2019
17:38 PM
bitmap
I don't think so (or it hasn't been determined they do), just that we haven't added the 'order' query param to those pages
2019-10-17 29029, 2019
17:38 PM
reosarevok
I mean, I wonder because apparently the catno thing made stuff a lot slower
2019-10-17 29040, 2019
17:38 PM
reosarevok
So if we allow sorting by catno (and we currently do) that might be an issue?
2019-10-17 29013, 2019
17:39 PM
bitmap
that's true, though even the old PR had multiple approvals so I don't think it was predicted :)
2019-10-17 29034, 2019
17:39 PM
bitmap
at least not in that case
2019-10-17 29041, 2019
17:44 PM
reosarevok
How much worse was it?
2019-10-17 29003, 2019
17:45 PM
reosarevok
(I only noticed when yvanzo asked me to put the reverting commit on beta, so I didn't even know you did it at first :D )
2019-10-17 29015, 2019
17:51 PM
bitmap
iirc it went from ~.1 to ~4000 ms
2019-10-17 29036, 2019
17:52 PM
reosarevok
jeesus
2019-10-17 29054, 2019
17:52 PM
reosarevok
Wanna test how slow the sorting in a release collection is? :p
2019-10-17 29004, 2019
17:54 PM
paurieraf has quit
2019-10-17 29021, 2019
17:55 PM
bitmap
it might be equally slow, but at least that's only done if you select it, heh
2019-10-17 29027, 2019
17:55 PM
bitmap
I can check
2019-10-17 29034, 2019
18:01 PM
bitmap
(also, now that the DB server isn't overloaded, the slow catno query only takes ~1000ms, so that was misleading, it's only 10,000x slower :P)
2019-10-17 29055, 2019
18:03 PM
reosarevok
(yaaaaay.)
2019-10-17 29015, 2019
18:07 PM
bitmap
the collection one is just as slow
2019-10-17 29047, 2019
18:08 PM
bitmap
just that waiting an extra second for the page to load isn't unbearable, and it's an infrequent query so it doesn't cause a server meltdown
2019-10-17 29007, 2019
18:09 PM
reosarevok
I guess
2019-10-17 29016, 2019
18:09 PM
reosarevok
Would it still be safe putting it elsewhere?
2019-10-17 29040, 2019
18:09 PM
reosarevok
I guess it shouldn't be a big deal unless someone started a popular userscript to request that order automatically on page load...
2019-10-17 29041, 2019
18:09 PM
bitmap
maybe-ish but I'd rather look into why it's slow first
2019-10-17 29059, 2019
18:09 PM
reosarevok
Is that volunteering I hear? :p
2019-10-17 29007, 2019
18:10 PM
bitmap
crap
2019-10-17 29044, 2019
18:10 PM
bitmap
if you add the ticket, lol
2019-10-17 29055, 2019
18:10 PM
reosarevok
Ok
2019-10-17 29010, 2019
18:11 PM
reosarevok
In general, do you feel the ordering system makes sense?
2019-10-17 29025, 2019
18:11 PM
reosarevok
Like, this issue aside, is this good enough to put everywhere?
2019-10-17 29058, 2019
18:11 PM
reosarevok
Or is it a hacky mess we should improve first?
2019-10-17 29044, 2019
18:13 PM
bitmap
sure, it's more the pagination that's not so efficient than the ordering (poor indexes notwithstanding)
2019-10-17 29056, 2019
18:14 PM
reosarevok
I mean, redoing the query every time seems like a mess but I guess with pagination that might be the least bad thing anyway
2019-10-17 29006, 2019
18:15 PM
reosarevok
And without pagination some pages would die, so eh
2019-10-17 29019, 2019
18:17 PM
bitmap
2019-10-17 29007, 2019
18:20 PM
reosarevok
Hmm
2019-10-17 29019, 2019
18:20 PM
reosarevok
Not being able to fetch page X immediately seems like a pretty bad drawback
2019-10-17 29059, 2019
18:20 PM
bitmap
yeah
2019-10-17 29017, 2019
18:21 PM
reosarevok
(I know I certainly load the next bunch of pages in one go often, and I sometimes just jump around like "hmm, I bet stuff starting with S is around page 50"
2019-10-17 29018, 2019
18:21 PM
reosarevok
)
2019-10-17 29052, 2019
18:22 PM
bitmap
but if you have a 100 pages list we're also probably not giving good enough options to filter that properly
2019-10-17 29020, 2019
18:23 PM
reosarevok
Sure, that's also true
2019-10-17 29018, 2019
18:28 PM
reosarevok
2019-10-17 29018, 2019
18:28 PM
BrainzBot
MBS-10434: Investigate slowness of sorting by catalog number
2019-10-17 29023, 2019
18:29 PM
bitmap
thanks :) not sure either
2019-10-17 29058, 2019
18:55 PM
yvanzo
2019-10-17 29058, 2019
18:55 PM
BrainzBot
2019-10-17 29018, 2019
18:59 PM
yvanzo
(btw, it also makes sense to me to replace date/country columns with release event column)
2019-10-17 29047, 2019
19:00 PM
yvanzo
(except if sortable by year/by country is wished)
2019-10-17 29023, 2019
19:02 PM
yvanzo
bitmap, reosarevok: I have been trying to use react-table that features client-side sorting pagination.
2019-10-17 29034, 2019
19:03 PM
reosarevok
2019-10-17 29035, 2019
19:03 PM
BrainzBot
MBS-10229: Block smart links
2019-10-17 29005, 2019
19:04 PM
yvanzo
right, thanks!
2019-10-17 29050, 2019
19:17 PM
yvanzo
bitmap: sorry that was just an example for exactly the same issue as the ticket.
2019-10-17 29033, 2019
19:21 PM
Freso
pristine__: Do you still need GCI link?
2019-10-17 29008, 2019
19:22 PM
Freso
Cyna: Like I said in the meeting, consider the task suggestions page as a "brainstorm" page. If you think something might be applicable, go ahead and add it.
2019-10-17 29030, 2019
19:47 PM
SothoTalKer
helo
2019-10-17 29045, 2019
19:51 PM
bitmap
yvanzo: yea it's the same issue, I think we need to keep the Date / Country names for sorting to work but I did add an aria-label of "Release events"
2019-10-17 29055, 2019
19:52 PM
bitmap
react-table looks like a good replacement for the tablesorter plugin I guess
2019-10-17 29005, 2019
19:59 PM
paurieraf joined the channel
2019-10-17 29017, 2019
20:32 PM
paurieraf has quit
2019-10-17 29046, 2019
20:46 PM
Lotheric_ joined the channel
2019-10-17 29002, 2019
20:48 PM
Lotheric has quit
2019-10-17 29051, 2019
20:49 PM
Lotheric_ is now known as Lotheric
2019-10-17 29041, 2019
21:35 PM
HenryG has quit
2019-10-17 29027, 2019
21:37 PM
HenryG joined the channel
2019-10-17 29053, 2019
22:32 PM
paurieraf joined the channel
2019-10-17 29050, 2019
22:36 PM
paurieraf has quit
2019-10-17 29023, 2019
23:14 PM
zas
2019-10-17 29056, 2019
23:34 PM
Lotheric_ joined the channel
2019-10-17 29017, 2019
23:35 PM
Lotheric has quit
2019-10-17 29008, 2019
23:36 PM
Lotheric_ is now known as Lotheric
