#metabrainz

Hoping that's the plan you asked about!

Error (500) Similarity server returned error 400

ruaok: works well :)

track not found in index, basically.

ah, right

your and aidanlw17's fault not mine. :)

well, fault is quite a strong word

are you still hitting our endpoint? or do you have the indices yourself?

I've written my own endpoint in your path codebase.

Project bookbrainz-site build #2378: errored in 12 min 35 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

right, so we should improve that to not fail in this case

Happily surprised by both yours and Rob's reaction :) guess it isn't that bad. Though I know you are not the biggest fan of Spain!

Haha. I haven't used the service but a couple people I do like it

And I'm not a fan, but from what I've heard / read, it sounds like a step up

so what am I looking at here? there are the distances, and the % is how far off the actual values are?

the card always works, which I can't say for my spanish or US cards.

Spain I mean :p

reosarevok: oh heh.

alastairp: its a bit confusing, I hope to improve it next week with Mr_Monkey

... a couple people I KNOW do like it

me slow

acoustic, aggressive, bmp, energy (spectral energy) happy and party are high level metrics.

small suggestion, it'd be nice that clicking submit is a GET request or similar, so that we can paste urls around to show interesting results

and the first number for each column is the value that we get from AB. the percent is how that value changes from the base track

yeah, right

cool

Hehe nice nice. I hope both Spain and N26 grows on you ;)

alastairp: yeah, the UI stuff is all quite raw, but duly noted.

which is why there are no % for mfccw, because it's a vector and you don't really know how to calculate difference? :)

alastairp: avg diff is the average difference of all the differences and thus the point that is being used for final sort order.

anyway, I used https://musicbrainz.org/recording/471dc436-80be... mfccw similarity and the top 3 were 3 other mbids for the same track

which is great

chhavi_: Don't listen to grumpysarevok. I think nobody who's left really likes the country they're from ;)

alastairp: because I am no post filtering on mfccw -- only the other metrics, so I don't calculate anything for it.

but since the player is busted, I've spot checked results so far and its improved quite a lot

Mr_Monkey: Plus reo hasn't been to New Delhi yet. He will start loving Spain after it :P

ha, no.

fat chance getting him to go to Delhi. lol.

I mean, I could go

I might have a heart attack though

How's the ER queue?

pretty much.

Reo, we still like you enough to not take you to Delhi :)

speak for yourself, chhavi_.

Haha :D

Freso: ping

[bookbrainz-site] sbvkrishna opened pull request #307 (master…fix-BB354): add passing warnMessage from new-date-field https://github.com/bookbrainz/bookbrainz-site/p...

ruaok: pong? (meeting doodle? looking now)

exactly.

[bookbrainz-site] panwarabhishek345 closed pull request #306 (master…500-error-fix): BB-353 fix: Editing some author entities return 500 error. https://github.com/bookbrainz/bookbrainz-site/p...

BB-353: Editing some author entities return 500 error https://tickets.metabrainz.org/browse/BB-353

[bookbrainz-site] panwarabhishek345 opened pull request #308 (master…500-error-fix): fix(profile):(Updated)Fixed the 500 error when Editing some author entities. https://github.com/bookbrainz/bookbrainz-site/p...

It's PR day for BookBrainz ! :)

🎉

PR day ?

PRocrastination day

lol

Thats basically my every day :)

[musicbrainz-server] mwiencek merged pull request #1224 (master…enable-flow-features): Enable some Flow features https://github.com/metabrainz/musicbrainz-serve...

reosarevok: what is mommy shark and baby shark milestones 🤔

We release every two weeks

Baby Shark was last release, the one currently in beta is Mommy Shark

Next is Daddy Shark

I think I missed something before. Is there any significance to the release names?

chhavi_: ima need a n26 account soon. They won't verify with my passport. Can't you start sooner? 😏

rdswift: No.

reosarevok: yvanzo: around?

More or less

yup

Flying tomorrow so I'm packing etc, but up for actual talking / deciding. Maybe not code review / fixing rn tho

no problem

can we decide what we're moving from https://github.com/metabrainz/musicbrainz-serve... to daddy shark and add more stuff to the latter?

yvanzo: you left an open-ended comment on https://github.com/metabrainz/musicbrainz-serve... but didn't request any changes, so not sure what the status of that one is

not sure I have a suggestion for this one but keep it readable!

I think reosarevok wanted to expand https://github.com/metabrainz/musicbrainz-serve... to other entities before merging, so maybe that one can be moved

do you find italics to be unreadable?

just trying to figure out how to progress on this :)

heterogeneous styling is not desirable imho

would you be okay with removing the italics but keeping the positioning etc. the same?

I'd move that one to Daddy, yeah

okay, moving the merge queue one

I'm afraid the DB genres one might be too much to merge this late, so should probably move that one too

bitmap, reosarevok: maybe using the the same frame styling as for ar-desc would do, like for https://github.com/metabrainz/musicbrainz-serve...

(that was about https://github.com/metabrainz/musicbrainz-serve... but yes it can be moved to DS)

ok that sounds like it might work

Maybe :)

or some kind of border, idk

reosarevok: you'll be at a conference for the rest of the week right?

(some of these smaller ones might be fine to still include in mommy shark if you have time to update them, just not sure you do)

I will be mostly off on tomorrow too.

gotcha

I am, but will have some time to code

That said, not in a hurry, they can be reviewed this week anyway but left for DS

alrighty, I think we can just move everything that's left to DS then except maybe https://github.com/metabrainz/musicbrainz-serve...

that seems fine to merge before updating whatever docker configuration is needed anyway, right?

yes

feel free to merge it then, I left it in MS

I'd like to include https://github.com/metabrainz/musicbrainz-serve... just so I don't have to fix conflicts anymore :)

In MS?

[musicbrainz-server] yvanzo merged pull request #1195 (master…test-sq): Add Albanian (sq) to tested languages https://github.com/metabrainz/musicbrainz-serve...

in DS

MS has been cleared out except for what's already been merged

Oh

Then sure :)

in fact we already have quite a few things in DS though some of these are already mostly-reviewed leftovers

so if you want to go ahead and add any more older small PRs you have up to DS when you're done packing

Let's see :) Hopefully we can merge a good bunch of DS even before MS is released

yup

I will be off on 11th Nov, should we move DS to 13th?

We can probably manage to release on our own if needed :)

yea, I can do the release in that case

[listenbrainz-server] mayhem merged pull request #650 (master…dependabot/pip/flask-sqlalchemy-2.4.1): Bump flask-sqlalchemy from 2.4.0 to 2.4.1 https://github.com/metabrainz/listenbrainz-serv...

why metabrainz/musicbrainz-tests:2019-09 isn't in .circleci/config.yml?

[listenbrainz-server] mayhem merged pull request #652 (master…dependabot/pip/pytz-2019.3): Bump pytz from 2019.2 to 2019.3 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] mayhem merged pull request #653 (master…dependabot/pip/pytest-cov-2.8.1): Bump pytest-cov from 2.7.1 to 2.8.1 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] mayhem merged pull request #656 (master…dependabot/pip/redis-3.3.11): Bump redis from 3.3.8 to 3.3.11 https://github.com/metabrainz/listenbrainz-serv...

that image should probably be deleted

I think I was making changes to the Dockerfile to try to fix those permissions issues on circleci during the summit, but reverted them

done

yvanzo: https://github.com/metabrainz/musicbrainz-serve... was changed to disallow mul but awaits your feedback (might be something we can add to DS)

that's a wrap for now, but we can improve on the DS milestone during the rest of the week

Ok, I will review it!

I will work on making https://github.com/metabrainz/musicbrainz-serve... ready for DS.

cool, I can check it this week

[listenbrainz-server] mayhem merged pull request #654 (master…dependabot/pip/pytest-5.2.1): Bump pytest from 5.1.3 to 5.2.1 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] mayhem merged pull request #655 (master…dependabot/pip/jsonschema-3.1.1): Bump jsonschema from 3.0.2 to 3.1.1 https://github.com/metabrainz/listenbrainz-serv...

rdswift: don't listen to Freso, the release names coem from https://www.youtube.com/watch?v=FX20kcp7j5c

CatQuest, that explains a lot. :-) Thanks.