Ah, I see. Could you amend the comment for that bit of css then, to explain why it's needed? There isn't much missing, just a bit more context
sbvkrishna
sure. The problem is- the styles for the icons (those I added) were being added pretty late, which is making the already rendered icons pretty big on screen. I was looking for a solution and added the styles explicily, so that I won't forget about it
particularly the 'height' property, which defaults to 'auto'
so I have used 'height: 1em;' explicitly, which is implemented first, and when the FontAwesome styles load, it is overriding the existing styles (with same styles).
Mr_Monkey actually should we merge the second commit in the PR-317 (which removes old font-awesome) before migration completes? It won't raise any errors, but icons in pending pages will be missing.
Anish1712 has quit
rdswift
<amCap1712> can you try with deadbeef above 1.0? Not easily, because it's not available packaged for the version of Linux on that machine, so I would have to try to compile from source, which means (manually) installing / updating all the tools and dependencies.
Mr_Monkey
sbvkrishna: I think that's acceptable; at least the goal of the tasks will be clear !
The other option would be to merge PR #317 without the last commit, and add a sub-task that describes said necessary cleanup as a potential GCI task. Not sure that's necessary
I think we can plan to merge the PR just before GCI, and merge the PRs from the GCI tasks as they come.
sbvkrishna
yeah I just wanted to verify that the 2nd commit works and I unknowingly completed the task :D
also, I've reported another 'potential' GCI task if you didn't see :) - BB-362
sbvkrishna: Well, there's still the unofficial react-fontawesome package in package.json, which isn't much of a task by itself. If you're up for it, you can undo the cleanup commit of your PR and we'll consider that it's part of a GCI task insteada
Ah thanks ! :)
sbvkrishna
sounds good!
KassOtsimine joined the channel
I might not be available daily till 21st, because of exams, but expect me atleast once in 2-3 days.
rdswift
amCap1712: The new file works, sort of. My listens show up in the "My Listens", "Recent" and "Follow" tabs, but only after the track is completed, and don't show up at all in the "listening Now" section of the "Follow" tab. Also, it only works for the first song played. All subsequent songs don't show up anywhere.
antlarr has quit
antlarr joined the channel
Also looks like the lastfm proxy quit working a couple of months ago.
production showed me i got a new edit now, beta showed me nothing, even though i had not viewed it yet
*note
reosarevok
That's connected to your cookies I think
(you probably dismissed the banner on beta but not prod, those are separate)
SothoTalKer
nope (:
reosarevok
Anyway, I found a bug, but it wouldn't have worked anywhere we use React, and would work anywhere we didn't
So that's why I was asking - if you saw it in your user page, that'd explain that
SothoTalKer
at least not that i know of
reosarevok
Since that just got converted
bitmap
zas: I don't see anything out of the ordinary in the website logs on pink (haven't the other times I checked either). the container is identical to every other node and yet only pink has problems for some reason
SothoTalKer
if it works for you, just close it with not reproduceable :)
reosarevok
I mean, there was a bug anyway
So that should be fixed now (with the next release, anyway)
I'm just trying to figure out if that's what you saw or there's something else too :)
SothoTalKer
why don't you make a not to one of my edits :D
reosarevok
Was going to propose that
Read your notes on both servers, and then I'll leave a note
SothoTalKer
well, i do not have any open edits now :x
reosarevok
Doesn't need to be open IIRC
SothoTalKer
currently, all are read
reosarevok
Try now
I mean, beta is released, so rn there shouldn't be any difference at all
SothoTalKer
prod shows the note, beta does not
reosarevok
Huh. They're running the same code
So it has to be something else
Maybe we're failing to overwrite the cookie
bitmap: ^ suggestions?
SothoTalKer
i can log out, clear cookies and re login ^^
bitmap
hmm, which page are you trying to view the notes on?
SothoTalKer: can you check your new_edit_notes_dismissed_mtime cookie first?
In both servers, ideally
SothoTalKer
i don't have it on beta
bitmap
that page should still be .tt in both sites
SothoTalKer
i have server_details and alert as dismissed cookies
on prod i have the new_edit_notes cookie
_dismissed_mtime, but too lazy to type :p
bitmap
oh
prod & beta have separate redis stores, so the person leaving the note has to be on the same server as the person reading it
reosarevok
... really?
bitmap
yeah. which is definitely dumb
reosarevok
That's kinda awful - can it be avoided?
Anyway, that's probably why then but you still made us find a bug, so !m SothoTalKer
!m SothoTalKer
BrainzBot
You're doing good work, SothoTalKer!
SothoTalKer
dunno o.o
bitmap
we should probably move these keys to the cache rather than the store, and just have a high ttl on the keys so they don't get evicted (if that's possible with the eviction policy we're using)
since prod & beta share a cache
SothoTalKer
sounds complicated
reosarevok
Sounds like bitmap is volunteering
bitmap
got me
reosarevok
Is this relatively simple? Probably not GCI simple?
SothoTalKer
at least i got the email regarding the note ;)
reosarevok
Sorry about that note :p
bitmap
prob not gci, I'll just look at it now before I lose my train of thought
first, let's make a ticket, then let's make another ticket :)
reosarevok
Oh, yeah, you mentioned that one
Make a STYLE ticket with some examples, if I like it (chances are I will) you can make an implementation ticket and add it yourself :p
SothoTalKer
yep. well it's not urgent. i'll whip something up until weekend hopefully
reosarevok
ruaok: wow, I think this is the first time I've actually seen a party I voted for get into government of anything. I mean, assuming they don't fuck it up
