Ah, I see. Could you amend the comment for that bit of css then, to explain why it's needed? There isn't much missing, just a bit more context
2019-11-12 31657, 2019
sbvkrishna
sure. The problem is- the styles for the icons (those I added) were being added pretty late, which is making the already rendered icons pretty big on screen. I was looking for a solution and added the styles explicily, so that I won't forget about it
2019-11-12 31632, 2019
sbvkrishna
particularly the 'height' property, which defaults to 'auto'
2019-11-12 31620, 2019
sbvkrishna
so I have used 'height: 1em;' explicitly, which is implemented first, and when the FontAwesome styles load, it is overriding the existing styles (with same styles).
Mr_Monkey actually should we merge the second commit in the PR-317 (which removes old font-awesome) before migration completes? It won't raise any errors, but icons in pending pages will be missing.
2019-11-12 31610, 2019
Anish1712 has quit
2019-11-12 31640, 2019
rdswift
<amCap1712> can you try with deadbeef above 1.0? Not easily, because it's not available packaged for the version of Linux on that machine, so I would have to try to compile from source, which means (manually) installing / updating all the tools and dependencies.
2019-11-12 31652, 2019
Mr_Monkey
sbvkrishna: I think that's acceptable; at least the goal of the tasks will be clear !
2019-11-12 31652, 2019
Mr_Monkey
The other option would be to merge PR #317 without the last commit, and add a sub-task that describes said necessary cleanup as a potential GCI task. Not sure that's necessary
2019-11-12 31659, 2019
Mr_Monkey
I think we can plan to merge the PR just before GCI, and merge the PRs from the GCI tasks as they come.
2019-11-12 31631, 2019
sbvkrishna
yeah I just wanted to verify that the 2nd commit works and I unknowingly completed the task :D
2019-11-12 31638, 2019
sbvkrishna
also, I've reported another 'potential' GCI task if you didn't see :) - BB-362
sbvkrishna: Well, there's still the unofficial react-fontawesome package in package.json, which isn't much of a task by itself. If you're up for it, you can undo the cleanup commit of your PR and we'll consider that it's part of a GCI task insteada
2019-11-12 31615, 2019
Mr_Monkey
Ah thanks ! :)
2019-11-12 31635, 2019
sbvkrishna
sounds good!
2019-11-12 31604, 2019
KassOtsimine joined the channel
2019-11-12 31630, 2019
sbvkrishna
I might not be available daily till 21st, because of exams, but expect me atleast once in 2-3 days.
2019-11-12 31628, 2019
rdswift
amCap1712: The new file works, sort of. My listens show up in the "My Listens", "Recent" and "Follow" tabs, but only after the track is completed, and don't show up at all in the "listening Now" section of the "Follow" tab. Also, it only works for the first song played. All subsequent songs don't show up anywhere.
2019-11-12 31642, 2019
antlarr has quit
2019-11-12 31647, 2019
antlarr joined the channel
2019-11-12 31638, 2019
rdswift
Also looks like the lastfm proxy quit working a couple of months ago.
production showed me i got a new edit now, beta showed me nothing, even though i had not viewed it yet
2019-11-12 31604, 2019
SothoTalKer
*note
2019-11-12 31620, 2019
reosarevok
That's connected to your cookies I think
2019-11-12 31644, 2019
reosarevok
(you probably dismissed the banner on beta but not prod, those are separate)
2019-11-12 31656, 2019
SothoTalKer
nope (:
2019-11-12 31604, 2019
reosarevok
Anyway, I found a bug, but it wouldn't have worked anywhere we use React, and would work anywhere we didn't
2019-11-12 31617, 2019
reosarevok
So that's why I was asking - if you saw it in your user page, that'd explain that
2019-11-12 31618, 2019
SothoTalKer
at least not that i know of
2019-11-12 31636, 2019
reosarevok
Since that just got converted
2019-11-12 31605, 2019
bitmap
zas: I don't see anything out of the ordinary in the website logs on pink (haven't the other times I checked either). the container is identical to every other node and yet only pink has problems for some reason
2019-11-12 31606, 2019
SothoTalKer
if it works for you, just close it with not reproduceable :)
2019-11-12 31616, 2019
reosarevok
I mean, there was a bug anyway
2019-11-12 31627, 2019
reosarevok
So that should be fixed now (with the next release, anyway)
2019-11-12 31638, 2019
reosarevok
I'm just trying to figure out if that's what you saw or there's something else too :)
2019-11-12 31656, 2019
SothoTalKer
why don't you make a not to one of my edits :D
2019-11-12 31604, 2019
reosarevok
Was going to propose that
2019-11-12 31614, 2019
reosarevok
Read your notes on both servers, and then I'll leave a note
2019-11-12 31615, 2019
SothoTalKer
well, i do not have any open edits now :x
2019-11-12 31623, 2019
reosarevok
Doesn't need to be open IIRC
2019-11-12 31630, 2019
SothoTalKer
currently, all are read
2019-11-12 31659, 2019
reosarevok
Try now
2019-11-12 31618, 2019
reosarevok
I mean, beta is released, so rn there shouldn't be any difference at all
2019-11-12 31628, 2019
SothoTalKer
prod shows the note, beta does not
2019-11-12 31639, 2019
reosarevok
Huh. They're running the same code
2019-11-12 31644, 2019
reosarevok
So it has to be something else
2019-11-12 31602, 2019
reosarevok
Maybe we're failing to overwrite the cookie
2019-11-12 31619, 2019
reosarevok
bitmap: ^ suggestions?
2019-11-12 31632, 2019
SothoTalKer
i can log out, clear cookies and re login ^^
2019-11-12 31634, 2019
bitmap
hmm, which page are you trying to view the notes on?
SothoTalKer: can you check your new_edit_notes_dismissed_mtime cookie first?
2019-11-12 31622, 2019
reosarevok
In both servers, ideally
2019-11-12 31644, 2019
SothoTalKer
i don't have it on beta
2019-11-12 31646, 2019
bitmap
that page should still be .tt in both sites
2019-11-12 31623, 2019
SothoTalKer
i have server_details and alert as dismissed cookies
2019-11-12 31655, 2019
SothoTalKer
on prod i have the new_edit_notes cookie
2019-11-12 31607, 2019
SothoTalKer
_dismissed_mtime, but too lazy to type :p
2019-11-12 31620, 2019
bitmap
oh
2019-11-12 31608, 2019
bitmap
prod & beta have separate redis stores, so the person leaving the note has to be on the same server as the person reading it
2019-11-12 31631, 2019
reosarevok
... really?
2019-11-12 31655, 2019
bitmap
yeah. which is definitely dumb
2019-11-12 31655, 2019
reosarevok
That's kinda awful - can it be avoided?
2019-11-12 31613, 2019
reosarevok
Anyway, that's probably why then but you still made us find a bug, so !m SothoTalKer
2019-11-12 31618, 2019
reosarevok
!m SothoTalKer
2019-11-12 31618, 2019
BrainzBot
You're doing good work, SothoTalKer!
2019-11-12 31656, 2019
SothoTalKer
dunno o.o
2019-11-12 31601, 2019
bitmap
we should probably move these keys to the cache rather than the store, and just have a high ttl on the keys so they don't get evicted (if that's possible with the eviction policy we're using)
2019-11-12 31609, 2019
bitmap
since prod & beta share a cache
2019-11-12 31648, 2019
SothoTalKer
sounds complicated
2019-11-12 31658, 2019
reosarevok
Sounds like bitmap is volunteering
2019-11-12 31632, 2019
bitmap
got me
2019-11-12 31614, 2019
reosarevok
Is this relatively simple? Probably not GCI simple?
2019-11-12 31632, 2019
SothoTalKer
at least i got the email regarding the note ;)
2019-11-12 31613, 2019
reosarevok
Sorry about that note :p
2019-11-12 31622, 2019
bitmap
prob not gci, I'll just look at it now before I lose my train of thought
first, let's make a ticket, then let's make another ticket :)
2019-11-12 31658, 2019
reosarevok
Oh, yeah, you mentioned that one
2019-11-12 31622, 2019
reosarevok
Make a STYLE ticket with some examples, if I like it (chances are I will) you can make an implementation ticket and add it yourself :p
2019-11-12 31623, 2019
SothoTalKer
yep. well it's not urgent. i'll whip something up until weekend hopefully
2019-11-12 31616, 2019
reosarevok
ruaok: wow, I think this is the first time I've actually seen a party I voted for get into government of anything. I mean, assuming they don't fuck it up
