yvanzo: no visual (UI) differences, only that some artists which are not connected to writing at all get filtered out from the writers display. So "dedicated to" (for example) won't be shown in the Writers column in the works page nor under Writers in inline search :)
Once you approve, I will add tests and then we can head towards merging :)
2019-11-20 32433, 2019
antlarr has quit
2019-11-20 32434, 2019
antlarr joined the channel
2019-11-20 32437, 2019
ruaok
the delete_model function seems a bit odd. it deletes everything in that dir -- won't that nuke all the models?
2019-11-20 32441, 2019
ruaok
pristine__: ^
2019-11-20 32452, 2019
pristine__
Right now we are saving only the current model in HDFS. When we will want to save more than one we can simply pass model_id to this function and delete that particular model
2019-11-20 32437, 2019
ruaok
I think it might be good to add that functionality now.
2019-11-20 32400, 2019
ruaok
because when we get to the point where want to have more than one model, we need to code it, review it and merge it before we can.
2019-11-20 32402, 2019
pristine__
Okay
2019-11-20 32420, 2019
BestSteve has quit
2019-11-20 32443, 2019
BestSteve joined the channel
2019-11-20 32450, 2019
ruaok
but, lets get this PR approved, tests added, merged and then add a new PR for having more than one model, yes?
2019-11-20 32423, 2019
yvanzo
reosarevok: I don’t get why you don’t want this work to show up in there.
2019-11-20 32401, 2019
reosarevok
Because this is not a work by this artist, it's just marginally connected with this artist
2019-11-20 32431, 2019
yvanzo
I disagree, hiding linked data is not an improvement.
2019-11-20 32438, 2019
pristine__
ruaok: sounds good to me. Anyway I can add that feature while writing tests. Not much complex
2019-11-20 32450, 2019
reosarevok
I don't think anyone would expect it to be shown there (this wasn't even originally complained about by me, but in the forum somewhere by others)
2019-11-20 32456, 2019
yvanzo
reosarevok: Maybe we should wait for filters to be available.
2019-11-20 32409, 2019
ruaok
may not be complex, but it makes the PR even long and I have to review it yet again. I would prefer a separate PR.
2019-11-20 32418, 2019
reosarevok
Another option will be to have two versions of the page, a default one without this stuff, and one with all the cruft
2019-11-20 32436, 2019
yvanzo
No, I mean client-side filters.
2019-11-20 32448, 2019
reosarevok
I know, but that'd still show those by default, which is wrong
2019-11-20 32449, 2019
reosarevok
The data is not hidden, it's on the relationships page
that nickname makes it seem that last message very excited :D
2019-11-20 32414, 2019
ruaok
agreed.
2019-11-20 32411, 2019
BrainzGit
[bookbrainz-site] adithyaanilkumar opened pull request #325 (master…adiiiiiiiiiiiiii-contributors-edit): docs: Added Forking and Cloning to CONTRIBUTING.md https://github.com/bookbrainz/bookbrainz-site/pul…
2019-11-20 32443, 2019
adiiiiiiiiiiiiii
I have added some changes to CONTRIBUTING.md as requested. Please verify it.
2019-11-20 32428, 2019
adiiiiiiiiiiiiii
yvanzo: Thank you for the reply. I will look into the website.
2019-11-20 32459, 2019
iliekcomputers
#thisismylifenow
2019-11-20 32431, 2019
ruaok
i know the feeling. :)
2019-11-20 32440, 2019
alastairp
> 10:29 AM <ruaok> alastairp: would fixing the MLHD be one of those topics that would make an academic paper? all the work is practically done.
2019-11-20 32422, 2019
alastairp
yes, sure. something like describing its issues, putting out the fix, and then doing an experiment that shows that the changes make it work much better
2019-11-20 32445, 2019
iliekcomputers
Noice!
2019-11-20 32409, 2019
ruaok
I mean I don't particularly care about academic papers, but if you think it would be worth doing that, and it is something you'd like to be involved in, then sure.
2019-11-20 32426, 2019
ruaok
otherwise I'll fix the dataset and offer it back to Gabriel.
2019-11-20 32432, 2019
ruaok
certainly use it for ourseves.
2019-11-20 32435, 2019
ruaok
ourselves.
2019-11-20 32437, 2019
iliekcomputers
My contribution to academia is very negative rn, I'd like to get in on this
2019-11-20 32440, 2019
iliekcomputers
😂
2019-11-20 32400, 2019
alastairp
it's definitely something that could be written
2019-11-20 32407, 2019
ruaok
I thought you were trying to avoid academia.
2019-11-20 32418, 2019
ruaok
alastairp: doesn't sound very definitive. :)
2019-11-20 32434, 2019
ruaok
how about we fix the dataset, look at the popularity data and then see if we want to do a paper?
2019-11-20 32451, 2019
alastairp
just for an overview: the mbids in the dataset are bad? (because of lastfm badness?) and that means... that algorithms that use the data can't utilise all of its value?
2019-11-20 32415, 2019
ruaok
remember how last.fm never fully deconflated their artists?
2019-11-20 32419, 2019
alastairp
yeah
2019-11-20 32441, 2019
alastairp
if you can concretely show that using the fixed version makes algorithm x work y% better, that's a paper that can be written in less than a week
2019-11-20 32450, 2019
ruaok
the artist popularity data iliekcomputers cacluated had obvious problems in like two or more artists called "muse"
2019-11-20 32452, 2019
iliekcomputers
ruaok: I'm trying to avoid mandatory academic obligations, to be accurate.
2019-11-20 32401, 2019
ruaok
iliekcomputers: got it.
2019-11-20 32456, 2019
ruaok
alastairp: we should be able to quantify the results in the context of artist popularity, for sure.
2019-11-20 32459, 2019
ruaok
not sure if that is sufficient.
2019-11-20 32400, 2019
alastairp
it could be interesting [ok, ok, in an academic context] to look and see if anyone else is using the data in that way
2019-11-20 32409, 2019
alastairp
and show how their process is flawed because of x, y, z
2019-11-20 32426, 2019
sbvkrishna
adiiiiiiiiiiiiii: Hi ! we are currently trying to improve the documentation for new-comers at https://github.com/bookbrainz/bookbrainz-site/pul… and if you are interested, you're welcome to give suggestions :)
