18:54 PM
reosarevok
Oh, wait, that seems perfectly fine
2019-12-04 33859, 2019
18:54 PM
bitmap
but right now it uses a separate string for that, 'Medium {position}: {title}'
2019-12-04 33815, 2019
18:55 PM
reosarevok
yvanzo: ok, I'd rerun the selenium test to see if it's it just being shit again, let's see
2019-12-04 33816, 2019
18:55 PM
bitmap
dunno if that's necessary
2019-12-04 33824, 2019
18:55 PM
reosarevok
Hmm. I can't see why it'd be needed tbh
2019-12-04 33824, 2019
18:55 PM
nav2002_ joined the channel
2019-12-04 33851, 2019
18:55 PM
bitmap
it could be argued that l('Medium') isn't a format
2019-12-04 33822, 2019
18:56 PM
reosarevok
I mean, it could, but I'd be surprised to see it being a problem that it's translated in the same way as CD would
2019-12-04 33824, 2019
18:56 PM
bitmap
so substituting that might not make sense in some cases?
2019-12-04 33839, 2019
18:56 PM
bitmap
alright then
2019-12-04 33842, 2019
18:56 PM
reosarevok
I dunno. I mean, I'm fine with what we have too
2019-12-04 33847, 2019
18:56 PM
reosarevok
yvanzo: what do you think?
2019-12-04 33817, 2019
18:57 PM
bitmap
also the medium_description macro uses add_colon to join '{medium_format} {position}' with the title instead of having one '{medium_format} {position}: {title}' string
2019-12-04 33829, 2019
18:57 PM
bitmap
we should prob pick one way and combine these
2019-12-04 33842, 2019
18:57 PM
BrainzGit
2019-12-04 33843, 2019
18:57 PM
BrainzBot
2019-12-04 33831, 2019
18:59 PM
reosarevok
yvanzo: re the flow eslint thing
2019-12-04 33850, 2019
18:59 PM
yvanzo
reosarevok: I mean, can you please test it once again? (last minute changes sometimes have surprises)
2019-12-04 33857, 2019
18:59 PM
reosarevok
yvanzo: sure, I can
2019-12-04 33804, 2019
19:00 PM
reosarevok
re: eslint, It would for example mean that we wouldn't have genreMap: {+[string]: GenreT, ...}; on TagEditor, but genreMap: {+[descriptive-key: string]: GenreT, ...};
2019-12-04 33811, 2019
19:00 PM
yvanzo
So we can merge it without waiting for Selenium tests to pass again.
2019-12-04 33839, 2019
19:00 PM
reosarevok
I'd tell you what the descriptive key would be, but I've forgotten what the key string is, which proves my point of why it'd be nice to have :p
2019-12-04 33847, 2019
19:00 PM
bitmap
tagName: string probably
2019-12-04 33817, 2019
19:01 PM
bitmap
just makes it clear how the object is supposed to be used by reading the type
2019-12-04 33831, 2019
19:01 PM
reosarevok
+stats: {[string]: number}, would become +stats: {[statName: string]: number},
2019-12-04 33839, 2019
19:01 PM
reosarevok
OR something to that effect, in the stats code
2019-12-04 33857, 2019
19:01 PM
yvanzo
Thank you!
2019-12-04 33818, 2019
19:06 PM
rahul24 has quit
2019-12-04 33834, 2019
19:07 PM
BrainzGit
2019-12-04 33852, 2019
19:08 PM
BrainzGit
2019-12-04 33852, 2019
19:08 PM
BrainzBot
2019-12-04 33853, 2019
19:09 PM
reosarevok
2019-12-04 33813, 2019
19:11 PM
rahul24 joined the channel
2019-12-04 33843, 2019
19:11 PM
BrainzGit
2019-12-04 33844, 2019
19:11 PM
BrainzBot
2019-12-04 33837, 2019
19:12 PM
iliekcomputers
pristine__: did you make the test dir in listenbrainz-labs because of import problems?
2019-12-04 33808, 2019
19:13 PM
reosarevok
2019-12-04 33848, 2019
19:13 PM
reosarevok
2019-12-04 33814, 2019
19:14 PM
reosarevok
2019-12-04 33809, 2019
19:18 PM
yvanzo
reosarevok: I removed myself from 1285 reviewers as it is English text change only, thus it can be merged. :)
2019-12-04 33827, 2019
19:18 PM
BrainzGit
2019-12-04 33829, 2019
19:18 PM
BrainzBot
2019-12-04 33830, 2019
19:18 PM
reosarevok
If you're sure :)
2019-12-04 33830, 2019
19:19 PM
yvanzo
deploying 1246 to test.mb.o for quick review
2019-12-04 33851, 2019
19:19 PM
reosarevok
2019-12-04 33802, 2019
19:21 PM
bitmap
I still agree with my last comment there (so I think displaying the full relationships might be a better solution but am fine with merging this)
2019-12-04 33828, 2019
19:21 PM
bitmap
approved it since it appears I didn't do that
2019-12-04 33848, 2019
19:22 PM
reosarevok
I can't imagine how to do that without making a huge mess of the table
2019-12-04 33811, 2019
19:23 PM
CatQuest
\o/
2019-12-04 33826, 2019
19:23 PM
CatQuest
any improvement of this is bestter
2019-12-04 33830, 2019
19:23 PM
reosarevok
Like, if we had all rels inline under the stuff, it'd make the table huge :/
2019-12-04 33853, 2019
19:23 PM
CatQuest
it will make moving things from generic drum and mebranophone A LOT easier
2019-12-04 33804, 2019
19:25 PM
bitmap
I guess you'd need an option to hide them if it showed the rels
2019-12-04 33829, 2019
19:25 PM
yvanzo
bitmap: Is that something that can be improved more easily after refactoring tables?
2019-12-04 33851, 2019
19:25 PM
CatQuest
don' overthink this please
2019-12-04 33852, 2019
19:25 PM
yvanzo
reosarevok: ^
2019-12-04 33812, 2019
19:26 PM
yvanzo
CatQuest: there already is a PR for that
2019-12-04 33820, 2019
19:26 PM
CatQuest
overthinking?
2019-12-04 33828, 2019
19:26 PM
reosarevok
Yes, there's a few for overthinking :D
2019-12-04 33836, 2019
19:26 PM
bitmap
that'd make hiding stuff easier but don't think it should depend on it
2019-12-04 33843, 2019
19:26 PM
reosarevok
The refactoring tables, I guess - but that's still quite a while away, so I'd still merge this to help CatQuest
2019-12-04 33846, 2019
19:26 PM
reosarevok
If it seems ok
2019-12-04 33850, 2019
19:26 PM
CatQuest
haha probably :D
2019-12-04 33803, 2019
19:28 PM
yvanzo
reosarevok: that is exactly my suggestion, so as to avoid "making a huge mess of the table"
2019-12-04 33846, 2019
19:28 PM
reosarevok
Then I like the suggestion :p
2019-12-04 33851, 2019
19:30 PM
yvanzo
bitmap: I checked 1246 on test.mb.o and I cannot reproduce the two remaining issues you mentioned.
2019-12-04 33852, 2019
19:31 PM
bitmap
for the first one, did the "Subscribed" column update to Yes after you subscribed to a collection?
2019-12-04 33859, 2019
19:31 PM
bitmap
I couldn't get that to work
2019-12-04 33814, 2019
19:32 PM
yvanzo
yes, it works for my account at least
2019-12-04 33808, 2019
19:33 PM
bitmap
2019-12-04 33842, 2019
19:33 PM
reosarevok
2019-12-04 33815, 2019
19:35 PM
yvanzo
bitmap: you ruined my test results :p
2019-12-04 33834, 2019
19:35 PM
bitmap
sorry :P
2019-12-04 33851, 2019
19:35 PM
yvanzo
(deploying it atm)
2019-12-04 33823, 2019
19:37 PM
rahul24 has quit
2019-12-04 33820, 2019
19:38 PM
bitmap
yvanzo: you're still without a local mbs setup, right?
2019-12-04 33853, 2019
19:41 PM
rahul24 joined the channel
2019-12-04 33857, 2019
19:41 PM
nav2002_ has quit
2019-12-04 33827, 2019
19:42 PM
yvanzo
right
2019-12-04 33841, 2019
19:43 PM
bitmap
getting a new laptop first?
2019-12-04 33815, 2019
19:45 PM
BrainzGit
2019-12-04 33851, 2019
19:45 PM
yvanzo
bitmap: got it already :) but still running dev env from chroot (so no lxc atm)
2019-12-04 33811, 2019
19:46 PM
nav2002__ joined the channel
2019-12-04 33814, 2019
19:46 PM
bitmap
ohh nice
2019-12-04 33833, 2019
19:48 PM
yvanzo
bitmap: found the issue with 1246 :)
2019-12-04 33843, 2019
19:48 PM
rahul24 has quit
2019-12-04 33823, 2019
19:49 PM
bitmap
do you see teh css one too?
2019-12-04 33840, 2019
19:49 PM
bitmap
(don't have any collections on test.mb for me to check)
2019-12-04 33829, 2019
19:53 PM
bitmap
nvm I saw you just pushed a fix
2019-12-04 33834, 2019
19:53 PM
yvanzo
stupid typo th->td
2019-12-04 33853, 2019
19:53 PM
yvanzo
building test images with that fix
2019-12-04 33833, 2019
19:54 PM
bitmap
lol
2019-12-04 33841, 2019
19:54 PM
bitmap
how hard will it be to get your local setup working again?
2019-12-04 33826, 2019
19:55 PM
bitmap
waiting for test images to build and deploying them seems much harder :P
2019-12-04 33844, 2019
19:57 PM
BrainzGit
2019-12-04 33804, 2019
20:00 PM
yvanzo
bitmap: check my collections
2019-12-04 33837, 2019
20:02 PM
bitmap
that looks better but I can't test the subscription column there
2019-12-04 33827, 2019
20:03 PM
BrainzGit
2019-12-04 33848, 2019
20:03 PM
BrainzGit
2019-12-04 33814, 2019
20:04 PM
BrainzGit
2019-12-04 33805, 2019
20:08 PM
c1e0 has quit
2019-12-04 33819, 2019
20:15 PM
rahul24 joined the channel
2019-12-04 33842, 2019
20:24 PM
BrainzGit
2019-12-04 33843, 2019
20:24 PM
BrainzBot
2019-12-04 33843, 2019
20:26 PM
antara has quit
2019-12-04 33801, 2019
20:30 PM
BrainzGit
2019-12-04 33803, 2019
20:30 PM
BrainzBot
2019-12-04 33803, 2019
20:30 PM
BrainzBot
2019-12-04 33818, 2019
20:30 PM
rahul24 has quit
2019-12-04 33847, 2019
20:38 PM
sbvkrishna has quit
2019-12-04 33852, 2019
20:47 PM
chirlu joined the channel
2019-12-04 33824, 2019
20:52 PM
bitmap
2019-12-04 33817, 2019
20:54 PM
chirlu has quit
2019-12-04 33816, 2019
20:55 PM
ohrstrom joined the channel
2019-12-04 33834, 2019
21:06 PM
jbs1
Hi -- I was wondering whether you had a process for handling security vulnerabilities?
2019-12-04 33823, 2019
21:08 PM
reosarevok
Heh, already found something?
2019-12-04 33824, 2019
21:08 PM
BrainzGit
2019-12-04 33856, 2019
21:08 PM
reosarevok
jbs1: which of the sites?
2019-12-04 33854, 2019
21:09 PM
jbs1
metabrainz-server, low severity -- to the point where some would debate if it's a security issue (I would argue that it is)
2019-12-04 33858, 2019
21:09 PM
jbs1
I tested locally
2019-12-04 33843, 2019
21:10 PM
reosarevok
if it's metabrainz- rather than musicbrainz- I'd suggest letting ruaok know directly in PM and he can take it from there or suggest you what to do :)
2019-12-04 33820, 2019
21:12 PM
BrainzGit
2019-12-04 33828, 2019
21:13 PM
rahul24 joined the channel
2019-12-04 33837, 2019
21:13 PM
BrainzGit
2019-12-04 33815, 2019
21:15 PM
iliekcomputers
jbs1: happy to help with the issue as well if it's urgent, ruaok might not be around.
2019-12-04 33844, 2019
21:15 PM
reosarevok
iliekcomputers: it was actually MBS, it seems :)
2019-12-04 33856, 2019
21:15 PM
reosarevok
Just a misunderstanding. So we got this
2019-12-04 33859, 2019
21:15 PM
reosarevok
But thanks!
2019-12-04 33803, 2019
21:16 PM
BrainzGit
2019-12-04 33804, 2019
21:16 PM
iliekcomputers
no problem!
2019-12-04 33817, 2019
21:16 PM
reosarevok
jbs1: if you do find something with metabrainz (which isn't impossible either) then you can also contact iliekcomputers :)
2019-12-04 33850, 2019
21:16 PM
iliekcomputers
or any of the other python sites
2019-12-04 33852, 2019
21:19 PM
jbs1
will do, thank you!
2019-12-04 33853, 2019
21:20 PM
rahul24 has quit
2019-12-04 33840, 2019
21:21 PM
ruaok is around enough
2019-12-04 33845, 2019
21:21 PM
CatQuest has quit
2019-12-04 33807, 2019
21:24 PM
iliekcomputers
oh awesome, wasn't sure which timezone you were on :P
2019-12-04 33843, 2019
21:24 PM
rahul24 joined the channel
2019-12-04 33854, 2019
21:24 PM
reosarevok
Oh no. A hint is given
2019-12-04 33827, 2019
21:26 PM
CatQuest joined the channel
2019-12-04 33839, 2019
21:26 PM
iliekcomputers
or maybe a misdirection
2019-12-04 33844, 2019
21:27 PM
CatQuest
ack, what a time to have a disconnect
2019-12-04 33847, 2019
21:27 PM
reosarevok
oh no, not the old ruaok travel bamboozle
2019-12-04 33849, 2019
21:27 PM
BrainzGit
2019-12-04 33809, 2019
21:28 PM
iliekcomputers
odd are the ways of music metadata geeks
2019-12-04 33813, 2019
21:31 PM
iliekcomputers
gonna need a screenshot for that emoji / unicode character CatQuest
2019-12-04 33837, 2019
21:31 PM
CatQuest
iliekcomputers: finally one yo udon't have
2019-12-04 33842, 2019
21:31 PM
CatQuest
2019-12-04 33831, 2019
21:32 PM
iliekcomputers
lol
2019-12-04 33847, 2019
21:37 PM
CatQuest
hm now I wonder how 🖒 looks for you
