#metabrainz

Oh, wait, that seems perfectly fine

but right now it uses a separate string for that, 'Medium {position}: {title}'

yvanzo: ok, I'd rerun the selenium test to see if it's it just being shit again, let's see

dunno if that's necessary

Hmm. I can't see why it'd be needed tbh

it could be argued that l('Medium') isn't a format

I mean, it could, but I'd be surprised to see it being a problem that it's translated in the same way as CD would

so substituting that might not make sense in some cases?

alright then

I dunno. I mean, I'm fine with what we have too

yvanzo: what do you think?

also the medium_description macro uses add_colon to join '{medium_format} {position}' with the title instead of having one '{medium_format} {position}: {title}' string

we should prob pick one way and combine these

[musicbrainz-server] reosarevok merged pull request #1276 (master…MBS-10468): MBS-10468: Stop breaking Bandcamp merch links https://github.com/metabrainz/musicbrainz-serve...

MBS-10468: URL cleanup breaks Bandcamp URLs containing "merch" https://tickets.metabrainz.org/browse/MBS-10468

yvanzo: re the flow eslint thing

reosarevok: I mean, can you please test it once again? (last minute changes sometimes have surprises)

yvanzo: sure, I can

re: eslint, It would for example mean that we wouldn't have genreMap: {+[string]: GenreT, ...}; on TagEditor, but genreMap: {+[descriptive-key: string]: GenreT, ...};

So we can merge it without waiting for Selenium tests to pass again.

I'd tell you what the descriptive key would be, but I've forgotten what the key string is, which proves my point of why it'd be nice to have :p

tagName: string probably

just makes it clear how the object is supposed to be used by reading the type

+stats: {[string]: number}, would become +stats: {[statName: string]: number},

OR something to that effect, in the stats code

Thank you!

[musicbrainz-server] reosarevok merged pull request #1267 (master…eslint-add-require-indexer-name): Adding flow/require-indexer-name to eslintrc https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] yvanzo merged pull request #1299 (master…mbs-10502-rg45cat): MBS-10502: Map 45cat/45worlds records with MB RGs https://github.com/metabrainz/musicbrainz-serve...

MBS-10502: 45cat/45worlds URLs point to the wrong place on MB https://tickets.metabrainz.org/browse/MBS-10502

oh, yvanzo: https://github.com/metabrainz/musicbrainz-serve... passed on second try it seems

[musicbrainz-server] reosarevok merged pull request #1275 (master…MBS-10479): MBS-10479: Show RG types on recording page https://github.com/metabrainz/musicbrainz-serve...

MBS-10479: Show release group types on recording page https://tickets.metabrainz.org/browse/MBS-10479

pristine__: did you make the test dir in listenbrainz-labs because of import problems?

yvanzo: https://github.com/metabrainz/musicbrainz-serve... from bitmap might not be too bad to review maybe?

Oh, yvanzo: also tiny, https://github.com/metabrainz/musicbrainz-serve...

https://github.com/metabrainz/musicbrainz-serve... is also very small and includes a screenshot of the UI change and all, if you want :p

reosarevok: I removed myself from 1285 reviewers as it is English text change only, thus it can be merged. :)

[musicbrainz-server] reosarevok merged pull request #1285 (master…MBS-10489): MBS-10489: Make EnterEditNote text less redundant https://github.com/metabrainz/musicbrainz-serve...

MBS-10489: EnterEditNote text is redundant https://tickets.metabrainz.org/browse/MBS-10489

If you're sure :)

deploying 1246 to test.mb.o for quick review

yvanzo, bitmap: opinions on https://github.com/metabrainz/musicbrainz-serve... by now?

I still agree with my last comment there (so I think displaying the full relationships might be a better solution but am fine with merging this)

approved it since it appears I didn't do that

I can't imagine how to do that without making a huge mess of the table

\o/

any improvement of this is bestter

Like, if we had all rels inline under the stuff, it'd make the table huge :/

it will make moving things from generic drum and mebranophone A LOT easier

I guess you'd need an option to hide them if it showed the rels

bitmap: Is that something that can be improved more easily after refactoring tables?

don' overthink this please

reosarevok: ^

CatQuest: there already is a PR for that

overthinking?

that'd make hiding stuff easier but don't think it should depend on it

The refactoring tables, I guess - but that's still quite a while away, so I'd still merge this to help CatQuest

If it seems ok

haha probably :D

reosarevok: that is exactly my suggestion, so as to avoid "making a huge mess of the table"

Then I like the suggestion :p

bitmap: I checked 1246 on test.mb.o and I cannot reproduce the two remaining issues you mentioned.

for the first one, did the "Subscribed" column update to Yes after you subscribed to a collection?

I couldn't get that to work

yes, it works for my account at least

test.mb.org is running 8d9e70c9d3 though?

Updated https://github.com/metabrainz/musicbrainz-serve... as requested, FWIW - also a very small change, screenshot present

bitmap: you ruined my test results :p

sorry :P

(deploying it atm)

yvanzo: you're still without a local mbs setup, right?

right

getting a new laptop first?

[listenbrainz-labs] paramsingh opened pull request #72 (master…param/test-rabbitmq-consumer): Add tests for request consumer and fix test.sh path problems https://github.com/metabrainz/listenbrainz-labs...

bitmap: got it already :) but still running dev env from chroot (so no lxc atm)

ohh nice

bitmap: found the issue with 1246 :)

do you see teh css one too?

(don't have any collections on test.mb for me to check)

nvm I saw you just pushed a fix

stupid typo th->td

building test images with that fix

lol

how hard will it be to get your local setup working again?

waiting for test images to build and deploying them seems much harder :P

[musicbrainz-server] joker314 opened pull request #1300 (master…refactor/no-negated-condition): Fix issues relating to eslint rule no-negatated-condition https://github.com/metabrainz/musicbrainz-serve...

bitmap: check my collections

that looks better but I can't test the subscription column there

[listenbrainz-server] paramsingh merged pull request #670 (master…dependabot/pip/jsonschema-3.2.0): Bump jsonschema from 3.1.1 to 3.2.0 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] paramsingh merged pull request #671 (master…dependabot/pip/pygments-2.5.2): Bump pygments from 2.4.2 to 2.5.2 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] paramsingh merged pull request #672 (master…dependabot/pip/pytest-5.3.1): Bump pytest from 5.2.4 to 5.3.1 https://github.com/metabrainz/listenbrainz-serv...

[musicbrainz-server] reosarevok merged pull request #1288 (master…MBS-10422): MBS-10422: Add ISRCs to release editor recording search https://github.com/metabrainz/musicbrainz-serve...

MBS-10422: Recording inline search in release editor doesn't display ISRCs https://tickets.metabrainz.org/browse/MBS-10422

[musicbrainz-server] mwiencek merged pull request #1148 (master…mbs-10188): Fix release merge issues MBS-10188 and MBS-10279 https://github.com/metabrainz/musicbrainz-serve...

MBS-10188: "Merge releases" edit is stuck https://tickets.metabrainz.org/browse/MBS-10188

MBS-10279: Release merge edits display stale, possibly incorrect recording merge info https://tickets.metabrainz.org/browse/MBS-10279

yvanzo: can we merge https://github.com/metabrainz/musicbrainz-serve... for this release too?

Hi -- I was wondering whether you had a process for handling security vulnerabilities?

Heh, already found something?

[musicbrainz-server] mwiencek merged pull request #1292 (master…style/react-jsx-handler-names): Eliminate warnings caused by eslint rule react/jsx-handler-names https://github.com/metabrainz/musicbrainz-serve...

jbs1: which of the sites?

metabrainz-server, low severity -- to the point where some would debate if it's a security issue (I would argue that it is)

I tested locally

if it's metabrainz- rather than musicbrainz- I'd suggest letting ruaok know directly in PM and he can take it from there or suggest you what to do :)

[listenbrainz-labs] paramsingh opened pull request #73 (master…param/add_init_py): Add __init__.py to recommendations module https://github.com/metabrainz/listenbrainz-labs...

[musicbrainz-server] mwiencek merged pull request #1294 (master…master): Fix JS to follow the no-cond-assign eslint rule https://github.com/metabrainz/musicbrainz-serve...

jbs1: happy to help with the issue as well if it's urgent, ruaok might not be around.

iliekcomputers: it was actually MBS, it seems :)

Just a misunderstanding. So we got this

But thanks!

[musicbrainz-server] rahulm24 closed pull request #1297 (master…master): Fixed: E-mail verification is sometimes called confirmation https://github.com/metabrainz/musicbrainz-serve...

no problem!

jbs1: if you do find something with metabrainz (which isn't impossible either) then you can also contact iliekcomputers :)

or any of the other python sites

will do, thank you!

oh awesome, wasn't sure which timezone you were on :P

Oh no. A hint is given

or maybe a misdirection

ack, what a time to have a disconnect

oh no, not the old ruaok travel bamboozle

[musicbrainz-server] rahulm24 reopened pull request #1297 (master…master): Fixed: E-mail verification is sometimes called confirmation https://github.com/metabrainz/musicbrainz-serve...

odd are the ways of music metadata geeks

gonna need a screenshot for that emoji / unicode character CatQuest

iliekcomputers: finally one yo udon't have

https://emojipedia.org/pinching-hand/ <-

lol

hm now I wonder how 🖒 looks for you