#metabrainz

/

      • D4RK-PH0ENiX has quit
      • 2019-12-06 34052, 2019

      • moufl joined the channel
      • 2019-12-06 34015, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-12-06 34017, 2019

      • D4RK-PH0ENiX has quit
      • 2019-12-06 34059, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-12-06 34031, 2019

      • jbs1 has quit
      • 2019-12-06 34009, 2019

      • sangeetk joined the channel
      • 2019-12-06 34000, 2019

      • Nyanko-sensei joined the channel
      • 2019-12-06 34027, 2019

      • D4RK-PH0ENiX has quit
      • 2019-12-06 34018, 2019

      • ruaok wonders if bitmap happens to be about
      • 2019-12-06 34041, 2019

      • Nyanko-sensei has quit
      • 2019-12-06 34018, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-12-06 34045, 2019

      • c1e0 joined the channel
      • 2019-12-06 34017, 2019

      • chaban has quit
      • 2019-12-06 34048, 2019

      • chaban joined the channel
      • 2019-12-06 34006, 2019

      • crashtestdummy
        If I submit an adit to mb, how long before it shows up in the search, adding a barcode, eg?
      • 2019-12-06 34000, 2019

      • nav2002__ joined the channel
      • 2019-12-06 34039, 2019

      • c1e0 has quit
      • 2019-12-06 34008, 2019

      • c1e0 joined the channel
      • 2019-12-06 34041, 2019

      • nav2002__ has quit
      • 2019-12-06 34006, 2019

      • nav2002_ joined the channel
      • 2019-12-06 34010, 2019

      • Nyanko-sensei joined the channel
      • 2019-12-06 34017, 2019

      • D4RK-PH0ENiX has quit
      • 2019-12-06 34013, 2019

      • bitmap
        ruaok: I'm here for a bit
      • 2019-12-06 34043, 2019

      • bitmap
        crashtestdummy: if the edit is applied, should be fairly instant
      • 2019-12-06 34053, 2019

      • bitmap has quit
      • 2019-12-06 34046, 2019

      • bitmap joined the channel
      • 2019-12-06 34027, 2019

      • Nyanko-sensei has quit
      • 2019-12-06 34003, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-12-06 34028, 2019

      • reosarevok
        rdswift: I dunno what the original idea for "In review" is, but we use it for a PR being up anyway :)
      • 2019-12-06 34052, 2019

      • CODEin_JDB joined the channel
      • 2019-12-06 34004, 2019

      • CODEin_JDB has quit
      • 2019-12-06 34026, 2019

      • crashtestdummy
        -rw-r--r-- 1 root root 6998687 Nov 22 06:07 roundcubemail-1.4.1-complete.tar.gz
      • 2019-12-06 34031, 2019

      • crashtestdummy
        Wrong window.
      • 2019-12-06 34037, 2019

      • crashtestdummy
        Hmm, I submitted a barcode for https://musicbrainz.org/release/e559fbeb-938b-442… and entered the fact into the notes then hit submit not showing up
      • 2019-12-06 34034, 2019

      • crashtestdummy
        Yeah "Enter Edit"
      • 2019-12-06 34027, 2019

      • reosarevok
        crashtestdummy: that's because your edit is open for review: https://musicbrainz.org/release/e559fbeb-938b-442…
      • 2019-12-06 34012, 2019

      • reosarevok
        Not anymore, since I just approved it (Discogs data confirms it too)
      • 2019-12-06 34018, 2019

      • reosarevok
        so now it should be there :)
      • 2019-12-06 34001, 2019

      • crashtestdummy
        Ah yup.
      • 2019-12-06 34007, 2019

      • crashtestdummy
        So every edit needs a review?
      • 2019-12-06 34000, 2019

      • ohrstrom joined the channel
      • 2019-12-06 34058, 2019

      • Wassabi joined the channel
      • 2019-12-06 34049, 2019

      • reosarevok
        No
      • 2019-12-06 34052, 2019

      • reosarevok
        But many do
      • 2019-12-06 34011, 2019

      • reosarevok
        Or well, ideally yes, every edit needs a review :) But new additions generally get applied automatically
      • 2019-12-06 34023, 2019

      • reosarevok
        Changes to existing stuff require review
      • 2019-12-06 34058, 2019

      • reosarevok
        (the voting period is 7 days - if nobody has seen it in 7 days, we give up and let it apply, so it won't be stuck forever)
      • 2019-12-06 34052, 2019

      • sangeetk has quit
      • 2019-12-06 34036, 2019

      • c1e0 has quit
      • 2019-12-06 34034, 2019

      • sangeetk joined the channel
      • 2019-12-06 34050, 2019

      • reosarevok
        yvanzo: around?
      • 2019-12-06 34008, 2019

      • yvanzo
        reosarevok: yup!
      • 2019-12-06 34027, 2019

      • reosarevok
        Now that the react-table things are there, what's the next step?
      • 2019-12-06 34008, 2019

      • yvanzo
        using it for other table/list
      • 2019-12-06 34038, 2019

      • reosarevok
        Should we collaborate on that (you take some, I take some) or would you rather do it yourself?
      • 2019-12-06 34013, 2019

      • reosarevok
        (I'm trying to figure out what to work on next)
      • 2019-12-06 34025, 2019

      • reosarevok
        Ok, first I should finally review Cyna's code
      • 2019-12-06 34012, 2019

      • yvanzo
        So the user collections list was a proof-of-concept for using react-table, but it doesn’t share much code with other tables.
      • 2019-12-06 34023, 2019

      • reosarevok
        Mhm
      • 2019-12-06 34058, 2019

      • reosarevok
        So next we should create some columns for shared use? Say, take ArtistList or something like that?
      • 2019-12-06 34012, 2019

      • yvanzo
        I can work on list of collected entities first (since I will have to deal with it later on for last schema change stuff).
      • 2019-12-06 34052, 2019

      • yvanzo
        That should bootstrap something to share the rest of the work on other tables, see MBS-10365.
      • 2019-12-06 34053, 2019

      • BrainzBot
        MBS-10365: Refactor display of entity list/table https://tickets.metabrainz.org/browse/MBS-10365
      • 2019-12-06 34059, 2019

      • reosarevok
        Ok :)
      • 2019-12-06 34017, 2019

      • reosarevok
        Is this the next thing on your plate now or how does your plan look like?
      • 2019-12-06 34031, 2019

      • yvanzo
        Yes, will do that today.
      • 2019-12-06 34053, 2019

      • reosarevok
        Awesome
      • 2019-12-06 34010, 2019

      • reosarevok
        Happy to review pretty much as soon as you're done then
      • 2019-12-06 34007, 2019

      • BrainzGit
        [musicbrainz-server] ruinername opened pull request #1303 (master…no-empty): Fix: not have empty block statements (ESLint 'no-empty' rule) https://github.com/metabrainz/musicbrainz-server/…
      • 2019-12-06 34041, 2019

      • BrainzGit
        [musicbrainz-server] ruinername closed pull request #1303 (master…no-empty): Fix: not have empty block statements (ESLint 'no-empty' rule) https://github.com/metabrainz/musicbrainz-server/…
      • 2019-12-06 34024, 2019

      • BrainzGit
        [musicbrainz-server] ruinername reopened pull request #1303 (master…no-empty): Fix: not have empty block statements (ESLint 'no-empty' rule) https://github.com/metabrainz/musicbrainz-server/…
      • 2019-12-06 34044, 2019

      • BrainzGit
        [musicbrainz-server] ruinername closed pull request #1303 (master…no-empty): Fix: not have empty block statements (ESLint 'no-empty' rule) https://github.com/metabrainz/musicbrainz-server/…
      • 2019-12-06 34036, 2019

      • BrainzGit
        [musicbrainz-server] ruinername opened pull request #1304 (master…no-empty): Fix: not have empty block statements (ESLint 'no-empty' rule) https://github.com/metabrainz/musicbrainz-server/…
      • 2019-12-06 34018, 2019

      • reosarevok
        Cyna: left some comments, sorry I took forever
      • 2019-12-06 34001, 2019

      • Gazooo has quit
      • 2019-12-06 34045, 2019

      • Gazooo joined the channel
      • 2019-12-06 34008, 2019

      • ohrstrom has quit
      • 2019-12-06 34020, 2019

      • Wassabi has quit
      • 2019-12-06 34000, 2019

      • Cyna
        Thanks reosarevok. I'll have a look and push the changes by tonight or tomorrow
      • 2019-12-06 34044, 2019

      • ohrstrom joined the channel
      • 2019-12-06 34042, 2019

      • Cyna
        Hi reosarevok, Could you create a task in gci to convert musicbrainz-server/root/static/scripts/common/utility/formatDate.js to React ?
      • 2019-12-06 34051, 2019

      • Cyna
        Or should I do it myself ?
      • 2019-12-06 34005, 2019

      • Wassabi joined the channel
      • 2019-12-06 34034, 2019

      • CODEin_JDB joined the channel
      • 2019-12-06 34043, 2019

      • CODEin_JDB
        Hey!
      • 2019-12-06 34034, 2019

      • Mr_Monkey
        Hi CODEin_JDB
      • 2019-12-06 34057, 2019

      • Mr_Monkey
        (And also everyone else ! 👋 )
      • 2019-12-06 34036, 2019

      • CODEin_JDB has quit
      • 2019-12-06 34027, 2019

      • sbvkrishna joined the channel
      • 2019-12-06 34045, 2019

      • reosarevok
        Cyna: confirm with bitmap that we want that, and if we do we can write it together (you can start and I can review it maybe?)
      • 2019-12-06 34038, 2019

      • yvanzo
      • 2019-12-06 34010, 2019

      • yvanzo
      • 2019-12-06 34056, 2019

      • yvanzo
        Collection content tables are actually based on root/common/list/
      • 2019-12-06 34035, 2019

      • yvanzo
        Just converted AreaList above but all other entity types probably have to be converted to.
      • 2019-12-06 34041, 2019

      • yvanzo
        *o
      • 2019-12-06 34003, 2019

      • reosarevok
        Yeah, I know (re: it using the main lists)
      • 2019-12-06 34013, 2019

      • yvanzo
        (I forgot about it)
      • 2019-12-06 34014, 2019

      • reosarevok
        I'm getting an error on test
      • 2019-12-06 34037, 2019

      • yvanzo
        I don’t ^^
      • 2019-12-06 34044, 2019

      • yvanzo
        Which one?
      • 2019-12-06 34023, 2019

      • reosarevok
      • 2019-12-06 34039, 2019

      • yvanzo
        logged in or not?
      • 2019-12-06 34040, 2019

      • reosarevok
        Seems not
      • 2019-12-06 34036, 2019

      • D4RK-PH0ENiX has quit
      • 2019-12-06 34030, 2019

      • reosarevok
        Also, yvanzo: in case you missed my q yesterday - should I just drop the iife commit in https://github.com/metabrainz/musicbrainz-server/… for now? Is it otherwise mergeable?
      • 2019-12-06 34057, 2019

      • yvanzo
        reosarevok: is 'any' an acceptable option?
      • 2019-12-06 34013, 2019

      • reosarevok
        I don't like it, so I'd rather not make that change myself
      • 2019-12-06 34021, 2019

      • reosarevok
        I won't block it if someone else does though :)
      • 2019-12-06 34043, 2019

      • reosarevok
        But in that case we should still drop that specific commit, so :)
      • 2019-12-06 34003, 2019

      • yvanzo
        I mean, it still detects unwrapped iif.
      • 2019-12-06 34020, 2019

      • c1e0 joined the channel
      • 2019-12-06 34054, 2019

      • reosarevok
        Sure, that's why I won't block it if you want to send a PR to change our eslintrc :)
      • 2019-12-06 34037, 2019

      • yvanzo
        Would you prefer to takeover the react-table thing?
      • 2019-12-06 34059, 2019

      • yvanzo
        I would focus on SIR/VM stuff instead.
      • 2019-12-06 34053, 2019

      • reosarevok
        If you're willing to help a bit if and when I get stuck, I can - sir and the vm do need the work too
      • 2019-12-06 34007, 2019

      • reosarevok
        (and I'm more likely to be able to do react-table than those)
      • 2019-12-06 34053, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-12-06 34034, 2019

      • yvanzo
        Ok, but I have no clue about the current error. That should be debugged one column after another.
      • 2019-12-06 34027, 2019

      • yvanzo
        The weird bit is all columns are defined with id and string accessor.
      • 2019-12-06 34059, 2019

      • yvanzo
        Ooh, got it.
      • 2019-12-06 34058, 2019

      • nav2002_ has quit
      • 2019-12-06 34057, 2019

      • CatQuest
        ack, i just tried the AcousticBrainz client thing. and I can't actually access the folder where the music is because i can't select volume (it's on an extHD)
      • 2019-12-06 34057, 2019

      • CatQuest
        if it'd a way to see "invisible" folders I could use the "go through system and volumes there" trick. but no luck there either
      • 2019-12-06 34026, 2019

      • CatQuest
        I tried copying the AcousticBrainz client to the extHD and run it from there. this stil doenst work
      • 2019-12-06 34033, 2019

      • CatQuest
        or if it had could jsut use the system's file browser isntead!
      • 2019-12-06 34048, 2019

      • Wassabi has quit
      • 2019-12-06 34005, 2019

      • Wassabi joined the channel
      • 2019-12-06 34056, 2019

      • nav2002_ joined the channel
      • 2019-12-06 34039, 2019

      • antara joined the channel
      • 2019-12-06 34052, 2019

      • ZoeB joined the channel
      • 2019-12-06 34002, 2019

      • ZoeB
        Whoever added the ability for MB recordings to link to the IMDB entries of films they sampled, thank you!
      • 2019-12-06 34040, 2019

      • ohrstrom has quit
      • 2019-12-06 34027, 2019

      • iliekcomputers
      • 2019-12-06 34058, 2019

      • iliekcomputers
        google wouldn't have this problem if we had lyrics :P
      • 2019-12-06 34052, 2019

      • CODEin_JDB joined the channel
      • 2019-12-06 34058, 2019

      • sangeetk has quit
      • 2019-12-06 34030, 2019

      • ZoeB
        I've been vying for lyrics specifically in the cases of artists who explicitly allow them to be published anywhere. It amazes me how many people don't see it as free advertising, but there you go.
      • 2019-12-06 34044, 2019

      • reosarevok
        yvanzo: do you have an updated commit? (since it sounds like you found the issue)
      • 2019-12-06 34018, 2019

      • ZoeB
        Ah, further down that thread, he shows that Rap Genius has a licensing deal with music publishers. Nevermind then.
      • 2019-12-06 34041, 2019

      • ruaok
        iliekcomputers: yep, I did.
      • 2019-12-06 34004, 2019

      • ruaok
        ZoeB: lyrics are one of the few aspects of copyright that are being strictly enforced and are making money for them. this is why they are fully overprotective of it. because, as usual, they cannot see that they could be making more money by being open. as per usual we will have to force them to earn more money. 🙄
      • 2019-12-06 34034, 2019

      • ZoeB
        Sounds about right!
      • 2019-12-06 34054, 2019

      • ruaok
        hmmm. crashed the 64gigger. again. time to refactor this code for more mild memory usage.
      • 2019-12-06 34000, 2019

      • ruaok
        ^^ pristine__
      • 2019-12-06 34001, 2019

      • ruaok
        :(
      • 2019-12-06 34055, 2019

      • reosarevok
        yvanzo: nvm, saw you have a branch. I'll look into it
      • 2019-12-06 34020, 2019

      • pristine__
        ruaok: which code?
      • 2019-12-06 34001, 2019

      • ruaok
        messybrainz-labs, the mappings. I tried something new and it works so well that 💥
      • 2019-12-06 34038, 2019

      • nav2002_ has quit