0:00 AM
rahul24 has left the channel
2020-01-08 00808, 2020
0:05 AM
D4RK-PH0ENiX has quit
2020-01-08 00818, 2020
0:15 AM
rdswift_lt joined the channel
2020-01-08 00836, 2020
0:24 AM
D4RK-PH0ENiX joined the channel
2020-01-08 00822, 2020
0:28 AM
nav2002__ joined the channel
2020-01-08 00811, 2020
0:47 AM
nav2002__ has quit
2020-01-08 00806, 2020
0:56 AM
nav2002__ joined the channel
2020-01-08 00808, 2020
1:27 AM
yokel has quit
2020-01-08 00824, 2020
1:29 AM
yokel joined the channel
2020-01-08 00802, 2020
1:36 AM
BrainzBot has quit
2020-01-08 00803, 2020
1:37 AM
-- BotBot disconnected, possible missing messages --
2020-01-08 00832, 2020
1:37 AM
BrainzBot joined the channel
2020-01-08 00855, 2020
2:13 AM
Lotheric_ is now known as Lotheric
2020-01-08 00816, 2020
3:42 AM
rdswift_lt has quit
2020-01-08 00838, 2020
3:52 AM
ASAINT joined the channel
2020-01-08 00850, 2020
3:52 AM
ASAINT has quit
2020-01-08 00841, 2020
4:00 AM
chaban has quit
2020-01-08 00831, 2020
4:01 AM
chaban joined the channel
2020-01-08 00817, 2020
4:26 AM
c1e0 joined the channel
2020-01-08 00805, 2020
4:45 AM
thomasross joined the channel
2020-01-08 00834, 2020
5:25 AM
sarthak_jain joined the channel
2020-01-08 00841, 2020
5:25 AM
sarthak_jain
Hi iliekcomputers
2020-01-08 00851, 2020
5:25 AM
sarthak_jain
I was writing the test for send_mail function
2020-01-08 00825, 2020
5:26 AM
sarthak_jain
2020-01-08 00812, 2020
5:27 AM
sarthak_jain
But I am getting this error
2020-01-08 00814, 2020
5:27 AM
sarthak_jain
2020-01-08 00847, 2020
5:28 AM
ishaanshah[m] joined the channel
2020-01-08 00803, 2020
5:37 AM
sarthak_jain
Oops got the error :)
2020-01-08 00810, 2020
5:57 AM
sarthak_jain has quit
2020-01-08 00845, 2020
6:08 AM
sarthak_jain joined the channel
2020-01-08 00828, 2020
6:09 AM
sarthak_jain
iliekcomputers: I raised a PR, but the build is failing. Reason is that in the mail.py file, it says it cannot import current_app.
2020-01-08 00837, 2020
6:10 AM
sarthak_jain
But the mail.py is as it is. I just added the 'To' field.
2020-01-08 00856, 2020
6:10 AM
sarthak_jain
Also the test_mail which I wrote ran in my local.
2020-01-08 00830, 2020
6:11 AM
c1e0 has quit
2020-01-08 00838, 2020
6:51 AM
nav2002__ has quit
2020-01-08 00842, 2020
6:51 AM
iliekcomputers
I'll reply on the pull request. It's easier to reason about code there.
2020-01-08 00816, 2020
6:54 AM
sarthak_jain
Okay sure :)
2020-01-08 00857, 2020
6:55 AM
nav2002_ joined the channel
2020-01-08 00836, 2020
7:02 AM
sarthak_jain
2020-01-08 00843, 2020
7:02 AM
sarthak_jain
But I get this error
2020-01-08 00812, 2020
7:03 AM
sarthak_jain
2020-01-08 00856, 2020
7:03 AM
iliekcomputers
The keyerror is because the app you're creating doesn't have smtp host and port in the config.
2020-01-08 00802, 2020
7:05 AM
iliekcomputers
Add them to the app (any value works), otherwise the code looks pretty sane to me.
2020-01-08 00817, 2020
7:17 AM
cleo joined the channel
2020-01-08 00840, 2020
7:17 AM
cleo is now known as Guest49318
2020-01-08 00807, 2020
7:18 AM
sarthak_jain
iliekcomputers: Where am I doing it wrong?
2020-01-08 00808, 2020
7:18 AM
sarthak_jain
2020-01-08 00804, 2020
7:21 AM
iliekcomputers
Can you push this
2020-01-08 00811, 2020
7:21 AM
iliekcomputers
It's hard to comment on gists
2020-01-08 00833, 2020
7:21 AM
iliekcomputers
But specifically
2020-01-08 00839, 2020
7:21 AM
iliekcomputers
When you create the app
2020-01-08 00854, 2020
7:21 AM
iliekcomputers
You need to set smtp host and port in app.config
2020-01-08 00821, 2020
7:26 AM
sarthak_jain
iliekcomputers
2020-01-08 00845, 2020
7:26 AM
sarthak_jain
So now I have set the port and server correctly
2020-01-08 00854, 2020
7:26 AM
sarthak_jain
I am getting assertion error
2020-01-08 00806, 2020
7:27 AM
iliekcomputers
Right.
2020-01-08 00828, 2020
7:27 AM
sarthak_jain
2020-01-08 00833, 2020
7:27 AM
sarthak_jain
Like this
2020-01-08 00802, 2020
7:29 AM
iliekcomputers
Try to look into what's different between the call you're expecting and the call that's actually happening. And then see how to fix your assertion
2020-01-08 00826, 2020
7:29 AM
iliekcomputers
I have to go away for today.
2020-01-08 00843, 2020
7:30 AM
sarthak_jain
I guess it is composing the message in a certain format
2020-01-08 00849, 2020
7:30 AM
sarthak_jain
Yaa sure
2020-01-08 00803, 2020
7:40 AM
iliekcomputers
Makes sense.
2020-01-08 00823, 2020
7:47 AM
Cyna
reosarevok: regarding the perl test, I think it would be better to start writing Selenium test instead of fixing perl tests as we would eventually import perl tests to selenium tests. what do you think bitmap ?
2020-01-08 00826, 2020
7:50 AM
bitmap
selenium tests are good, but it depends on what the test is and what involves fixing it
2020-01-08 00803, 2020
7:51 AM
bitmap
in this case I only see a failure for t::TemplateMacros which wouldn't be replaced with a selenium test (we'll just remove this once TT is gone)
2020-01-08 00844, 2020
7:51 AM
bitmap
this test just checks some TT macros against their React ports and makes sure they have equivalent output
2020-01-08 00820, 2020
7:56 AM
Cyna
I'll try understanding perl tests.... bitmap, I just added a commit to use conditionals instead of deepcompare in my PR. It would be great if you could have a look :)
2020-01-08 00801, 2020
8:00 AM
bitmap
re: that commit, that's much more complicated than what I'm suggesting lol
2020-01-08 00839, 2020
8:00 AM
bitmap
I was saying to just compare area.new.gid === area.old.gid *outside* the component
2020-01-08 00806, 2020
8:01 AM
bitmap
for the simple string case you can keep oldContent === newContent inside FullChangeDiff how it was
2020-01-08 00812, 2020
8:06 AM
Cyna
ohh oops... though it would work but flow errors will make it hell
2020-01-08 00829, 2020
8:06 AM
Cyna
cool I'll do what you suggested
2020-01-08 00847, 2020
8:28 AM
prabal joined the channel
2020-01-08 00818, 2020
8:29 AM
prabal
Hi. I'm working on creating RevisionsPage right now. In the pagination part of the page, the next, previous button and also dropdown isn't working.
2020-01-08 00847, 2020
8:29 AM
prabal
Is it because I didn't pass out js-script in res.send()? I passed only the markup in it
2020-01-08 00857, 2020
8:34 AM
prabal
Also one thing thing I noticed, I was making some changes in src/client/components/pages/search.js and these changes were automatically reflected in static/js/search.js. Are these static files made automatically? Or do I have to write one for the RevisionsPage
2020-01-08 00852, 2020
8:37 AM
BrainzGit
2020-01-08 00834, 2020
8:39 AM
MajorLurker joined the channel
2020-01-08 00839, 2020
8:40 AM
BrainzGit
2020-01-08 00830, 2020
8:54 AM
nav2002_ has quit
2020-01-08 00824, 2020
9:03 AM
ZaphodBeeblebrox is now known as CatQuest
2020-01-08 00813, 2020
9:04 AM
CatQuest is now known as BilleeKhoj
2020-01-08 00805, 2020
9:21 AM
sarthak_jain has quit
2020-01-08 00803, 2020
9:33 AM
Guest49318 has quit
2020-01-08 00827, 2020
9:34 AM
ruaok
moooin
2020-01-08 00814, 2020
9:35 AM
Cyna
moin ruaok
2020-01-08 00801, 2020
10:05 AM
Gazooo has quit
2020-01-08 00841, 2020
10:06 AM
Gazooo joined the channel
2020-01-08 00806, 2020
10:12 AM
madmouser1 joined the channel
2020-01-08 00842, 2020
10:18 AM
pristine__
Moin
2020-01-08 00822, 2020
11:08 AM
cleo joined the channel
2020-01-08 00846, 2020
11:08 AM
cleo is now known as Guest32351
2020-01-08 00814, 2020
11:20 AM
Guest32351 is now known as c1e0
2020-01-08 00836, 2020
11:29 AM
alastairp
ruaok: morning. lunch where/when?
2020-01-08 00845, 2020
11:30 AM
ruaok
2020-01-08 00847, 2020
11:30 AM
ruaok
14h?
2020-01-08 00842, 2020
11:31 AM
alastairp
see you there
2020-01-08 00848, 2020
11:31 AM
ruaok
fabu.
2020-01-08 00811, 2020
11:43 AM
MajorLurker has quit
2020-01-08 00844, 2020
12:35 PM
chaban has quit
2020-01-08 00834, 2020
13:31 PM
BrainzGit
2020-01-08 00834, 2020
13:31 PM
BrainzBot
2020-01-08 00828, 2020
13:56 PM
D4RK-PH0ENiX has quit
2020-01-08 00811, 2020
14:07 PM
D4RK-PH0ENiX joined the channel
2020-01-08 00832, 2020
14:36 PM
pristine__
iliekcomputers: I will be happy if you can have a look at #77 whenever you get the chance :)
2020-01-08 00854, 2020
14:48 PM
sarthak_jain joined the channel
2020-01-08 00846, 2020
14:49 PM
sarthak_jain has quit
2020-01-08 00840, 2020
14:57 PM
nav2002_ joined the channel
2020-01-08 00803, 2020
15:03 PM
iliekcomputers
pristine__: I'll take a look today
2020-01-08 00809, 2020
15:03 PM
iliekcomputers
However
2020-01-08 00805, 2020
15:04 PM
iliekcomputers
I think it's a good idea to agree in the team that one approval is enough for merging. In case you're blocked because of my review.
2020-01-08 00828, 2020
15:23 PM
garvacho joined the channel
2020-01-08 00818, 2020
15:25 PM
pristine__
iliekcomputers: I am not blocked because of review, we will merge it after I am done with tests.
2020-01-08 00838, 2020
15:25 PM
pristine__
I just thought it will be a good if you can review too.
2020-01-08 00845, 2020
15:25 PM
ruaok
what does everyone have against Cthulhu??
2020-01-08 00811, 2020
15:26 PM
pristine__
Against?
2020-01-08 00826, 2020
15:26 PM
ruaok
everyone seems to be objecting to him today. :(
2020-01-08 00804, 2020
15:27 PM
pristine__
I actually don't know what's that :p
2020-01-08 00826, 2020
15:27 PM
garvacho has quit
2020-01-08 00805, 2020
15:28 PM
ruaok
2020-01-08 00843, 2020
15:28 PM
nav2002_ has quit
2020-01-08 00835, 2020
15:32 PM
chaban joined the channel
2020-01-08 00805, 2020
15:33 PM
Mr_Monkey
Compatible with Pastafarianism: All hail His noodly appendages.
2020-01-08 00852, 2020
15:36 PM
BilleeKhoj
who is arguing against cthulhu????
2020-01-08 00803, 2020
15:37 PM
ruaok
zas. sheesh.
2020-01-08 00820, 2020
15:37 PM
BilleeKhoj
ಠ_ಠ
2020-01-08 00843, 2020
15:37 PM
BilleeKhoj
anyway, there are worse gods
2020-01-08 00811, 2020
15:38 PM
ruaok
yea, like the ones that most people hold in high regards.
2020-01-08 00846, 2020
15:38 PM
BilleeKhoj
oh yea. I meant like the lovecraft mythos held some truely horrific other elder thihgs much worse thna chutulhu, but that wors to?
2020-01-08 00808, 2020
15:39 PM
BilleeKhoj
anyway, are we calling a server chutulhu?
2020-01-08 00812, 2020
15:39 PM
BilleeKhoj
(hard to type right though)
2020-01-08 00804, 2020
15:54 PM
iliekcomputers
BilleeKhoj: nice nick
2020-01-08 00815, 2020
15:55 PM
iliekcomputers
That feel when you grew up speaking two languages which means you don't know either well. :(
2020-01-08 00823, 2020
15:55 PM
iliekcomputers
I don't know what computer is in hindi
2020-01-08 00859, 2020
15:55 PM
SothoTalKer
wasnt hindi the one with the squiggly letters?
2020-01-08 00844, 2020
15:57 PM
reosarevok
2020-01-08 00845, 2020
15:57 PM
BrainzBot
MBS-10559: Allow filtering instrument tabs on relationship type
2020-01-08 00851, 2020
15:57 PM
reosarevok
Did I get what you wanted right'
2020-01-08 00852, 2020
15:57 PM
reosarevok
*?
2020-01-08 00800, 2020
15:58 PM
BilleeKhoj
let me check!
2020-01-08 00847, 2020
15:58 PM
BilleeKhoj
SothoTalKer: yes, but freenode won't let me register बिल्ली खोज,
2020-01-08 00851, 2020
15:58 PM
BilleeKhoj
as a nick
2020-01-08 00857, 2020
15:58 PM
BilleeKhoj
iliekcomputers: :D
2020-01-08 00827, 2020
15:59 PM
BilleeKhoj
(I frequently forget a word in norwegian but know it in english (sometimes the opposite too))
2020-01-08 00843, 2020
16:01 PM
BilleeKhoj
reosarevok: I can't really see.. where is that change now? (give me a link)
2020-01-08 00856, 2020
16:01 PM
reosarevok
It isn't, just wanted to know whether that's the point
2020-01-08 00801, 2020
16:02 PM
reosarevok
For the ticket
2020-01-08 00803, 2020
16:02 PM
BilleeKhoj
what?
2020-01-08 00811, 2020
16:02 PM
SothoTalKer
no unicode support for names, it seems ^^
