I haven't looked into it in detail but the gist should be that you'd have to add jest and enzyme to package.json, add the test files and have a npm function to run the tests
2020-01-18 01850, 2020
ishaanshah[m]
Ohk
2020-01-18 01826, 2020
sarthak_jain has quit
2020-01-18 01809, 2020
Cyna
bitmap: is there a way to port our current selenium tests and custom commands over to the latest version so we can use browser to create selenium tests easily ?
2020-01-18 01837, 2020
antara has quit
2020-01-18 01847, 2020
rahul24 joined the channel
2020-01-18 01848, 2020
bitmap
Cyna: not atm, it'll require a ton of work
2020-01-18 01850, 2020
Cyna
If possible, please let me know how its possible. I'll give it some time :)
Cyna: I haven't thought too much about the best way to solve this, I just know it'll be a lot of work :) it's a better use of time to work with what we have (after all, it's not impossible to write tests now) and get your existing work merged
(the i18n error doesn't have a ticket afaik but it's on sentry)
2020-01-18 01859, 2020
Cyna
bitmap: the problem was that the plackup was not active in the background. I was assuming that plackup is not required
2020-01-18 01805, 2020
bitmap
ah ok. yes it's required, it just runs the selenium tests against your local server but doesn't start anything for you
2020-01-18 01854, 2020
Cyna
Is there a way for me to remove an account from the db without having to reset it ?
2020-01-18 01835, 2020
Cyna
When running the selenium suite again I'm getting user already exist, because it was created initially and wasnt removed
2020-01-18 01813, 2020
reosarevok
bitmap: if you send it in the next couple hours max I can review it today
2020-01-18 01818, 2020
reosarevok
(I'm going for a hike tomorrow)
2020-01-18 01850, 2020
bitmap
reosarevok: I'll try, we can do a late release on monday/early tuesday if not
2020-01-18 01854, 2020
reosarevok
Ok
2020-01-18 01807, 2020
reosarevok
I guess Monday review is fine too, actually :D
2020-01-18 01811, 2020
reosarevok
Forgot about that
2020-01-18 01802, 2020
bitmap
Cyna: the selenium.js script should clear the db for you
2020-01-18 01819, 2020
bitmap
if it's not working you can drop/recreate it
2020-01-18 01846, 2020
bitmap
but I haven't had an issue with it leaving users behind
2020-01-18 01813, 2020
rahul24
Hi everyone, in Picard, is there a way to know if it is taking the fingerprint of an audio file or not? I am trying to take the fingerprint of a larger file and so I don’t know if it is taking the fingerprint
2020-01-18 01813, 2020
reosarevok
bitmap: it might be one of those cases where if it crashes it doesn't clean up
2020-01-18 01826, 2020
reosarevok
I remember hitting one of those, maybe even with selenium
2020-01-18 01802, 2020
Cyna
why is it necessary to run `./script/compile_resources.sh` from create_test_db.sh ?
2020-01-18 01809, 2020
bitmap
that's probably possible, though it should clean it when you run selenium.js again (before running any tests), so a bit confused why that's not working
Ah right, I forgot about those, I’ll try downloading them. Thanks again :D
2020-01-18 01805, 2020
bitmap
Cyna: those scripts aren't related (so the order doesn't matter). it suggests running compile_resources.sh again just to make sure the tests are running against the current code. if you're sure it's current (or are using --watch), you don't need to
2020-01-18 01816, 2020
bitmap
the only idea I have for the user thing is to drop musicbrainz_test and run create_test_db again
2020-01-18 01839, 2020
bitmap
maybe it was present in the test db before you created musicbrainz_selenium, so the template wasn't clean
2020-01-18 01806, 2020
bitmap
of course you'll need to drop musicbrainz_selenium again and recreate that afterward, too
2020-01-18 01856, 2020
bitmap
let me know if that helps tomorrow. sleep well!
2020-01-18 01819, 2020
rahul24
In BookBrainz, when you are adding an author to a book, is the relationship “edited”? I don’t see a simple author option which is why I ask
2020-01-18 01812, 2020
rdswift_lt
I don't think "edited" is correct, but I'm not at all familiar with BookBrainz. I do know that, in the publishing world, editor is different from author.
2020-01-18 01819, 2020
reosarevok
Is there "wrote"?
2020-01-18 01827, 2020
reosarevok
If so, I'd expect that
2020-01-18 01838, 2020
rdswift_lt
I agree.
2020-01-18 01857, 2020
awalvie[m]
Hi there, does metabrainz have plans for participating in GSOC 2020 ? If yes, can someone please direct me to the relevant ideas page associated with it.
2020-01-18 01808, 2020
rahul24
I got the “wrote” option after adding it directly from the author page :)
