#metabrainz

/

      • Mr_Monkey
        Roger
      • 2020-01-20 02051, 2020

      • ruaok
        I've been steadily keeping track of projects that I want to see done, so I'llbe adding them in the next few days.
      • 2020-01-20 02009, 2020

      • ruaok
        I'll cover LB and MsB. hopefully I can get alastairp to cover AB.
      • 2020-01-20 02015, 2020

      • ruaok
        oh and I have one for CAA as well. :)
      • 2020-01-20 02023, 2020

      • ruaok
        so, ideas please.
      • 2020-01-20 02040, 2020

      • ruaok
        Freso: keep this topic on for next week when I will talk about this in a little more detail.
      • 2020-01-20 02043, 2020

      • ruaok
        back to you Freso
      • 2020-01-20 02051, 2020

      • Freso
        ruaok: Roger. :)
      • 2020-01-20 02058, 2020

      • Freso
        Aaaaaand…
      • 2020-01-20 02001, 2020

      • ruaok
        oh and I will not make next week's meeting.
      • 2020-01-20 02001, 2020

      • Cyna
        I have a proposal idea this time... Improving our test coverage for Musicbrainz
      • 2020-01-20 02012, 2020

      • Freso
        ruaok: 😂
      • 2020-01-20 02012, 2020

      • ruaok
        I'll send a review and I may be around for the tail end.
      • 2020-01-20 02013, 2020

      • Cyna
        Maybe discuss it later then
      • 2020-01-20 02023, 2020

      • Freso
        Anyway.
      • 2020-01-20 02033, 2020

      • Freso
        That wraps up tonight’s meeting!
      • 2020-01-20 02039, 2020

      • Freso
        Thank you all for your time! ❤️
      • 2020-01-20 02042, 2020

      • Freso
        </BANG>
      • 2020-01-20 02049, 2020

      • ruaok
        oh, no, I was wrong. I will make the meeting.
      • 2020-01-20 02051, 2020

      • Mr_Monkey
        Thanks !
      • 2020-01-20 02052, 2020

      • ruaok
        yay.
      • 2020-01-20 02053, 2020

      • Freso
        🙌
      • 2020-01-20 02021, 2020

      • yvanzo
        Thanks!
      • 2020-01-20 02031, 2020

      • sbvkrishna
        Cya
      • 2020-01-20 02001, 2020

      • shivam-kapila
        Hello everyone! My name is Shivam and I am form NIT Hamirpur. I am a GSoC inspirant and I am interested on working on Listenbrainz project (particularly the earlier known listenbrainz-labs). I am currently looking into the tickets to start contributing. I wanted to introduce myself to the community. Also looking forward to interact with LB mentors to know the future roadmap for the project.
      • 2020-01-20 02054, 2020

      • reosarevok
        pristine__: ^
      • 2020-01-20 02002, 2020

      • reosarevok
        D4RK-PH0ENiX: when you have some time, could you help translate the answer we got back into English? :)
      • 2020-01-20 02001, 2020

      • reosarevok
        yvanzo: does https://github.com/metabrainz/musicbrainz-server/… have any specific way of testing it? (the commits seem sensible, at least)
      • 2020-01-20 02017, 2020

      • yvanzo
        bitmap, reosarevok: any idea about why relationship type pages might not be localized with 1359?
      • 2020-01-20 02037, 2020

      • reosarevok
        Were they before?
      • 2020-01-20 02043, 2020

      • reosarevok
        (good first check :D )
      • 2020-01-20 02005, 2020

      • yvanzo
        reosarevok: on 1360, ideally that should be tested by generating every possible image from docker/ and make sure pkg-config is correctly installed.
      • 2020-01-20 02058, 2020

      • yvanzo
        reosarevok: yes, for example https://musicbrainz.org/relationship/45115945-597… is correctly localized
      • 2020-01-20 02017, 2020

      • reosarevok
        Ok
      • 2020-01-20 02018, 2020

      • yvanzo
      • 2020-01-20 02029, 2020

      • yvanzo
      • 2020-01-20 02048, 2020

      • reosarevok
        But locally they don't work?
      • 2020-01-20 02054, 2020

      • yvanzo
        right
      • 2020-01-20 02059, 2020

      • reosarevok
        I can test them locally too in a sec
      • 2020-01-20 02046, 2020

      • bitmap
        not sure, lemme see
      • 2020-01-20 02011, 2020

      • yvanzo
        (relationship types are correctly localized on artist pages though)
      • 2020-01-20 02038, 2020

      • bitmap
        they seem to be localized correctly on my machine
      • 2020-01-20 02045, 2020

      • bitmap
        that's weird
      • 2020-01-20 02014, 2020

      • yvanzo
        more weird: header is localized, footer isn't :D
      • 2020-01-20 02042, 2020

      • yvanzo
        (checking js console)
      • 2020-01-20 02050, 2020

      • bitmap
        lol
      • 2020-01-20 02004, 2020

      • bitmap
        for me the whole page is
      • 2020-01-20 02005, 2020

      • bitmap
        restart root/server.js maybe?
      • 2020-01-20 02022, 2020

      • yvanzo
        already did
      • 2020-01-20 02006, 2020

      • bitmap
        not sure why that page in particular
      • 2020-01-20 02019, 2020

      • yvanzo
        bitmap: unrelated, but FTR: [BABEL] Note: The code generator has deoptimised the styling of /musicbrainz-server/root/static/build/jed-de.source.js as it exceeds the max of 500KB.
      • 2020-01-20 02033, 2020

      • yvanzo
        (for every single locale)
      • 2020-01-20 02019, 2020

      • bitmap
        ok, I can prob change the webpack config to ignore those
      • 2020-01-20 02053, 2020

      • c1e0 has quit
      • 2020-01-20 02039, 2020

      • bitmap
        reosarevok: lmk if it works for you
      • 2020-01-20 02039, 2020

      • reosarevok
        Ok, I'll try
      • 2020-01-20 02021, 2020

      • CatQuest
        lol so if i disable javascript discourse loads for me and i can read what was said :D
      • 2020-01-20 02019, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1358 (master…mbs-10571): MBS-10571: Fix "localized" ModBot email display https://github.com/metabrainz/musicbrainz-server/…
      • 2020-01-20 02020, 2020

      • BrainzBot
        MBS-10571: Localized modbot notes are not properly formatted when sent via email https://tickets.metabrainz.org/browse/MBS-10571
      • 2020-01-20 02054, 2020

      • Lotheric has quit
      • 2020-01-20 02048, 2020

      • reosarevok
      • 2020-01-20 02009, 2020

      • reosarevok
        So it might be some weird yvanzo-setup thing? :p
      • 2020-01-20 02041, 2020

      • reosarevok
        I can't see any issues
      • 2020-01-20 02016, 2020

      • reosarevok goes to bed for now
      • 2020-01-20 02040, 2020

      • bitmap
        thanks for checking! 'night
      • 2020-01-20 02001, 2020

      • yvanzo
        'night reosarevok!
      • 2020-01-20 02050, 2020

      • bitmap
        could it be that you need to pull new po files? or try clearing root/static/build/ before running compile_resources again, but not sure what if any effect that'd have
      • 2020-01-20 02027, 2020

      • yvanzo
        I tried clearing root/static/build and .mo files already: https://chatlogs.metabrainz.org/brainzbot/metabra…
      • 2020-01-20 02057, 2020

      • yvanzo
        I just tried disabling DEVELOPMENT_SERVER and CATALYST_DEBUG too.
      • 2020-01-20 02053, 2020

      • bitmap
        oh sorry I missed that message
      • 2020-01-20 02017, 2020

      • bitmap
        honestly not sure
      • 2020-01-20 02016, 2020

      • yvanzo
        not sure this is related to this PR
      • 2020-01-20 02019, 2020

      • yvanzo
        I just observed the same issue with production branch.
      • 2020-01-20 02054, 2020

      • sbvkrishna has quit
      • 2020-01-20 02035, 2020

      • yvanzo
        fwiw, here is how it is displayed here: https://nimb.ws/OS8RpZ
      • 2020-01-20 02052, 2020

      • bitmap
        huh, English is selected but the menus are still translated?
      • 2020-01-20 02036, 2020

      • yvanzo
        yes
      • 2020-01-20 02055, 2020

      • yvanzo
        I tried with other available languages too, same thing: English is displayed but menus are localized
      • 2020-01-20 02051, 2020

      • yvanzo
        I should worry about my dev env but you shouldn't worry about your PR for that :)
      • 2020-01-20 02039, 2020

      • yvanzo
        bitmap: yes -> no, another language is selected, but English is displayed.
      • 2020-01-20 02012, 2020

      • yvanzo
        I mean, the locale picker wrongly displays English.
      • 2020-01-20 02031, 2020

      • yvanzo
        Also this page is TT, whereas artist pages are JS, I suspect something wrong with starting renderer.
      • 2020-01-20 02027, 2020

      • yvanzo
        Is script/start_renderer.pl still to be used?
      • 2020-01-20 02033, 2020

      • yvanzo
        bitmap: can we merge 1359 / 1360 and then start the release process?
      • 2020-01-20 02056, 2020

      • Nyanko-sensei
        reosarevok: sure. give me a link to it
      • 2020-01-20 02051, 2020

      • bitmap
        yvanzo: yes, sorry
      • 2020-01-20 02017, 2020

      • bitmap
        I can do the release in a few hours if it's late for you
      • 2020-01-20 02037, 2020

      • bitmap
        re script/start_renderer.pl I use it, but I don't think it needs to be for things to work properly
      • 2020-01-20 02055, 2020

      • bitmap
        it's mainly useful to daemonize things
      • 2020-01-20 02015, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1359 (master…mbs-10572): Fix MBS-10572: Have one Jed bundle per language https://github.com/metabrainz/musicbrainz-server/…
      • 2020-01-20 02016, 2020

      • BrainzBot
        MBS-10572: Pages that display release events trigger an error when a non-English UI language is selected: "Domain `countries` was not found." https://tickets.metabrainz.org/browse/MBS-10572
      • 2020-01-20 02032, 2020

      • yvanzo
        alright, the selenium test continues to fail on 1360 for some reason, I guess it is just fine to ignore it.
      • 2020-01-20 02000, 2020

      • yvanzo
        I use that script too, I was just wondering because there is little doc about it in the repo.
      • 2020-01-20 02028, 2020

      • bitmap
        true
      • 2020-01-20 02055, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #1360 (master…pkg-config): Install pkg-config to probe ICU headers/libraries https://github.com/metabrainz/musicbrainz-server/…
      • 2020-01-20 02015, 2020

      • bitmap
        before we had access to DBDefs in our JS, it used to pass DBDefs values to server.js through there, so it was necessary in that regard
      • 2020-01-20 02045, 2020

      • bitmap
        but now it's mainly only handy for the --daemonize flag
      • 2020-01-20 02031, 2020

      • yvanzo
        OK, have a good day, thanks :)
      • 2020-01-20 02006, 2020

      • rahul24 has quit
      • 2020-01-20 02039, 2020

      • rahul24 joined the channel
      • 2020-01-20 02034, 2020

      • Gazooo has quit
      • 2020-01-20 02003, 2020

      • Gazooo joined the channel
      • 2020-01-20 02013, 2020

      • rahul24 has quit
      • 2020-01-20 02012, 2020

      • shivam-kapila has quit