(plus we don't really support BC dates, so in this case it'd be an issue even if we knew the year, but that's a separate problem)
2020-01-21 02110, 2020
reosarevok
So we mark him as deceased
2020-01-21 02144, 2020
rdswift
Perhaps the system should automatically check the "deceased" box when a date is entered?
2020-01-21 02110, 2020
Cyna
Yea that would be better
2020-01-21 02120, 2020
reosarevok
Maybe. It is checked if an end date is *saved* at least (so, if you edit an artist with a death date)
2020-01-21 02129, 2020
reosarevok
But not automatically when you do this
2020-01-21 02143, 2020
Cyna
I could become automatic right ?
2020-01-21 02147, 2020
reosarevok
Problem would be that either it always unchecks it if you remove the date (which might be unwanted)
2020-01-21 02100, 2020
reosarevok
Or it never does (which might be unwanted too)
2020-01-21 02106, 2020
rdswift
Good points.
2020-01-21 02144, 2020
Cyna
I'd say the checkbox and data is meaning less in the first glance. I'd have checkbox. that tells if a person has died / not. If it has, then a date option comes up. which may or may not be filled.
2020-01-21 02108, 2020
rdswift
All things considered, I think it's probably best as it is currently.
2020-01-21 02117, 2020
Cyna
that way our edit system would be more responsive
2020-01-21 02105, 2020
rdswift
That may be a valid option as well.
2020-01-21 02140, 2020
Cyna
I already have these forms in react... We could explore improvement options better once it gets merged.
2020-01-21 02153, 2020
rdswift
But you need to remember to handle the case where someone checks the box, fills in a date, then unchecks the box. Date should probably not be saved.
2020-01-21 02125, 2020
Cyna
Date wont make be visible if someone unchecks the box
2020-01-21 02144, 2020
rdswift
But the field may still contain data.
2020-01-21 02157, 2020
rdswift
Just hidden.
2020-01-21 02111, 2020
Cyna
that how it becomes responsive. So if the checkbox is true, then the data entry component is rendered, when its not true. Its hidden.
2020-01-21 02136, 2020
Cyna
The data written to the component is detroyed with the component unrendering
2020-01-21 02148, 2020
rdswift
Hidden on screen, but is it still parsed and saved to the data record?
2020-01-21 02127, 2020
Cyna
Most of the files / components I write in react have states within the component. so unless the component exist, the data wont be there
2020-01-21 02115, 2020
rdswift
Okay, I know nothing about react. I'll have to take your word on it.
2020-01-21 02132, 2020
Cyna
I think reosarevok can confirm it 😅
2020-01-21 02101, 2020
Cyna
Im still not experienced with the whole codebase. Its strange how everything works even when written in different languages
2020-01-21 02132, 2020
sumedh
Hello! I am trying to setup a development environment for 'listenbrainz-server'
I am not able to figure out what to fill out in the following fields
2020-01-21 02106, 2020
sumedh
> Callback URL
2020-01-21 02110, 2020
sumedh
> Application homepage
2020-01-21 02116, 2020
sumedh
Could someone please guide me on this?
2020-01-21 02156, 2020
Cyna
pristine__: iliekcomputers ruaok I guess they can help you out
2020-01-21 02146, 2020
rdswift
I think that the application homepage is the page describing the application that you are wanting the api key for.
2020-01-21 02156, 2020
rdswift
Typically the callback is the url to which the response is sent when an api request is made.
2020-01-21 02151, 2020
rdswift
But it's entirely possible that I've misunderstood and am wrong.
2020-01-21 02151, 2020
sumedh
I guess 'http://localhost/login/musicbrainz/post' can be the 'Callback URL', since I filled the same when I registered my application on "Musicbrainz applications page"
2020-01-21 02102, 2020
sumedh
Still not sure about the 'Application homepage'
2020-01-21 02144, 2020
sumedh has quit
2020-01-21 02153, 2020
shivam-kapila joined the channel
2020-01-21 02107, 2020
rdswift
It's where they can lookup information about your application, download it, etc.
2020-01-21 02136, 2020
rdswift
I think.
2020-01-21 02149, 2020
reosarevok
So probably just your listenbrainz-server fork or something?
2020-01-21 02157, 2020
reosarevok
(for now, since you won't be setting up an actual site)
I just had a meeting today with some people from the Royal Concertgebouw Orchestra and they were complaining about classical music metadata and I showed them what was on Musicbrainz and they were amazed that metadata could look so nice
2020-01-21 02115, 2020
alastairp
well done everyone :)
2020-01-21 02112, 2020
zas
:)
2020-01-21 02149, 2020
alastairp
"oh, AllMusic should have good data right?" *looks it up* "ohhh my eyes this is terrible"
2020-01-21 02106, 2020
CatQuest
wait having to check a box before i cna enter an deth date? UGH pita
alastairp: at least some metadata is nice. but its a pita to enter it ;P
2020-01-21 02120, 2020
SothoTalKer
allmusic cant even get catalog numbers right. and i've seen releases removed because of "legal stuff" ~.~
2020-01-21 02135, 2020
shivam-kapila
Hey pristine__ Sorry for the delay. I wished to know are there any tasks in your mind for the listenbrainz-labs? Also I was looking into the ticket LB-473 and needed some insights into it, whenever you would be free.
