10:52 AM
iliekcomputers
If you're doing LB webserver dev, you most probably won't need the spark containers at all.
2020-01-26 02653, 2020
10:52 AM
iliekcomputers
And vice versa
2020-01-26 02658, 2020
10:52 AM
reosarevok
yvanzo: thanks! Might want to mark unresolved for now?
2020-01-26 02612, 2020
10:53 AM
yvanzo
I did already :)
2020-01-26 02651, 2020
10:53 AM
pristine__
iliekcomputers: sounds cool :)
2020-01-26 02653, 2020
10:54 AM
d4rkie joined the channel
2020-01-26 02632, 2020
10:55 AM
D4RK-PH0ENiX has quit
2020-01-26 02626, 2020
11:02 AM
yvanzo
bitmap, reosarevok: About the localization issue of the other day: I found out that $c.stash.current_language is always set to 'en' (in <BottoMenu> at least). Still no idea what is causing this for now.
2020-01-26 02632, 2020
11:18 AM
ishaanshah[m]
iliekcomputers: Which browser are you using?
2020-01-26 02647, 2020
11:25 AM
iliekcomputers
Firefox
2020-01-26 02613, 2020
11:26 AM
ishaanshah[m]
Can you try on chrome or chromium
2020-01-26 02602, 2020
11:28 AM
iliekcomputers
lemme try on chrome
2020-01-26 02637, 2020
11:28 AM
iliekcomputers
*chromium
2020-01-26 02648, 2020
11:30 AM
ishaanshah[m]
It seems that the server is sending the file as text/html
2020-01-26 02647, 2020
11:31 AM
iliekcomputers
same on chrome
2020-01-26 02651, 2020
11:31 AM
iliekcomputers
(ium)
2020-01-26 02658, 2020
11:31 AM
iliekcomputers
but the error is a 404 for some reason.
2020-01-26 02603, 2020
11:32 AM
iliekcomputers
2020-01-26 02654, 2020
11:32 AM
ishaanshah[m]
In the network tab can you look at the type of import.js you are getting.
2020-01-26 02641, 2020
11:33 AM
iliekcomputers
it's 404ing for me.
2020-01-26 02648, 2020
11:33 AM
iliekcomputers
let me see what I get on firefox
2020-01-26 02614, 2020
11:34 AM
iliekcomputers
right
2020-01-26 02616, 2020
11:34 AM
iliekcomputers
404
2020-01-26 02620, 2020
11:34 AM
iliekcomputers
type: html
2020-01-26 02631, 2020
11:34 AM
shivam-kapila
iliekcomputers: I will close the PR. I agree that it will bring all the containers up when user intends to use one of the webspark or spark containers.
2020-01-26 02647, 2020
11:34 AM
iliekcomputers
ishaanshah[m]: do you want a screenshot?
2020-01-26 02608, 2020
11:35 AM
ishaanshah[m]
That would be helpful
2020-01-26 02628, 2020
11:35 AM
iliekcomputers
2020-01-26 02632, 2020
11:35 AM
BrainzGit
2020-01-26 02647, 2020
11:36 AM
iliekcomputers
2020-01-26 02621, 2020
11:39 AM
iliekcomputers
shivam-kapila: thanks, i feel we'll need to discuss our approach on develop.sh soon, now that we have two different things going on in one file.
2020-01-26 02601, 2020
11:45 AM
iliekcomputers
2020-01-26 02621, 2020
11:45 AM
ishaanshah[m]
page not found
2020-01-26 02648, 2020
11:45 AM
Wassabi joined the channel
2020-01-26 02616, 2020
11:46 AM
d4rkie has quit
2020-01-26 02626, 2020
11:46 AM
D4RK-PH0ENiX joined the channel
2020-01-26 02638, 2020
11:46 AM
iliekcomputers
right.
2020-01-26 02655, 2020
11:46 AM
iliekcomputers
2020-01-26 02602, 2020
11:47 AM
iliekcomputers
this is what we want, I think
2020-01-26 02635, 2020
11:47 AM
ishaanshah[m]
Yep your right
2020-01-26 02643, 2020
11:47 AM
iliekcomputers
2020-01-26 02606, 2020
11:49 AM
iliekcomputers
`get_static_url` might be linking the incorrect file
2020-01-26 02627, 2020
11:49 AM
ishaanshah[m]
Yep
2020-01-26 02653, 2020
11:49 AM
ishaanshah[m]
Should I use url_for instead
2020-01-26 02645, 2020
11:50 AM
iliekcomputers
hmm, can we check what we use in the other pages which use compiled js
2020-01-26 02638, 2020
11:51 AM
iliekcomputers
2020-01-26 02641, 2020
11:51 AM
iliekcomputers
interesting
2020-01-26 02629, 2020
11:52 AM
ishaanshah[m]
Also its linking it to the correct file on my laptop
2020-01-26 02643, 2020
11:52 AM
ishaanshah[m]
But not yours for some reason
2020-01-26 02657, 2020
11:52 AM
iliekcomputers
that's very weird
2020-01-26 02614, 2020
11:53 AM
iliekcomputers
do you have any uncommitted changes by any chance?
2020-01-26 02636, 2020
11:53 AM
ishaanshah[m]
nope
2020-01-26 02649, 2020
11:53 AM
iliekcomputers
2020-01-26 02617, 2020
11:54 AM
iliekcomputers
can we change this to `{% extends 'base-react.html' %}`
2020-01-26 02629, 2020
11:54 AM
iliekcomputers
i think that might fix it
2020-01-26 02635, 2020
11:54 AM
iliekcomputers
not completely sure
2020-01-26 02640, 2020
11:55 AM
iliekcomputers
wait
2020-01-26 02642, 2020
11:55 AM
iliekcomputers
probably not
2020-01-26 02609, 2020
11:56 AM
ishaanshah[m]
But base-react is just adding react-props if I am not wrong
2020-01-26 02613, 2020
11:56 AM
iliekcomputers
yep
2020-01-26 02621, 2020
11:56 AM
iliekcomputers
yeah, let's just use url_for for now
2020-01-26 02640, 2020
11:56 AM
ishaanshah[m]
Ok, cool
2020-01-26 02655, 2020
11:56 AM
ishaanshah[m]
Can you change it in your copy and tell me
2020-01-26 02605, 2020
11:57 AM
ishaanshah[m]
Coz it's already working for me
2020-01-26 02627, 2020
11:58 AM
Lisa761 joined the channel
2020-01-26 02637, 2020
11:58 AM
iliekcomputers
sooo
2020-01-26 02604, 2020
11:59 AM
iliekcomputers
I'm not sure if removing get_static_path would work
2020-01-26 02627, 2020
11:59 AM
iliekcomputers
2020-01-26 02645, 2020
11:59 AM
iliekcomputers
it only makes one request for a main.{randomstring}.js
2020-01-26 02605, 2020
12:00 PM
iliekcomputers
if we use url_for, it'll probably break in production
2020-01-26 02620, 2020
12:00 PM
iliekcomputers
we need to investigate why get_static_path isn't linking correctly for me.
2020-01-26 02627, 2020
12:00 PM
ishaanshah[m]
Hmm
2020-01-26 02642, 2020
12:00 PM
ishaanshah[m]
Can you try rebuilding the container
2020-01-26 02607, 2020
12:01 PM
iliekcomputers
hmm, sure
2020-01-26 02616, 2020
12:01 PM
iliekcomputers
can you look where `get_static_path` is defined
2020-01-26 02628, 2020
12:01 PM
ishaanshah[m]
sure
2020-01-26 02603, 2020
12:02 PM
ishaanshah[m]
Ah
2020-01-26 02605, 2020
12:02 PM
ishaanshah[m]
gotit
2020-01-26 02621, 2020
12:02 PM
ishaanshah[m]
I guess import hasn't been added to your manifest
2020-01-26 02603, 2020
12:03 PM
Lisa761 has quit
2020-01-26 02606, 2020
12:03 PM
ishaanshah[m]
Try adding it
2020-01-26 02643, 2020
12:03 PM
iliekcomputers
what file
2020-01-26 02648, 2020
12:03 PM
iliekcomputers
and what should I add?
2020-01-26 02619, 2020
12:04 PM
ishaanshah[m]
manifest.json in static/js/dist
2020-01-26 02628, 2020
12:04 PM
ishaanshah[m]
add "import.js": "import.js",
2020-01-26 02655, 2020
12:04 PM
iliekcomputers
it exists already
2020-01-26 02600, 2020
12:05 PM
Guest55827 is now known as c1e0
2020-01-26 02610, 2020
12:05 PM
iliekcomputers
manifest.json is autogenerated, yes?
2020-01-26 02643, 2020
12:05 PM
ishaanshah[m]
ya it is
2020-01-26 02606, 2020
12:06 PM
ishaanshah[m]
if you look at the get_static_path method
2020-01-26 02646, 2020
12:06 PM
ishaanshah[m]
in static_manager.py
2020-01-26 02651, 2020
12:07 PM
ishaanshah[m]
it returns the /static/file if it isn't defined in manifest
2020-01-26 02645, 2020
12:08 PM
iliekcomputers
hmm, this is very weird.
2020-01-26 02652, 2020
12:08 PM
ishaanshah[m]
What are you getting on this
2020-01-26 02652, 2020
12:08 PM
ishaanshah[m]
2020-01-26 02625, 2020
12:09 PM
iliekcomputers
2020-01-26 02631, 2020
12:09 PM
iliekcomputers
wtf is this lol
2020-01-26 02646, 2020
12:10 PM
iliekcomputers
soooo
2020-01-26 02649, 2020
12:10 PM
iliekcomputers
i think i found the bug
2020-01-26 02641, 2020
12:11 PM
iliekcomputers
2020-01-26 02654, 2020
12:11 PM
iliekcomputers
and it came up as undefined
2020-01-26 02609, 2020
12:12 PM
iliekcomputers
we should add a `global manifest_content` before the check.
2020-01-26 02614, 2020
12:12 PM
iliekcomputers
it fixes the problem for me.
2020-01-26 02625, 2020
12:12 PM
ishaanshah[m]
ohk
2020-01-26 02659, 2020
12:12 PM
ishaanshah[m]
But its wierd that main.js is working but import.js is not
2020-01-26 02603, 2020
12:13 PM
iliekcomputers
but now it works for me even if i remove the `global` line wtf
2020-01-26 02616, 2020
12:13 PM
ishaanshah[m]
Lol
2020-01-26 02623, 2020
12:13 PM
iliekcomputers
I think we should investigate where `read_manifest` is called
2020-01-26 02648, 2020
12:13 PM
ishaanshah[m]
Its called in init.py in webserbver
2020-01-26 02653, 2020
12:13 PM
ishaanshah[m]
webserver*
2020-01-26 02612, 2020
12:14 PM
iliekcomputers
2020-01-26 02615, 2020
12:14 PM
iliekcomputers
*shrugs*
2020-01-26 02629, 2020
12:14 PM
iliekcomputers
so umm, i'm not sure what to make of this.
2020-01-26 02651, 2020
12:14 PM
iliekcomputers
the only thing i've got is that we should add the `global manifest_content` line just to be safe.
2020-01-26 02601, 2020
12:15 PM
iliekcomputers
and then when we deploy to beta, check that the page works.
2020-01-26 02623, 2020
12:15 PM
ishaanshah[m]
Hmm
2020-01-26 02629, 2020
12:15 PM
iliekcomputers
does that sound reasonable to you?
2020-01-26 02649, 2020
12:15 PM
ishaanshah[m]
Ya, I think that should fix it.
2020-01-26 02658, 2020
12:16 PM
ishaanshah[m]
Anyways, tell me if I need to change anything
2020-01-26 02624, 2020
12:17 PM
iliekcomputers
hmm, i'm testing now.
2020-01-26 02657, 2020
12:18 PM
iliekcomputers
the react import seems faster lol
2020-01-26 02654, 2020
12:20 PM
ishaanshah[m]
I used the from option available in recenttracks
2020-01-26 02634, 2020
12:21 PM
ishaanshah[m]
Initially all the pages were fetched and then compared wit the latest import time to decide whether to import or not
2020-01-26 02606, 2020
12:23 PM
iliekcomputers
don't see any requests to submit-listens
2020-01-26 02644, 2020
12:23 PM
iliekcomputers
yep, nothing's being imported.
2020-01-26 02641, 2020
12:24 PM
iliekcomputers
which explains why it's parsing each page so fast, i guess :D
2020-01-26 02626, 2020
12:25 PM
iliekcomputers
(and it seems to have started over after completing the 1455 pages)
2020-01-26 02630, 2020
12:26 PM
ishaanshah[m]
Did you pull the latest changes that i made after your comments
2020-01-26 02640, 2020
12:26 PM
ishaanshah[m]
Coz there was a bug which I fixed
2020-01-26 02654, 2020
12:26 PM
iliekcomputers
i think i did.
2020-01-26 02617, 2020
12:27 PM
iliekcomputers
i'm at `5af3bd3cc4e7b3f6d072a60c44b4d402c1750d76`
2020-01-26 02659, 2020
12:27 PM
ishaanshah[m]
Yep thats the correct one
2020-01-26 02625, 2020
12:28 PM
iliekcomputers
nvm, the listens were slow to come up, i think
2020-01-26 02643, 2020
12:28 PM
ishaanshah[m]
Are you getting any errors in console
2020-01-26 02654, 2020
12:28 PM
iliekcomputers
let me start over.
2020-01-26 02604, 2020
12:30 PM
iliekcomputers
ishaanshah[m]: could you push some logging statements so that we can see what listens are being fetched and submitted to the API in the console
2020-01-26 02612, 2020
12:30 PM
iliekcomputers
I think that will be helpful here.
2020-01-26 02601, 2020
12:31 PM
ishaanshah[m]
Ok give 10 minutes
2020-01-26 02615, 2020
12:31 PM
ishaanshah[m]
Not near my laptop
2020-01-26 02648, 2020
12:31 PM
ishaanshah[m]
Also what is ur lastfm username
2020-01-26 02657, 2020
12:31 PM
ishaanshah[m]
So that we get the same data
2020-01-26 02658, 2020
12:32 PM
iliekcomputers
ishaanshah[m]: we can do this later if you're busy, no worries.
2020-01-26 02612, 2020
12:34 PM
ishaanshah[m]
Nah its fine
2020-01-26 02632, 2020
12:34 PM
ishaanshah[m]
Just went out to get a cup of coffee :D
2020-01-26 02648, 2020
12:34 PM
iliekcomputers
wait
2020-01-26 02657, 2020
12:34 PM
iliekcomputers
is it getting all of the pages and then sending them to LB?
2020-01-26 02612, 2020
12:35 PM
ishaanshah[m]
Yep
2020-01-26 02635, 2020
12:35 PM
iliekcomputers
that sounds ... unreasonable
2020-01-26 02605, 2020
12:36 PM
iliekcomputers
we used to do get page 1 -> submit page 1 -> get next page
2020-01-26 02620, 2020
12:36 PM
iliekcomputers
that way if the user has to stop the import in the middle, we still get some listens.
