#metabrainz

Ohk

is there a reason you went with getting ALL of them and then sending them?

No particular reason as such

Just thought it would be easier to handle all the fetches and then deal with the sending part

in that case, i'd prefer to not change current functionality, as it might confuse users who are used to thinking that if a page was done by the importer, it must have been imported.

I was definitely confused for a second :D

Ohk

How about this

I get 10 pages, send those and get next

10

And so on

let me look up what exactly we do currently.

ruaok: zas: could we deploy https://livegrep.com/search/linux for our codebases? :D

would make life much better when searching code :D :D

since it has github integration and docker images, I guess it is feasible

What are the advantages over gtihub searches?

zas: it's miles better than github search

github is bad at searching for files by name

here's a search for the file "scraper.js": https://github.com/metabrainz/listenbrainz-serv...

also has cool stuff like search in this directory or in these type of files etc.

this is the file I was looking for btw: https://github.com/metabrainz/listenbrainz-serv...

nowhere in the github search :(

https://livegrep.com/search/linux?q=file%3A.jso... (stuff like this is just not possible with github search)

ishaanshah[m]: i would prefer to get 1 page, submit 1 page, update the message, get another, submit another, update message for now.

because that's what we do right now.

Ok.

zas: should I open an MBH ticket?

I will make the necessary changes.

I just changed the flow of the code a bit

So as to make it easy to read.

ishaanshah[m]: thanks!

once you change the behaviour to get 1 page, submit 1 page, request a review again.

Can you just take a look at the flow and tell me if it is fine

ishaanshah[m]: do you have specific commits you want me to look at?

Just tell me if what I am is correct

I am getting the total pages

Then I will get a single page

Encode it and submit it

Repeat this until everything is done

what do you mean by getting the total pages?

The total number of pages that Lastfm is gonna send

mhmm, that flow makes sense to me.

My only concern was that this would be a bit slow

ishaanshah[m]: why? we're making the same number of requests either way?

Coz we are not doing anything while the page is fetched we arent doing anything with the scrobbles waiting in the queue

zas: https://tickets.metabrainz.org/browse/MBH-532

MBH-532: Deploy a livegrep instance for our codebases at livegrep.metabrainz.org

ishaanshah[m]: but aren't we doing the same thing right now?

Ya we are

when we're fetching the scrobbles, we aren't doing anything with the scrobbles in the queue.

ishaanshah[m]: let's do the 1 page flow and see if it's very slow

Ok fine

if it is, we'll look into how to fix that.

Cool

I will let you know when I make the changes

awesome

https://tickets.metabrainz.org/browse/BB-397 @Mr_Monkey What do you think of this

BB-397: revisions in editor's profile can be improved

https://github.com/bookbrainz/bookbrainz-site/p... Have a look at this when you're free. Also I made changes in revisionsPage PR :)

@rahul24 Hey sorry for late reply, I assigned myself only a few of them, you can have a look at the rest :)

[bookbrainz-site] prabalsingh24 opened pull request #348 (master…react-fontawesome-#BB371): React fontawesome #bb371 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] prabalsingh24 opened pull request #349 (master…react-fontawesome-#BB372): React fontawesome #bb372 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] prabalsingh24 opened pull request #350 (master…react-fontawesome-BB373): React fontawesome bb373 https://github.com/bookbrainz/bookbrainz-site/p...

outsidecontext: i personally think the Scan/AcoustID function in Picard needs more feedback for users

[bookbrainz-site] prabalsingh24 opened pull request #351 (master…react-fontawesome-BB374): React fontawesome bb374 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] prabalsingh24 opened pull request #352 (master…react-fontawesome-#BB376): React fontawesome #bb376 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] prabalsingh24 opened pull request #353 (master…react-fontawesome-#BB375): React fontawesome #bb375 https://github.com/bookbrainz/bookbrainz-site/p...

outsidecontext: also, when a DiscID does not exist, there are errors in the log - is this wanted? :)

[listenbrainz-server] paramsingh merged pull request #708 (master…stream-export): LB-484: Stream response from /profile/export endpoint https://github.com/metabrainz/listenbrainz-serv...

LB-484: 504 Gateway Timeout when trying to export listens https://tickets.metabrainz.org/browse/LB-484

shivam-kapila: you around?

someone messed the recents page up https://usercontent.irccloud-cdn.com/file/Xbu8Z...

CatQuest: I see a few unrelated issues in this epic: https://tickets.metabrainz.org/projects/LB/issu...

shivam-kapila: Whenver you're up have a look at https://tickets.metabrainz.org/browse/LB-486 ( as per your wish to hold to a task in labs) .

LB-486: Create dumps of candidate recordings

if it makes sense to you, assign it to yourself, please :)

pristine__: iliekcomputers: i had a question about listens. say, a user pauses a song after listening to enough duration to count as a listen. he resumes the song but at a later time and again listens the song for enough duration to count as a listen. Should this be treated as a single listen or two different listens?

amCap1712: thinking about this holistically, i think it depends on the duration for which the song was paused.

if it was paused for like 30s, i'd prefer if it was counted as a single listen.

if it was longer, say a minute or 5 minutes, that's probably two listens.

amCap1712: is this about your vlc plugin?

iliekcomputers: yes, i was testing it out and found that vlc provides somes options to behave differently on pausing a song, manually stopping a song or when a song play fully. so i asked?

mhmm, makes sense.

If what I said is technically difficult to implement, I would tend towards recording them as two listens.

I'll try to implement so what should keep the cutoff time for two listens?

let's go with a minute

we can get user feedback later (once we release)

ok great

do you have source code somewhere, by any chance?

its a single file in C

I can send you the file if you want.

haha, np.

what's the plan tho?

are you gonna try to get it merged into vlc?

yes

because that would be amazing!

amCap1712: awesome!

its working fine on linux

i am testing windows at this moment

and then will check on mac

ah, awesome.

please link your PR whenever you create it.

if it goes well then i will ask the community to test and then submit it to vlc

yeah sure

pristine__: Hi. I am up now. I have had a look into the task. So I have to create data dumps just like the LB listens?

> like LB listens?

I am not sure what you mean.

We want to create dumps of recordings

shivam-kapila: ^

I meant like the data dumps on ftp server.

ruaok: a meeting tomorrow to catch up would be helpful.

Perfect! Let's do it

bitmap, reosarevok : would be great if you could review both PRs of Series entity. Soon after I'll push PRs for next set of entity type

shivam-kapila: yeah. A good place to start with will be to get the desired attributes as in the schema

prabal: Thanks :)

Sorry wrong mention

pristine__: Thanks

Cyna: I'll check in a bit, not sure if bitmap is around tonight or not though :)

Oh

So, I guess he's not around right now :p

ruaok: I thought you were back in Europe lol

he was, last week ;)

Haha

Yep. And will be tomorrow.

Lx9 leaves in 4:30. And stop this wild culture shock ride

iliekcomputers: ack. that would be GCI students messing things up

CatQuest: np, just wanted to flag the issue.

huh. say iliekcomputers can "epic" type ticekts have tickets that have sub-tiets in them?