#metabrainz

/

      • prabal has quit
      • 2020-01-27 02708, 2020

      • CatQuest
        only if you click thme, afaik
      • 2020-01-27 02716, 2020

      • reosarevok
        itunes.apple.com isn't really a thing
      • 2020-01-27 02730, 2020

      • reosarevok
        If you click "see on itunes" they don't even add a parameter, they just change on the same URL
      • 2020-01-27 02737, 2020

      • yvanzo
        We should not change them, but we can display it with that parameter to force using iTunes.
      • 2020-01-27 02748, 2020

      • reosarevok
      • 2020-01-27 02757, 2020

      • yvanzo
        (Or even display both.)
      • 2020-01-27 02720, 2020

      • reosarevok
      • 2020-01-27 02730, 2020

      • reosarevok
        (for now, of course, who knows if that'll remain)
      • 2020-01-27 02750, 2020

      • yvanzo
        So we can just display both links?
      • 2020-01-27 02709, 2020

      • reosarevok
        I guess we could, if that's something we want (and it won't overload the sidebar)
      • 2020-01-27 02728, 2020

      • reosarevok
        In that case, it'd make sense to clean everything up to music.apple and then automatically provide the ?app one too, I guess?
      • 2020-01-27 02729, 2020

      • Freso
        I’d say to change itunes.apple.com URLs to music.apple.com ones then. We can display both if we want, but let’s keep the upstream "canonical" one in the db.
      • 2020-01-27 02751, 2020

      • reosarevok
        But then we should change the relationship
      • 2020-01-27 02708, 2020

      • reosarevok
        Should we add an actual Apple Music relationship, or have it be a generic streaming one?
      • 2020-01-27 02728, 2020

      • Freso
        Sounds like it might be good to make an Apple Music one.
      • 2020-01-27 02729, 2020

      • CatQuest
        hmm. does streaming have a "purchase for streaming"
      • 2020-01-27 02730, 2020

      • reosarevok
        The second would be more consistent with what we do with Spotify etc, but the first would make it less weird when this one streaming rel creates a second link
      • 2020-01-27 02733, 2020

      • rahul24 has quit
      • 2020-01-27 02746, 2020

      • CatQuest
        becasue right now that says "stream for free"
      • 2020-01-27 02749, 2020

      • CatQuest
        iirc
      • 2020-01-27 02755, 2020

      • reosarevok
      • 2020-01-27 02701, 2020

      • reosarevok
        I added it for Tidal a while ago
      • 2020-01-27 02711, 2020

      • Freso
        Since it can be both streaming and purchase but we don’t really want to store both $URL and $URL?app=itunes
      • 2020-01-27 02720, 2020

      • reosarevok
        But because this is a weird case, I agree maybe Apple Music makes sense
      • 2020-01-27 02733, 2020

      • reosarevok
        (Ideally I would want to separate them all, but that's a longer-future idea)
      • 2020-01-27 02750, 2020

      • reosarevok
        (and only if they're not shown at all to a user when picking, only ever autoselected)
      • 2020-01-27 02725, 2020

      • reosarevok
        Ok, it's full hour, does anyone think its own rel for apple music is an awful horrible idea?
      • 2020-01-27 02728, 2020

      • yvanzo
        Having "both streaming and purchase" is MBS-9902
      • 2020-01-27 02729, 2020

      • BrainzBot
        MBS-9902: Support auto-select/cleanup/validation of more than one relationship type for external links https://tickets.metabrainz.org/browse/MBS-9902
      • 2020-01-27 02739, 2020

      • CatQuest
        nah
      • 2020-01-27 02708, 2020

      • CatQuest
        (to reo)
      • 2020-01-27 02723, 2020

      • reosarevok
        Ok, I'll do it that way I guess
      • 2020-01-27 02724, 2020

      • bitmap
        dedicated rel sounds reasonable
      • 2020-01-27 02730, 2020

      • yvanzo
        Yup!
      • 2020-01-27 02742, 2020

      • reosarevok
        yvanzo, bitmap: we can maybe coordinate on the actual move since this involves changing a ton of rels
      • 2020-01-27 02748, 2020

      • reosarevok
        Freso: bang us off!
      • 2020-01-27 02753, 2020

      • reosarevok
        ... that sounds wrong
      • 2020-01-27 02756, 2020

      • Freso
        >_>
      • 2020-01-27 02714, 2020

      • Freso
        That wraps up this week’s meeting!
      • 2020-01-27 02718, 2020

      • Freso
        Thanks for your time everyone!
      • 2020-01-27 02720, 2020

      • Freso
        </BANG>
      • 2020-01-27 02740, 2020

      • Freso
        First time we’ve used the full hour in a long time.
      • 2020-01-27 02703, 2020

      • ruaok
        iliekcomputers: I'm still semi-sentient.
      • 2020-01-27 02717, 2020

      • yvanzo
        Thanks Freso!
      • 2020-01-27 02717, 2020

      • reosarevok
        ruaok: it's ok, that's already progress
      • 2020-01-27 02722, 2020

      • reosarevok
        You'll get there
      • 2020-01-27 02738, 2020

      • CatQuest
        :D
      • 2020-01-27 02741, 2020

      • iliekcomputers
        ruaok: hey
      • 2020-01-27 02750, 2020

      • iliekcomputers
        We can do this tomorrow if you want.
      • 2020-01-27 02712, 2020

      • iliekcomputers
        Actually, I think it might be better if we do this tomorrow. Once you've looked at the pull requests for context.
      • 2020-01-27 02713, 2020

      • ruaok
        I think that is wise.
      • 2020-01-27 02719, 2020

      • ruaok
        normal meeting time tomorrow?
      • 2020-01-27 02755, 2020

      • iliekcomputers
        Sounds good
      • 2020-01-27 02728, 2020

      • ruaok
        fabu.
      • 2020-01-27 02755, 2020

      • shivam-kapila
        iliekcomputers: Please have a look at Pg 3 & 4
      • 2020-01-27 02759, 2020

      • shivam-kapila
      • 2020-01-27 02716, 2020

      • yvanzo
        CatQuest: INST screen scheme was not showing epic fields. You should be able to name epics now, see https://tickets.metabrainz.org/secure/QuickSearch…
      • 2020-01-27 02745, 2020

      • CatQuest
        yes
      • 2020-01-27 02713, 2020

      • rahul24 joined the channel
      • 2020-01-27 02739, 2020

      • reosarevok
        Oh btw
      • 2020-01-27 02745, 2020

      • reosarevok
        I'm off to Finland on Wed
      • 2020-01-27 02750, 2020

      • CatQuest
        wat
      • 2020-01-27 02751, 2020

      • reosarevok
        Back on Monday, I'll try to make the meeting
      • 2020-01-27 02702, 2020

      • rahul24 has quit
      • 2020-01-27 02722, 2020

      • reosarevok
        I might not be super-available at all times from 29 to 3rd
      • 2020-01-27 02728, 2020

      • reosarevok
        (so... like during a recent meeting, sigh)
      • 2020-01-27 02714, 2020

      • rahul24 joined the channel
      • 2020-01-27 02720, 2020

      • reosarevok
        yvanzo: is it possible to have something that works the same as "Epic" but is called "Mini Version"?
      • 2020-01-27 02702, 2020

      • CatQuest
        yvanzo: if that's not possiblw, just revert the moving of tickets from MV to epic
      • 2020-01-27 02704, 2020

      • yvanzo
        CatQuest: what isn't possible?
      • 2020-01-27 02750, 2020

      • CatQuest
        neverm ind.
      • 2020-01-27 02705, 2020

      • CatQuest
        uhm. just revert the move of tickets from "Mini-version" to epic
      • 2020-01-27 02716, 2020

      • CatQuest
        I don't need it after all I think
      • 2020-01-27 02730, 2020

      • CatQuest
        (this is why you sohudl aks before doing stuff like this ;)
      • 2020-01-27 02714, 2020

      • yvanzo
        bitmap, iliekcomputers: here is another error I got with sqlachemy 1.1 "AttributeError: _wildcard_token", see https://gist.github.com/yvanzo/a4191722c5ed474161…
      • 2020-01-27 02735, 2020

      • reosarevok
        yvanzo: if having "Epic" but with another name, I guess :)
      • 2020-01-27 02752, 2020

      • reosarevok
        yvanzo: also, I'm releasing to test, did you want to check something during a release or am I remembering wrong?
      • 2020-01-27 02737, 2020

      • yvanzo
      • 2020-01-27 02714, 2020

      • bitmap
      • 2020-01-27 02739, 2020

      • reosarevok
        bitmap: I just want to try this one for a sec, so maybe let's do that (see if the translation works there) and then put that one instead? :)
      • 2020-01-27 02745, 2020

      • yvanzo
        reosarevok: I mean, please try using it to deploy to test (no need to put it on test).
      • 2020-01-27 02752, 2020

      • reosarevok
        I'd like to put it on beta, but
      • 2020-01-27 02719, 2020

      • reosarevok
        yvanzo: so, check this branch out locally, then deploy using what command?
      • 2020-01-27 02750, 2020

      • c1e0 has quit
      • 2020-01-27 02726, 2020

      • yvanzo
        reosarevok: update the remote test branch with what you want to deploy first, build it through ci as usual, then run script/update_containers.sh
      • 2020-01-27 02736, 2020

      • rdswift
        outsidecontext / zas, is there a write-up somewhere that identifies the sequence of events in Picard processing when a release is loaded / matched / saved / etc? For example: (1) download info from mb.o; (2) execute plugins; (3) execute tagging scripts; (4) files matched; (5) initiate save; (6) execute naming script; (7) complete save. I thought I saw one once, but I can't seem to find it now. Thanks.
      • 2020-01-27 02756, 2020

      • reosarevok
        yvanzo: script/update_containers.sh test I assume? :)
      • 2020-01-27 02705, 2020

      • reosarevok
        Oh
      • 2020-01-27 02706, 2020

      • reosarevok
        Please set $LIST_METABRAINZ_HOSTS or specify hosts list
      • 2020-01-27 02740, 2020

      • yvanzo
        yes, it needs a working copy of docker-server-configs.
      • 2020-01-27 02745, 2020

      • outsidecontext
        rdswift: only the code I think. I think I also mentioned the loading procedure in some forum answer somewhere
      • 2020-01-27 02723, 2020

      • yvanzo
        reosarevok: it implements what you have been asking for: not requiring to type the list of hosts, but it relies on docker-server-configs for that.
      • 2020-01-27 02735, 2020

      • reosarevok
        Ok. So I get that how? :)
      • 2020-01-27 02758, 2020

      • yvanzo
        git clone if you didn't already?
      • 2020-01-27 02704, 2020

      • rahul24 has quit
      • 2020-01-27 02705, 2020

      • rdswift
        Okay, I'll hunt the forum then (first). That seems to ring a bell. Thanks.
      • 2020-01-27 02726, 2020

      • rahul24 joined the channel
      • 2020-01-27 02746, 2020

      • reosarevok
        Oh, it's a different repo
      • 2020-01-27 02746, 2020

      • reosarevok
        Ok
      • 2020-01-27 02704, 2020

      • yvanzo
        reosarevok: in the same parent directory as musicbrainz-server working copy if that works for you
      • 2020-01-27 02718, 2020

      • reosarevok
        But not inside musicbrainz-server, just side by side?
      • 2020-01-27 02736, 2020

      • yvanzo
        otherwise, any path, but you will have to set LIST_METABRAINZ_HOSTS
      • 2020-01-27 02737, 2020

      • yvanzo
        right
      • 2020-01-27 02716, 2020

      • yvanzo
        (inside could work with LIST_METABRAINZ_HOSTS but it would not be ignored by git)
      • 2020-01-27 02717, 2020

      • rahul24 has quit
      • 2020-01-27 02745, 2020

      • sarthak_jain joined the channel
      • 2020-01-27 02705, 2020

      • zas
        rdswift: I don't think there is any yet.
      • 2020-01-27 02722, 2020

      • rdswift
        If I can come up with something based on the code and/or what was posted in the forum, is it worth documenting somewhere?
      • 2020-01-27 02753, 2020

      • CatQuest
        rdswift: I'd say heck yes
      • 2020-01-27 02733, 2020

      • zas
        Sure, always worth documenting ;)
      • 2020-01-27 02736, 2020

      • rdswift
        Okay. The next obvious question... Where? ;-)
      • 2020-01-27 02749, 2020

      • sarthak_jain
        pristine__: After the integration of LB spark and server, do I have setup the environment again ?
      • 2020-01-27 02758, 2020

      • sarthak_jain
        I cant find the config.py file !
      • 2020-01-27 02746, 2020

      • sarthak_jain has quit
      • 2020-01-27 02746, 2020

      • yvanzo
        zas: Would be safer with your review at https://github.com/metabrainz/postgresql-musicbra… :)
      • 2020-01-27 02710, 2020

      • reosarevok
        yvanzo: ok, the fabric stuff does seem to work then
      • 2020-01-27 02715, 2020

      • reosarevok
        Or well, not-fabric stuff
      • 2020-01-27 02758, 2020

      • reosarevok
        Feel free to merge then I guess
      • 2020-01-27 02718, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1366 (master…MBS-10586): Fix MBS-10586 / MBS-10587 / MBS-10588: Release Duplicates medium format fixes https://github.com/metabrainz/musicbrainz-server/…
      • 2020-01-27 02720, 2020

      • BrainzBot
        MBS-10586: Release duplicates tab shows [missing media] when medium format is simply unknown https://tickets.metabrainz.org/browse/MBS-10586
      • 2020-01-27 02720, 2020

      • BrainzBot
        MBS-10587: Medium counts broken in Release Duplicates list https://tickets.metabrainz.org/browse/MBS-10587
      • 2020-01-27 02720, 2020

      • BrainzBot
        MBS-10588: Medium formats untranslated in Release Duplicates list https://tickets.metabrainz.org/browse/MBS-10588
      • 2020-01-27 02703, 2020

      • travis-ci joined the channel
      • 2020-01-27 02703, 2020

      • travis-ci
        Project bookbrainz-data-js build #1368: passed in 1 min 57 sec: https://travis-ci.org/bookbrainz/bookbrainz-data-…
      • 2020-01-27 02703, 2020

      • travis-ci has left the channel
      • 2020-01-27 02723, 2020

      • yvanzo
        reosarevok: is the help message enough?
      • 2020-01-27 02743, 2020

      • reosarevok
        Which one? :)
      • 2020-01-27 02758, 2020

      • reosarevok
        The Please set $LIST_METABRAINZ_HOSTS or specify hosts list one?
      • 2020-01-27 02758, 2020

      • yvanzo
        script/update_containers.sh
      • 2020-01-27 02703, 2020

      • reosarevok
        I mean, I guess?
      • 2020-01-27 02709, 2020

      • reosarevok
        I'd expect us to document this in syswiki anyway
      • 2020-01-27 02711, 2020

      • zas
        rdswift: you can make a markdown document in Picard, or just start a googledoc to start with
      • 2020-01-27 02700, 2020

      • rdswift
        Okay, will do.
      • 2020-01-27 02757, 2020

      • reosarevok
        bitmap: wanna throw it up on test or should I?
      • 2020-01-27 02729, 2020

      • bitmap
        if you don't mind
      • 2020-01-27 02709, 2020

      • reosarevok
        Ok
      • 2020-01-27 02732, 2020

      • bitmap
        thx
      • 2020-01-27 02744, 2020

      • bitmap
        yvanzo: not sure about that new sir error, that's an odd one
      • 2020-01-27 02722, 2020

      • rahul24 joined the channel
      • 2020-01-27 02759, 2020

      • bitmap
        I feel like we're hacking around way too many sqlalchemy internals that we're not supposed to atm
      • 2020-01-27 02712, 2020

      • yvanzo
        bitmap: I found some doc about wild card, but I don't see where it is used here, I don't see how it can be related to attribute either.
      • 2020-01-27 02745, 2020

      • bitmap
        might have something to do with begin_date being a CompositeProperty
      • 2020-01-27 02745, 2020

      • yvanzo
        not only with sqlalchemy internals tbh
      • 2020-01-27 02710, 2020

      • yvanzo
        reosarevok: I just pushed a new commit to https://github.com/metabrainz/musicbrainz-server/… that tries to summarize what I just had to explain on IRC.
      • 2020-01-27 02741, 2020

      • reosarevok
        Seems good
      • 2020-01-27 02720, 2020

      • BrainzGit
        [postgresql-musicbrainz-collate] yvanzo merged pull request #5 (master…master): Switch to pkg-config https://github.com/metabrainz/postgresql-musicbra…
      • 2020-01-27 02725, 2020

      • yvanzo
        zas: thanks!
      • 2020-01-27 02725, 2020

      • prabal joined the channel
      • 2020-01-27 02714, 2020

      • reosarevok
        bitmap: should be up I think