#metabrainz

/

      • shivam-kapila joined the channel
      • 2020-02-07 03824, 2020

      • abhishek_ has quit
      • 2020-02-07 03819, 2020

      • travis-ci joined the channel
      • 2020-02-07 03819, 2020

      • travis-ci
        Project bookbrainz-site build #2612: passed in 2 min 8 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-02-07 03819, 2020

      • travis-ci has left the channel
      • 2020-02-07 03803, 2020

      • shivam-kapila
        sarthak_jain: You needed some help regarding uploading listens. You can consult here if you are stuck somewhere https://github.com/metabrainz/listenbrainz-server…
      • 2020-02-07 03810, 2020

      • BrainzGit
        [bookbrainz-site] MonkeyDo opened pull request #362 (master…reindex-aliases-on-edit): Fix BB-367: reindex entities (search) with updated aliases https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-02-07 03811, 2020

      • BrainzBot
        BB-367: Entities are not reindexed if you change their name (defaultAlias) https://tickets.metabrainz.org/browse/BB-367
      • 2020-02-07 03814, 2020

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #362 (master…reindex-aliases-on-edit): Fix BB-367: reindex entities (search) with updated aliases https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-02-07 03815, 2020

      • BrainzBot
        BB-367: Entities are not reindexed if you change their name (defaultAlias) https://tickets.metabrainz.org/browse/BB-367
      • 2020-02-07 03859, 2020

      • travis-ci joined the channel
      • 2020-02-07 03859, 2020

      • travis-ci
        Project bookbrainz-site build #2614: passed in 2 min 10 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-02-07 03859, 2020

      • travis-ci has left the channel
      • 2020-02-07 03859, 2020

      • travis-ci joined the channel
      • 2020-02-07 03859, 2020

      • travis-ci
        Project bookbrainz-site build #2615: passed in 2 min 54 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-02-07 03859, 2020

      • travis-ci has left the channel
      • 2020-02-07 03831, 2020

      • Somal joined the channel
      • 2020-02-07 03848, 2020

      • Somal
        Hello ! The new idea page of MusicBrainz doesnt contain any android related idea.. https://wiki.musicbrainz.org/Development/Summer_o….. Can someone check and confirm the same??
      • 2020-02-07 03818, 2020

      • Etua
        Somal: I don't see anything Android related. Should I?
      • 2020-02-07 03847, 2020

      • Somal
        Actually 2019's project on musicBrainz was android based one.. But this time in the organization's idea list there's no mention of anything android related.. so should I consider it as a halt to android project on musicbrainz or should i pitch my idea regarding the android app??
      • 2020-02-07 03809, 2020

      • yvanzo
        Hi Somal, you should not consider this list as exhaustive, any project beyond this list will be considered.
      • 2020-02-07 03824, 2020

      • Somal
        Thanks yvanzo ! Could you tell me whether it would be a good idea to go through the last year's android app based project's repository and make changes and commit them and make a proposal based on that? As this is my first time in GSOC this would mean a great help
      • 2020-02-07 03822, 2020

      • prabal has quit
      • 2020-02-07 03812, 2020

      • yvanzo
        Probably, you might want to check with amCap1712, I don’t know the exact current status and potential future plans.
      • 2020-02-07 03839, 2020

      • amCap1712
        Hi Somal, Yes you can surely do that. I worked on the app last year so you can reach out to me for any queries.
      • 2020-02-07 03852, 2020

      • Somal
        Hi amCap1712 ! I will start working on it thn..thanks for your gesture!
      • 2020-02-07 03811, 2020

      • shivam-kapila has quit
      • 2020-02-07 03813, 2020

      • Somal has quit
      • 2020-02-07 03801, 2020

      • djinni` has quit
      • 2020-02-07 03859, 2020

      • Etua has quit
      • 2020-02-07 03813, 2020

      • Cyna
      • 2020-02-07 03826, 2020

      • djinni` joined the channel
      • 2020-02-07 03825, 2020

      • Cyna
        This is the structure of `edit.display_data.attributes`. I am confused as to what type it would be. According to WorkT this should be `+attributes: $ReadOnlyArray<WorkAttributeT>,`. but that wouldn't make sense as this is an object of `$ReadOnlyArray<WorkAttributeT>`. bitmap let me know what you think
      • 2020-02-07 03859, 2020

      • bitmap
        based on your link it'd be {+[string]: $ReadOnlyArray<WorkAttributeT>}
      • 2020-02-07 03818, 2020

      • bitmap
        keep in mind `edit.display_data` isn't a WorkT
      • 2020-02-07 03827, 2020

      • bitmap
        it's just whatever format build_display_data returns
      • 2020-02-07 03843, 2020

      • Cyna
        Yea, I dont know if its right but here is what I deduced ```type AttributeT = {
      • 2020-02-07 03843, 2020

      • Cyna
        [key: string]: $ReadOnlyArray<WorkAttributeT>,
      • 2020-02-07 03843, 2020

      • Cyna
        };```
      • 2020-02-07 03830, 2020

      • bitmap
        yes, that's the same as what I pasted above :)
      • 2020-02-07 03853, 2020

      • bitmap
        no need to assign it to a type alias though unless you need an alias outside of display_data
      • 2020-02-07 03813, 2020

      • Cyna
        Well here is another flow error when I try using attributes
      • 2020-02-07 03816, 2020

      • Cyna
        Cannot create `table` element because in property `children`: Either inexact children array [1] is incompatible with exact `React.Element` [2]. Or children array [1] is incompatible with `React.Portal` [3]. Or property `key` is missing in object literal [4] but exists in `React.Element` [2] in type argument `Yield` [5] of the return value of property `@@iterator`. Or object literal [4] is incompatible with `React.Portal`
      • 2020-02-07 03816, 2020

      • Cyna
        [3] in type argument `Yield` [5] of the return value of property `@@iterator`. Or property `@@iterator` is missing in object literal [4] but exists in `$Iterable` [6] in type argument `Yield` [5] of the return value of property `@@iterator`.
      • 2020-02-07 03822, 2020

      • bitmap
        I can't help with type errors without seeing the code
      • 2020-02-07 03833, 2020

      • Cyna
        I"ll push it
      • 2020-02-07 03847, 2020

      • BrainzGit
        [musicbrainz-server] anirudhjain75 opened pull request #1372 (master…add-work-detail): [WIP] Add work edit template https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-07 03800, 2020

      • Cyna
      • 2020-02-07 03839, 2020

      • bitmap
        it's from the {attributes ? {} : null} line
      • 2020-02-07 03813, 2020

      • Cyna
        Yea as soon as I use `Object.keys` or `Object.values` Im getting the same error
      • 2020-02-07 03837, 2020

      • bitmap
        you have to output a react element, or array/fragment, or null, not an object
      • 2020-02-07 03821, 2020

      • Cyna
        ohh I'll implement the output first and check try to fix the flow error then, Hope that should make things cleared for flow checker
      • 2020-02-07 03859, 2020

      • Darkloke joined the channel
      • 2020-02-07 03838, 2020

      • Cyna
        reosarevok: I guess you forgot to create issues on jira for `add work edit detail` and `edit work detail`
      • 2020-02-07 03816, 2020

      • Cyna
        nvm, I created them
      • 2020-02-07 03825, 2020

      • Cyna atleast something I can do XD
      • 2020-02-07 03859, 2020

      • Cyna
        bitmap: Just completed the code and updated the PR.
      • 2020-02-07 03811, 2020

      • bitmap
        awesome
      • 2020-02-07 03822, 2020

      • Cyna
        Manually testing doesn't seem to give me any error, hope the CI passes too
      • 2020-02-07 03834, 2020

      • Cyna
        Am off to bed then, good night
      • 2020-02-07 03846, 2020

      • bitmap
        ok, I'll try to check it today too, sleep well
      • 2020-02-07 03836, 2020

      • Darkloke has quit
      • 2020-02-07 03841, 2020

      • reosarevok
        Cyna: thanks, sorry, I guess I did maybe
      • 2020-02-07 03849, 2020

      • reosarevok
        I'll review too
      • 2020-02-07 03832, 2020

      • ayerhart joined the channel
      • 2020-02-07 03841, 2020

      • ayerhart has quit
      • 2020-02-07 03856, 2020

      • prabal joined the channel
      • 2020-02-07 03851, 2020

      • chaban
        Meh, hit the Discourse limit again: "You’ve reached the maximum number of edits. Please wait 14 hours before trying again."
      • 2020-02-07 03804, 2020

      • Darkloke joined the channel
      • 2020-02-07 03827, 2020

      • reosarevok
      • 2020-02-07 03826, 2020

      • Darkloke has quit