0:37 AM
thomasross is now known as Guest29729
2020-02-09 04037, 2020
0:37 AM
thomasross_ joined the channel
2020-02-09 04037, 2020
0:37 AM
Guest29729 has quit
2020-02-09 04037, 2020
0:37 AM
thomasross_ is now known as thomasross
2020-02-09 04043, 2020
1:24 AM
D4RK-PH0ENiX has quit
2020-02-09 04039, 2020
1:47 AM
D4RK-PH0ENiX joined the channel
2020-02-09 04048, 2020
1:47 AM
D4RK-PH0ENiX has quit
2020-02-09 04038, 2020
1:49 AM
D4RK-PH0ENiX joined the channel
2020-02-09 04030, 2020
3:08 AM
thomasross_ joined the channel
2020-02-09 04030, 2020
3:08 AM
thomasross is now known as Guest42794
2020-02-09 04030, 2020
3:08 AM
Guest42794 has quit
2020-02-09 04030, 2020
3:08 AM
thomasross_ is now known as thomasross
2020-02-09 04022, 2020
3:13 AM
thomasross has quit
2020-02-09 04049, 2020
3:13 AM
Lotheric has quit
2020-02-09 04050, 2020
3:13 AM
thomasross joined the channel
2020-02-09 04039, 2020
3:19 AM
thomasross has quit
2020-02-09 04028, 2020
3:20 AM
thomasross joined the channel
2020-02-09 04058, 2020
3:20 AM
thomasross_ joined the channel
2020-02-09 04058, 2020
3:20 AM
thomasross has quit
2020-02-09 04058, 2020
3:20 AM
thomasross_ is now known as thomasross
2020-02-09 04041, 2020
3:43 AM
thomasross has quit
2020-02-09 04045, 2020
3:44 AM
thomasross joined the channel
2020-02-09 04054, 2020
4:06 AM
thomasross has quit
2020-02-09 04052, 2020
4:20 AM
thomasross joined the channel
2020-02-09 04027, 2020
4:25 AM
thomasross has quit
2020-02-09 04058, 2020
4:33 AM
thomasross joined the channel
2020-02-09 04028, 2020
4:34 AM
djwhitey joined the channel
2020-02-09 04009, 2020
4:49 AM
djwhitey has quit
2020-02-09 04040, 2020
4:49 AM
djwhitey joined the channel
2020-02-09 04045, 2020
5:01 AM
shivam-kapila joined the channel
2020-02-09 04018, 2020
6:08 AM
thomasross has quit
2020-02-09 04030, 2020
6:13 AM
thomasross joined the channel
2020-02-09 04051, 2020
6:18 AM
thomasross has quit
2020-02-09 04018, 2020
6:22 AM
thomasross joined the channel
2020-02-09 04000, 2020
7:08 AM
BrainzGit
2020-02-09 04022, 2020
7:08 AM
travis-ci joined the channel
2020-02-09 04022, 2020
7:08 AM
travis-ci
2020-02-09 04022, 2020
7:08 AM
travis-ci has left the channel
2020-02-09 04016, 2020
7:47 AM
c1e0 joined the channel
2020-02-09 04014, 2020
7:59 AM
thomasross has quit
2020-02-09 04048, 2020
8:05 AM
abhishekpanwar joined the channel
2020-02-09 04033, 2020
8:21 AM
shivam-kapila has quit
2020-02-09 04051, 2020
8:22 AM
Prabhleen joined the channel
2020-02-09 04057, 2020
8:23 AM
Prabhleen
hello everyone!
2020-02-09 04048, 2020
8:24 AM
Prabhleen
i am here to contribute in #bookbrainz!
2020-02-09 04010, 2020
8:25 AM
Prabhleen
i know node.js and express ;-))
2020-02-09 04025, 2020
8:25 AM
Prabhleen
let me know what all i can do
2020-02-09 04022, 2020
8:31 AM
thomasross joined the channel
2020-02-09 04024, 2020
8:33 AM
reosarevok
2020-02-09 04025, 2020
8:33 AM
BrainzBot
MBS-10622: Beta: grouped relationships with open edits are only highlighted if all types are affected
2020-02-09 04014, 2020
8:50 AM
yvanzo
2020-02-09 04047, 2020
8:55 AM
yvanzo
2020-02-09 04013, 2020
8:58 AM
Prabhleen
thank you yvanzo!
2020-02-09 04023, 2020
8:58 AM
Prabhleen has quit
2020-02-09 04051, 2020
9:06 AM
shivam-kapila joined the channel
2020-02-09 04047, 2020
9:08 AM
thomasross has quit
2020-02-09 04058, 2020
9:13 AM
thomasross joined the channel
2020-02-09 04030, 2020
9:27 AM
abhishekpanwar has quit
2020-02-09 04004, 2020
9:28 AM
reosarevok
yvanzo: should I still apply that? :) (I see you approved)
2020-02-09 04042, 2020
9:29 AM
thomasross has quit
2020-02-09 04058, 2020
9:30 AM
Wassabi joined the channel
2020-02-09 04034, 2020
9:32 AM
Etua joined the channel
2020-02-09 04027, 2020
9:55 AM
Etua has quit
2020-02-09 04030, 2020
9:55 AM
abhishekpanwar joined the channel
2020-02-09 04016, 2020
10:03 AM
thomasross joined the channel
2020-02-09 04001, 2020
10:05 AM
Gazooo has quit
2020-02-09 04012, 2020
10:07 AM
Gazooo joined the channel
2020-02-09 04041, 2020
10:07 AM
yvanzo
reosarevok: Feel free to apply it if you want to, I honestly don’t recall if it makes a functional difference.
2020-02-09 04055, 2020
10:07 AM
reosarevok
I mean, you're the regexp master :D
2020-02-09 04000, 2020
10:08 AM
reosarevok
If you don't know...
2020-02-09 04004, 2020
10:08 AM
yvanzo
(I’m not sure Amazon will ever have another subdomain with "music" in it.)
2020-02-09 04032, 2020
10:08 AM
reosarevok
Oh, in that sense
2020-02-09 04053, 2020
10:08 AM
reosarevok
But you're sure that it will make the regexp more precise without causing any problems, right?
2020-02-09 04058, 2020
10:08 AM
reosarevok
IF so, I see no reason not to apply it :)
2020-02-09 04041, 2020
10:10 AM
yvanzo
I’m confident in my own comment (and probably tested it) but there is nothing better than passing it through tests. :)
2020-02-09 04002, 2020
10:14 AM
thomasross has quit
2020-02-09 04057, 2020
10:15 AM
reosarevok
Ok
2020-02-09 04013, 2020
10:16 AM
reosarevok
Do we currently have a way to make sure something is *not* matched, in URL Cleanup tests?
2020-02-09 04033, 2020
10:16 AM
reosarevok
I know we have a way to make sure it matches but isn't allowed, but not sure about not matching at all
2020-02-09 04044, 2020
10:18 AM
yvanzo
2020-02-09 04036, 2020
10:19 AM
yvanzo
"expected_relationship_type: undefined," is for not matching at all
2020-02-09 04002, 2020
10:20 AM
yvanzo
"only_valid_entity_types: []," is for not allowed
2020-02-09 04056, 2020
10:20 AM
reosarevok
Oooh, neat
2020-02-09 04057, 2020
10:20 AM
reosarevok
Thanks
2020-02-09 04059, 2020
10:36 AM
thomasross joined the channel
2020-02-09 04045, 2020
10:40 AM
madmouser1 has quit
2020-02-09 04014, 2020
11:13 AM
BestSteve has quit
2020-02-09 04007, 2020
11:19 AM
Major_Lurker has quit
2020-02-09 04040, 2020
11:26 AM
thomasross_ joined the channel
2020-02-09 04051, 2020
11:26 AM
thomasross has quit
2020-02-09 04052, 2020
11:26 AM
thomasross_ is now known as thomasross
2020-02-09 04040, 2020
11:28 AM
BestSteve joined the channel
2020-02-09 04055, 2020
11:28 AM
abhishekpanwar has quit
2020-02-09 04024, 2020
11:34 AM
D4RK-PH0ENiX has quit
2020-02-09 04039, 2020
11:34 AM
Lotheric joined the channel
2020-02-09 04014, 2020
11:39 AM
c1e0 has quit
2020-02-09 04014, 2020
11:51 AM
D4RK-PH0ENiX joined the channel
2020-02-09 04014, 2020
11:59 AM
thomasross has quit
2020-02-09 04019, 2020
11:59 AM
thomasross_ joined the channel
2020-02-09 04019, 2020
11:59 AM
thomasross_ is now known as thomasross
2020-02-09 04006, 2020
12:15 PM
thomasross_ joined the channel
2020-02-09 04006, 2020
12:15 PM
thomasross has quit
2020-02-09 04006, 2020
12:15 PM
thomasross_ is now known as thomasross
2020-02-09 04033, 2020
12:15 PM
Etua joined the channel
2020-02-09 04021, 2020
12:16 PM
shivam-kapila has quit
2020-02-09 04027, 2020
12:20 PM
Etua has quit
2020-02-09 04040, 2020
12:22 PM
zas
2020-02-09 04008, 2020
12:50 PM
thomasross is now known as Guest56571
2020-02-09 04008, 2020
12:50 PM
thomasross_ joined the channel
2020-02-09 04008, 2020
12:50 PM
Guest56571 has quit
2020-02-09 04008, 2020
12:50 PM
thomasross_ is now known as thomasross
2020-02-09 04029, 2020
12:50 PM
shivam-kapila joined the channel
2020-02-09 04056, 2020
12:59 PM
thomasross_ joined the channel
2020-02-09 04056, 2020
12:59 PM
thomasross has quit
2020-02-09 04056, 2020
12:59 PM
thomasross_ is now known as thomasross
2020-02-09 04023, 2020
14:01 PM
c1e0 joined the channel
2020-02-09 04016, 2020
14:13 PM
thomasross is now known as Guest3125
2020-02-09 04016, 2020
14:13 PM
thomasross_ joined the channel
2020-02-09 04016, 2020
14:13 PM
Guest3125 has quit
2020-02-09 04016, 2020
14:13 PM
thomasross_ is now known as thomasross
2020-02-09 04002, 2020
14:52 PM
sbvkrishna joined the channel
2020-02-09 04021, 2020
14:56 PM
shivam-kapila has quit
2020-02-09 04057, 2020
15:26 PM
c1e0_ joined the channel
2020-02-09 04052, 2020
15:27 PM
c1e0 has quit
2020-02-09 04026, 2020
15:28 PM
darkstardev13 joined the channel
2020-02-09 04032, 2020
15:29 PM
c1e0 joined the channel
2020-02-09 04000, 2020
15:31 PM
darkstardevx has quit
2020-02-09 04057, 2020
15:31 PM
c1e0_ has quit
2020-02-09 04008, 2020
15:32 PM
Lotheric has quit
2020-02-09 04053, 2020
15:32 PM
Lotheric joined the channel
2020-02-09 04023, 2020
15:34 PM
thomasross_ joined the channel
2020-02-09 04023, 2020
15:34 PM
thomasross has quit
2020-02-09 04023, 2020
15:34 PM
thomasross_ is now known as thomasross
2020-02-09 04029, 2020
16:06 PM
thomasross is now known as Guest12384
2020-02-09 04029, 2020
16:06 PM
thomasross_ joined the channel
2020-02-09 04029, 2020
16:06 PM
Guest12384 has quit
2020-02-09 04029, 2020
16:06 PM
thomasross_ is now known as thomasross
2020-02-09 04018, 2020
16:23 PM
thomasross_ joined the channel
2020-02-09 04018, 2020
16:23 PM
thomasross has quit
2020-02-09 04018, 2020
16:23 PM
thomasross_ is now known as thomasross
2020-02-09 04056, 2020
16:43 PM
prabal joined the channel
2020-02-09 04017, 2020
16:47 PM
prabal
@Mr_Monkey Hi
2020-02-09 04007, 2020
16:54 PM
djwhitey has quit
2020-02-09 04016, 2020
16:57 PM
prabal
Found a bug in pagination. Let's say you search something and you've set the size as 10, and you've got exactly 10 results. In that case `nextEnabled` should be `False` but because we've set condition as `nextEnabled : results.length>= size` we get it as true and clicking next button gives 'page not found error'.
2020-02-09 04053, 2020
16:58 PM
prabal
One solution I could think of is to get 1 result more than required and slice it.
2020-02-09 04013, 2020
16:59 PM
prabal
What do you think?
2020-02-09 04049, 2020
17:01 PM
sbvkrishna has quit
2020-02-09 04020, 2020
17:13 PM
thomasross_ joined the channel
2020-02-09 04020, 2020
17:13 PM
thomasross is now known as Guest67127
2020-02-09 04020, 2020
17:13 PM
Guest67127 has quit
