#metabrainz

/

      • ephemer0l has quit
      • 2020-02-10 04108, 2020

      • flamingspinach has quit
      • 2020-02-10 04147, 2020

      • D4RK-PH0ENiX has quit
      • 2020-02-10 04119, 2020

      • prabal
        Oh it's alright :)
      • 2020-02-10 04137, 2020

      • milkii_ is now known as milkii
      • 2020-02-10 04112, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-02-10 04125, 2020

      • tykling
        jeg /Win 32
      • 2020-02-10 04108, 2020

      • CatQuest
        hi tykling
      • 2020-02-10 04146, 2020

      • shivam-kapila has quit
      • 2020-02-10 04103, 2020

      • ephemer0l joined the channel
      • 2020-02-10 04147, 2020

      • Major_Lurker has quit
      • 2020-02-10 04105, 2020

      • c1e0 joined the channel
      • 2020-02-10 04124, 2020

      • c1e0_ joined the channel
      • 2020-02-10 04157, 2020

      • c1e0 has quit
      • 2020-02-10 04159, 2020

      • shivam-kapila joined the channel
      • 2020-02-10 04145, 2020

      • c1e0 joined the channel
      • 2020-02-10 04131, 2020

      • c1e0_ has quit
      • 2020-02-10 04154, 2020

      • adhawkins has quit
      • 2020-02-10 04120, 2020

      • adhawkins joined the channel
      • 2020-02-10 04128, 2020

      • sumedh joined the channel
      • 2020-02-10 04133, 2020

      • abhishekpanwar joined the channel
      • 2020-02-10 04120, 2020

      • legoktm has quit
      • 2020-02-10 04128, 2020

      • legoktm joined the channel
      • 2020-02-10 04108, 2020

      • prabal has quit
      • 2020-02-10 04146, 2020

      • shivam-kapila has quit
      • 2020-02-10 04138, 2020

      • abhishekpanwar has quit
      • 2020-02-10 04151, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo opened pull request #1374 (master…mbs-10625-smart-block-3): MBS-10625: Block even more smart URLs https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-10 04152, 2020

      • BrainzBot
        MBS-10625: Block even more smart links https://tickets.metabrainz.org/browse/MBS-10625
      • 2020-02-10 04133, 2020

      • reosarevok
        bitmap: please take a look at https://github.com/metabrainz/musicbrainz-server/… from yvanzo when you have some time :)
      • 2020-02-10 04138, 2020

      • reosarevok
        (and that one above too)
      • 2020-02-10 04136, 2020

      • yvanzo
        I fixed the automation rule, you should not worry about labeling, unlabeling, relabeling, ... PRs.
      • 2020-02-10 04154, 2020

      • reosarevok
        Thanks!
      • 2020-02-10 04103, 2020

      • yvanzo
        It is only triggered on PR opened, closed, marked as ready for review, and edited (title or description).
      • 2020-02-10 04107, 2020

      • reosarevok
        yvanzo: can you check https://github.com/metabrainz/musicbrainz-server/… at some point today? It's your kind of PR :p
      • 2020-02-10 04121, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1136 (master…MBS-3873): MBS-3873: Report: non-matching RG/release titles https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-10 04123, 2020

      • BrainzBot
        MBS-3873: New Report: Release groups with name not matching release’s name https://tickets.metabrainz.org/browse/MBS-3873
      • 2020-02-10 04112, 2020

      • reosarevok
        yvanzo: also please try to update MusicBrainzServerReleaseProcess.md when you have some time to drop fabric :)
      • 2020-02-10 04129, 2020

      • c1e0_ joined the channel
      • 2020-02-10 04113, 2020

      • yvanzo
        reosarevok: thanks for volunteering :)
      • 2020-02-10 04152, 2020

      • yvanzo
        reosarevok: you would probably want to review https://github.com/metabrainz/docker-server-confi… first
      • 2020-02-10 04109, 2020

      • c1e0 has quit
      • 2020-02-10 04141, 2020

      • c1e0 joined the channel
      • 2020-02-10 04125, 2020

      • c1e0_ has quit
      • 2020-02-10 04111, 2020

      • reosarevok
        Let me see
      • 2020-02-10 04107, 2020

      • reosarevok
        Seems good - at least the list it generated seems legit
      • 2020-02-10 04114, 2020

      • reosarevok
        bitmap: ^ maybe we can also merge that today
      • 2020-02-10 04149, 2020

      • yvanzo
        After all, I brewed this on your demand :)
      • 2020-02-10 04109, 2020

      • yvanzo
        reosarevok: please make sure it works for you to update beta.mb.o at least
      • 2020-02-10 04139, 2020

      • reosarevok
        I have the config already though now :D
      • 2020-02-10 04111, 2020

      • yvanzo
        Is it the same?
      • 2020-02-10 04114, 2020

      • reosarevok
        More or less
      • 2020-02-10 04121, 2020

      • reosarevok
        I guess I can replace it by the autogenerated one
      • 2020-02-10 04128, 2020

      • reosarevok
        And test further
      • 2020-02-10 04136, 2020

      • reosarevok
        Then I can actually update syswiki while at it
      • 2020-02-10 04153, 2020

      • yvanzo
        Nice, the scripts replacing fabfile should indeed be tested by people set to use it at some point.
      • 2020-02-10 04126, 2020

      • yvanzo
        It works for me at least (updated test/beta/prod using it) but we don’t have the same setup.
      • 2020-02-10 04151, 2020

      • reosarevok
        Hopefully we can merge a few more PRs today and then I can try to release beta and document it in the evening or tomorrow morning
      • 2020-02-10 04154, 2020

      • sumedh has quit
      • 2020-02-10 04115, 2020

      • sumedh joined the channel
      • 2020-02-10 04145, 2020

      • yvanzo
        reosarevok: no worry, you can update beta now if you want to, that doesn't prevent us from updating it afterwards.
      • 2020-02-10 04152, 2020

      • reosarevok
        I know, but that reduces the incentive to review more stuff :p
      • 2020-02-10 04120, 2020

      • reosarevok
        And stuff has been jumping from milestone to milestone that I really, really would like to actually get merged for once...
      • 2020-02-10 04131, 2020

      • reosarevok
        (not only my stuff, fwiw)
      • 2020-02-10 04109, 2020

      • reosarevok
        bitmap: should I remove https://github.com/metabrainz/musicbrainz-server/… from the milestone since it still has conflicts and you've mentioned you're not too motivated to work on it soonish?
      • 2020-02-10 04128, 2020

      • sumedh has quit
      • 2020-02-10 04147, 2020

      • yvanzo
        how does opening for beta test sooner reduce anything? ^^
      • 2020-02-10 04132, 2020

      • niceplace has quit
      • 2020-02-10 04120, 2020

      • niceplace joined the channel
      • 2020-02-10 04146, 2020

      • c1e0_ joined the channel
      • 2020-02-10 04102, 2020

      • Gazooo has quit
      • 2020-02-10 04157, 2020

      • c1e0 has quit
      • 2020-02-10 04119, 2020

      • Gazooo joined the channel
      • 2020-02-10 04103, 2020

      • abhishekpanwar joined the channel
      • 2020-02-10 04154, 2020

      • ruaok
        moooin!
      • 2020-02-10 04131, 2020

      • ruaok
        zas: how hard would it be to setup your mb_stats for LB? this is to address the ongoing rabbit mq messages for the LB queue.
      • 2020-02-10 04115, 2020

      • zas
        this is simple: it exists already ;)
      • 2020-02-10 04117, 2020

      • ruaok
        > For what it's worth, this is literally a spammer reporting someone for downvoting their spam. That's a first.
      • 2020-02-10 04117, 2020

      • zas
      • 2020-02-10 04120, 2020

      • ruaok
        lol.
      • 2020-02-10 04157, 2020

      • ruaok
        zas: not that one. I want to know top ips hitting the service.
      • 2020-02-10 04109, 2020

      • zas
        ah ;) ok
      • 2020-02-10 04119, 2020

      • zas
        let me check
      • 2020-02-10 04135, 2020

      • ruaok
        oh, but that is interesting too. it confirms what I already deduced from another view.
      • 2020-02-10 04150, 2020

      • ruaok
        large bursts of data coming in, but all duplicate. all removed, nothing written to DB.
      • 2020-02-10 04156, 2020

      • ruaok
        pointless.
      • 2020-02-10 04110, 2020

      • zas
        ruaok: there are multiple nginx log files for LB which one(s) should be parsed?
      • 2020-02-10 04134, 2020

      • ruaok
        listenbrainz-web-production is the container that I wish to monitor.
      • 2020-02-10 04115, 2020

      • zas
        so it should be prod.listenbrainz-web.access.log
      • 2020-02-10 04133, 2020

      • ruaok
        sounds like it.
      • 2020-02-10 04154, 2020

      • zas
        there's also a prod.listenbrainz-follow-dispatcher.access.log
      • 2020-02-10 04117, 2020

      • ruaok
        yes, not that one.
      • 2020-02-10 04144, 2020

      • yvanzo
        In your experience, would using a msg_queue table in PostgreSQL in place of RabbitMQ exchange cause performance issues?
      • 2020-02-10 04142, 2020

      • yvanzo
        That is about queuing MB search index messages. I think it does but didn’t have to deal with previous impl.
      • 2020-02-10 04143, 2020

      • ruaok
        yvanzo: is that directed at me?
      • 2020-02-10 04110, 2020

      • ruaok
        because I don't really have an answer for you.
      • 2020-02-10 04147, 2020

      • CatQuest
        hommik reosarevok
      • 2020-02-10 04152, 2020

      • shivam-kapila joined the channel
      • 2020-02-10 04115, 2020

      • CatQuest
        how is everyone? elsa hasn't blow you all away?
      • 2020-02-10 04120, 2020

      • yvanzo
        ruaok: to anyone having an experience with the current and previous design.
      • 2020-02-10 04140, 2020

      • ruaok
        k. right now it uses rabbitmq, no?
      • 2020-02-10 04159, 2020

      • CatQuest
        or drownd you ...
      • 2020-02-10 04105, 2020

      • yvanzo
        Yes and I guess it has been chosen for performances.
      • 2020-02-10 04134, 2020

      • CatQuest
        I guess spain is too south for this https://www.yr.no/en/extreme/elsa
      • 2020-02-10 04104, 2020

      • ruaok
        yvanzo: yes and it is really quite good at what it does.
      • 2020-02-10 04106, 2020

      • yvanzo
        But deploying pg_amqp extension can not work with managed databases (for mirrors only), so using a PG table can be an alternative.
      • 2020-02-10 04141, 2020

      • ruaok
        "managed databases (for mirrors only)" can you elaborate on this, please?
      • 2020-02-10 04157, 2020

      • yvanzo
        AWS and such I guess
      • 2020-02-10 04118, 2020

      • yvanzo
        Online services don't allow for any PG extension.
      • 2020-02-10 04133, 2020

      • ruaok
        ah, i see. ok, that provides more context around this.
      • 2020-02-10 04145, 2020

      • zas
      • 2020-02-10 04159, 2020

      • yvanzo
      • 2020-02-10 04115, 2020

      • yvanzo
        I think we had a conversation before this PR but I cannot find it again.
      • 2020-02-10 04144, 2020

      • ruaok
        zas: <3 <3 <3
      • 2020-02-10 04112, 2020

      • zas
        ruaok: stats based on yesterday's log (rotated around 7am)
      • 2020-02-10 04131, 2020

      • ruaok
        and now I realize that I need to ask one more thing of you. the API container as well.
      • 2020-02-10 04135, 2020

      • ruaok
        let me look which one that is.
      • 2020-02-10 04131, 2020

      • ruaok
        huh. no, its in the same container. does your stuff also scan for POST methods, zas?
      • 2020-02-10 04107, 2020

      • yvanzo
        Anyway, thank you, that already answered my main question.
      • 2020-02-10 04110, 2020

      • zas
        not sure, I re-used the parser made for MB website, let me check
      • 2020-02-10 04156, 2020

      • ruaok
        yvanzo: by the looks of it that PR doesn't change us away from rabbitmq, right?
      • 2020-02-10 04117, 2020

      • reosarevok
        yvanzo: https://github.com/metabrainz/musicbrainz-server/… - you mean [ 'artist', 'event', 'label', 'place', 'series' ] I guess?
      • 2020-02-10 04131, 2020

      • reosarevok
        (since the validation is only negative, but there's no validation for a specific entity type over others)
      • 2020-02-10 04149, 2020

      • reosarevok
        (which is why I didn't originally add it, it didn't seem to do much)
      • 2020-02-10 04137, 2020

      • yvanzo
        ruaok: if I read it correctly, it does insert an intermediary PG queueing table in front of MQ exchange.
      • 2020-02-10 04128, 2020

      • ruaok
        ok, that makes sense now. have they tried it in a production env?
      • 2020-02-10 04139, 2020

      • yvanzo
        That might be even more reliable than the current method (I don’t know what pg_amqp is doing when MQ server is down), but will likely impact performances for us.
      • 2020-02-10 04151, 2020

      • yvanzo
        yes, IIRC, they use it already for mirroring
      • 2020-02-10 04111, 2020

      • yvanzo
        which is nice for a dedicated mirror, but not for us.
      • 2020-02-10 04124, 2020

      • ruaok
        maybe just wait and see how it goes for them and then we have an option if we need an alternative?
      • 2020-02-10 04135, 2020

      • zas
        ruaok: POST aren't excluded, but you only have few (top IP did only 25 POST, most only few) so they don't really appear
      • 2020-02-10 04139, 2020

      • yvanzo
        reosarevok: yes, I didn’t test anything here :)
      • 2020-02-10 04103, 2020

      • reosarevok
        yvanzo: is there a point adding [ 'artist', 'event', 'label', 'place', 'series' ] as a "validate it's allowed in general" option?
      • 2020-02-10 04114, 2020

      • ruaok
        zas: something is not adding up. there should be TONS of posts. maybe they are hitting the beta container?
      • 2020-02-10 04151, 2020

      • yvanzo
        reosarevok: I would say yes, you wouldn't want a bug in 'validate' to block every legitimate url either
      • 2020-02-10 04155, 2020

      • reosarevok
        Ok
      • 2020-02-10 04143, 2020

      • sumedh joined the channel
      • 2020-02-10 04134, 2020

      • abhishekpanwar has quit
      • 2020-02-10 04156, 2020

      • yvanzo
        ruaok: thanks, replied.
      • 2020-02-10 04116, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #721 (master…dependabot/pip/flask-admin-1.5.5): Bump flask-admin from 1.5.4 to 1.5.5 https://github.com/metabrainz/listenbrainz-server…
      • 2020-02-10 04141, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #722 (master…dependabot/pip/pyspark-2.4.5): Bump pyspark from 2.4.4 to 2.4.5 https://github.com/metabrainz/listenbrainz-server…
      • 2020-02-10 04101, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #723 (master…dependabot/pip/sphinx-2.4.0): Bump sphinx from 2.3.1 to 2.4.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-02-10 04122, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #724 (master…dependabot/pip/flask-wtf-0.14.3): Bump flask-wtf from 0.14.2 to 0.14.3 https://github.com/metabrainz/listenbrainz-server…
      • 2020-02-10 04146, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #725 (master…dependabot/pip/flask-login-0.5.0): Bump flask-login from 0.4.1 to 0.5.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-02-10 04113, 2020

      • Shoaib_ joined the channel
      • 2020-02-10 04107, 2020

      • sumedh has quit
      • 2020-02-10 04103, 2020

      • D4RK-PH0ENiX has quit
      • 2020-02-10 04145, 2020

      • sumedh joined the channel
      • 2020-02-10 04124, 2020

      • Gore joined the channel
      • 2020-02-10 04105, 2020

      • shoaib joined the channel
      • 2020-02-10 04127, 2020

      • D4RK-PH0ENiX joined the channel