sarthak_jain: I have made a PR with front end part. You may proceed with the back end part now :)
2020-02-11 04216, 2020
bitmap
yvanzo: the jira github bot is cool <3
2020-02-11 04202, 2020
c1e0_ has quit
2020-02-11 04245, 2020
c1e0 joined the channel
2020-02-11 04225, 2020
djwhitey joined the channel
2020-02-11 04201, 2020
BrainzGit joined the channel
2020-02-11 04254, 2020
shivam-kapila
pristine__: I have updated the documentation PR too. Kindly take a look when you are free.
2020-02-11 04259, 2020
sampsyo has quit
2020-02-11 04247, 2020
sampsyo joined the channel
2020-02-11 04214, 2020
Darkloke joined the channel
2020-02-11 04227, 2020
sumedh has quit
2020-02-11 04213, 2020
sumedh joined the channel
2020-02-11 04211, 2020
sarthak_jain joined the channel
2020-02-11 04223, 2020
sarthak_jain
Hey shivam-kapila
2020-02-11 04256, 2020
sarthak_jain
The build aint passing for the changes you made. Can you please check and then re-commit. When the build passes, I will commit the backend part !
2020-02-11 04249, 2020
shivam-kapila
The build aint passing because `delete_listens_history` function doesn't exist. This function is to be added as in `user.py` file which constitutes the backend task. Once you make this function build will definitely pass. I tried it with a dummy function.
shivam-kapila: Whenever you push commits please resolve conversations which have been addressed and leave the ones which need more discussion. Can you do that for *update doc PR*? Almost all the comments are unresolved which gives me a reflection that I should answer all, but when I see them I realise most of them have been answered :(
2020-02-11 04220, 2020
shivam-kapila
pristine__: Oh sorry! I forgot to do that. Only 1-2 are unresolved.
2020-02-11 04245, 2020
pristine__
shivam-kapila: no hurry. do it when you get the time.
Congrats to all the winners, runners up and finalists
2020-02-11 04248, 2020
CODEin_JDB
I just want to say thank you to everyone who supported me in my code in journey.
2020-02-11 04216, 2020
c1e0_ joined the channel
2020-02-11 04244, 2020
CODEin_JDB
For the mentors for guiding me in every task. and to the students who shared their experiences with me.
2020-02-11 04246, 2020
c1e0 has quit
2020-02-11 04230, 2020
CODEin_JDB
it has been a really great journey so thanks again for that.
2020-02-11 04221, 2020
c1e0_ is now known as c1e0
2020-02-11 04251, 2020
CODEin_JDB
i hope to work with you next year as well.
2020-02-11 04257, 2020
CODEin_JDB
Good Bye!
2020-02-11 04204, 2020
CODEin_JDB has quit
2020-02-11 04234, 2020
Etua has quit
2020-02-11 04226, 2020
sumedh joined the channel
2020-02-11 04251, 2020
Etua joined the channel
2020-02-11 04258, 2020
outsidecontext
I love the helpful Github Bot on JIRA :) was this freshly setup?
2020-02-11 04216, 2020
reosarevok
Yes, thank yvanzo I think
2020-02-11 04237, 2020
iliekcomputers
what github bot
2020-02-11 04205, 2020
c1e0 has quit
2020-02-11 04208, 2020
c1e0 joined the channel
2020-02-11 04223, 2020
yvanzo
yup, I just mentionned it yesterday but set it up last Friday.
2020-02-11 04224, 2020
c1e0_ joined the channel
2020-02-11 04204, 2020
c1e0 has quit
2020-02-11 04204, 2020
ruaok
zas: let's look at this LB load stuff.
2020-02-11 04218, 2020
ruaok
when looking at back-end logs on lemmy, there are plenty of requests:
2020-02-11 04222, 2020
ruaok
... [Tue Feb 11 14:57:31 2020] POST /1/submit-listens => generated 16 bytes in 22 msecs (HTTP/2.0 200) 11 headers in 455 bytes (1 switches on core 0) ...
2020-02-11 04235, 2020
ruaok
> docker logs --tail=1 -f listenbrainz-web-prod
2020-02-11 04242, 2020
ruaok
to see those -- on lemmy
2020-02-11 04208, 2020
zas
that's web traffic, but alerts are about rabbitmq queues, how does the app queue stuff? it would be interesting to check traffic incoming to rabbitmq as well
2020-02-11 04252, 2020
ruaok
the -web-prod container sanity checks the data, then inserts it into the incoming rabbit mq queue.
2020-02-11 04213, 2020
ruaok
so, those submit commands translate directly into rabbitmq traffic.
2020-02-11 04233, 2020
ruaok
and I see some IPs that have been submitting data every second from... russia.
2020-02-11 04246, 2020
ruaok
and none of this data ever makes it past the deduplication step.
2020-02-11 04207, 2020
ruaok
if it did, we would see that data get passed onto the unique rabbit mq queue.
2020-02-11 04228, 2020
ruaok
so, the first question is: why are these posts not showing up in the tops reports?
2020-02-11 04233, 2020
zas
I don't know miuch about LB stuff, one single web request can store a lot of stuff at once, right?
2020-02-11 04208, 2020
ruaok
yes
2020-02-11 04229, 2020
ruaok
but, I think, that 1 request -> 1 rabbitmq packet.
2020-02-11 04258, 2020
zas
I could capture traffic at ethernet level, and analyze using wireshark
2020-02-11 04201, 2020
ruaok
let see why tops is not working. that is the first line report I want to see.
2020-02-11 04208, 2020
ruaok
because I think we need to block some IPs.
2020-02-11 04246, 2020
ruaok
and client IDs are in the Authorization headers -- if we can see which client IDs are high submitters, we can examine the accounts or revoke the IDs.
2020-02-11 04202, 2020
ruaok
so, I would *really* like to make the top reports work.
2020-02-11 04201, 2020
zas
first, ensure everything we need is logged on kiki
2020-02-11 04226, 2020
ruaok
k, lemme look there.
2020-02-11 04220, 2020
ruaok
remind me, where are log files stored on kiki?
2020-02-11 04224, 2020
ruaok
I can never remember.
2020-02-11 04252, 2020
sarthak_jain joined the channel
2020-02-11 04200, 2020
sarthak_jain
Hi pristine__
2020-02-11 04241, 2020
sarthak_jain
Meanwhile you review the PR, any other issue to work on, as I dont have much on my plate rn.
2020-02-11 04235, 2020
zas
in /var/docker-logs/openresty-gateways/nginx
2020-02-11 04243, 2020
zas
btw, I found something weird
2020-02-11 04248, 2020
zas
traffic between kiki and lemmy (on lb container port) is much lower than traffic between lemmy and trille, is there any other container writing to rabbitmq?
2020-02-11 04221, 2020
pristine__
sarthak_jain: weren't you working on #702?
2020-02-11 04230, 2020
ruaok
zas: trille? is there something special about trille?
2020-02-11 04249, 2020
zas
it hosts rabbitmq
2020-02-11 04250, 2020
sarthak_jain
Yes, I am.
2020-02-11 04256, 2020
ruaok
ah.
2020-02-11 04236, 2020
ruaok
yes, lemmy does all sorts of writing and reading from rabbitmq, so I would expect that traffic to be higher.
2020-02-11 04243, 2020
sarthak_jain
But shivam-kapila and I are both done with our parts, we're just looking forward on how to commit my backend part on his PR !
2020-02-11 04259, 2020
sarthak_jain
Meanwhile, I am open to new issues, if you've one for me !
2020-02-11 04259, 2020
ruaok
for every inbound request, there will be 3+ round trips to trille.
2020-02-11 04222, 2020
ruaok
doh.
2020-02-11 04231, 2020
ruaok
the container traffic is split. I see now.
2020-02-11 04252, 2020
c1e0_ has quit
2020-02-11 04200, 2020
ruaok
zas: can you please deploy the top stats on api.listenbrainz-web.access.log ?
2020-02-11 04229, 2020
ruaok
that is what we were missing. for some reason I remembed it being a separate container, but its a separate entry on the gateway pointing to the same container.
2020-02-11 04250, 2020
sarthak_jain5 joined the channel
2020-02-11 04222, 2020
zas
ok, let me see
2020-02-11 04224, 2020
sarthak_jain5
pristine__, will you be reviewing #719 today?
2020-02-11 04226, 2020
sarthak_jain has quit
2020-02-11 04216, 2020
shivam-kapila
sarthak_jain5: did you try making a PR onto my code? Or I will have to add you as contributor to my repo.
