#metabrainz

/

      • alastairp
        ruaok: hi, what's the listebrainz odyssey url?
      • 2020-02-11 04259, 2020

      • shivam-kapila
        sarthak_jain5: It will work. But it will make your tasks difficult in future. Wait lemme see PR on PR stuff once.
      • 2020-02-11 04213, 2020

      • ruaok
        I turned that off. it was just wasting our credits.
      • 2020-02-11 04219, 2020

      • ruaok
        alastairp: ^^
      • 2020-02-11 04227, 2020

      • alastairp
        yeah, I see it's down. thanks
      • 2020-02-11 04237, 2020

      • sarthak_jain5
        For PR on PR stuff, I have to clone your fork, set up the environment again and then commit !
      • 2020-02-11 04237, 2020

      • alastairp
        just trying to remember the url schema for similarity.ab.org
      • 2020-02-11 04238, 2020

      • ruaok
        but once I pick that back up, I will deploy it to the the machine that you already use.
      • 2020-02-11 04250, 2020

      • shivam-kapila
        sarthak_jain5: So you working on your fork currently?
      • 2020-02-11 04250, 2020

      • shivam-kapila
        Even if I add you collaborator it will require you to do `git pull` first. Hence both will be equal
      • 2020-02-11 04238, 2020

      • sarthak_jain5
        If you add me as a contributor, I'll directly edit the file `user.py` on the top of your PR.
      • 2020-02-11 04209, 2020

      • shivam-kapila
        Ok I will add you collaborator. Wait a sec.
      • 2020-02-11 04231, 2020

      • pristine__
        sarthak_jain5: I am glad that you are contributing to lab. We will not have a Labs specific project in GSOC this year but you can continue contributing :)
      • 2020-02-11 04238, 2020

      • shivam-kapila
        I have added collaborator to my fork.
      • 2020-02-11 04251, 2020

      • shivam-kapila
        sarthak_jain5: ^^
      • 2020-02-11 04211, 2020

      • pristine__
        We will have ListenBrainz projects in GSOC though :)
      • 2020-02-11 04229, 2020

      • pristine__
      • 2020-02-11 04245, 2020

      • sarthak_jain5
        Yaa sure. Labs is a part of Listenbrainz project, right?
      • 2020-02-11 04242, 2020

      • pristine__
        Yes.
      • 2020-02-11 04204, 2020

      • aJens joined the channel
      • 2020-02-11 04258, 2020

      • BrainzGit
        [guidelines] yvanzo opened pull request #13 (master…github-to-jira): Update GitHub & Jira guidelines with the new GitHub Bot’s automation rule in Jira https://github.com/metabrainz/guidelines/pull/13
      • 2020-02-11 04208, 2020

      • ruaok
        iliekcomputers: sanity check me on this, please... to try and debug the issue with the rabbitmq listens piling up, I wonder if we could write another python script that connects to rabbitmq and also listens to the stream of listens, and then for each packet received, it writes the user ID to stdout.
      • 2020-02-11 04226, 2020

      • ruaok
        that way we would get a stream of user IDs and could immediately see who is causing the traffic.
      • 2020-02-11 04212, 2020

      • iliekcomputers
        Sounds reasonable to me.
      • 2020-02-11 04256, 2020

      • ruaok
        ok, I'll try that in a minute.
      • 2020-02-11 04258, 2020

      • iliekcomputers
        Maybe more structured data like how many times we've seen the user in the last X minutes
      • 2020-02-11 04208, 2020

      • iliekcomputers
        So that it's easier to grok
      • 2020-02-11 04234, 2020

      • iliekcomputers
        Not sure if that's needed here though given that we have big spikes
      • 2020-02-11 04214, 2020

      • sumedh has quit
      • 2020-02-11 04243, 2020

      • aJens has quit
      • 2020-02-11 04200, 2020

      • ruaok
        yeah, I figured I'd start simple and work up from there.
      • 2020-02-11 04244, 2020

      • Etua has quit
      • 2020-02-11 04245, 2020

      • sarthak_jain5 has quit
      • 2020-02-11 04207, 2020

      • sampsyo has quit
      • 2020-02-11 04230, 2020

      • iliekcomputers
        Sgtm
      • 2020-02-11 04249, 2020

      • sampsyo joined the channel
      • 2020-02-11 04247, 2020

      • outsidecontext
        can someone with blog access look quickly over https://blog.metabrainz.org/?p=7864 ?
      • 2020-02-11 04235, 2020

      • yvanzo
        outsidecontext: can't be found
      • 2020-02-11 04237, 2020

      • yvanzo
        found RC post in drafts :)
      • 2020-02-11 04240, 2020

      • outsidecontext
        you need to be logged in, are you? it usually works when I share this with zas, not sure if there is a better way for sharing a preview of a post
      • 2020-02-11 04252, 2020

      • outsidecontext
        :)
      • 2020-02-11 04237, 2020

      • yvanzo
      • 2020-02-11 04208, 2020

      • yvanzo
        outsidecontext: just fixed a typo that came from a ticket's title, looks good!
      • 2020-02-11 04246, 2020

      • c1e0 joined the channel
      • 2020-02-11 04231, 2020

      • c1e0_ joined the channel
      • 2020-02-11 04218, 2020

      • c1e0 has quit
      • 2020-02-11 04253, 2020

      • c1e0 joined the channel
      • 2020-02-11 04214, 2020

      • c1e0_ has quit
      • 2020-02-11 04228, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1164 (master…MBS-4326): MBS-4326: Show DiscID edits in RG and artist history https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04230, 2020

      • BrainzBot
        MBS-4326: Add "Add discid" edits in release artist(s) editing history https://tickets.metabrainz.org/browse/MBS-4326
      • 2020-02-11 04219, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1373 (master…MBS-10620): MBS-10620: Add DAHR to the otherdbs whitelist https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04220, 2020

      • BrainzBot
        MBS-10620: Add the Discography of American Historical Recordings to the otherdbs whitelist https://tickets.metabrainz.org/browse/MBS-10620
      • 2020-02-11 04202, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1376 (beta…mbs-10622-10627): Fix MBS-10622, MBS-10627, MBS-10630 (regressions from MBS-7678) https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04204, 2020

      • BrainzBot
        MBS-10622: Beta: grouped relationships with open edits are only highlighted if all types are affected https://tickets.metabrainz.org/browse/MBS-10622
      • 2020-02-11 04204, 2020

      • BrainzBot
        MBS-10627: Beta: grouped relationships with less specific duplicates are harder to detect https://tickets.metabrainz.org/browse/MBS-10627
      • 2020-02-11 04204, 2020

      • BrainzBot
        MBS-10630: Beta: Link orders of 0 (meaning no ordering) are displayed https://tickets.metabrainz.org/browse/MBS-10630
      • 2020-02-11 04204, 2020

      • BrainzBot
        MBS-7678: Combine display of multiple relationships to the same entity https://tickets.metabrainz.org/browse/MBS-7678
      • 2020-02-11 04235, 2020

      • reosarevok
        yvanzo: does my small paragraph help? https://tickets.metabrainz.org/browse/MBS-10223
      • 2020-02-11 04235, 2020

      • BrainzBot
        MBS-10223: ArtistRoles lists don't use relationship credits
      • 2020-02-11 04243, 2020

      • reosarevok
        I can take screenshots if not I guess
      • 2020-02-11 04230, 2020

      • reosarevok
        yvanzo: what do you think about https://github.com/metabrainz/musicbrainz-server/… ? (I made the changes to avoid the max-len warnings, but you might have the opinion that it's better to do old-school multilines with +)
      • 2020-02-11 04229, 2020

      • Laverne has quit
      • 2020-02-11 04220, 2020

      • Laverne joined the channel
      • 2020-02-11 04221, 2020

      • yvanzo
        reosarevok: yes, or old-school "foo\
      • 2020-02-11 04223, 2020

      • yvanzo
        bar"
      • 2020-02-11 04207, 2020

      • yvanzo
        honestly, it seems to be all the same to me.
      • 2020-02-11 04232, 2020

      • reosarevok
        Yes to change it, or yes to keep as-is ? :p
      • 2020-02-11 04205, 2020

      • yvanzo
        Hmm... :)
      • 2020-02-11 04200, 2020

      • yvanzo
        Yes it seems fine as-is (since there is no breakage), and yes it would probably be better to test with plausible data only.
      • 2020-02-11 04231, 2020

      • yvanzo
        reosarevok: thanks for the small paragraph but I still fail at finding an example, even using linked work from the IRC log.
      • 2020-02-11 04255, 2020

      • bitmap
      • 2020-02-11 04237, 2020

      • bitmap
        it shows "Anodajay (lyricist)" for 7 chanceux, but as can be seen on https://beta.musicbrainz.org/work/49e21c1f-a27e-4… it's credited as Steve Jolin
      • 2020-02-11 04252, 2020

      • yvanzo
        as lyricist okay, thank you!
      • 2020-02-11 04250, 2020

      • yvanzo
        I kept focusing on "Anodajay" being credited for the recording. ^^
      • 2020-02-11 04233, 2020

      • outsidecontext
        yvanzo: thanks for checking the blog post
      • 2020-02-11 04233, 2020

      • outsidecontext
      • 2020-02-11 04248, 2020

      • yvanzo
        you're very welcome, thanks for the rc
      • 2020-02-11 04213, 2020

      • yvanzo
        bitmap, reosarevok: would a last merge of master with beta work for you?
      • 2020-02-11 04229, 2020

      • reosarevok
        Give me a few mins, but then yes
      • 2020-02-11 04244, 2020

      • bitmap
        +1
      • 2020-02-11 04258, 2020

      • reosarevok
        (want to change the backticks to + multilines)
      • 2020-02-11 04237, 2020

      • reosarevok
        So this should be better, right?
      • 2020-02-11 04256, 2020

      • reosarevok
      • 2020-02-11 04212, 2020

      • reosarevok
        Argh. stupid irccloud. Well, aligned under the other quote marks :P
      • 2020-02-11 04258, 2020

      • bitmap
        better as in "removes the spaces" yes :) whichever you prefer
      • 2020-02-11 04213, 2020

      • reosarevok
        Well, that means we test with the real titles it'd be expected to see "in the wild"
      • 2020-02-11 04203, 2020

      • rdswift
        !m outsidecontext and zas on the Picard release!
      • 2020-02-11 04203, 2020

      • BrainzBot
        You're doing good work, outsidecontext and zas on the Picard release!!
      • 2020-02-11 04244, 2020

      • reosarevok
        yvanzo: if you have the time, I think https://github.com/metabrainz/musicbrainz-server/… should be trivial to review commit-by-commit
      • 2020-02-11 04247, 2020

      • reosarevok
        As in, two minutes trivial
      • 2020-02-11 04259, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1101 (master…MBS-10223): MBS-10223: Use relationship credits in ArtistRoles https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04200, 2020

      • BrainzBot
        MBS-10223: ArtistRoles lists don't use relationship credits https://tickets.metabrainz.org/browse/MBS-10223
      • 2020-02-11 04257, 2020

      • reosarevok
        yvanzo, bitmap: also, can we merge https://github.com/metabrainz/musicbrainz-server/… and make a "figure out how to make this safer" ticket? :p
      • 2020-02-11 04208, 2020

      • reosarevok
        Because if we wait until we figure it out we won't merge it at all
      • 2020-02-11 04246, 2020

      • bitmap
        well, I did approve it
      • 2020-02-11 04225, 2020

      • bitmap
        but yes, showing raw html to the user for another release doesn't seem nice
      • 2020-02-11 04256, 2020

      • yvanzo
        yup, I will create a ticket for the long-term issue
      • 2020-02-11 04216, 2020

      • reosarevok
        Thanks!
      • 2020-02-11 04211, 2020

      • c1e0 has quit
      • 2020-02-11 04210, 2020

      • yvanzo
        !m reosarevok with sliced commits
      • 2020-02-11 04210, 2020

      • BrainzBot
        You're doing good work, reosarevok with sliced commits!
      • 2020-02-11 04229, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1361 (master…MBS-10576): Fix MBS-10576: Support errors with HTML https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04230, 2020

      • BrainzBot
        MBS-10576: Medium merge error messages with links are not properly formatted https://tickets.metabrainz.org/browse/MBS-10576
      • 2020-02-11 04224, 2020

      • reosarevok
        yvanzo: https://github.com/metabrainz/musicbrainz-server/… is very small and is bug-fixes, if you want :P
      • 2020-02-11 04201, 2020

      • reosarevok is waiting for the selenium tests for https://github.com/metabrainz/musicbrainz-server/pull/1192 to re-re-re-run to make sure it passes
      • 2020-02-11 04247, 2020

      • yvanzo
        don't wait too long for selenium tests if it is not consistently twice failing the same way
      • 2020-02-11 04256, 2020

      • reosarevok
        yvanzo: so is it ok to merge https://github.com/metabrainz/musicbrainz-server/… despite the comment, since you approved, or would you rather I added a comment inside or something?
      • 2020-02-11 04230, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1192 (master…guessFeat-eslint): Eslint fixes for guessFeat https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04213, 2020

      • yvanzo
        reosarevok: yes it is ok, that was mostly personal preference but it would be more pain to work around eslint here.
      • 2020-02-11 04218, 2020

      • reosarevok
        Ok
      • 2020-02-11 04234, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1268 (master…eslint-fix-by-rule-pt-1): Eslint fixes by rule, pt. 1 https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04253, 2020

      • reosarevok
      • 2020-02-11 04256, 2020

      • reosarevok
        14 closed isn't too bad
      • 2020-02-11 04217, 2020

      • yvanzo
        we crossed 50%, not sure that was too frequent lately
      • 2020-02-11 04237, 2020

      • SothoTalKer
        outsidecontext: i have picard set to check for stable, beta and dev releases, but the release candidate is not displayed when checking for updates :-)
      • 2020-02-11 04231, 2020

      • outsidecontext
        SothoTalKer: yea, I just fixed that thing. The released versions are unfortunately too stupid to detect the rc1 as being newer to the beta1 :( so it works for the users still on 2.2.x but for the ones having the 2.3 beta already
      • 2020-02-11 04241, 2020

      • SothoTalKer
        well, if its known already and (will) fixed then its all good :)
      • 2020-02-11 04243, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1366 (master…MBS-10586): Fix MBS-10586 / MBS-10587 / MBS-10588: Release Duplicates medium format fixes https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04245, 2020

      • BrainzBot
        MBS-10586: Release duplicates tab shows [missing media] when medium format is simply unknown https://tickets.metabrainz.org/browse/MBS-10586
      • 2020-02-11 04245, 2020

      • BrainzBot
        MBS-10587: Medium counts broken in Release Duplicates list https://tickets.metabrainz.org/browse/MBS-10587
      • 2020-02-11 04245, 2020

      • BrainzBot
        MBS-10588: Medium formats untranslated in Release Duplicates list https://tickets.metabrainz.org/browse/MBS-10588
      • 2020-02-11 04206, 2020

      • reosarevok
      • 2020-02-11 04207, 2020

      • BrainzBot
        MBS-10633: Can't change capitalization on username
      • 2020-02-11 04222, 2020

      • reosarevok
        (also, thanks, yvanzo. 15 PRs seems like a good number!)
      • 2020-02-11 04252, 2020

      • reosarevok
        It's so late now that I probably don't have time to do the release myself though :/
      • 2020-02-11 04208, 2020

      • reosarevok
        bitmap: I'm sure you'd love to do it and update syswiki for the new method while you do? :p
      • 2020-02-11 04227, 2020

      • yvanzo
        15 should be our lucky number
      • 2020-02-11 04234, 2020

      • yvanzo
        bitmap: I can update beta if you want to, but I cannot test this won't fail on your system: https://github.com/metabrainz/docker-server-confi…
      • 2020-02-11 04212, 2020

      • yvanzo
        ’night reosarevok!
      • 2020-02-11 04256, 2020

      • bitmap
        ah but I already have all the servers configured & don't want to overwrite all the LocalForward settings I have
      • 2020-02-11 04238, 2020

      • bitmap
        the config there looks fine otherwise though I'd remove ForwardAgent no from mine since I use agent forwarding a lot to be able to pull from private git repos
      • 2020-02-11 04235, 2020

      • Etua joined the channel
      • 2020-02-11 04231, 2020

      • bitmap
        (so I'd say just merge it since you're not going to be able to output a config that pleases everyone)
      • 2020-02-11 04225, 2020

      • yvanzo
        It doesn’t overwrite anything, it prints it to stdout.
      • 2020-02-11 04244, 2020

      • bitmap
        I know
      • 2020-02-11 04239, 2020

      • yvanzo
        Cool :)
      • 2020-02-11 04206, 2020

      • bitmap
        I mean I could test it with -F but I wouldn't end up using it :P
      • 2020-02-11 04248, 2020

      • bitmap
        since I'd have to add back all my LocalForward settings, remove the LocalForward stuff, then merge it back into my main ssh config
      • 2020-02-11 04218, 2020

      • bitmap
        which has a bunch of meb and non-meb servers mixed together
      • 2020-02-11 04245, 2020

      • bitmap
        *ForwardAgent stuff
      • 2020-02-11 04220, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo opened pull request #1378 (master…mbs-10623-us-itunes): MBS-10623: Auto-add US iTunes store country-code https://github.com/metabrainz/musicbrainz-server/…
      • 2020-02-11 04220, 2020

      • BrainzBot
        MBS-10623: Automatically add US store country-code to iTunes URLs missing it https://tickets.metabrainz.org/browse/MBS-10623
      • 2020-02-11 04221, 2020

      • yvanzo
        bitmap: besides there might never be a new developer using macOs needing this :P
      • 2020-02-11 04236, 2020

      • reosarevok
        yvanzo, bitmap: wanna merge https://github.com/metabrainz/musicbrainz-server/… too before release? :p
      • 2020-02-11 04247, 2020

      • reosarevok is still finishing getting ready for bed
      • 2020-02-11 04222, 2020

      • bitmap
        yvanzo: sad but true
      • 2020-02-11 04230, 2020

      • bitmap
        or probably just true
      • 2020-02-11 04219, 2020

      • bitmap
        approved that ^
      • 2020-02-11 04251, 2020

      • yvanzo
        (waiting for js ci at least)
      • 2020-02-11 04228, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #1378 (master…mbs-10623-us-itunes): MBS-10623: Auto-add US iTunes store country-code https://github.com/metabrainz/musicbrainz-server/…