iliekcomputers: Finally pushed the test. The rebase was stuck as I had some commit in the branch locally that was causing conflict. Sorry for the fuss
2020-02-21 05221, 2020
iliekcomputers
shivam-kapila: already reviewed
2020-02-21 05241, 2020
iliekcomputers
lol
2020-02-21 05244, 2020
shivam-kapila
wow!
2020-02-21 05202, 2020
iliekcomputers
ruaok: did you see the warnings in sentry š¤£
2020-02-21 05203, 2020
iliekcomputers
ouch
2020-02-21 05254, 2020
iliekcomputers
well, at least it works
2020-02-21 05200, 2020
iliekcomputers
for some definition of works
2020-02-21 05205, 2020
ruaok
I didn't look. what happened?
2020-02-21 05218, 2020
shivam-kapila
iliekcomputers: How can I test whether the listens are deleted or not. Any reference in already existing tests?
2020-02-21 05234, 2020
iliekcomputers
there's a log for when a file doesn't exist in hdfs and we try to load it. we don't have any listens for the years of 2005 - 2007 i think, and we try to load it all.
after this, you'd probably submit a POST to the endpoint you added
2020-02-21 05248, 2020
iliekcomputers
and then call the get_listens endpoint again, which should this time not return any listens
2020-02-21 05252, 2020
iliekcomputers
does that make sense?
2020-02-21 05216, 2020
shivam-kapila
yeah. thanks a lot :)
2020-02-21 05242, 2020
iliekcomputers
shivam-kapila: also, if you're adding something that is user-facing, it is very helpful if you post a video / gif / screenshot showing what you've changed
2020-02-21 05218, 2020
shivam-kapila
Sure. Locked in mind from now.
2020-02-21 05201, 2020
shivam-kapila
The check that listens were deleted successfully are to be added to both tesh.sh and integration-test.sh. Right?
shivam-kapila: did i ever follow up with you about the figma you made?
2020-02-21 05211, 2020
supersandro2000 has quit
2020-02-21 05224, 2020
supersandro2000 joined the channel
2020-02-21 05204, 2020
shivam-kapila
My fault here. I didnt discuss my status on it. Actually I am trying to remake the design using image based card view design. So as ruaok pointed out that there can be issues with loading so many images. So I am trying to optimise that. Also for the graph plotting I found http://recharts.org. But they dont have quite good docs so trying tweaking through that. I will finish that just after my exams.
2020-02-21 05213, 2020
iliekcomputers
question
2020-02-21 05224, 2020
iliekcomputers
can we do them one by one
2020-02-21 05258, 2020
shivam-kapila
You mean image loading?
2020-02-21 05215, 2020
iliekcomputers
like create a graph each in different react components, each on it's own page and then later add a dashboard
2020-02-21 05239, 2020
shivam-kapila
I guess yes.
2020-02-21 05205, 2020
shivam-kapila
Will try to separate the graph here and import it into the dashboard
