#metabrainz

but honestly a link to a general gpg tuto might be more appropriate

Will it be needed?

After importing the key, do I need to know anything else or will the script take care of all?

(not saying *I* couldn't use said tutorial, but this should be the bare minimum to release :) )

I mean if one cannot figure what to do about it, maybe it is worth having a better understanding of it first.

Plus, I don’t think we currently follow best practices.

That'd be nice and all to educate oneself, but if someone needs to do a one-off release because none of us can, that's not the time to go learn, but to follow simple instructions :)

Ok, made the requested changes, except the port # for now since bitmap seems to think the current one is fine

Do let me know how it looks now when you have some time! :)

yvanzo: also, somehow missed https://github.com/metabrainz/musicbrainz-serve... - sorry! approved and ready to merge now :)

reosarevok: I rather doubt allowing blind releases is ever wanted, and more important (again) we don’t most probably don’t follow best practices here.

It’s not about that doc, it’s more a general comment.

Well, then if we change that, we should update the docs to improve that

(and it would probably be nice to change that :D )

If I recall correctly there was a discussion here about that years ago.

Huh, wonder why I can add a recording named 🤷 locally but not on test

Project bookbrainz-site build #2691: passed in 2 min 16 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

I'm running the same code on both

So I assume the difference must be at the DB level, but I seem to have the constraint that is failing also locally

Wonder if emoji support has improved between 9.5 and the latest I'm running locally

I think 10. introduced better collation

https://www.2ndquadrant.com/en/blog/icu-support... mentions sorting emojis, I guess it also makes them not be returned when looking for the empty string

What was our plan for updating PSQL again?

12.x? I suspect that might fix MBS-9728 then!

MBS-9728: Edit ISE's on beta when using emoji https://tickets.metabrainz.org/browse/MBS-9728

yvanzo, bitmap: when do we start running tests for that? Maybe we could already make that transition to 12.x in test?

reosarevok: PG 12 can be tested using musicbrainz-docker already.

I would like to avoid another MB setup locally, since I don't have the space :(

yvanzo: do you have it running?

mb-docker, yes, since months

Ok, can you test it there then?

and it is supposed to become the default setup for new contributors.

Just try to add an artist or recording with name 🤷

I don’t run PG 12 though.

Oh

Do you run 9.5 still, or 10+?

PG 9.5 still

I think I used PG 10+ only once to test the docker env itself.

[15:27] <zas> ruaok: gaga is now ready

:O

I guess I can try to set it up locally on a secondary partition or something then

[17:12] <reosarevok> yvanzo, bitmap: when do we start running tests for that? Maybe we could already make that transition to 12.x in test?

please!!

CatQuest: that would only help for testing emojis though pretty much :D

yvanzo: wait, is test running musicbrainz-docker too? Could we just change POSTGRES_VERSION there?

but like, it's 2020. not beeing able to have recordings with meoji's is..

emojis

reosarevok: no it is running the same images as production and beta (musicbrainz-website, ...) but built on test branch.

Oh, ok

only the docker/consul config differs

Let's install this locally for testing then

For POSTGRES_VERSION, do I change it in docker-compose.yml ?

And will that automatically get and install 12.x?

Oh, Dockerfile too I guess

[musicbrainz-docker] reosarevok opened pull request #124 (master…patch-1): Fix typo https://github.com/metabrainz/musicbrainz-docke...

reosarevok: I was just mentioning musicbrainz-docker as a way to test PG 12 locally first, because it is easier to use than the consul stuff that is needed by containers running test.

Sure, gotcha

But yes we should move test.mb.o to PG 12 at some point.

by the way, you can probably use musicbrainz-docker to run a local PG 12 instance using your current MBS instance, you don’t need to build other services.

(that still requires to load sample data into it)

(without having to mess your current PG 9.5 instance)

so what kind of auth headers does listen brainz use ?

for the data ingester submit-listens endpoint i am writing a auth method

yvanzo: so I cloned musicbrainz-docker into my secondary partition, but it seems to still be actually doing docker-compose and creating all the stuff in the main one

Do you know how to change that?

(I keep running out of space...)

(I have a second partition on a slower disc with 300+GB, but it doesn't seem to use it despite being cloned into it)

ah nvm,i found the development docs for listenbrainz

Sigh, getting all sorts of errors

reosarveok how to do third person msgs on this channel ?

Do you mean direct messages? /query username usually works

no like the one you sent above

with self tags

Oh

That's /me

oh thanks reosarevok

haha, np

m! reosarevok

!m I think :p

You're doing good work, I think :p!

... yeah :D

!m reosarevok

You're doing good work, reosarevok!

why do we not have !s ?

!s

!s reosarevok

You're a slacker, reosarevok!

But I do a stellar job of it

!m slacker reosarevok

You're doing good work, slacker reosarevok!

ruaok to verify do i ping GET /1/validate-token and be done with it or or do i write my own func to access the database and verify the token with this new ingester

is there a preference that the mentor's or you'd like me to follow

Pac23: at this point I want you to read the code in detail -- you should be able to answer these questions yourself.

remember, at this point I am evaluating how well you can work independently.

ah yes,i may have forgotten that part :p i did see this https://github.com/metabrainz/listenbrainz-serv... i only asked because things change people change preferences change,all the what if questions.

i'll try not to ask such questions anymore, :)

reosarevok: you need to specify 'db' otherwise it builds and runs everything: sudo docker-compose up -d db

Turns out after restarting my laptop couldn't even open X because it was too full, had to drop to console only to remove the docker containers etc

And in the meantime it lost all my hundred plus Chrome tabs, including all the tickets I had open to check

Fun :D

(no)

Honestly, every time I try to do anything with docker it becomes a problem...

Project bookbrainz-site build #2692: passed in 2 min 13 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

Also, wow. Apparently some fanboys for this artist are coordinating on Twitter to rate them 5 stars (multiple times per person, creating extra accounts for it): https://musicbrainz.org/artist/9252ca18-015c-48...

Not sure if we should do anything about it...

like making emails mandatory for new users?

https://musicbrainz.org/user/atinsheyxsb19forev... https://musicbrainz.org/user/atinsheyxsb19forev... https://musicbrainz.org/user/atinsheyxsb19forev...

Huh, I didn't realize they could rate without an email

(they can't edit, after all)

Probably should block that, yes!

dunno what to do, but it seems far too easy

[bookbrainz-site] MonkeyDo opened pull request #382 (master…default-alias-selection): Default alias selection https://github.com/bookbrainz/bookbrainz-site/p...

Yeah, seems it's not blocked

sigh

Ok

[musicbrainz-server] reosarevok opened pull request #1404 (master…MBS-10671): MBS-10671: Block ratings for unverified users https://github.com/metabrainz/musicbrainz-serve...

MBS-10671: Block ratings for unverified users https://tickets.metabrainz.org/browse/MBS-10671

First draft ^ (bitmap, yvanzo: does it seem sensible?)

zas: new data imported, but the DB is catching up on its continous aggregate. I'll empty the pending rmq cache after dinner

reosarevok: also note the numbers of "tags" on that SB19 artist

reosarevok: PR looks good to me, is it a draft 'cause you were unsure about adding the ws changes?

Yes

[musicbrainz-server] yvanzo merged pull request #1383 (master…fix-editor-warning): Fix noisy warning about editor’s gravatar: uninitialized value in lc https://github.com/metabrainz/musicbrainz-serve...