#metabrainz

/

      • yvanzo
        but honestly a link to a general gpg tuto might be more appropriate
      • 2020-03-03 06312, 2020

      • reosarevok
        Will it be needed?
      • 2020-03-03 06331, 2020

      • reosarevok
        After importing the key, do I need to know anything else or will the script take care of all?
      • 2020-03-03 06354, 2020

      • reosarevok
        (not saying *I* couldn't use said tutorial, but this should be the bare minimum to release :) )
      • 2020-03-03 06301, 2020

      • yvanzo
        I mean if one cannot figure what to do about it, maybe it is worth having a better understanding of it first.
      • 2020-03-03 06342, 2020

      • yvanzo
        Plus, I don’t think we currently follow best practices.
      • 2020-03-03 06312, 2020

      • reosarevok
        That'd be nice and all to educate oneself, but if someone needs to do a one-off release because none of us can, that's not the time to go learn, but to follow simple instructions :)
      • 2020-03-03 06315, 2020

      • reosarevok
        Ok, made the requested changes, except the port # for now since bitmap seems to think the current one is fine
      • 2020-03-03 06324, 2020

      • reosarevok
        Do let me know how it looks now when you have some time! :)
      • 2020-03-03 06321, 2020

      • reosarevok
        yvanzo: also, somehow missed https://github.com/metabrainz/musicbrainz-server/… - sorry! approved and ready to merge now :)
      • 2020-03-03 06333, 2020

      • sumedh has quit
      • 2020-03-03 06347, 2020

      • yvanzo
        reosarevok: I rather doubt allowing blind releases is ever wanted, and more important (again) we don’t most probably don’t follow best practices here.
      • 2020-03-03 06314, 2020

      • yvanzo
        It’s not about that doc, it’s more a general comment.
      • 2020-03-03 06315, 2020

      • reosarevok
        Well, then if we change that, we should update the docs to improve that
      • 2020-03-03 06334, 2020

      • reosarevok
        (and it would probably be nice to change that :D )
      • 2020-03-03 06314, 2020

      • yvanzo
        If I recall correctly there was a discussion here about that years ago.
      • 2020-03-03 06320, 2020

      • reosarevok
        Huh, wonder why I can add a recording named 🤷 locally but not on test
      • 2020-03-03 06326, 2020

      • kori has quit
      • 2020-03-03 06336, 2020

      • travis-ci joined the channel
      • 2020-03-03 06336, 2020

      • travis-ci
        Project bookbrainz-site build #2691: passed in 2 min 16 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-03-03 06336, 2020

      • travis-ci has left the channel
      • 2020-03-03 06331, 2020

      • c1e0 joined the channel
      • 2020-03-03 06345, 2020

      • reosarevok
        I'm running the same code on both
      • 2020-03-03 06302, 2020

      • reosarevok
        So I assume the difference must be at the DB level, but I seem to have the constraint that is failing also locally
      • 2020-03-03 06347, 2020

      • reosarevok
        Wonder if emoji support has improved between 9.5 and the latest I'm running locally
      • 2020-03-03 06328, 2020

      • reosarevok
        I think 10. introduced better collation
      • 2020-03-03 06319, 2020

      • reosarevok
        https://www.2ndquadrant.com/en/blog/icu-support-p… mentions sorting emojis, I guess it also makes them not be returned when looking for the empty string
      • 2020-03-03 06327, 2020

      • reosarevok
        What was our plan for updating PSQL again?
      • 2020-03-03 06305, 2020

      • reosarevok
        12.x? I suspect that might fix MBS-9728 then!
      • 2020-03-03 06306, 2020

      • BrainzBot
        MBS-9728: Edit ISE's on beta when using emoji https://tickets.metabrainz.org/browse/MBS-9728
      • 2020-03-03 06333, 2020

      • reosarevok
        yvanzo, bitmap: when do we start running tests for that? Maybe we could already make that transition to 12.x in test?
      • 2020-03-03 06316, 2020

      • yvanzo
        reosarevok: PG 12 can be tested using musicbrainz-docker already.
      • 2020-03-03 06339, 2020

      • reosarevok
        I would like to avoid another MB setup locally, since I don't have the space :(
      • 2020-03-03 06343, 2020

      • reosarevok
        yvanzo: do you have it running?
      • 2020-03-03 06311, 2020

      • yvanzo
        mb-docker, yes, since months
      • 2020-03-03 06313, 2020

      • reosarevok
        Ok, can you test it there then?
      • 2020-03-03 06316, 2020

      • yvanzo
        and it is supposed to become the default setup for new contributors.
      • 2020-03-03 06330, 2020

      • reosarevok
        Just try to add an artist or recording with name 🤷
      • 2020-03-03 06348, 2020

      • yvanzo
        I don’t run PG 12 though.
      • 2020-03-03 06350, 2020

      • reosarevok
        Oh
      • 2020-03-03 06306, 2020

      • reosarevok
        Do you run 9.5 still, or 10+?
      • 2020-03-03 06359, 2020

      • yvanzo
        PG 9.5 still
      • 2020-03-03 06336, 2020

      • yvanzo
        I think I used PG 10+ only once to test the docker env itself.
      • 2020-03-03 06303, 2020

      • CatQuest
        [15:27] <zas> ruaok: gaga is now ready
      • 2020-03-03 06303, 2020

      • CatQuest
        :O
      • 2020-03-03 06345, 2020

      • reosarevok
        I guess I can try to set it up locally on a secondary partition or something then
      • 2020-03-03 06310, 2020

      • CatQuest
        [17:12] <reosarevok> yvanzo, bitmap: when do we start running tests for that? Maybe we could already make that transition to 12.x in test?
      • 2020-03-03 06310, 2020

      • CatQuest
        please!!
      • 2020-03-03 06334, 2020

      • reosarevok
        CatQuest: that would only help for testing emojis though pretty much :D
      • 2020-03-03 06358, 2020

      • reosarevok
        yvanzo: wait, is test running musicbrainz-docker too? Could we just change POSTGRES_VERSION there?
      • 2020-03-03 06324, 2020

      • CatQuest
        but like, it's 2020. not beeing able to have recordings with meoji's is..
      • 2020-03-03 06333, 2020

      • CatQuest
        emojis
      • 2020-03-03 06342, 2020

      • yvanzo
        reosarevok: no it is running the same images as production and beta (musicbrainz-website, ...) but built on test branch.
      • 2020-03-03 06354, 2020

      • reosarevok
        Oh, ok
      • 2020-03-03 06326, 2020

      • yvanzo
        only the docker/consul config differs
      • 2020-03-03 06332, 2020

      • reosarevok
        Let's install this locally for testing then
      • 2020-03-03 06347, 2020

      • reosarevok
        For POSTGRES_VERSION, do I change it in docker-compose.yml ?
      • 2020-03-03 06357, 2020

      • reosarevok
        And will that automatically get and install 12.x?
      • 2020-03-03 06334, 2020

      • reosarevok
        Oh, Dockerfile too I guess
      • 2020-03-03 06333, 2020

      • BrainzGit
        [musicbrainz-docker] reosarevok opened pull request #124 (master…patch-1): Fix typo https://github.com/metabrainz/musicbrainz-docker/…
      • 2020-03-03 06302, 2020

      • eharris has quit
      • 2020-03-03 06307, 2020

      • eharris joined the channel
      • 2020-03-03 06343, 2020

      • yvanzo
        reosarevok: I was just mentioning musicbrainz-docker as a way to test PG 12 locally first, because it is easier to use than the consul stuff that is needed by containers running test.
      • 2020-03-03 06306, 2020

      • reosarevok
        Sure, gotcha
      • 2020-03-03 06311, 2020

      • yvanzo
        But yes we should move test.mb.o to PG 12 at some point.
      • 2020-03-03 06300, 2020

      • yvanzo
        by the way, you can probably use musicbrainz-docker to run a local PG 12 instance using your current MBS instance, you don’t need to build other services.
      • 2020-03-03 06333, 2020

      • yvanzo
        (that still requires to load sample data into it)
      • 2020-03-03 06302, 2020

      • yvanzo
        (without having to mess your current PG 9.5 instance)
      • 2020-03-03 06314, 2020

      • Pac23
        so what kind of auth headers does listen brainz use ?
      • 2020-03-03 06353, 2020

      • Pac23
        for the data ingester submit-listens endpoint i am writing a auth method
      • 2020-03-03 06324, 2020

      • Pac23
        *auth method rather used
      • 2020-03-03 06324, 2020

      • c1e0 has quit
      • 2020-03-03 06335, 2020

      • reosarevok
        yvanzo: so I cloned musicbrainz-docker into my secondary partition, but it seems to still be actually doing docker-compose and creating all the stuff in the main one
      • 2020-03-03 06340, 2020

      • reosarevok
        Do you know how to change that?
      • 2020-03-03 06315, 2020

      • reosarevok
        (I keep running out of space...)
      • 2020-03-03 06334, 2020

      • reosarevok
        (I have a second partition on a slower disc with 300+GB, but it doesn't seem to use it despite being cloned into it)
      • 2020-03-03 06337, 2020

      • Pac23
        ah nvm,i found the development docs for listenbrainz
      • 2020-03-03 06328, 2020

      • reosarevok
        Sigh, getting all sorts of errors
      • 2020-03-03 06345, 2020

      • reosarevok still doesn't understand how anyone can say docker is easier than normal setup
      • 2020-03-03 06318, 2020

      • Pac23
        reosarveok how to do third person msgs on this channel ?
      • 2020-03-03 06321, 2020

      • reosarevok
        Do you mean direct messages? /query username usually works
      • 2020-03-03 06333, 2020

      • Pac23
        no like the one you sent above
      • 2020-03-03 06336, 2020

      • Pac23
        with self tags
      • 2020-03-03 06336, 2020

      • reosarevok
        Oh
      • 2020-03-03 06339, 2020

      • reosarevok
        That's /me
      • 2020-03-03 06346, 2020

      • Pac23 test
      • 2020-03-03 06300, 2020

      • Pac23
        oh thanks reosarevok
      • 2020-03-03 06306, 2020

      • reosarevok
        haha, np
      • 2020-03-03 06313, 2020

      • Pac23
        m! reosarevok
      • 2020-03-03 06322, 2020

      • reosarevok
        !m I think :p
      • 2020-03-03 06322, 2020

      • BrainzBot
        You're doing good work, I think :p!
      • 2020-03-03 06328, 2020

      • reosarevok
        ... yeah :D
      • 2020-03-03 06320, 2020

      • Pac23
        !m reosarevok
      • 2020-03-03 06320, 2020

      • BrainzBot
        You're doing good work, reosarevok!
      • 2020-03-03 06339, 2020

      • ptitjano joined the channel
      • 2020-03-03 06330, 2020

      • ptitjano_ has quit
      • 2020-03-03 06312, 2020

      • ruaok
        why do we not have !s ?
      • 2020-03-03 06314, 2020

      • ruaok
        !s
      • 2020-03-03 06322, 2020

      • ruaok
        !s reosarevok
      • 2020-03-03 06329, 2020

      • ruaok
        You're a slacker, reosarevok!
      • 2020-03-03 06356, 2020

      • reosarevok
        But I do a stellar job of it
      • 2020-03-03 06317, 2020

      • ruaok
        !m slacker reosarevok
      • 2020-03-03 06317, 2020

      • BrainzBot
        You're doing good work, slacker reosarevok!
      • 2020-03-03 06354, 2020

      • Pac23
        ruaok to verify do i ping GET /1/validate-token and be done with it or or do i write my own func to access the database and verify the token with this new ingester
      • 2020-03-03 06333, 2020

      • Pac23
        is there a preference that the mentor's or you'd like me to follow
      • 2020-03-03 06348, 2020

      • ruaok
        Pac23: at this point I want you to read the code in detail -- you should be able to answer these questions yourself.
      • 2020-03-03 06310, 2020

      • ruaok
        remember, at this point I am evaluating how well you can work independently.
      • 2020-03-03 06332, 2020

      • Pac23
        ah yes,i may have forgotten that part :p i did see this https://github.com/metabrainz/listenbrainz-server… i only asked because things change people change preferences change,all the what if questions.
      • 2020-03-03 06319, 2020

      • Pac23
        i'll try not to ask such questions anymore, :)
      • 2020-03-03 06321, 2020

      • yvanzo
        reosarevok: you need to specify 'db' otherwise it builds and runs everything: sudo docker-compose up -d db
      • 2020-03-03 06353, 2020

      • mudcrow joined the channel
      • 2020-03-03 06325, 2020

      • reosarevok
        Turns out after restarting my laptop couldn't even open X because it was too full, had to drop to console only to remove the docker containers etc
      • 2020-03-03 06346, 2020

      • reosarevok
        And in the meantime it lost all my hundred plus Chrome tabs, including all the tickets I had open to check
      • 2020-03-03 06347, 2020

      • reosarevok
        Fun :D
      • 2020-03-03 06349, 2020

      • reosarevok
        (no)
      • 2020-03-03 06308, 2020

      • reosarevok
        Honestly, every time I try to do anything with docker it becomes a problem...
      • 2020-03-03 06329, 2020

      • travis-ci joined the channel
      • 2020-03-03 06329, 2020

      • travis-ci
        Project bookbrainz-site build #2692: passed in 2 min 13 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-03-03 06329, 2020

      • travis-ci has left the channel
      • 2020-03-03 06321, 2020

      • reosarevok
        Also, wow. Apparently some fanboys for this artist are coordinating on Twitter to rate them 5 stars (multiple times per person, creating extra accounts for it): https://musicbrainz.org/artist/9252ca18-015c-484c…
      • 2020-03-03 06329, 2020

      • reosarevok
        Not sure if we should do anything about it...
      • 2020-03-03 06336, 2020

      • zas
        like making emails mandatory for new users?
      • 2020-03-03 06312, 2020

      • zas
      • 2020-03-03 06322, 2020

      • reosarevok
        Huh, I didn't realize they could rate without an email
      • 2020-03-03 06326, 2020

      • reosarevok
        (they can't edit, after all)
      • 2020-03-03 06335, 2020

      • reosarevok
        Probably should block that, yes!
      • 2020-03-03 06355, 2020

      • zas
        dunno what to do, but it seems far too easy
      • 2020-03-03 06329, 2020

      • BrainzGit
        [bookbrainz-site] MonkeyDo opened pull request #382 (master…default-alias-selection): Default alias selection https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-03-03 06331, 2020

      • reosarevok
        Yeah, seems it's not blocked
      • 2020-03-03 06332, 2020

      • reosarevok
        sigh
      • 2020-03-03 06333, 2020

      • reosarevok
        Ok
      • 2020-03-03 06316, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1404 (master…MBS-10671): MBS-10671: Block ratings for unverified users https://github.com/metabrainz/musicbrainz-server/…
      • 2020-03-03 06317, 2020

      • BrainzBot
        MBS-10671: Block ratings for unverified users https://tickets.metabrainz.org/browse/MBS-10671
      • 2020-03-03 06331, 2020

      • reosarevok
        First draft ^ (bitmap, yvanzo: does it seem sensible?)
      • 2020-03-03 06340, 2020

      • ruaok
        zas: new data imported, but the DB is catching up on its continous aggregate. I'll empty the pending rmq cache after dinner
      • 2020-03-03 06336, 2020

      • antfoo_ has quit
      • 2020-03-03 06305, 2020

      • antfoo joined the channel
      • 2020-03-03 06349, 2020

      • CatQuest
        reosarevok: also note the numbers of "tags" on that SB19 artist
      • 2020-03-03 06314, 2020

      • bitmap
        reosarevok: PR looks good to me, is it a draft 'cause you were unsure about adding the ws changes?
      • 2020-03-03 06302, 2020

      • reosarevok
        Yes
      • 2020-03-03 06354, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #1383 (master…fix-editor-warning): Fix noisy warning about editor’s gravatar: uninitialized value in lc https://github.com/metabrainz/musicbrainz-server/…
      • 2020-03-03 06346, 2020

      • niceplace has quit
      • 2020-03-03 06300, 2020

      • niceplace joined the channel
      • 2020-03-03 06345, 2020

      • djwhitey has quit
      • 2020-03-03 06324, 2020

      • Endurance21 has quit
      • 2020-03-03 06338, 2020

      • djwhitey joined the channel