15:10 PM
ruaok
ok, now examine listenbrainz/influx_writer
2020-03-10 07040, 2020
15:17 PM
Pac23
doing,
2020-03-10 07040, 2020
15:30 PM
_lucifer
2020-03-10 07025, 2020
15:31 PM
_lucifer
gr0uch0mars: i have read SomalRudra 's proposal and left a review.
2020-03-10 07041, 2020
15:32 PM
Pac23
ah,got it
2020-03-10 07059, 2020
15:32 PM
Pac23
thanks ruaok
2020-03-10 07015, 2020
15:34 PM
ruaok
update your diagram and post it again, please.
2020-03-10 07058, 2020
15:34 PM
Pac23
doing
2020-03-10 07016, 2020
15:35 PM
gr0uch0mars
_lucifer: thanks, I read it too and wanted to know your view
2020-03-10 07003, 2020
15:36 PM
_lucifer
Didn't know meb used to have a mailing list also.
2020-03-10 07055, 2020
15:36 PM
yvanzo
I’m not sure the ml is still active, never used it.
2020-03-10 07020, 2020
15:37 PM
_lucifer
yeah, there are dead as per the wiki.
2020-03-10 07040, 2020
15:37 PM
sumedh joined the channel
2020-03-10 07006, 2020
15:38 PM
_lucifer
yvanzo: did i mention the correct link to edit on the wiki?
2020-03-10 07017, 2020
15:38 PM
yvanzo
yes
2020-03-10 07031, 2020
15:38 PM
_lucifer
thanks, i'll update the page.
2020-03-10 07055, 2020
15:38 PM
_lucifer
ruaok: how was development and collaboration at the time of mailing lists?
2020-03-10 07023, 2020
15:39 PM
ruaok
we used a lot more stone tablets back in the day. it was all before electricity and such.
2020-03-10 07033, 2020
15:39 PM
ruaok
wait, what??
2020-03-10 07040, 2020
15:39 PM
yvanzo
2020-03-10 07012, 2020
15:40 PM
ruaok
yep, they did. and yes that put a 10 year debate to bed, finally.
2020-03-10 07013, 2020
15:40 PM
_lucifer
👍
2020-03-10 07055, 2020
15:40 PM
ruaok
yvanzo: who is our dev who uses mapbox? I just got an email about using a depricated API.
2020-03-10 07024, 2020
15:41 PM
reosarevok
2020-03-10 07036, 2020
15:41 PM
reosarevok
We have a MAPBOX_ACCESS_TOKEN
2020-03-10 07006, 2020
15:42 PM
ruaok
ok, you are. great, thanks reo. forwarding mail now. much <3
2020-03-10 07039, 2020
15:42 PM
_lucifer
ruaok: which license do you want to use for the app?
2020-03-10 07002, 2020
15:43 PM
ruaok
is the code all yours or did you borrow code from elsewhere?
2020-03-10 07015, 2020
15:43 PM
_lucifer
no borrowing
2020-03-10 07021, 2020
15:43 PM
yvanzo
I do use mapbox too for local development server.
2020-03-10 07042, 2020
15:44 PM
_lucifer
the original code of the app was also heavily modified so I don't think it resembles the original app's source code as well.
2020-03-10 07056, 2020
15:45 PM
ruaok
yvanzo: copied you as well.
2020-03-10 07022, 2020
15:46 PM
ruaok
_lucifer: it isn't about "resembling" but "does it contain even 1 line of code from someone else?"
2020-03-10 07035, 2020
15:46 PM
ruaok
does the codebase contain any code from the previous project?
2020-03-10 07019, 2020
15:47 PM
_lucifer
Yes, it does in a few layout files.
2020-03-10 07034, 2020
15:47 PM
_lucifer
Those will be changed for the new UI.
2020-03-10 07043, 2020
15:47 PM
ruaok
then we must use the existing license or replace those layouts with ones you've created.
2020-03-10 07050, 2020
15:47 PM
ruaok
what was the old license?
2020-03-10 07000, 2020
15:48 PM
yvanzo
thanks
2020-03-10 07002, 2020
15:48 PM
_lucifer
I can rewrite the old ones if you want.
2020-03-10 07019, 2020
15:48 PM
ruaok
what was the old license?
2020-03-10 07031, 2020
15:48 PM
_lucifer
MusicBrainz for Android is licensed under the GPL version 3 or later with sections under the Apache License version 2.
2020-03-10 07048, 2020
15:48 PM
_lucifer
the wiki says this
2020-03-10 07000, 2020
15:49 PM
ruaok
where is the github repo?
2020-03-10 07012, 2020
15:49 PM
_lucifer
wait a min
2020-03-10 07001, 2020
15:50 PM
_lucifer
2020-03-10 07004, 2020
15:50 PM
_lucifer
repo
2020-03-10 07017, 2020
15:50 PM
ruaok
where have you been pushing your code to?
2020-03-10 07029, 2020
15:50 PM
ruaok
we should really host that under the metabrainz account.
2020-03-10 07004, 2020
15:51 PM
_lucifer
2020-03-10 07015, 2020
15:51 PM
_lucifer
yeah i plan to do the same
2020-03-10 07021, 2020
15:51 PM
ruaok
ok, can we change the owner for that, please?
2020-03-10 07027, 2020
15:51 PM
_lucifer
yeah sure
2020-03-10 07033, 2020
15:51 PM
_lucifer
just give me the instructions
2020-03-10 07046, 2020
15:51 PM
ruaok
and I think the current license is fine; unless you have an strong objection, lets keep it.
2020-03-10 07059, 2020
15:51 PM
_lucifer
i don't have any objections.
2020-03-10 07011, 2020
15:52 PM
ruaok
ok, lets keep it then.
2020-03-10 07016, 2020
15:52 PM
_lucifer
👍
2020-03-10 07047, 2020
15:52 PM
_lucifer
Let's change the owner now
2020-03-10 07057, 2020
15:52 PM
ruaok
ok, go to settings for the repo.
2020-03-10 07008, 2020
15:53 PM
ruaok
down at the bottom is the danger zone.
2020-03-10 07018, 2020
15:53 PM
ruaok
click the transfer button and follow the instructions.
2020-03-10 07005, 2020
15:55 PM
_lucifer
done.
2020-03-10 07013, 2020
15:55 PM
_lucifer
what to set as new owner?
2020-03-10 07027, 2020
15:55 PM
ruaok
user "metabrainz"
2020-03-10 07020, 2020
15:56 PM
_lucifer
it says you don't have permission to create public repositories on metabainz
2020-03-10 07025, 2020
15:56 PM
_lucifer
*metabrainz
2020-03-10 07012, 2020
15:57 PM
ruaok
ok, hang on.
2020-03-10 07020, 2020
15:57 PM
shivam-kapila
To add repo to org a user needs to be its member.
2020-03-10 07010, 2020
15:58 PM
_lucifer
i can transfer to you or any other member ruaok
2020-03-10 07025, 2020
15:58 PM
_lucifer
who can do it to metabrainz then
2020-03-10 07033, 2020
15:58 PM
ruaok
ah, that might be easier.
2020-03-10 07040, 2020
15:58 PM
ruaok
transfer to user "mayhem"
2020-03-10 07012, 2020
15:59 PM
_lucifer
Repository transfer to mayhem requested
2020-03-10 07019, 2020
15:59 PM
_lucifer
can you see it?
2020-03-10 07024, 2020
15:59 PM
ruaok
yes.
2020-03-10 07034, 2020
15:59 PM
ruaok
I invited you to the android team. got that invite?
2020-03-10 07002, 2020
16:00 PM
_lucifer
yeah and joined.
2020-03-10 07054, 2020
16:00 PM
_lucifer
😄😄 I am a member of the metabrainz team now. woohoo...
2020-03-10 07031, 2020
16:01 PM
ruaok
ok, repo moved and assigned to android team
2020-03-10 07027, 2020
16:03 PM
ruaok
try making a branch and pushing it, just to make sure you have access.
2020-03-10 07002, 2020
16:04 PM
_lucifer
yvanzo: bitmap: i was thinking of setting up CI for the app. can you tell why you used Circle CI over Jenkins or other providers?
2020-03-10 07009, 2020
16:04 PM
_lucifer
yeah sure ruaok i'll check
2020-03-10 07017, 2020
16:04 PM
Pac23
2020-03-10 07052, 2020
16:05 PM
Pac23
i'll remove the big ass arrow for influx area if you think it looks ugly
2020-03-10 07059, 2020
16:07 PM
yvanzo
_lucifer: mostly because our Jenkins setup was too slow
2020-03-10 07019, 2020
16:08 PM
yvanzo
but we now use both CircleCI and Jenkins
2020-03-10 07021, 2020
16:11 PM
_lucifer
yvanzo: ok, was any other CI like Travis or AppVeyour considered ?
2020-03-10 07039, 2020
16:11 PM
_lucifer
becuase that would save me the time for comparing the providers
2020-03-10 07045, 2020
16:11 PM
ruaok
Pac23: sure that link is right? looks the same
2020-03-10 07028, 2020
16:12 PM
yvanzo
_lucifer: no, I don’t think so, CircleCI should do.
2020-03-10 07014, 2020
16:13 PM
gr0uch0mars
_lucifer: may I have access to the repo, too please? 🙏
2020-03-10 07018, 2020
16:13 PM
_lucifer
thanks yvanzo, I'll go forward with it unless there is some serious drawback for using it on android projects
2020-03-10 07040, 2020
16:13 PM
ruaok
gr0uch0mars: what is your github username?
2020-03-10 07059, 2020
16:13 PM
gr0uch0mars
Miguel-Herrero
2020-03-10 07018, 2020
16:14 PM
yvanzo
The only drawback we had about MBS with CircleCI was the maximum number of containers, but that probably won’t be a problem for an app.
2020-03-10 07040, 2020
16:14 PM
ruaok
gr0uch0mars: invited.
2020-03-10 07003, 2020
16:15 PM
yvanzo
That’s why we are running Jenkins again for a few tests only.
2020-03-10 07015, 2020
16:15 PM
_lucifer
yeah that won't matter for the app.
2020-03-10 07019, 2020
16:16 PM
gr0uch0mars
ruaok: gracias! invitation accepted :)
2020-03-10 07033, 2020
16:16 PM
_lucifer
2020-03-10 07023, 2020
16:17 PM
_lucifer
The latest android preview yet again changes file api
2020-03-10 07044, 2020
16:17 PM
reosarevok
yvanzo: I'll look into mapbox
2020-03-10 07046, 2020
16:17 PM
gr0uch0mars
😓
2020-03-10 07047, 2020
16:17 PM
_lucifer
this impacts the tagging feature implementation and needs to reviewed
2020-03-10 07045, 2020
16:18 PM
_lucifer
and it breaks the current implementation
2020-03-10 07041, 2020
16:19 PM
gr0uch0mars
_lucifer: would it be a good idea to split into “picard library” (generate audioprint, fetch metadata, write metadata) and “app” (uses file api and pass them to “picard library”)
2020-03-10 07058, 2020
16:19 PM
gr0uch0mars
that way both can be developed separately and without dependency
2020-03-10 07006, 2020
16:20 PM
ruaok
ok, in theory both of you should have write access to that repo. please test this soon to avoid surprises.
2020-03-10 07014, 2020
16:25 PM
gr0uch0mars
Confirmed, I can write
2020-03-10 07015, 2020
16:25 PM
_lucifer
works for me ruaok
2020-03-10 07032, 2020
16:25 PM
ruaok
woo. thanks for transferring the repo, _lucifer
2020-03-10 07003, 2020
16:27 PM
_lucifer
gr0uch0mars: if i understand correctly, do you mean to create a separate android library by picard library?
2020-03-10 07032, 2020
16:27 PM
_lucifer
I don't have any issues with that.
2020-03-10 07045, 2020
16:27 PM
gr0uch0mars
yes, something with an Interface that can be used by the app but without interfering with the Infrastructure domain of the app
2020-03-10 07054, 2020
16:27 PM
gr0uch0mars
(Remember Clean Architecture?)
2020-03-10 07003, 2020
16:28 PM
_lucifer
yeah, I do.
2020-03-10 07053, 2020
16:31 PM
shivam-kapila
Just out of curiousity. Do you follow MVVM architecture for app or some other
2020-03-10 07024, 2020
16:32 PM
Pac23
2020-03-10 07025, 2020
16:32 PM
Pac23
vguny0xoW0fcEZQTDcuVpj%2BXsfBKsExO1K9D9lwIaVJHgeI3ccYgcvHBSbobgV9dvSRooK2Lcgyonsm3QxxFE2TKEmLa0EYhpbv0%2FaMpMkv1DgSuDPXcemR6hlRStB678ubtUgpFFGyRCTd0FOqC0D10BUKTbvaf9zq1OQvtmjo063aYAWjed3zVtJ0oxL2MwRvSYKfLpD%2Fq4BoyoSe0%2Bc6Pzmb3qkJGuwVdMQBTjYrdKawtk5N3I4k7m8wwgEkqDGknJ2cbffU5DyW5Dyy3Ije9TLAD3RzzjY50r%2FgJRP%2FHYHLFT%2BN3rVxZsvFvGmWii3ipWevTku7Or0WdQpiRXFwwQgN3fMjmGXY35Ukffd0872SerHzg%2B28dfju1bp58GrD99aYfOd90O3GVXRvexHb4deUD4cCiTsJGqAvkOSp
2020-03-10 07026, 2020
16:32 PM
Pac23
j554c07qYDpH5JDDlDXa0JjTojDelqIIEvyw%2B7htWqzucFNRHY4wRwCMIQChfM3qqiYJEzqqL9wIHfOOSjlIHRWgql%2B7O84mPeCsA166YrNHnFmKOAM6cWYJOKv9%2B3NxBgScWeNhcWbKgcUgQOsRMEARMI5OwNgTQc9eR8A4ttARGBgwckDUGTBbkPxoHDk6YLQCwRENXnQsykCw9nCjoYCwP2ArwwfKLHnIdvbEEwDdxNO0W%2BxubyBBUlj8T%2B8NaUwHWe9xM5SGMdNOxLZVo4fXHHjYlnb9ywE7VzYMAkxwEsOikzhMXoDAHVO7wN0eHF1Np7cM%2BscOgX461NPkIMeKjMrUysHNyR4bfXasJ1AqMDQHb8sRnRelMlVJeOnGtJEvobwAzK7kS%2BxoaPLVRx5KM2RsVcjo5evi4NB1lJE6G
2020-03-10 07031, 2020
16:32 PM
Pac23
jijZMmR%2Fvs4oz6btt3ATZTA4Ax5w%2FjkCivcEl9h6s5RtOh9Oh3Gol0xtTvpaNGuswd7Q1m0HBJe5PMlVVsRepexXvYCjFp%2F2ceSo68PXLwGoQGX8TlHOSpvTV8V0ZC4SoP8%2FHKeKRBRCUC%2FEjSRnq5RXI8jq6VKliytZMk9xHGUh1YhtgNiHe%2FYQ2uP9bdzg5pyoVdrKDcWCypdoeaJBZWBocYjyacTuzcR3OB4%2FvMTxZtqfvZ67S9gTCFxhKxsDw5GHCxs7Tl20BYi%2BcmSCX4rTM1i88yTE5sc8VRwpY0NwG7rBBVZOjEA1hU1fZKUa2ocgFuKeWL4OwGptZXGXomzVg25gdGu1GGc9UTkhSIWVJ31ROSFYgL32M5ajgMHh9p4F2xvDTpqHCgnsb0blGL6%2BijViUKtiR%2FTEDI%
2020-03-10 07036, 2020
16:32 PM
Pac23
2FQJw7owpD0xDnGYrTeY6Nw9dbnOQ6Oww2SyfY3LHgJrtiTczD2ENDTVN18gS8K1ANhYHWQrjoFCWEqA9r%2B0KygbBmKzC5%2F5U5ddi%2FtsypW%2FyxK5KYNNrLv36Ys2korE6xjRag2GKJojfubMuE5n1MMIYRW%2BFpGbdwNitWGX78PLKmtyjALL9dzh57H4dRvqYbV1Q6xrRc2ImTntcNeT5qT3bPPMd2jL5UI66Hc2XVDBvV2ArjbraAK7YZRmhdDcCXym7%2FDaWOxniXS3pgclwueXAotbVmFcVAxemaVZRsHXBLOzCUUt3BTeO0Yi1v9sQTizzDMQXolT32O07LlZgbmBJcWr%2BxLY0Vu5cwK0aNJKQ%2FX7OiNvYJLlG%2FpcnAQV5gtw0UnjUDbl%2FrZsWBokaevoFCU61C3egPEi1bN
2020-03-10 07041, 2020
16:32 PM
Pac23
YAsgactgDTFWkHXPIYpTl60Bk5kOHKm8RYtkwfm86%2FyVYR9SJiBMuMtZhMUlszWp1aLU41LJvfPOfUERXKyJgMvwaj117qdlrkdAdPDFziX1JLBYtkwodrJKu3Mcoa2AIchKqRACVy9FOD89aO%2F5uHIvPlitUIFL%2F4a43%2Fy7TL6eorIX4%2FcOb4QM9E%2FSd%2BR82D3KS6%2BYVCIvFbF9Xrhl%2BU74%2FaSxTL9KmCgKEWcqX4CCugxO3Rusx1VSUsJUm2kxRLTQ%2BLyBmXSAsT0kDgX%2BtikRQ47dqy9%2FhLSHUlS9FvhG0OIozxlpxQL4KiiWTRFhernaUalGm1%2B73cohsgLW0cC1%2FfQLDzSSHACHvH1frKAk7XDI4He8AUIuYLO0%2FPM2vI1zc%2FjKN5JWzaykXvyZIz%2F
2020-03-10 07046, 2020
16:32 PM
Pac23
ZmxsGGSmhAnEkbfFSN0hbdS1Xq%2BNeoo26mqdKWGKHwSRVpape2uxRi0WEY5to3KKQQ1sNIZNiVoO23wentrTXMaT2O0Rg9yuD%2FsJvQtrRZ7X3U%2BII6Cqn3huFlx2SJWr65gGp7vbD36Wp2%2B%2Fmgqu%2FwM%3D
2020-03-10 07049, 2020
16:32 PM
Pac23
aw shit
2020-03-10 07007, 2020
16:33 PM
sumedh has quit
2020-03-10 07008, 2020
16:33 PM
ruaok
someone needs to win an award for that URL.
2020-03-10 07023, 2020
16:33 PM
alastairp
the entire image is encoded in the url, yeah?
2020-03-10 07024, 2020
16:33 PM
gr0uch0mars
hahahaha
2020-03-10 07035, 2020
16:33 PM
Pac23
only bitly will let me shorten it,
2020-03-10 07035, 2020
16:33 PM
shivam-kapila
I thought he kept some heavy thing on keyboard and left
2020-03-10 07040, 2020
16:33 PM
Pac23
and no one else
2020-03-10 07046, 2020
16:33 PM
Pac23
#channel sorry :/
2020-03-10 07054, 2020
16:33 PM
ruaok
alastairp: my thoughts exactly.
2020-03-10 07057, 2020
16:33 PM
Pac23
and bitly wont accept the new link,doing a pastebin now
2020-03-10 07057, 2020
16:33 PM
shivam-kapila
draw.io is on weed
2020-03-10 07015, 2020
16:34 PM
ruaok
much worse than weed, really.
2020-03-10 07017, 2020
16:34 PM
ruaok
crack.
2020-03-10 07036, 2020
16:34 PM
_lucifer
We can do that gr0uch0mars, should we do that now (before GSoC) or after it?
2020-03-10 07023, 2020
16:35 PM
shivam-kapila
ruaok: Crarck seems more apt here 😂
2020-03-10 07026, 2020
16:35 PM
gr0uch0mars
hmmm, I'd prefer if we could split before. Maybe that way we could schedule GSoC's tasks better
2020-03-10 07029, 2020
16:35 PM
shivam-kapila
Crack*
2020-03-10 07037, 2020
16:35 PM
ruaok
because stoners are too lazy for long urls.
2020-03-10 07019, 2020
16:36 PM
shivam-kapila
Wait. Now that was a clean shot
2020-03-10 07024, 2020
16:36 PM
gr0uch0mars
shivam-kapila: we started trying to follow MVVM, although i'd like to implement some Domain Driven, but that would be too much I think. We have to prioritize
2020-03-10 07052, 2020
16:36 PM
gr0uch0mars
And follow Clean Code and SOLID and so on (it's a rewrite of the old app, so we're doing it slowly)
2020-03-10 07053, 2020
16:36 PM
Pac23
2020-03-10 07056, 2020
16:36 PM
Pac23
the only option i had
2020-03-10 07019, 2020
16:37 PM
shivam-kapila
gr0uch0mars: Thanks for info. I dont know much about android though
