I did already test with that fix, so hopefully that was the last bug.
2020-03-12 07243, 2020
dpmittal_ has quit
2020-03-12 07251, 2020
yvanzo
updating beta.mb.o
2020-03-12 07212, 2020
yvanzo
done
2020-03-12 07224, 2020
yvanzo
bitmap, reosarevok: there are a lot of unassigned tickets in beta, likely yours.
2020-03-12 07243, 2020
Endurance21
Mr_Monkey: i am having hard time understanding how props are passed down to entity-editor. Can you please give a rough sketch of that?. I am currently working on https://tickets.metabrainz.org/browse/BB-296
2020-03-12 07244, 2020
BrainzBot
BB-296: Save creation form state on (or before) page navigation
2020-03-12 07209, 2020
Endurance21
Mr_Monkey: if I get the way how data of forms are passed then it will be easy for me to save them in localstorage as discussed.
2020-03-12 07213, 2020
Mr_Monkey
Endurance21: We use Redux as the state for the entity editor. Are you familiar with Redux?
2020-03-12 07214, 2020
Endurance21
Mr_Monkey: yes I am familiar with that.
2020-03-12 07212, 2020
Mr_Monkey
Each section of the form has actions that can be dispatched, which trigger something in the accompanying reducer that modifies the state
Mr_Monkey: bcz reducer functions are meant to change the state only, and I am using localstorage thing. So I think I should not include that in reducers.
2020-03-12 07214, 2020
Mr_Monkey
I haven't thought of where the best place would be to put this. What's your suggestion?
Mr_Monkey: i think this must be placed inside submission-section.js itself
2020-03-12 07226, 2020
Endurance21
Is it possible to get app store in submission-section.js
2020-03-12 07250, 2020
_lucifer
ruaok: let me know when you are done with that form, I'll then push an update to verify releases are working are fine.
2020-03-12 07201, 2020
ruaok
sorry, just got back from lunch.
2020-03-12 07215, 2020
_lucifer
no hurry
2020-03-12 07220, 2020
_lucifer
gr0uch0mars: how do you suggest I do the further development on the app, do I work on my fork of the official repo and submit a PR or work on a new branch in the official repo ?
2020-03-12 07203, 2020
Endurance21
Mr_Monkey: i have a another idea! Why to use save button? Whenever there is state change our form data automatically should be saved In local storage. Only we need. A clear button. To clear the saved data in forms.
Mr_Monkey: do you agree with not having a save button?.
2020-03-12 07245, 2020
Mr_Monkey
yes
2020-03-12 07200, 2020
Endurance21
Okay! Thanks.
2020-03-12 07207, 2020
Mr_Monkey
But there need to be clear rules about when we clear the state
2020-03-12 07233, 2020
Endurance21
We will be clearing the form data of state. Not the whole state..
2020-03-12 07258, 2020
Endurance21
And on button click
2020-03-12 07258, 2020
Mr_Monkey
For example if I submit an edit and it goes through, you would need to clear the saved state. However if there's an error when submitting, don't clear the state.
2020-03-12 07213, 2020
Endurance21
Ya that's error handling. I will take care of that..
2020-03-12 07245, 2020
Endurance21
There will be a active or inactive state of clear button, it will be active only when if either data is submitted successfully or the submit button is not yet hit.
2020-03-12 07211, 2020
Endurance21
And it will be inactive for all other cases
2020-03-12 07216, 2020
Mr_Monkey
There should also be a mechanism to automatically clear the saved form state if succesfully submitted.
2020-03-12 07207, 2020
leonardo
looks like i cannot import anymore releases from bandcamp using the greasemonkey script on firefox, is just me or something is changed in the musicbrainz site and the script is now broken?
leonardo: latest version works fine for me in Chrome at least
2020-03-12 07223, 2020
leonardo
i see
2020-03-12 07228, 2020
leonardo
so is definitely me
2020-03-12 07203, 2020
leonardo
problem is, even when i'm logged in, the system redirect me on the login page
2020-03-12 07224, 2020
leonardo
i submit once again my credentials, but then i lost every other parameter
2020-03-12 07203, 2020
Pac23m joined the channel
2020-03-12 07240, 2020
leonardo
probably some session cookie is not sent correctly
2020-03-12 07259, 2020
Endurance21
Mr_Monkey: ya i agree about automatically clearing the data if it is submitted successfully! So that if in any case user need to update the same he/she will revise it from edit section..
2020-03-12 07258, 2020
leonardo
which is strance, since i whitelisted *.musicbrainz.org on my ublock extension
2020-03-12 07252, 2020
reosarevok
leonardo: huh. Are you maybe logged in in beta and the script send you to the normal server or the other way around?
2020-03-12 07254, 2020
leonardo
mmm nope iwas not even aware of a beta version
2020-03-12 07220, 2020
leonardo
interestingly, the "import" button redirects me to the login page, while the "search" button shows me the search results and shows me that i am logged in
2020-03-12 07205, 2020
reosarevok
Huh
2020-03-12 07209, 2020
reosarevok
What's your version?
2020-03-12 07258, 2020
leonardo
using 2020.2.14.2 on Tampèermonkey on Firefox Nightly
I have 2020.2.14.2 as well. But I seem to remember someone else had an issue with it recently?
2020-03-12 07204, 2020
reosarevok
Yeah, they did, also firefox
2020-03-12 07221, 2020
reosarevok
So something probably broke with recent FF or tampermonkey updates
2020-03-12 07226, 2020
leonardo
i haven't tried with chromium, maybe is just a firefox issue
2020-03-12 07252, 2020
leonardo
lol we reached the same conclusions
2020-03-12 07225, 2020
leonardo
i'll try chromium and maybe some alternative to tampermonkey and see what happen
2020-03-12 07202, 2020
leonardo
speaking of which... is there any alternatives to tampermonkey?
2020-03-12 07239, 2020
gr0uch0mars
_lucifer: I think creating branches and PRs on the official repo would be enough. I will add templates for PRs so it's easier to review
2020-03-12 07250, 2020
gr0uch0mars
_lucifer: you can start by creating an issue describing what you're doing, and create a branch like: “feature/#4-my-awesome-thing”, that way we know it's related to issue #4
2020-03-12 07216, 2020
gr0uch0mars
later we'll try to migrate schedule to tasks in MB's JIRA, but let's start easy
2020-03-12 07246, 2020
_lucifer
👍 gr0uch0mars
2020-03-12 07227, 2020
SothoTalKer_ joined the channel
2020-03-12 07251, 2020
SothoTalKer has quit
2020-03-12 07226, 2020
leonardo
reosarevok: installed greasemonkey, tried again, still the same result
bitmap: yvanzo : Any idea why I face this only on a docker container of ubuntu when making it run ./scripts/compile_resources.sh ?
2020-03-12 07257, 2020
yvanzo
Cyna: isn't it due to the way you mount submodule as a volume in docker?
2020-03-12 07229, 2020
Cyna
I dont think that should be the reason should it? submoduling in based on my local machine... for the container the it should simply be a folder bound as a volume.
2020-03-12 07200, 2020
Cyna
When running from docker-compose from my mac everything runs fine.. It submoduling was the case, it should also have occurred on mac, right ?
2020-03-12 07207, 2020
yvanzo
Cyna: because of “fatal: Not a git repository: ../.git/modules/musicbrainz-server”
2020-03-12 07234, 2020
yvanzo
ỳour 'mb-docker' repo has a submodule named 'musicbrainz-server'
2020-03-12 07256, 2020
Cyna
Yea which is also a git repository right
2020-03-12 07247, 2020
yvanzo
Yes which probably references 'mb-docker' as parent repo
2020-03-12 07228, 2020
yvanzo
So when trying to get git info from 'musicbrainz-server', it also tries to get git info from 'mb-docker' which is not mounted into docker.
