#metabrainz

/

      • D4RK-PH0ENiX has quit
      • 2020-03-17 07715, 2020

      • c1e0 joined the channel
      • 2020-03-17 07722, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-03-17 07732, 2020

      • yokel has quit
      • 2020-03-17 07705, 2020

      • yokel joined the channel
      • 2020-03-17 07701, 2020

      • d4rkie joined the channel
      • 2020-03-17 07744, 2020

      • D4RK-PH0ENiX has quit
      • 2020-03-17 07756, 2020

      • d4rkie has quit
      • 2020-03-17 07752, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-03-17 07726, 2020

      • Lotheric has quit
      • 2020-03-17 07739, 2020

      • shivam-kapila joined the channel
      • 2020-03-17 07738, 2020

      • greenapple joined the channel
      • 2020-03-17 07729, 2020

      • greenapple has quit
      • 2020-03-17 07711, 2020

      • sam joined the channel
      • 2020-03-17 07731, 2020

      • sam
        Hi, I want to participate in GSoC.
      • 2020-03-17 07735, 2020

      • sam is now known as Guest60802
      • 2020-03-17 07743, 2020

      • Cyna
        hi Guest60802, which project are you interested in ?
      • 2020-03-17 07710, 2020

      • Cyna
        https://bit.ly/2NUaxgb you can refer this guide for help on deciding
      • 2020-03-17 07745, 2020

      • Guest60802 has quit
      • 2020-03-17 07750, 2020

      • sam joined the channel
      • 2020-03-17 07713, 2020

      • sam
        I am interested in BookBrainz.
      • 2020-03-17 07714, 2020

      • sam is now known as Guest98574
      • 2020-03-17 07714, 2020

      • Guest98574
        Who are the mentors of this?
      • 2020-03-17 07724, 2020

      • Guest98574
        Can someone please guide me
      • 2020-03-17 07707, 2020

      • shivam-kapila
        Hi Guest98574
      • 2020-03-17 07715, 2020

      • Guest98574
        hi
      • 2020-03-17 07717, 2020

      • c1e0 has quit
      • 2020-03-17 07725, 2020

      • shivam-kapila
        Mr_Monkey will be the mentor for BB
      • 2020-03-17 07709, 2020

      • Guest98574
        How many students are getting selected for GSoC.
      • 2020-03-17 07722, 2020

      • shivam-kapila
        I am also an aspirant so I cant say exactly but I guess there is no fixed number. It depends on the mentor and student's work. If contributions are good and proposal is good, chances stand high
      • 2020-03-17 07734, 2020

      • samagra joined the channel
      • 2020-03-17 07711, 2020

      • Guest98574
        In Which project are you contributing?
      • 2020-03-17 07724, 2020

      • samagra
        Hi, I am a 3rd year UG student. I am interested in participating in GSoC 2020. I liked the idea of the project: BookBrainzHow can I increase my chances of getting selected?
      • 2020-03-17 07747, 2020

      • shivam-kapila
        Guest98574: LB
      • 2020-03-17 07725, 2020

      • shivam-kapila
        samagra: Hi. You can get started here https://bit.ly/2NUaxgb
      • 2020-03-17 07726, 2020

      • samagra has quit
      • 2020-03-17 07726, 2020

      • Guest98574 has quit
      • 2020-03-17 07717, 2020

      • VxJasonxV has quit
      • 2020-03-17 07759, 2020

      • VxJasonxV joined the channel
      • 2020-03-17 07736, 2020

      • reosarevok
        yvanzo: reviewed, take a look and feel free to publish
      • 2020-03-17 07705, 2020

      • reosarevok
        Guest69148: I don't think we even know yet how many slots we have as a maximum, but also what shivam-kapila said :)
      • 2020-03-17 07713, 2020

      • reosarevok
        Oh, sorry, wrong guest :D
      • 2020-03-17 07715, 2020

      • reosarevok
        nvm
      • 2020-03-17 07720, 2020

      • eharris has quit
      • 2020-03-17 07709, 2020

      • Chinmay3199 joined the channel
      • 2020-03-17 07709, 2020

      • eharris joined the channel
      • 2020-03-17 07738, 2020

      • Guest69148 is now known as killme
      • 2020-03-17 07702, 2020

      • Gazooo has quit
      • 2020-03-17 07751, 2020

      • Gazooo joined the channel
      • 2020-03-17 07753, 2020

      • guest23 joined the channel
      • 2020-03-17 07731, 2020

      • IamDheerajS has quit
      • 2020-03-17 07756, 2020

      • IamDheerajS joined the channel
      • 2020-03-17 07725, 2020

      • samagra joined the channel
      • 2020-03-17 07725, 2020

      • samagra
        Hi, I am a 3rd year UG student. I am interested in participating in GSoC 2020. I liked the idea of the project: BookBrainz. How can I increase my chances of getting selected?
      • 2020-03-17 07730, 2020

      • Mr_Monkey
        Hi samagra ! Welcome ! Here's a page with lots of information; it's a good starting place and I recommend reading it all: https://bit.ly/2NUaxgb
      • 2020-03-17 07753, 2020

      • Mr_Monkey
      • 2020-03-17 07703, 2020

      • samagra
        Sure
      • 2020-03-17 07706, 2020

      • guest23 has quit
      • 2020-03-17 07725, 2020

      • samagra has quit
      • 2020-03-17 07733, 2020

      • yvanzo
        mo’’in’ reosarevok, published, thanks!
      • 2020-03-17 07746, 2020

      • reosarevok
        np!
      • 2020-03-17 07743, 2020

      • reosarevok
      • 2020-03-17 07747, 2020

      • reosarevok
        Will look into it
      • 2020-03-17 07705, 2020

      • reosarevok
        I'd suggest the same we did with annotations - open discID edits shouldn't actually add the discID at all until they apply - but maybe we don't want to do that just so that people can still use them in the meantime?
      • 2020-03-17 07745, 2020

      • alastairp
        I remember way back when I was ripping cds, that's exactly what I did - add the metadata, add the discid, rip+rename. waiting for the edit would put a hiccup in the process
      • 2020-03-17 07721, 2020

      • reosarevok
        I mean, these are only votable if the user specifically marks stuff as votable I think
      • 2020-03-17 07749, 2020

      • reosarevok
        I'm not sure they should ever be - how do I even vote on a discID add anyway? - but :/
      • 2020-03-17 07746, 2020

      • reosarevok
        Well I guess nobody can add a discid that's already present, so there shouldn't be a conflict of any sort if the cancellation / rejection actually *removes* the discid instead
      • 2020-03-17 07730, 2020

      • D4RK-PH0ENiX has quit
      • 2020-03-17 07731, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-03-17 07710, 2020

      • ishaanshah[m]
        iliekcomputers: ping
      • 2020-03-17 07722, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1427 (master…MBS-10707): MBS-10707: Actually remove discID if add edit is rejected https://github.com/metabrainz/musicbrainz-server/…
      • 2020-03-17 07724, 2020

      • BrainzBot
        MBS-10707: Open Add DiscID edit already adds discID, cancelling does not remove it https://tickets.metabrainz.org/browse/MBS-10707
      • 2020-03-17 07759, 2020

      • reosarevok
        yvanzo, bitmap ^ let's make sure to release this next time
      • 2020-03-17 07702, 2020

      • Lotheric joined the channel
      • 2020-03-17 07734, 2020

      • Lotheric has quit
      • 2020-03-17 07710, 2020

      • bitmap
        moinmoin
      • 2020-03-17 07755, 2020

      • bitmap
        maybe we ought to store the medium_cdtoc id in insert to remove it easier
      • 2020-03-17 07710, 2020

      • P23 has left the channel
      • 2020-03-17 07736, 2020

      • Lotheric joined the channel
      • 2020-03-17 07725, 2020

      • reosarevok
        I thought about it, but then it will break for edits that didn't yet have it, no?
      • 2020-03-17 07726, 2020

      • adhawkins has quit
      • 2020-03-17 07710, 2020

      • bitmap
        for ones opened before the fix is released it'll still fail to remove the discid, yeah
      • 2020-03-17 07732, 2020

      • supersandro2000 joined the channel
      • 2020-03-17 07716, 2020

      • adhawkins joined the channel
      • 2020-03-17 07703, 2020

      • BestSteve has quit
      • 2020-03-17 07718, 2020

      • Lotheric has quit
      • 2020-03-17 07709, 2020

      • Lotheric joined the channel
      • 2020-03-17 07720, 2020

      • adhawkins has quit
      • 2020-03-17 07755, 2020

      • BestSteve joined the channel
      • 2020-03-17 07715, 2020

      • adhawkins joined the channel
      • 2020-03-17 07732, 2020

      • reosarevok
        Do you think that's still better? Dunno, maybe
      • 2020-03-17 07713, 2020

      • bitmap
        I like the idea of it & it wouldn't affect many edits at least. but we'd have to hotfix the edit data changes to prod before releasing the fix to beta, which is meh
      • 2020-03-17 07730, 2020

      • shivam-kapila has quit
      • 2020-03-17 07741, 2020

      • reosarevok
        I mean, we could just hope that nobody cancels or votes down the edits for a week :p
      • 2020-03-17 07747, 2020

      • reosarevok
        It's probably not super common, 270 total
      • 2020-03-17 07734, 2020

      • reosarevok
        bitmap: do you have any good ideas on how to remove the ones that should have been removed in the meantime? Or should we just sigh and let them be?
      • 2020-03-17 07751, 2020

      • blup
        reosarevok: when can I start nagging you about MBS-10590 ?
      • 2020-03-17 07752, 2020

      • BrainzBot
        MBS-10590: Figure out how and implement IROM instrument images in StaticBrainz https://tickets.metabrainz.org/browse/MBS-10590
      • 2020-03-17 07708, 2020

      • bitmap
        is 270 how many were incorrectly left added, or is it less than that?
      • 2020-03-17 07751, 2020

      • blup
        at this point I'm finding the images myself and if I could jsut uplaod thme to SB myself...
      • 2020-03-17 07722, 2020

      • blup
        honestly just a dump of all those iamges somewhere
      • 2020-03-17 07732, 2020

      • blup
        I could jsut pick and chose which anyway
      • 2020-03-17 07707, 2020

      • blup
        (sorry, I'm getting sikc of not having images :P)
      • 2020-03-17 07714, 2020

      • reosarevok
        bitmap: that was the number of cancelled add disc id edits, but I guess we should also check rejected
      • 2020-03-17 07747, 2020

      • shivam-kapila joined the channel
      • 2020-03-17 07750, 2020

      • reosarevok
        blup: left one comment in one of the subtickets. bitmap: how would we add a new bunch of images to staticbrainz? Just put them under the images/ folder of MBS?
      • 2020-03-17 07700, 2020

      • reosarevok
        yvanzo: do you know how to pass data- attributes to react-table?
      • 2020-03-17 07755, 2020

      • djwhitey joined the channel
      • 2020-03-17 07716, 2020

      • reosarevok
        We need them for data-score
      • 2020-03-17 07724, 2020

      • reosarevok
        If we want to use it for searches
      • 2020-03-17 07727, 2020

      • bitmap
        reosarevok: yeah but you also have to require() them from somewhere or they won't be copied to the build dir
      • 2020-03-17 07750, 2020

      • yvanzo
        reosarevok: It has to be implemented into 'Table' component, more accurately its function 'renderTableRow'.
      • 2020-03-17 07709, 2020

      • yvanzo
        We already do it for setting odd/even class.
      • 2020-03-17 07713, 2020

      • reosarevok
        Ok, will check
      • 2020-03-17 07704, 2020

      • reosarevok
        I converted the last table, but now would like to also use it for search (since artist tables were being shared already) so let's hope I can get it in
      • 2020-03-17 07715, 2020

      • blup
        reosarevok: replyed to that comment
      • 2020-03-17 07729, 2020

      • reosarevok
      • 2020-03-17 07733, 2020

      • zas
        guys, if you happen to have a GPU, you can throw few resources to Folding@Home project: https://foldingathome.org/2020/03/15/coronavirus-…
      • 2020-03-17 07749, 2020

      • reosarevok
        Also if you don't, I'm running on CPU too
      • 2020-03-17 07700, 2020

      • zas
        yup, works too
      • 2020-03-17 07731, 2020

      • reosarevok
        I do have a GPU but I struggled to configure it in Ubuntu to actually use it, but CPU is better than nothing!
      • 2020-03-17 07703, 2020

      • reosarevok
        The package I got is to help research cancer instead of covid, but eh, I actually have more of a chance of dying of cancer so works for me too :D
      • 2020-03-17 07732, 2020

      • zas
        for GPU, at start it wasn't detected on Ubuntu, I had to reboot, and sacrifice a chicken, but now it works
      • 2020-03-17 07726, 2020

      • yvanzo
        thanks for the link
      • 2020-03-17 07723, 2020

      • yvanzo
        reosarevok: I can try a patch for data- attr. if you want to.
      • 2020-03-17 07756, 2020

      • reosarevok
        I can try and figure out :)
      • 2020-03-17 07710, 2020

      • reosarevok
        If you want you can review the above so we advance the React train :D
      • 2020-03-17 07743, 2020

      • yvanzo
        reosarevok: Ok, it is likely it can be done by adding a rowAttributes parameter to Table.
      • 2020-03-17 07710, 2020

      • reosarevok
        I'll give that a go and ask for help if stuck :)
      • 2020-03-17 07714, 2020

      • reosarevok
        !m yvanzo
      • 2020-03-17 07714, 2020

      • BrainzBot
        You're doing good work, yvanzo!
      • 2020-03-17 07704, 2020

      • blup
        🚆 choo choo
      • 2020-03-17 07719, 2020

      • reosarevok
        blup: eeeexactly!
      • 2020-03-17 07737, 2020

      • blup
        dang should used 🚂
      • 2020-03-17 07748, 2020

      • reosarevok
        Ok, *almost* exactly then :D
      • 2020-03-17 07758, 2020

      • blup
        good enough ™
      • 2020-03-17 07718, 2020

      • yvanzo
        $ sl
      • 2020-03-17 07731, 2020

      • blup
        uuuhh
      • 2020-03-17 07732, 2020

      • reosarevok
        yvanzo: if adding rowAttributes would you move className to be one of them?
      • 2020-03-17 07754, 2020

      • yvanzo
        reosarevok: no, unless there is a need to control it.
      • 2020-03-17 07756, 2020

      • reosarevok
        Ok
      • 2020-03-17 07739, 2020

      • blup
        reosarevok
      • 2020-03-17 07754, 2020

      • Chinmay3199 has quit
      • 2020-03-17 07705, 2020

      • blup
        sigh
      • 2020-03-17 07754, 2020

      • blup
        hello?
      • 2020-03-17 07753, 2020

      • blup
        why suddenly nothing for 2 hours on a tuesday :[
      • 2020-03-17 07743, 2020

      • blup
        HELLO?
      • 2020-03-17 07746, 2020

      • blup
        :(
      • 2020-03-17 07738, 2020

      • blup has quit