yvanzo: so in reference to this project `Embed documentation into the MusicBrainz website`, The task is to distribute the documentation of each entity in pieces like hovers, bubbles, etc. and parse the whole documentation from pieces incase the whole is required
2020-03-18 07833, 2020
Cyna
right ?
2020-03-18 07825, 2020
sumedh has quit
2020-03-18 07822, 2020
yvanzo
"mini" because it is not a whole editing form, it is just a field, code is at root/forms/relationship-editor.tt
2020-03-18 07858, 2020
yvanzo
(while release relationships editing form’s code is at root/release/edit_relationships.tt)
2020-03-18 07804, 2020
yvanzo
Cyna: right
2020-03-18 07825, 2020
skywinder__ joined the channel
2020-03-18 07814, 2020
skywinder__ has quit
2020-03-18 07819, 2020
ollie18 joined the channel
2020-03-18 07856, 2020
ollie18 has quit
2020-03-18 07834, 2020
goldenshimmer has quit
2020-03-18 07815, 2020
goldenshimmer joined the channel
2020-03-18 07831, 2020
sumedh joined the channel
2020-03-18 07817, 2020
shivam-kapila
ruaok: Hi. Actually while working of tests I would need to refer`timescale_listenstore.py`. Can you share the code upto which you have worked till now so that I can refer it. A gist would do :)
2020-03-18 07858, 2020
sotpap joined the channel
2020-03-18 07808, 2020
sotpap has quit
2020-03-18 07818, 2020
ruaok
assume that nearly all functions in influx_listenstore will be available in timescale_listenstore.
not quite sure yet. may still change. I'll try and work on this more later.
2020-03-18 07814, 2020
shivam-kapila
okay. I think I should proceed with modifying the test functions as of now. Thanks ruaok :)
2020-03-18 07809, 2020
Chinmay3199 joined the channel
2020-03-18 07851, 2020
sumedh has quit
2020-03-18 07805, 2020
reosarevok
yvanzo: feels like year should also use the number / count column then :)
2020-03-18 07812, 2020
reosarevok
Maybe I should rename from count to number
2020-03-18 07859, 2020
sumedh joined the channel
2020-03-18 07832, 2020
lks has quit
2020-03-18 07859, 2020
yvanzo
reosarevok: no, because 2020 as a number would be localized as 2,020.
2020-03-18 07805, 2020
reosarevok
Oh, true
2020-03-18 07814, 2020
reosarevok
So we should have a separate way to format these, huh
2020-03-18 07825, 2020
reosarevok
(also, we should move formatCount out of /statistics by now
2020-03-18 07828, 2020
reosarevok
I suspect)
2020-03-18 07837, 2020
yvanzo
I don’t feel it’s useful except if we have year columns in other tables.
2020-03-18 07830, 2020
yvanzo
reosarevok: as mentionned in comment, actual localization can be implemented later on.
2020-03-18 07818, 2020
reosarevok
Sure - I just thought it could use the same, but if not let's do it later
2020-03-18 07820, 2020
yvanzo
(it isn’t currently localized anyway)
2020-03-18 07804, 2020
reosarevok
Ok :)
2020-03-18 07824, 2020
reosarevok
yvanzo: re: the comment on https://github.com/metabrainz/musicbrainz-server/… - I left the comment on the previous commit as requested, should I change anything on the commit removing the file as well?
2020-03-18 07823, 2020
reosarevok
Also, did you manage to check the search implementation?
2020-03-18 07805, 2020
reosarevok
I think it's reasonable, but :)
2020-03-18 07844, 2020
CatQuest
reo?!
2020-03-18 07819, 2020
CatQuest
T_T y u no reply since 13 yesterday
2020-03-18 07824, 2020
CatQuest
i was kidna worried :x
2020-03-18 07849, 2020
reosarevok
Because I thought you saw me elsewhere :p
2020-03-18 07854, 2020
reosarevok
I'm fine!
2020-03-18 07856, 2020
CatQuest
saw yo uwhere?!
2020-03-18 07803, 2020
reosarevok
Here! :D
2020-03-18 07804, 2020
CatQuest
i tried talking to you for hours and i got no reply
2020-03-18 07853, 2020
reosarevok
Sowwy :) Hopefully it's all good now
2020-03-18 07839, 2020
yvanzo
reosarevok: which previous commit? can you please link to commit#line when addressing a conversation?
Ok, for some reason I did not see your latest commit. (That’s why links are welcome.)
2020-03-18 07833, 2020
yvanzo
Thanks!
2020-03-18 07816, 2020
yvanzo
Figured out, clicking on the link probably reopened an outdated tab.
2020-03-18 07856, 2020
adhawkins has quit
2020-03-18 07853, 2020
yvanzo
reosarevok: we should be able to use 'results' directly as rows
2020-03-18 07824, 2020
yvanzo
that would allow adding extra columns for data reports and user collections.
2020-03-18 07832, 2020
reosarevok
Wouldn't we just be able to pass {extracolumns} to the list if desired?
2020-03-18 07847, 2020
reosarevok
With a list of extra columns
2020-03-18 07821, 2020
sumedh has quit
2020-03-18 07831, 2020
yvanzo
no since data for these extra columns have to come from rows
2020-03-18 07833, 2020
yvanzo
It could be solved by adding an optional entityAccessor parameter to *List and passing this to utility functions that define 'accessor' for columns.
2020-03-18 07859, 2020
reosarevok
I mean, we have plenty of ones that go with entity => entity.whatever as a function
2020-03-18 07803, 2020
reosarevok
Wouldn't that work here too?
2020-03-18 07818, 2020
yvanzo
e.g. in ArtistList, we would have 'rows' instead of 'artists' and 'row => row.entity.sort_name' instead of 'entity => entity.sort_name'
2020-03-18 07814, 2020
reosarevok
Hmm. Not sure I follow
2020-03-18 07830, 2020
reosarevok
So that would apply for all of them, not just searches
2020-03-18 07832, 2020
reosarevok
?
2020-03-18 07839, 2020
yvanzo
(in root/components/list/ArtistList.js)
2020-03-18 07848, 2020
yvanzo
reosarevok: yes
2020-03-18 07807, 2020
yvanzo
hmm, wait :D
2020-03-18 07857, 2020
yvanzo
with above suggested entityAccessor, we would have 'row => entityAccessor(row).sort_name'
2020-03-18 07854, 2020
yvanzo
entityAccessor would just be identity function by default, and '(row) => (row.entity)' for search results.
2020-03-18 07839, 2020
adhawkins joined the channel
2020-03-18 07825, 2020
reosarevok
What's the benefit compared to just changing the way we pass the results to React?
2020-03-18 07829, 2020
yvanzo
we can bundle any extra column within 'data' (Table parameter)
2020-03-18 07839, 2020
yvanzo
this can be used for reports and collections
2020-03-18 07856, 2020
reosarevok
Collections already use the default columns, unless I'm forgetting something
2020-03-18 07823, 2020
yvanzo
collections have extra data since latest schema change
2020-03-18 07838, 2020
Cyna
yvanzo: as far as I can remember from last years summit, we planned on embedding docs in relevant code as comments. for example, API docs, Function specification, etc
2020-03-18 07812, 2020
reosarevok
yvanzo: would this also mean passing scores like that then?
I mean it certainly would be interesting but would be it qualified as a gsoc project
2020-03-18 07842, 2020
shivam-kapila
ruaok: I have modified the tests(not quite sure how much correct they are). But they are too much dependent on `timescale_listenstore.py` and `test.utils.py`. Most of the tests use functions in these files. Anything you have in mind I can proceed further with?
Well then I'll stick with embedding documentation to edit forms.. I'll need help with others on how to embed them
2020-03-18 07826, 2020
Cyna
I'll convert place edit form tomorrow and then embed the documentation into it.
2020-03-18 07838, 2020
Cyna
I also have an idea of adding tutorial of some sort as some games have where you'll have to just go through the tutorial to understand what each attribute is and how to add them. but I dont have much idea on how to implement it
2020-03-18 07812, 2020
Cyna
yvanzo: that should be enough for pre gsoc preparation right ?
2020-03-18 07844, 2020
blinky42 has quit
2020-03-18 07827, 2020
yvanzo
Cyna: it looks like a good start at least, depends on your ideas I guess, hopefully it should become clearer once you wrote an actual proposal.
Hi!I'm a student and I would like to participate in the project of AcusticBrain of Google Summer of Code. I have seen that I must do some task but there's some that I don't understand like the first "Install the server on your computer or use the Vagrant setup scripts". Which server are you referring to?
2020-03-18 07838, 2020
_lucifer
Josue: Welcome to the community. I think this might be what you are looking for.
2020-03-18 07852, 2020
shivam-kapila
Josue: Hi. It means setting up local dev environment. So you need to set up accoustic brainz server
Josue: hah, that's because we copied the text from last year (and that from the year before [and that from the year before]) and didn't update it to say to use docker
2020-03-18 07818, 2020
alastairp
can you update the page (it's a wiki) and fix it?
2020-03-18 07819, 2020
Josue
_lucifer ok, thanks so much! I'm going to check it out.
2020-03-18 07810, 2020
Josue
alastairp So, what are the tasks I have to perform to apply? or are they same?
2020-03-18 07848, 2020
alastairp
Josue: there are instructions in the link that _lucifer sent about how to set up the server. however, the instructions on the Summer of Code page are out of date, so it would be great if someone updates them
2020-03-18 07807, 2020
alastairp
I was suggesting that if you want to, you can make that change
2020-03-18 07806, 2020
Josue
alastairp All right, what are the updates that need to be made?
2020-03-18 07833, 2020
alastairp
Josue: just to remove the reference to vagrant, and to say that you can use docker to install the server
