#metabrainz

It's smaller than the release one, so mini :D

yvanzo: so in reference to this project `Embed documentation into the MusicBrainz website`, The task is to distribute the documentation of each entity in pieces like hovers, bubbles, etc. and parse the whole documentation from pieces incase the whole is required

right ?

"mini" because it is not a whole editing form, it is just a field, code is at root/forms/relationship-editor.tt

(while release relationships editing form’s code is at root/release/edit_relationships.tt)

Cyna: right

ruaok: Hi. Actually while working of tests I would need to refer`timescale_listenstore.py`. Can you share the code upto which you have worked till now so that I can refer it. A gist would do :)

assume that nearly all functions in influx_listenstore will be available in timescale_listenstore.

I haven't gotten far yet.

ruaok: I was using the following configuration for tests. Can you have a look

not quite sure yet. may still change. I'll try and work on this more later.

okay. I think I should proceed with modifying the test functions as of now. Thanks ruaok :)

yvanzo: feels like year should also use the number / count column then :)

Maybe I should rename from count to number

reosarevok: no, because 2020 as a number would be localized as 2,020.

Oh, true

So we should have a separate way to format these, huh

(also, we should move formatCount out of /statistics by now

I suspect)

I don’t feel it’s useful except if we have year columns in other tables.

reosarevok: as mentionned in comment, actual localization can be implemented later on.

Sure - I just thought it could use the same, but if not let's do it later

(it isn’t currently localized anyway)

Ok :)

yvanzo: re: the comment on https://github.com/metabrainz/musicbrainz-serve... - I left the comment on the previous commit as requested, should I change anything on the commit removing the file as well?

Also, did you manage to check the search implementation?

I think it's reasonable, but :)

reo?!

T_T y u no reply since 13 yesterday

i was kidna worried :x

Because I thought you saw me elsewhere :p

I'm fine!

saw yo uwhere?!

Here! :D

i tried talking to you for hours and i got no reply

Sowwy :) Hopefully it's all good now

reosarevok: which previous commit? can you please link to commit#line when addressing a conversation?

What you asked for https://github.com/metabrainz/musicbrainz-serve...

reosarevok: 👍

reosarevok: right, but where did you “left the comment on the previous commit as requested”?

https://github.com/metabrainz/musicbrainz-serve... :p

Didn't realize it would be hard to find :p

Anyway, that bit :)

Ok, for some reason I did not see your latest commit. (That’s why links are welcome.)

Thanks!

Figured out, clicking on the link probably reopened an outdated tab.

reosarevok: we should be able to use 'results' directly as rows

that would allow adding extra columns for data reports and user collections.

Wouldn't we just be able to pass {extracolumns} to the list if desired?

With a list of extra columns

no since data for these extra columns have to come from rows

It could be solved by adding an optional entityAccessor parameter to *List and passing this to utility functions that define 'accessor' for columns.

I mean, we have plenty of ones that go with entity => entity.whatever as a function

Wouldn't that work here too?

e.g. in ArtistList, we would have 'rows' instead of 'artists' and 'row => row.entity.sort_name' instead of 'entity => entity.sort_name'

Hmm. Not sure I follow

So that would apply for all of them, not just searches

?

(in root/components/list/ArtistList.js)

reosarevok: yes

hmm, wait :D

with above suggested entityAccessor, we would have 'row => entityAccessor(row).sort_name'

entityAccessor would just be identity function by default, and '(row) => (row.entity)' for search results.

What's the benefit compared to just changing the way we pass the results to React?

we can bundle any extra column within 'data' (Table parameter)

this can be used for reports and collections

Collections already use the default columns, unless I'm forgetting something

collections have extra data since latest schema change

yvanzo: as far as I can remember from last years summit, we planned on embedding docs in relevant code as comments. for example, API docs, Function specification, etc

yvanzo: would this also mean passing scores like that then?

Cyna: last year, BB API doc has been generated using Swagger, and it seems interesting to use it for MB WS/2: https://api.test.bookbrainz.org/1/api-docs/

reosarevok: yes

wanna modify my PR / make a separate one with an example so I can take it from there? I'm still not quite seeing it

ok, will do in a separate branch

Do base it on the same branch https://github.com/metabrainz/musicbrainz-serve... if you can? :)

Then it's easier

Ok

yvanzo: would it be an interesting gsoc project ?

I mean it certainly would be interesting but would be it qualified as a gsoc project

ruaok: I have modified the tests(not quite sure how much correct they are). But they are too much dependent on `timescale_listenstore.py` and `test.utils.py`. Most of the tests use functions in these files. Anything you have in mind I can proceed further with?

please vote to fix mess: https://beta.musicbrainz.org/edit/68186783 (instrument edit)

Cyna: I don’t think it would be enough, see it was just part of https://blog.metabrainz.org/2019/08/25/gsoc-201...

Well then I'll stick with embedding documentation to edit forms.. I'll need help with others on how to embed them

I'll convert place edit form tomorrow and then embed the documentation into it.

I also have an idea of adding tutorial of some sort as some games have where you'll have to just go through the tutorial to understand what each attribute is and how to add them. but I dont have much idea on how to implement it

yvanzo: that should be enough for pre gsoc preparation right ?

Cyna: it looks like a good start at least, depends on your ideas I guess, hopefully it should become clearer once you wrote an actual proposal.

reosarevok: is that more telling? https://github.com/yvanzo/musicbrainz-server/co...

Hi!I'm a student and I would like to participate in the project of AcusticBrain of Google Summer of Code. I have seen that I must do some task but there's some that I don't understand like the first "Install the server on your computer or use the Vagrant setup scripts". Which server are you referring to?

Josue: Welcome to the community. I think this might be what you are looking for.

Josue: Hi. It means setting up local dev environment. So you need to set up accoustic brainz server

Josue: hah, that's because we copied the text from last year (and that from the year before [and that from the year before]) and didn't update it to say to use docker

can you update the page (it's a wiki) and fix it?

_lucifer ok, thanks so much! I'm going to check it out.

alastairp So, what are the tasks I have to perform to apply? or are they same?

Josue: there are instructions in the link that _lucifer sent about how to set up the server. however, the instructions on the Summer of Code page are out of date, so it would be great if someone updates them

I was suggesting that if you want to, you can make that change

alastairp All right, what are the updates that need to be made?

Josue: just to remove the reference to vagrant, and to say that you can use docker to install the server

ruaok: https://www.meetup.com/PythonGirona/events/2695...

I can't change it. I'm having trouble with the permit.

if you get a username/password prompt, use NOSPAM for both the username and password