let's try to keep master and production as close as possible from now on.
2020-03-28 08835, 2020
ruaok
yes, please.
2020-03-28 08838, 2020
ruaok
thank you iliekcomputers !
2020-03-28 08839, 2020
ruaok
!m
2020-03-28 08846, 2020
ruaok
!m iliekcomputers
2020-03-28 08846, 2020
BrainzBot
You're doing good work, iliekcomputers!
2020-03-28 08848, 2020
ruaok
sigh. :)
2020-03-28 08845, 2020
alastairp
related to that, is there public docs about the branching method used? :)
2020-03-28 08829, 2020
ruaok
not yet, but I'm glad you'll be writing them up for us. :)
2020-03-28 08835, 2020
alastairp
you're welcome
2020-03-28 08841, 2020
alastairp
someone needs to tell me what that is first
2020-03-28 08846, 2020
alastairp
and then, I'll just copy that
2020-03-28 08825, 2020
ruaok
we don't plan to merge PRs until right before release, essentially.
2020-03-28 08820, 2020
alastairp
get all PRs ready to merge. then on release, merge to master, merge master to production, deploy production?
2020-03-28 08832, 2020
ruaok
yep. right iliekcomputers ?
2020-03-28 08855, 2020
alastairp
which means that it's either a good idea to release often, or make sure PRs are small, or both?
2020-03-28 08859, 2020
iliekcomputers
critical part of this would be to have regular releases (possibly weekly)
2020-03-28 08810, 2020
alastairp
especially when 2 PRs may be overlappin
2020-03-28 08817, 2020
iliekcomputers
otherwise it'll just be a bunch of prs based on each other
2020-03-28 08802, 2020
alastairp
if the idea is to release regularly, maybe merging to master isn't a bad idea - at least it means there'll be a centralised branch which has _all_ changes on it at once, for testing etc
2020-03-28 08806, 2020
alastairp
something to deploy to beta, etc
2020-03-28 08813, 2020
alastairp
(just throwing ideas out)
2020-03-28 08835, 2020
iliekcomputers
alastairp: yeah, i think that makes more sense
2020-03-28 08812, 2020
alastairp
but agreed that it depends strongly on keeping discipline for regular releases
2020-03-28 08852, 2020
shivam-kapila
iliekcomputers: Thanks for that :D.
2020-03-28 08814, 2020
alastairp
shivam-kapila: you pinged last night?
2020-03-28 08814, 2020
shivam-kapila
New release. Yay! 🎉
2020-03-28 08848, 2020
shivam-kapila
alastairp: Hi. Yes. Actually regarding that PSQL login. I found a fix. Can you have a look at it? I will share it as a pastebin and then push the commit
2020-03-28 08821, 2020
alastairp
shivam-kapila: use the PR, that's what we have it for
2020-03-28 08831, 2020
alastairp
it's much easier to keep the discussion all in one place
shivam-kapila: yes, but for now just the timescale branch should be sufficient.
2020-03-28 08835, 2020
shivam-kapila
alastairp: The PR is updated. Its waiting for you. :)
2020-03-28 08839, 2020
ruaok
iliekcomputers: uhm.
2020-03-28 08855, 2020
shivam-kapila
ruaok: Modified to timescale branch :)
2020-03-28 08802, 2020
ruaok
th
2020-03-28 08803, 2020
ruaok
thx
2020-03-28 08833, 2020
alastairp
shivam-kapila: it's easy. first I ignore it completely, and wait until it's been approved and merged. and then I review it, asking for a number of changes, and so the author has to do more work
2020-03-28 08839, 2020
ruaok
iliekcomputers: I dont think we've moved that yet. we moved the android package.
2020-03-28 08850, 2020
alastairp
apparently it's become a running joke now
2020-03-28 08858, 2020
iliekcomputers
:D
2020-03-28 08811, 2020
ruaok
s/become/been/
2020-03-28 08837, 2020
iliekcomputers
ruaok: we can merge the pr then, right?
2020-03-28 08846, 2020
shivam-kapila
alastairp: Well perhaps GitHub will like to honour you for your approach :p
ruaok: Just out curiousity when will you review the proposals for a final push?
2020-03-28 08825, 2020
ruaok
when I feel well enough to do so.
2020-03-28 08834, 2020
ruaok
please stop pestering me, ok?
2020-03-28 08848, 2020
CatQuest
oohh. is the new lb update on prod or beta?
2020-03-28 08857, 2020
ruaok
prod
2020-03-28 08800, 2020
iliekcomputers
CatQuest: prod
2020-03-28 08801, 2020
CatQuest
:OO
2020-03-28 08806, 2020
CatQuest goes to test right away
2020-03-28 08820, 2020
iliekcomputers
the last.fm importer definitely needs some tester love
2020-03-28 08835, 2020
shivam-kapila
ruaok: Oh sorry for that. Take care of your health.
2020-03-28 08809, 2020
CatQuest
ok first thing: it now shows in the middle of the page and not the bottom \o/
2020-03-28 08830, 2020
CatQuest
it's responisive to resising the window, good good
2020-03-28 08853, 2020
CatQuest
aand the import worked!
2020-03-28 08821, 2020
CatQuest
!m well done ListenBrainz devs! 👏
2020-03-28 08821, 2020
BrainzBot
You're doing good work, well done ListenBrainz devs! 👏!
2020-03-28 08842, 2020
CatQuest
oh. guess what i'm 33106 listens off 1,5M! so then I thought about stuff and here's an idea: how about a timeline for listens? it could easily be calculated with play count-numbers. so it could be like "months" and a graph how many accumulated listens. or you could do "year" view also
2020-03-28 08818, 2020
iliekcomputers
what do you mean by timeline?
2020-03-28 08831, 2020
CatQuest
so then like, I could see when likly I'll have listened to 33k tracks
2020-03-28 08839, 2020
CatQuest
oh i meant a grap with x time and y listens
2020-03-28 08845, 2020
CatQuest
sorry, english
2020-03-28 08857, 2020
iliekcomputers
that does sound cool
2020-03-28 08801, 2020
CatQuest
:D
2020-03-28 08812, 2020
iliekcomputers
although i guess it would be relatively linear for most people
2020-03-28 08822, 2020
iliekcomputers
i think ishaanshah[m] has something similar-ish in his proposal
2020-03-28 08854, 2020
CatQuest
possibly linear yes. but the "angle" of that linear is interesting to me. tbh
ruaok: Hi, this might be a silly question but can we get musicbrainz database on lb
2020-03-28 08816, 2020
iliekcomputers
we can get read access, yes
2020-03-28 08836, 2020
ishaanshah[m]
Oh direct read access, not through api
2020-03-28 08801, 2020
iliekcomputers
it's hard to develop for because you have to set up an entire MB environment locally
2020-03-28 08807, 2020
iliekcomputers
what's your use case here?
2020-03-28 08849, 2020
ishaanshah[m]
In my proposal I have stats which require data to be obtained from MB
2020-03-28 08811, 2020
CatQuest
oh jeez. it i devide the number of listens minus my listens on the number of users minus me it's 37 730 listens
2020-03-28 08812, 2020
ishaanshah[m]
Artist Origin and Top Genres specifically
2020-03-28 08804, 2020
CatQuest
here's another stat idea: amount listens leaderboard 😹
2020-03-28 08828, 2020
ishaanshah[m]
> here's another stat idea: amount listens leaderboard
2020-03-28 08831, 2020
ishaanshah[m]
That's actually really cool
2020-03-28 08834, 2020
iliekcomputers
ishaanshah[m]: i'd prefer to do it via the API.
2020-03-28 08856, 2020
iliekcomputers
i don't want to add musicbrainz as a dependency unless absolutely necessary.
2020-03-28 08826, 2020
ishaanshah[m]
iliekcomputers: about that, I was writing the code for the trackMBID issue that I described before
2020-03-28 08832, 2020
ishaanshah[m]
However api requests slow down the process significantly
2020-03-28 08845, 2020
ishaanshah[m]
Not to mention rate limiting
2020-03-28 08829, 2020
iliekcomputers
hmmm
2020-03-28 08841, 2020
ishaanshah[m]
As we have get such kind of data for all users, I thought direct access would be better
2020-03-28 08853, 2020
iliekcomputers
we can't really add an exception for the rate limiting because the importer works on the client.
2020-03-28 08823, 2020
CatQuest
>trackMBID
2020-03-28 08823, 2020
CatQuest
is that a fix to the problem with lastfm imported listens using a bugged recording mbid? (it uses a track mbid but website assumes recording mbid, so every single link is error)
