So I will make a PR fixing the frontend part first
2020-03-30 09005, 2020
iliekcomputers
yes
2020-03-30 09011, 2020
ishaanshah[m]1
Then look into the backend
2020-03-30 09019, 2020
iliekcomputers
hopefully that doesn't hit the ratelimit given we show what 25 listens?
2020-03-30 09031, 2020
ishaanshah[m]1
thanks for the help
2020-03-30 09011, 2020
ishaanshah[m]1
> hopefully that doesn't hit the ratelimit given we show what 25 listens?
2020-03-30 09055, 2020
ishaanshah[m]1
no it won't
2020-03-30 09026, 2020
ishaanshah[m]1
we can safely put a delay of .5 sec
2020-03-30 09004, 2020
CatQuest has quit
2020-03-30 09043, 2020
BrainzGit has quit
2020-03-30 09048, 2020
iliekcomputers
i'm not sure we wanna do that
2020-03-30 09008, 2020
iliekcomputers
that would mean the listens page would take >= 50s to load?
2020-03-30 09003, 2020
iliekcomputers
actually
2020-03-30 09009, 2020
ishaanshah[m]1
Oh, no we could do that async or something. But lets see most prolly we won't hit the limit in the first place
2020-03-30 09025, 2020
iliekcomputers
it might be a good idea to do this on the backend too
2020-03-30 09054, 2020
iliekcomputers
i'm not sure, feel free to explore what works better
2020-03-30 09028, 2020
ishaanshah[m]1
Yep, will do
2020-03-30 09008, 2020
Mineo has quit
2020-03-30 09008, 2020
aidanlw17 has quit
2020-03-30 09008, 2020
zas has quit
2020-03-30 09008, 2020
ruaok has quit
2020-03-30 09009, 2020
alastairp has quit
2020-03-30 09010, 2020
heyarne[m] has quit
2020-03-30 09010, 2020
davic has quit
2020-03-30 09034, 2020
heyarne[m] joined the channel
2020-03-30 09034, 2020
Mineo joined the channel
2020-03-30 09034, 2020
aidanlw17 joined the channel
2020-03-30 09034, 2020
zas joined the channel
2020-03-30 09034, 2020
ruaok joined the channel
2020-03-30 09034, 2020
alastairp joined the channel
2020-03-30 09034, 2020
davic joined the channel
2020-03-30 09047, 2020
CatQuest joined the channel
2020-03-30 09006, 2020
Mr_Monkey
Cyna: I'm not sure, actually. It wouldn't be a bad thing to standardize with MB, but it would probably require to change the existing entity editor to follow the same practises
2020-03-30 09010, 2020
CatQuest has quit
2020-03-30 09010, 2020
CatQuest joined the channel
2020-03-30 09039, 2020
Mr_Monkey
What's your opinion?
2020-03-30 09018, 2020
Cyna
Yea I understand that... I have gone thought the code for the forms. It would be great to follow with MB and I propose to follow the same with the Unified Form
I dont see the config.json here. It is autogenerated ?
2020-03-30 09000, 2020
rohitdandamudi
yvanzo: Thank you so much for spending your valuable time. I will post with some of the fixes that I can do now in the forum and make final changes by deadline.
And I've reproduced the error locally, let me open a ticket
2020-03-30 09041, 2020
Cyna
Great !!
2020-03-30 09003, 2020
Freso
Oh, also, everyone not in Europe heads up: Europe has switched to DST now, so meeting will be an hour earlier now for you. Meeting is in an hour from now. (ping: bitmap, Cyna, shivam-kapila, ishaanshah[m], _lucifer (not sure which of y’all are not in Europe, and maybe I missed some too, so feel free to ping others).)
2020-03-30 09045, 2020
rohitdandamudi
acknowleged
2020-03-30 09006, 2020
Cyna
How does time even work in Europe then 🤔. Specially for those with analog watches
2020-03-30 09025, 2020
Cyna
Do you change the timezone every time there is a change ?
Its twice a year.. Like in IST. We don't ever have to change time on our watches as its fixed
2020-03-30 09017, 2020
alastairp
twice a year we change the time
2020-03-30 09022, 2020
Cyna
ohh
2020-03-30 09042, 2020
iliekcomputers
Freso: can you take me off the default meeting list? I'll be around this week, but I'm not sure how often I'll be attending.
2020-03-30 09021, 2020
prabal joined the channel
2020-03-30 09052, 2020
yvanzo
rohitdandamudi: you're welcome, I made one last comment about the timeline. Note that your final application must be submitted to GSoC website too.
2020-03-30 09053, 2020
rohitdandamudi
yvanzo: noted
2020-03-30 09026, 2020
thomasross joined the channel
2020-03-30 09035, 2020
Cyna
Hey guys, I was wondering why don't we give option to users to create language incase if its not in the languages list. I don't see anything of the sort in BookBrainz
2020-03-30 09005, 2020
Cyna
neither of MusicBrainz
2020-03-30 09009, 2020
Cyna
*on
2020-03-30 09023, 2020
Mr_Monkey
I suppose the way to deal with that is to open a ticket, and someone will enter the language manually.
2020-03-30 09027, 2020
Cyna
Its a rare case but it should be covered ?
2020-03-30 09042, 2020
Mr_Monkey
I think it's something we want more control over
2020-03-30 09056, 2020
Mr_Monkey
And as you say, a rare enough case to be dealt with manually
2020-03-30 09056, 2020
Cyna
Do we have a schema of some sort for language?
2020-03-30 09000, 2020
Cyna
ohh
2020-03-30 09005, 2020
yvanzo
Another reason is static resources for editing forms depend on languages, thus changes won't be visible immediately.
It would require a schema change, yes. I would want to introduces Series as the same time, not sure that would work with the GSOC timeline
2020-03-30 09025, 2020
Cyna
Sometimes the timeline sees too large, sometimes too small :(
2020-03-30 09041, 2020
Cyna
*seems
2020-03-30 09057, 2020
sweta05 joined the channel
2020-03-30 09011, 2020
Mr_Monkey
chaban: jinx! Thanks for helping clean up the jira mess
2020-03-30 09018, 2020
Cyna
Mr_Monkey: I dont see a EntitySearchFieldOption for Artist in any of the forms.. Work, Edition, Edition Group. Is there some reason for it or does it rely on editor to add a relationship for it ?
Cyna: There is in src/client/entity-editor/relationship-editor/relationship-editor.js but the type is dynamic
2020-03-30 09053, 2020
Cyna
Yea that relies on editor to add author through relationship section right ?
2020-03-30 09052, 2020
Mr_Monkey
No, it searches for any of the types that could have a relationship with the current entity
2020-03-30 09011, 2020
Mr_Monkey
Not sure I understand the question
2020-03-30 09034, 2020
MagnusSvensson[m joined the channel
2020-03-30 09035, 2020
Cyna
I mean you have to open the relationship editor to add author to an edition or work
2020-03-30 09048, 2020
Mr_Monkey
correct
2020-03-30 09049, 2020
Cyna
You can't link it any other way, right ?
2020-03-30 09004, 2020
Mr_Monkey
right
2020-03-30 09051, 2020
CatQuest
prell
2020-03-30 09013, 2020
ruaok
Freso: I have more announcements. can I please go first again?
2020-03-30 09027, 2020
alastairp
sweta05: thanks for your proposal, I hope the feedback is useful
2020-03-30 09007, 2020
alastairp
for the patch that you're working on, feel free to open a PR - if you're only worried about the layout of the label then we can definitely discuss that on the PR instead
){kind=link}