10:27 AM
prabal
Also
2020-03-31 09104, 2020
10:28 AM
prabal
Even if Edition Name = Work Name
2020-03-31 09110, 2020
10:28 AM
prabal
i still have to add the name twice
2020-03-31 09129, 2020
10:28 AM
prabal
And if I remember correctly that's something that should be avoided
2020-03-31 09145, 2020
10:28 AM
Cyna
Ill add a copy option.. like the 2 window icon
2020-03-31 09147, 2020
10:28 AM
prabal
Mr_Monkey mentioned this at project ideas page IG
2020-03-31 09153, 2020
10:28 AM
Cyna
yea..
2020-03-31 09110, 2020
10:29 AM
Cyna
I missed so many cases :(
2020-03-31 09118, 2020
10:29 AM
Cyna
Thanks prabal :)
2020-03-31 09108, 2020
10:30 AM
prabal
You're welcome :)
2020-03-31 09125, 2020
10:32 AM
Mr_Monkey
Good suggestions ther e!
2020-03-31 09150, 2020
10:32 AM
prabal
Thanks :P
2020-03-31 09157, 2020
10:32 AM
Mr_Monkey
Cyna: I'm afraid once the proposals are posted that what we'll be going off of for selecting projects
2020-03-31 09138, 2020
10:40 AM
Mr_Monkey finally has a good reason to go outside, BBL
2020-03-31 09105, 2020
10:54 AM
d4rkie has quit
2020-03-31 09154, 2020
10:57 AM
SothoTalKer_ joined the channel
2020-03-31 09111, 2020
10:59 AM
SothoTalKer has quit
2020-03-31 09119, 2020
11:04 AM
Sophist-UK joined the channel
2020-03-31 09156, 2020
11:07 AM
D4RK-PH0ENiX joined the channel
2020-03-31 09158, 2020
11:12 AM
sweta05 has quit
2020-03-31 09148, 2020
11:13 AM
shivam-kapila has quit
2020-03-31 09102, 2020
11:29 AM
shivam-kapila joined the channel
2020-03-31 09124, 2020
11:31 AM
sweta05 joined the channel
2020-03-31 09123, 2020
11:34 AM
SothoTalKer_ has quit
2020-03-31 09137, 2020
11:39 AM
yvanzo
ping back sir rohitdandamudi
2020-03-31 09120, 2020
11:41 AM
rohitdandamudi
yvanzo: yes, shall we finalize in google doc? or here?
2020-03-31 09147, 2020
11:41 AM
yvanzo
the google doc will be the final version?
2020-03-31 09115, 2020
11:42 AM
c1e0 joined the channel
2020-03-31 09132, 2020
11:42 AM
yvanzo
I mean it is not the same version as on the forum, right?
2020-03-31 09149, 2020
11:42 AM
yvanzo
we can discuss here anyway
2020-03-31 09105, 2020
11:44 AM
rohitdandamudi
yvanzo: I have updated it(google doc)
2020-03-31 09121, 2020
11:46 AM
rohitdandamudi
All changes that I made is underlined, so it’s easier for you to read and comment.
2020-03-31 09126, 2020
11:48 AM
yvanzo
rohitdandamudi: Ok, please ping me when you updated the google doc according to comments on the forum.
2020-03-31 09125, 2020
11:50 AM
rohitdandamudi
yvanzo: Ok ..
2020-03-31 09131, 2020
11:51 AM
yvanzo
Thanks!
2020-03-31 09154, 2020
11:52 AM
c1e0_ joined the channel
2020-03-31 09114, 2020
11:55 AM
c1e0 has quit
2020-03-31 09158, 2020
11:57 AM
yvanzo
rohitdandamudi: the figure you just added looks nice!
2020-03-31 09118, 2020
12:11 PM
shivam-kapila
ruaok: Submitted final pdf. Thanks for your help :)
2020-03-31 09128, 2020
12:11 PM
ruaok
yay, np
2020-03-31 09123, 2020
12:13 PM
yvanzo
rohitdandamudi: on page 2, the <edited> snippet is the new version?
2020-03-31 09143, 2020
12:16 PM
rohitdandamudi
yup
2020-03-31 09130, 2020
12:17 PM
rohitdandamudi
yvanzo: made it more generalised as the implementation isn’t decided
2020-03-31 09146, 2020
12:17 PM
yvanzo
is the doc stable enough to be discussed here? or do you need more time to edit it?
2020-03-31 09123, 2020
12:18 PM
rohitdandamudi
give me 11 mins, will be done
2020-03-31 09144, 2020
12:18 PM
yvanzo
cool :)
2020-03-31 09139, 2020
12:29 PM
rohitdandamudi
yvanzo: it’s done,
2020-03-31 09113, 2020
12:30 PM
rohitdandamudi
please give review from beginning I hurried it.
2020-03-31 09125, 2020
12:35 PM
ruaok
shivam-kapila: I just pushed more completed functions to the timescale branch. so far've not even checked if the code compiles.
2020-03-31 09135, 2020
12:35 PM
ruaok
but hopefully I can finish this module today.
2020-03-31 09144, 2020
12:35 PM
alastairp
last minute rush. this reminds me of school, and I don't miss it one bit
2020-03-31 09156, 2020
12:35 PM
BrainzGit
2020-03-31 09157, 2020
12:35 PM
BrainzBot
2020-03-31 09104, 2020
12:36 PM
shivam-kapila
ruaok: I also found wht was freezing my code
2020-03-31 09128, 2020
12:36 PM
shivam-kapila
I will those functions first
2020-03-31 09107, 2020
12:37 PM
shivam-kapila
A silly one. My proposal didnt need any changes now na?
2020-03-31 09117, 2020
12:37 PM
shivam-kapila
pull those functions*
2020-03-31 09135, 2020
12:37 PM
ruaok
your proposal is done. don't worry about what we do with timescale in relation to your proposl.
2020-03-31 09109, 2020
12:38 PM
shivam-kapila
Just a bit tensed. Thank you :)
2020-03-31 09137, 2020
12:40 PM
reosarevok
2020-03-31 09107, 2020
12:41 PM
reosarevok
(I get "it would have been helpful to split this patch" but it's still pretty small so hopefully it can be reviewed)
2020-03-31 09124, 2020
12:42 PM
yvanzo
rohitdandamudi: do you have a link ot the readthedocs example you are showing?
2020-03-31 09112, 2020
12:44 PM
yvanzo
reosarevok: how would you review it?
2020-03-31 09157, 2020
12:45 PM
rohitdandamudi
yvanzo: you mean the sampleBrainz doc website example?
2020-03-31 09102, 2020
12:46 PM
yvanzo
yes
2020-03-31 09132, 2020
12:47 PM
reosarevok
yvanzo: by checking if the headers seem to make sense, I guess?
2020-03-31 09106, 2020
12:48 PM
reosarevok
I mean, before many of them didn't have any consistency anyway, so we might not even want to duplicate the old stuff
2020-03-31 09107, 2020
12:48 PM
rohitdandamudi
2020-03-31 09121, 2020
12:48 PM
reosarevok
I'd rather you checked it as is and thought whether it seems sensible
2020-03-31 09107, 2020
12:50 PM
shivam-kapila
ruaok: isnt the ts missing connection to `SQLALCHEMY_TIMESCALE_URI`. There is not init_ts_connection
2020-03-31 09134, 2020
12:50 PM
ruaok
say again, that wasn't very clear.
2020-03-31 09136, 2020
12:50 PM
yvanzo
rohitdandamudi: alright
2020-03-31 09108, 2020
12:53 PM
shivam-kapila
We import ts from db.timescale.py. But we need to initialize the connection to timescale db by calling init_db_connection present in db.timescale.py. That connection is missing. Please correct me if I am going wrong
2020-03-31 09124, 2020
12:55 PM
ruaok
in __init__ in timescalelistenstore.py ?
2020-03-31 09140, 2020
12:55 PM
shivam-kapila
yes
2020-03-31 09101, 2020
12:56 PM
ruaok
yep. let me add it.
2020-03-31 09149, 2020
12:56 PM
ruaok
ts.init_db_connection(conf['SQLALCHEMY_TIMESCALE_URI'])
2020-03-31 09150, 2020
12:56 PM
ruaok
right?
2020-03-31 09113, 2020
12:57 PM
shivam-kapila
yes
2020-03-31 09138, 2020
12:57 PM
ruaok
pushed.
2020-03-31 09144, 2020
12:57 PM
shivam-kapila
thanx
2020-03-31 09104, 2020
13:13 PM
yvanzo
reosarevok: I already wrote that changes seem sensible (actually "reasonable")
2020-03-31 09129, 2020
13:13 PM
reosarevok
But you didn't approve so I assumed you wanted to check more :)
2020-03-31 09136, 2020
13:14 PM
yvanzo
but these are untraceable too, doesn't this comment make sense?
2020-03-31 09118, 2020
13:15 PM
yvanzo
since you just went through old edits to check actual changes, it would have been nice to share your findings (as commit references) in commit messages.
2020-03-31 09133, 2020
13:16 PM
reosarevok
Sure, I get that, for next time I can do that
2020-03-31 09140, 2020
13:16 PM
reosarevok
2020-03-31 09101, 2020
13:17 PM
reosarevok
(titled Convert whatever_list to React)
2020-03-31 09120, 2020
13:17 PM
yvanzo
another point is it is supposed to be a fix for a bug in beta, not new changes that we won't have time to test in beta.
2020-03-31 09109, 2020
13:18 PM
reosarevok
I mean, that didn't seem like a problem when I put it up six days ago
2020-03-31 09121, 2020
13:18 PM
reosarevok
I expected to get it merged in a day or two and then it'd have had several days in beta
2020-03-31 09130, 2020
13:18 PM
reosarevok
Just didn't realize it would take longer
2020-03-31 09133, 2020
13:19 PM
Cyna
Hey Mr_Monkey, I just updated my proposal. Do have a look. Thanks :)
2020-03-31 09144, 2020
13:19 PM
yvanzo
That was an issue 6 days ago, I made a comment about making the lesser possible change.
2020-03-31 09133, 2020
13:20 PM
reosarevok
Yes, but why would we make a crap change that requires us to send yet another change immediately afterwards, when fixing it properly in one go is easy enough
2020-03-31 09102, 2020
13:21 PM
yvanzo
to release in time? :D
2020-03-31 09105, 2020
13:21 PM
reosarevok
(for a change that was more complex, I agreed, and separated the sorting bug fix and the sorting improvements)
2020-03-31 09147, 2020
13:22 PM
reosarevok
I guess :p
2020-03-31 09148, 2020
13:22 PM
reosarevok
Oh well
2020-03-31 09143, 2020
13:23 PM
yvanzo
and I didn't approve because you didn't replied, now you pinged me I just did.
2020-03-31 09144, 2020
13:24 PM
yvanzo
(not that I restrained from approving, I just already made a comment)
2020-03-31 09153, 2020
13:24 PM
BrainzGit
2020-03-31 09155, 2020
13:24 PM
BrainzBot
2020-03-31 09109, 2020
13:25 PM
reosarevok
yvanzo: ok, do you have time to release?
2020-03-31 09107, 2020
13:28 PM
yvanzo
reosarevok: not now, trying to help rohitdandamudi with his proposal before deadline in a few hours.
2020-03-31 09117, 2020
13:28 PM
reosarevok
Oh, ok
2020-03-31 09122, 2020
13:28 PM
reosarevok
I guess I could give it a go?
2020-03-31 09100, 2020
13:29 PM
reosarevok
I guess it'd be "release beta, give chaban or whoever a bit of time to see if something else broke, release prod"? :)
2020-03-31 09132, 2020
13:29 PM
yvanzo
PRs have been merged into beta already, right?
2020-03-31 09143, 2020
13:30 PM
yvanzo
maybe just retrieve latest translations before updating beta.mb.o
2020-03-31 09102, 2020
13:31 PM
reosarevok
Ok
2020-03-31 09101, 2020
13:32 PM
reosarevok
yvanzo: separately on master and beta?
2020-03-31 09118, 2020
13:32 PM
reosarevok
Or I guess I should merge beta into master somehow, or rebase it
2020-03-31 09116, 2020
13:33 PM
yvanzo
just update beta for now
2020-03-31 09134, 2020
13:33 PM
yvanzo
beta will be merged in production that will be merged in master after release
2020-03-31 09143, 2020
13:33 PM
reosarevok
Ok
2020-03-31 09134, 2020
13:35 PM
yvanzo
thanks!
2020-03-31 09140, 2020
13:40 PM
_lucifer
4 hours left in application deadline!
2020-03-31 09157, 2020
13:40 PM
gr0uch0mars
Yeah!
2020-03-31 09138, 2020
13:43 PM
_lucifer
It seems BookBrainz is the most popular *Brainz this year.
2020-03-31 09144, 2020
13:43 PM
yvanzo
rohitdandamudi: no pressure ^^
2020-03-31 09107, 2020
13:44 PM
Mr_Monkey
🥇
2020-03-31 09144, 2020
13:44 PM
_lucifer
I think 50% of the proposals are for BookBrainz.
2020-03-31 09151, 2020
13:44 PM
_lucifer
!m Mr_Monkey
2020-03-31 09151, 2020
13:44 PM
BrainzBot
You're doing good work, Mr_Monkey!
2020-03-31 09155, 2020
13:44 PM
ruaok
_lucifer: not really, no.
2020-03-31 09157, 2020
13:44 PM
alastairp
Mr_Monkey will be busy this summer, then
2020-03-31 09109, 2020
13:45 PM
Mr_Monkey
Well, uh, I'm not doing the proposals, eh !
2020-03-31 09144, 2020
13:45 PM
rohitdandamudi
I am getting so tensed haha
2020-03-31 09158, 2020
13:45 PM
shivam-kapila
me too 😶
2020-03-31 09101, 2020
13:46 PM
ruaok
of the viable proposals I've seen, 2 LB, 1 AB, 2 MB, 1BB
2020-03-31 09116, 2020
13:46 PM
ruaok
unless a pile just arrived.
2020-03-31 09135, 2020
13:46 PM
_lucifer
Some proposals have not been tagged with GSoC
2020-03-31 09138, 2020
13:46 PM
Cyna
Its getting to tense.. for sure
2020-03-31 09110, 2020
13:47 PM
ruaok
_lucifer: I'm going why what is on the gsoc site.
2020-03-31 09117, 2020
13:47 PM
_lucifer
Oh OK.
2020-03-31 09118, 2020
13:47 PM
ruaok
s/why/on
2020-03-31 09142, 2020
13:47 PM
ruaok
which is the only thing that matters. and I've already set a pile of proposals to ignore.
2020-03-31 09154, 2020
13:47 PM
ruaok
e.g if this is the first time I hear from you, bang, you're gone.
2020-03-31 09112, 2020
13:48 PM
_lucifer
Yeah, makes sense.
2020-03-31 09113, 2020
13:48 PM
yvanzo
rohitdandamudi: please ping me when you are done with diagrams and references so we can discuss the timeline finally. :)
2020-03-31 09125, 2020
13:48 PM
rohitdandamudi
yvanzo: fine :)
2020-03-31 09116, 2020
13:49 PM
_lucifer
The proposal is a document after all. Real work says more than a document.
2020-03-31 09151, 2020
13:53 PM
iliekcomputers
documents can very much be real work :D
2020-03-31 09101, 2020
13:54 PM
ruaok
and useless at the same time.
2020-03-31 09106, 2020
13:55 PM
iliekcomputers
yeah, depends on the document
2020-03-31 09140, 2020
13:55 PM
reosarevok
chaban: new beta out, do you have time to try to break it for a little while before I release it on production?
2020-03-31 09142, 2020
13:55 PM
_lucifer
its the most boring part of GSoC writing the proposal.
2020-03-31 09150, 2020
13:56 PM
shivam-kapila
One of the best part of meb is that previous GSoCers are still so much interested. Boom. What a community!
2020-03-31 09115, 2020
13:59 PM
chaban
reosarevok: not right now. Maybe in ca. 30min
