It'd be nice for you to step me through how to deploy AB some time if you have time. Today/tomorrow?
2020-04-02 09358, 2020
ruaok notes that there is still no PR for the meb team page
2020-04-02 09358, 2020
alastairp
oh yeah, you're one of _those_ bosses, huh? :)
2020-04-02 09358, 2020
alastairp
PR incoming today
2020-04-02 09358, 2020
alastairp
I even found a photo of myself!
2020-04-02 09358, 2020
alastairp
ruaok: what's the process for updating syswiki? just make a change, or make a PR?
2020-04-02 09358, 2020
ruaok
normally skip the PR
2020-04-02 09358, 2020
ruaok
alastairp: I only nag the people who don't do what they should've already done. :)
2020-04-02 09358, 2020
alastairp
k, thanks
2020-04-02 09353, 2020
iliekcomputers
alastairp: today evening should work for me.
2020-04-02 09323, 2020
BestSteve has quit
2020-04-02 09306, 2020
BestSteve joined the channel
2020-04-02 09335, 2020
alastairp
iliekcomputers: if that's within the next 3-4 hours, perfect
2020-04-02 09352, 2020
alastairp
oh, I guess you're in more or less the same tz as me. what time do you finish?
2020-04-02 09352, 2020
ABCbum joined the channel
2020-04-02 09342, 2020
iliekcomputers
5 PM mostly
2020-04-02 09359, 2020
ABCbum has quit
2020-04-02 09335, 2020
byyz joined the channel
2020-04-02 09335, 2020
byyz
hey guys, quick question. It looks like XML genre/tags data is sorted alphabetically instead of by popularity(?). For example, https://musicbrainz.org/artist/39c2a93d-9afa-4a22… correctly has psychedelic as the top genre for Jefferson Airplane, but the XML data is listed alphabetically so it shows folk as the genre if pulling the top result. Since I dont know how many genres each artist has, I'm not sure how to pull the correct
2020-04-02 09335, 2020
byyz
one each time (in this case I should pull 4). Any ideas?
2020-04-02 09338, 2020
alastairp
cool. how about 6pm/7pm?
2020-04-02 09303, 2020
iliekcomputers
6 pm would be nice
2020-04-02 09332, 2020
Lotheric_ joined the channel
2020-04-02 09306, 2020
Lotheric has quit
2020-04-02 09338, 2020
shivam-kapila
ruaok: I think we need to modify the `fetch_recent_listens_for_users`
2020-04-02 09309, 2020
ruaok
k, what needs to be done?
2020-04-02 09320, 2020
shivam-kapila
The reason being when we apply limit say 2 then it will fetch only 2 rows rather than 2 per user
2020-04-02 09336, 2020
shivam-kapila
so we need output as 4 rows but it will return only 2
2020-04-02 09358, 2020
shivam-kapila
did I explain properly?
2020-04-02 09308, 2020
sweta05 joined the channel
2020-04-02 09323, 2020
ruaok
yes. I see. ok, hang on.
2020-04-02 09325, 2020
alastairp
byyz: how are you getting these tags? from the webservice? I'm not sure I understand your problem
2020-04-02 09350, 2020
alastairp
to get the most popular tag, yes you will need to load all tags + their counts, and order by count yourself
2020-04-02 09338, 2020
ruaok
shivam-kapila: confirmed. let me see how to best fix.
2020-04-02 09357, 2020
shivam-kapila
ruaok: Also you need to modify the lines 250-260 as
ruaok: We can iterate per user as we did in influx
2020-04-02 09349, 2020
ruaok
influx is stupiud, whereas postgres is much smarter. it would be better to have postgres do it.
2020-04-02 09304, 2020
ruaok
so, missing is the tuple() around user_list?
2020-04-02 09329, 2020
shivam-kapila
removed the () in the query around user_list
2020-04-02 09351, 2020
shivam-kapila
and ORDER BY time to ORDER BY listened_at
2020-04-02 09339, 2020
sweta05
iliekcomputers: https://pasteboard.co/J1XuLSu.png have a look at the checkbox, i tried to change a bit. Let me know if there are still some changes to be made.
2020-04-02 09319, 2020
iliekcomputers
sweta05: that looks good to me!
2020-04-02 09326, 2020
shivam-kapila
ruaok: and args need not be in sqlalchemy.text(). It gives bind error.
2020-04-02 09352, 2020
ruaok
ok.
2020-04-02 09308, 2020
sweta05
iliekcomputers: great! shall i go ahead and commit these changes?
2020-04-02 09326, 2020
iliekcomputers
yes, in general feel free to push changes and ask for reviews on the PR
2020-04-02 09340, 2020
alastairp
sweta05: oh, I was going to make a comment on the PR too about that ccheckbox :)
2020-04-02 09357, 2020
alastairp
it seems like the most amount of work for such a small part of the page :)
2020-04-02 09327, 2020
alastairp
I told you to order it as [box] [text] because that's the order that it was in the new dataset page. but then when I saw your changes I realised that on the import page we have [label] [input] for all other fields, and we should make them consistent
2020-04-02 09349, 2020
alastairp
sorry about that, I didn't pay enough attention to the layout of that page before suggesting that you change it
2020-04-02 09354, 2020
sweta05
alastairp: Yeah initially, even i thought of the same but i felt the checkbox and the text were little far away so i tried having the text before the checkbox.
2020-04-02 09332, 2020
sweta05
it is always good to maintain consistency right, so i think it is better this way.
