Mr_Monkey: I am continuing with PR #408 making myself comfortable with end to end tests. I have even written some basic tests which I would show you once they are done
2020-04-20 11100, 2020
Mr_Monkey
đź‘Ť
2020-04-20 11102, 2020
Chinmay3199
I think I should continue with tests only. Thanks
2020-04-20 11107, 2020
ruaok
iliekcomputers: how does one deal with merge conflicts in package-lock.json in LB? its a generated file and I've got a massive conflict while trying to rebase the timescale branch
2020-04-20 11106, 2020
alastairp
what's the url for granfa again?
2020-04-20 11120, 2020
Mr_Monkey
ruaok: if you installed a new package in the branch, then use the branch's package-lock file. If not, then use the master file
stats. that's it. I tried statistics, logs, granfa
2020-04-20 11100, 2020
ruaok
Mr_Monkey: ok. thanks.
2020-04-20 11140, 2020
Mr_Monkey
Cyna: So you could do `const relationshipSet = await author.relationshipSet()` followed by `const relationships = relationshipSet.relationships()`, or…
2020-04-20 11106, 2020
alastairp
zas: hi. can you explain to me what kind of http log stats we can do on granfa?
2020-04-20 11126, 2020
alastairp
Ideally I'd like to be able to see how many POSTs we get, as well as how many GETs to a specific URL prefix
not urgent at all, it's just the next thing on my list that I was looking at
2020-04-20 11134, 2020
shivam-kapila
iliekcomputers: Hi. Are you here?
2020-04-20 11139, 2020
alastairp
would you like an issue on mbstats, a ticket on jira....?
2020-04-20 11100, 2020
zas
create an MBH ticket on Jira
2020-04-20 11133, 2020
shivam-kapila
ruaok: Hi. There is still some timing issue between timescale_writer and RabbitMQ. When we run `develop.sh up` by the time it starts the timescale writer, the rabbitMQ pipeline is still not up. So the writer exits. Did you get me?
2020-04-20 11109, 2020
zas
basically that's adding the method field to special log format, and adding parsing code so we can output this to influx
2020-04-20 11129, 2020
ruaok
yes, I've been trying to figure out what is going on there, shivam-kapila.
2020-04-20 11148, 2020
ruaok
it breaks when do I an import,but not when i record a single listen.
2020-04-20 11153, 2020
alastairp
Freso: MBH-292 looks fixed to me. can you confirm?
ruaok: Might be possible that just after writing 1st listen it exits.
2020-04-20 11124, 2020
ruaok
using the submit.py script that is in the docs, I can enter hundreds and the pipeline works.
2020-04-20 11156, 2020
ruaok
I've been working to rebase the timescale branch on master. I stopped trying to use rebase and I've made a new branch.
2020-04-20 11122, 2020
ruaok
the merge was much cleaner, but now there are two tests failing that need to be resolved.
2020-04-20 11139, 2020
ruaok
but they are minor. let me look at timescale_writer exiting
2020-04-20 11110, 2020
shivam-kapila
Oh. I can have a look at the tests. I haven't tested much as that stupid brainzutils error took my whole weekend.
2020-04-20 11157, 2020
ruaok
ok, look. at `timescale-rebased`
2020-04-20 11106, 2020
shivam-kapila
Okay
2020-04-20 11140, 2020
shivam-kapila
iliekcomputers: Please ping me when you got some time. The brainzutils error is finally done. I need to know your views on my approach.
2020-04-20 11129, 2020
iliekcomputers
shivam-kapila: hey
2020-04-20 11139, 2020
iliekcomputers
can you open a PR and I'll take a look
2020-04-20 11140, 2020
iliekcomputers
?
2020-04-20 11147, 2020
shivam-kapila
I will
2020-04-20 11110, 2020
iliekcomputers
thanks
2020-04-20 11131, 2020
iliekcomputers
base off master, because from what I understand the issue should be in master too
2020-04-20 11103, 2020
iliekcomputers
(so as to not complicate the timescale branch with an unrelated issue)
2020-04-20 11104, 2020
shivam-kapila
Actually I just used pip install --upgrade instead of pip install in requirements.txt. Messybrainz is based on brainzutilsv1.10.0 which didnt have the methods in cache.py
2020-04-20 11100, 2020
shivam-kapila
Should I use --upgrade flag with all pip installs. I had this doubt.
2020-04-20 11108, 2020
iliekcomputers
I do not think that is a good idea
2020-04-20 11122, 2020
iliekcomputers
that would upgrade everything to the latest version which would lead to breakages
2020-04-20 11129, 2020
shivam-kapila
I am afraid it might break some code
2020-04-20 11138, 2020
shivam-kapila
Yes. Same
2020-04-20 11154, 2020
iliekcomputers
let's just upgrade brainzutils in messybrainz
2020-04-20 11120, 2020
shivam-kapila
Will that be able to solve issue? Bkz if someone is using the projects already, they will have older versions of brainzutils and the docker build will skip upgrading it in that case. It returns `Requirement already satisfied`
2020-04-20 11134, 2020
shivam-kapila
I saw that my LB is based on v1.8.0(I dont know how even when MsB was on v1.10.1) and it didnt upgrade that.
2020-04-20 11158, 2020
shivam-kapila
I searched on livegrep from where its getting v1.8.0 but no use
2020-04-20 11103, 2020
iliekcomputers
we're trying to fix the problem in production first, and i'll rebuild to fix it
2020-04-20 11118, 2020
alastairp
shivam-kapila: docker build doesn't work like that. If you update requirements.txt then the dependencies will be installed again from scratch
2020-04-20 11156, 2020
iliekcomputers
someone needs to make messybrainz a package in pip
2020-04-20 11158, 2020
iliekcomputers
:D
2020-04-20 11108, 2020
iliekcomputers
the github clone stuff is not ideal
2020-04-20 11117, 2020
shivam-kapila
+1
2020-04-20 11138, 2020
shivam-kapila
MsB and Brainzutils should be in pip.
2020-04-20 11117, 2020
shivam-kapila
alastairp: But why didnt I upgrade to 1.10.1 from 1.8.0? Did I do something wrong.
2020-04-20 11139, 2020
iliekcomputers
livegrep has been very behind
2020-04-20 11152, 2020
alastairp
I don't know the specific steps that you did, but that should be the case
2020-04-20 11101, 2020
iliekcomputers
there are no typescript files in there yet
2020-04-20 11110, 2020
iliekcomputers
we merged those like a week ago
2020-04-20 11112, 2020
shivam-kapila
Yeah. I noticed that too
2020-04-20 11127, 2020
alastairp
however, if you're talking about listenbrainz + messybrainz + dependencies, then there might be some additional complications
2020-04-20 11151, 2020
shivam-kapila
alastairp: There are so many dependency hierarchies
2020-04-20 11107, 2020
alastairp
iliekcomputers: it might be interesting to see how to put messybrainz in lb's requirements.txt, which would remove the git clone stuff
here's a radical idea: merge messybrainz into listenbrainz, it isn't used anywhere else, there's lots of duplicated code. there'd be one requirements.txt so no conflicts, no need to do the git clone OR pip install :D
2020-04-20 11146, 2020
alastairp
yeah, that's not a crazy idea
2020-04-20 11108, 2020
alastairp
originally messybrainz was a separate webservice, but for reasons that was stopped
2020-04-20 11109, 2020
ruaok
can't really argue against it.
2020-04-20 11127, 2020
alastairp
so, put it as a separate package in lb and remove all the webservice stuff
2020-04-20 11137, 2020
Zastai
CatQuest: transclusion seems to be based on a specific table (https://beta.musicbrainz.org/admin/wikidoc) - your page is not in that list, which I think is why it has "This page has not been reviewed by our documentation team" at the top
2020-04-20 11138, 2020
iliekcomputers
+1
2020-04-20 11147, 2020
ruaok
I'm ok with that.
2020-04-20 11127, 2020
Zastai
CatQuest: I'm not sure how update propagation works for page not in that table; it probably requires a "transclusion editor" to push a button
2020-04-20 11137, 2020
BrainzGit
[musicbrainz-server] mwiencek opened pull request #1475 (master…csrf): MBS-10717, MBS-10778: Set SameSite=None on session cookie and add CSRF tokens to user/admin forms https://github.com/metabrainz/musicbrainz-server/…
shivam-kapila: huh, I just saw that - I don't know why we install messybrainz both from requiremets.txt and using git clone in the Dockerfile. that's definitely wrong
2020-04-20 11148, 2020
iliekcomputers
i haven't looked at that stuff in a long time, but i have a feeling the git clone is needed because we create the messybrainz schema in dev which needs the sql files
2020-04-20 11140, 2020
alastairp
ah, that might be the case. however, if that was the reason then an alternative solution would have been to install the sql files into the package when installing from pip
>It looks like RabbitMQ is closing your connection on you, perhaps because you're redeclaring an exchange that is already declared with different parameters?
2020-04-20 11141, 2020
iliekcomputers
could this be happening somewhere
2020-04-20 11126, 2020
ruaok
interesting. what is weird about it is that it happens after running fine for a while.
2020-04-20 11151, 2020
alastairp
zas: FYI I deleted 50GB of data from boingo, in case you have reporting and noticed something funny
Mr_Monkey: I have a suggestion for entity.js file.. We have to all tests for all the functions in entity.js to ensure they are working properly. It would help avoid errors and provide clarity
2020-04-20 11115, 2020
Cyna
For example, getEntityByBbid() could surely use test case to verify cases like if entityBbid exist or not
2020-04-20 11143, 2020
chaban
!m bitmap for adding CSRF tokens
2020-04-20 11143, 2020
BrainzBot
You're doing good work, bitmap for adding CSRF tokens!
2020-04-20 11153, 2020
Mr_Monkey
If you're suggesting adding more tests where tests are missing, I 100% agree !
2020-04-20 11126, 2020
Mr_Monkey
As for the length, try seeing what authorRelationships.toJSON() gives you
People up for reviews: yvanzo, bitmap, pristine__, ruaok, Mr_Monkey, Freso, zas, alastairp, reosarevok, shivam-kapila, _lucifer, Cyna,CatQuest, ishaanshah[m] – anyone else who wants to give review, please let me know ASAP. :)
2020-04-20 11106, 2020
Freso
yvanzo: Go!
2020-04-20 11129, 2020
yvanzo
Hi!
2020-04-20 11148, 2020
yvanzo
Last week, I released a new version of MBS and updated beta.
2020-04-20 11124, 2020
yvanzo
I finally merged, deployed, tested, fixed, and redeployed MBS-10546.
