that's the only one that is borked. the first one is wrong.
2020-05-04 12508, 2020
ruaok
make me a ticket.
2020-05-04 12512, 2020
reosarevok
Ok, fine :) Will do!
2020-05-04 12516, 2020
ruaok
yvanzo: what should I do with your invoice?
2020-05-04 12517, 2020
yvanzo
if reosarevok is invalid, he should have an allowance.
2020-05-04 12535, 2020
reosarevok
yvanzo: I don't think English uses that word like Spanish and French do :)
2020-05-04 12551, 2020
yvanzo
ruaok: just ignore the first PDF.
2020-05-04 12522, 2020
ruaok
ah, then the transfer I just cancelled was correct.
2020-05-04 12544, 2020
reosarevok
alastairp and our Indian peeps: so, we've had a request for Carnatic classical and Hindustani classical as genres :) What would be the best name for them? "carnatic" or "carnatic classical" or something else?
2020-05-04 12551, 2020
reosarevok knows nothing about these
2020-05-04 12514, 2020
yvanzo
ruaok: got it, sorry again, I did not reply to the right email...
2020-05-04 12503, 2020
ruaok
should be on the way.
2020-05-04 12520, 2020
yvanzo
I thought I sent you the file for March but actually did not check the right email.
MEB-115: Can't check donation status for users with slashes in their names
2020-05-04 12527, 2020
thomasross joined the channel
2020-05-04 12527, 2020
reosarevok
(I understand it's fairly minor, unless it also affects more important bits and some customers have slashes in their names, but worth keeping track of I guess :)
2020-05-04 12536, 2020
yvanzo
reosarevok: so that is a private joke :)
2020-05-04 12540, 2020
shivam-kapila
Also can we bring BrainzGit back too. It went away on Saturday
2020-05-04 12541, 2020
yvanzo
reosarevok: does someone actually encounter this bug?
2020-05-04 12534, 2020
reosarevok
Anyone who goes to their donation tab with a slash in their name
2020-05-04 12538, 2020
reosarevok
So, one of the 137 :p
2020-05-04 12554, 2020
yvanzo
reosarevok: or is the bug that anyone can check donation nags of any user?
2020-05-04 12523, 2020
reosarevok
As I said, minor, if that's all that happens, but if it means the entire meb.org system was based on the assumption usernames can't contain a slash, then it might be a problem in some way :)
2020-05-04 12538, 2020
reosarevok
yvanzo: well, that's a separate question, dunno if ruaok thinks this should be closed in some way :)
2020-05-04 12559, 2020
reosarevok
Usernames are publicly listed as donors though so it's probably fine?
2020-05-04 12525, 2020
shivam-kapila
reosarevok: Looks like Hindustani Classical is set of 6 genres
2020-05-04 12534, 2020
shivam-kapila
`Śāstriya Saṅgīt` is the other name for it and IMO it goes best
2020-05-04 12543, 2020
nawcom has quit
2020-05-04 12540, 2020
nawcom joined the channel
2020-05-04 12546, 2020
ruaok
reosarevok: fixed and deployed.
2020-05-04 12555, 2020
ruaok
I hope that we can move on to something else super critical now.
2020-05-04 12514, 2020
jmp_music has quit
2020-05-04 12526, 2020
reosarevok
Thanks! Let's see
2020-05-04 12511, 2020
ishaanshah[m]
iliekcomputers: I have added the test that you asked. I couldn't figure out the deletion. I will have a look at that later as it is not that important right now. I will start working on the API endpoint for stats. I will open a ticket for the deletion nevertheless.
2020-05-04 12554, 2020
iliekcomputers
great, thanks!
2020-05-04 12509, 2020
Chinmay3199 has quit
2020-05-04 12555, 2020
reosarevok
PR sent up, thanks ruaok <3
2020-05-04 12505, 2020
reosarevok
yvanzo: did you have the BrainzGit powers?
2020-05-04 12533, 2020
iliekcomputers
ishaanshah[m]: can you link the ticket to the `dev env and docs` epic
ishaanshah[m]: can you mark stuff you're working on as "In progress" on JIRA? makes things easier to track
2020-05-04 12552, 2020
iliekcomputers
shivam-kapila: you too
2020-05-04 12503, 2020
ishaanshah[m]
Done
2020-05-04 12504, 2020
alastairp
reosarevok: you could always just add them as 'carnatic' and 'hindustani' and wait until someone asks you for something more specific
2020-05-04 12530, 2020
reosarevok
alastairp: I was considering that, I just wasn't sure whether that implies the "classical"
2020-05-04 12538, 2020
reosarevok
Like, is there carnatic hip hop or something :D
2020-05-04 12500, 2020
alastairp
my feeling is no
2020-05-04 12518, 2020
alastairp
it'd be like saying classical baroque, I think
2020-05-04 12521, 2020
iliekcomputers
ishaanshah[m]: let's start tagging pull requests with jira tickets too, as long as it's reasonable. the jira tickets should close automatically when the PR gets merged then.
2020-05-04 12549, 2020
iliekcomputers
title "LB-xyz: fix a bug" vs "fix a bug"
2020-05-04 12503, 2020
shivam-kapila
iliekcomputers: They dont close automatically as of now. They are marked resolved though
2020-05-04 12524, 2020
alastairp
ruaok: I used to write invoices in latex, but it became annoying and complex to maintain
2020-05-04 12538, 2020
iliekcomputers
i don't know what the difference is, shivam-kapila
2020-05-04 12545, 2020
alastairp
I feel really bad for using a _spreadsheet_ now, but ohwell, as long as it works...
2020-05-04 12549, 2020
iliekcomputers
as long as they're marked "done", i'm ok with it
2020-05-04 12510, 2020
iliekcomputers
alastairp: the amount of things I use spreadsheets for now has been surprising :D
2020-05-04 12519, 2020
reosarevok
As a database?
2020-05-04 12524, 2020
alastairp
iliekcomputers: yeah, I just noticed that with AB PRs, it marks them as Fixed, but doesn't actually close them
2020-05-04 12534, 2020
reosarevok
(I also use a spreadsheet for my invoices)
2020-05-04 12546, 2020
alastairp
imo, that's a pretty good tradeoff - that is, fixed means merged into master. I manually mark as closed when actually deployed
2020-05-04 12524, 2020
iliekcomputers
yeah, that makes sense. as long as it updates the status to something that comes after "in progress" i'm ok with it :D
2020-05-04 12528, 2020
BrainzGit joined the channel
2020-05-04 12523, 2020
yvanzo
reosarevok: I don't have special powers, I just restart it ^ when it goes missing, see the syswiki.
I'll just merge that into the timescale-rebased branch.
2020-05-04 12524, 2020
shivam-kapila
I will rebase over it and push then
2020-05-04 12530, 2020
ruaok
k
2020-05-04 12559, 2020
iliekcomputers
sorry about that, i was cleaning up and thought that it might have been merged into the timescale branch already
2020-05-04 12513, 2020
ruaok
no biggie.
2020-05-04 12520, 2020
ruaok
as you said, we can easily re-open things.
2020-05-04 12505, 2020
ruaok
shivam-kapila: those failing tests you fixed, did you push them to your timescale-rebased?
2020-05-04 12534, 2020
shivam-kapila
The listenbrainz_ts ones?
2020-05-04 12543, 2020
ruaok
yes
2020-05-04 12552, 2020
shivam-kapila
Yeah they are up. Verified
2020-05-04 12518, 2020
ruaok
I'm commit af8af39d6b5001 after merging your timescale rebase branch into mine.
2020-05-04 12557, 2020
ruaok
I have no container up when I started, but test.sh fails with `FATAL: database "timescale_lb" does not exist`
2020-05-04 12527, 2020
ruaok
anything else I need to clean up that I am forgetting?
2020-05-04 12550, 2020
shivam-kapila
Did you give test.sh -d a try?
2020-05-04 12543, 2020
ruaok
shivam-kapila: no change, since I had no containers up at all.
2020-05-04 12501, 2020
shivam-kapila
ruaok: I will check once
2020-05-04 12533, 2020
ruaok
pushing that branch to main repo
2020-05-04 12527, 2020
shivam-kapila
Thanks
2020-05-04 12534, 2020
alastairp
yvanzo: jenkins warns that it has a number of security upgrades available and should be upgraded. Do you want to collaborate on updating this?
2020-05-04 12501, 2020
alastairp
I recall that we also maybe had a pending task for cleaning up old build images in docker on williams because of jenkins. I see that there are > 2000 old images there. Happy to help work out a better way to deal with this
alastairp: Why note but I never touched it before. We should probably get in touch with bitmap for potential caveats/tips.
2020-05-04 12557, 2020
yvanzo
s/note/not/
2020-05-04 12543, 2020
alastairp
I recall you had some ideas a few years ago when we raised it as a possible problem. e.g. a solution may be to use LABELs in the Dockerfile, and then have a post-test job to clean up all images that match a label
2020-05-04 12520, 2020
dseomn joined the channel
2020-05-04 12502, 2020
bitmap
alastairp: I usually just upgrade all the outdated packages and fix anything if it breaks (but don't think I've had anything break yet)
