15:10 PM
bitmap
ah I was thinking of plugins
2020-05-04 12501, 2020
15:11 PM
alastairp
yvanzo: yes, that kind of label
2020-05-04 12517, 2020
15:11 PM
bitmap
for jenkins itself I just rebuild the image and restart the container
2020-05-04 12520, 2020
15:12 PM
alastairp
cool. I see the start script for it. just runs on :master I see
2020-05-04 12531, 2020
15:12 PM
bitmap
yep
2020-05-04 12559, 2020
15:12 PM
bitmap
there are supposed to be some steps in the execute shell config for each project to clean up unused images, but I don't think it works well
2020-05-04 12503, 2020
15:13 PM
alastairp
ok, I'll try that this week. I see a few musicbrainz projects run on jenkins, I hope I don't break it
2020-05-04 12509, 2020
15:13 PM
yvanzo
2020-05-04 12519, 2020
15:13 PM
alastairp
there's definitely none in AcousticBrainz
2020-05-04 12530, 2020
15:13 PM
alastairp
let me do an audit of existing projects and add them if necessary
2020-05-04 12532, 2020
15:13 PM
yvanzo
to be fair, there are none in most of our projects
2020-05-04 12534, 2020
15:13 PM
bitmap
hmm weird
2020-05-04 12551, 2020
15:13 PM
alastairp
jenkinsbuildjenkinsacousticbrainzserver456_acousticbrainz latest 6d486c7b5238 12 months ago 1.36GB
2020-05-04 12554, 2020
15:13 PM
bitmap
2020-05-04 12507, 2020
15:14 PM
alastairp
jenkinsbuildjenkinsmetabrainzorg449_db_test latest b42127213e96 12 months ago 264MB
2020-05-04 12509, 2020
15:14 PM
bitmap
I modified them for musicbrainz-selenium, which may have actually fixed things
2020-05-04 12525, 2020
15:14 PM
alastairp
OK, I'll look at what's there and come back if I have any questions
2020-05-04 12536, 2020
15:14 PM
yvanzo
2020-05-04 12500, 2020
15:15 PM
yvanzo
2020-05-04 12508, 2020
15:15 PM
alastairp
does anything else important run on williams?
test.mb.org and ftp? just in case I break docker
2020-05-04 12544, 2020
15:15 PM
bitmap
mb json dumps run there
2020-05-04 12559, 2020
15:15 PM
bitmap
but I'll get notificatiosn if those break :)
2020-05-04 12504, 2020
15:16 PM
bitmap
notifications*
2020-05-04 12523, 2020
15:16 PM
alastairp
ok, cool
2020-05-04 12525, 2020
15:16 PM
alastairp
thanks
2020-05-04 12526, 2020
15:16 PM
yvanzo
test.mb.o is meant to be broken.
2020-05-04 12544, 2020
15:17 PM
bitmap
and yeah, looks like for the selenium config I just used a hardcoded container name that it rm -fv's after each run
2020-05-04 12555, 2020
15:17 PM
yvanzo
williams runs mb search dumps too but only twice a week (next time on Wednesday)
2020-05-04 12555, 2020
15:17 PM
bitmap
whereas the meb one tries to do something fancy with the build tag
2020-05-04 12545, 2020
15:18 PM
bitmap
since it doesn't run multiple builds simultaneously anyway the fixed name should be fine
2020-05-04 12553, 2020
15:20 PM
rohitdandamudi joined the channel
2020-05-04 12502, 2020
15:22 PM
alastairp
the images have the jenkins build number in them anyway, so this will always be unique to the specific build, you're right that it might just be easier to remove it based on its name
2020-05-04 12534, 2020
15:26 PM
reosarevok
navap: your PR seems fine, if you are around and can be bothered then maybe you can also add the MBS ticket number to the commit title (as with the PR title, "MBS-10804: Remove redundant header with editor name"), but if not I'll merge it in a bit :)
2020-05-04 12535, 2020
15:26 PM
BrainzBot
2020-05-04 12540, 2020
15:26 PM
reosarevok
Not a big deal
2020-05-04 12504, 2020
15:27 PM
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews, PG extensions (bitmap)
2020-05-04 12511, 2020
15:28 PM
alastairp
iliekcomputers: remind me how you make releases on github after making a new version?
2020-05-04 12559, 2020
15:28 PM
alastairp
git tag $version; git push --tags, then go to releases -> draft new release, use that tag as the tag version?
2020-05-04 12508, 2020
15:29 PM
iliekcomputers
2020-05-04 12515, 2020
15:29 PM
iliekcomputers
Yep
2020-05-04 12534, 2020
15:29 PM
iliekcomputers
Actually, I realized recently that you don't necessarily need to tag yourself either
2020-05-04 12535, 2020
15:29 PM
alastairp
and is it github, or this release-drafter that fills in the release with PRs?
2020-05-04 12556, 2020
15:29 PM
alastairp
right, if you make the release from the interface, it'll make the tag?
2020-05-04 12503, 2020
15:30 PM
iliekcomputers
Yep
2020-05-04 12504, 2020
15:30 PM
alastairp
you use a lightweight tag, right?
2020-05-04 12524, 2020
15:30 PM
alastairp
(git tag, not git tag -m)
2020-05-04 12524, 2020
15:30 PM
iliekcomputers
Release drafter fills in the PRs
2020-05-04 12532, 2020
15:30 PM
iliekcomputers
Yeah, git tag
2020-05-04 12546, 2020
15:30 PM
alastairp
how did you fill in the PRs before?
2020-05-04 12544, 2020
15:31 PM
iliekcomputers
By hand. :/
2020-05-04 12551, 2020
15:31 PM
alastairp
oh, that's fun
2020-05-04 12556, 2020
15:31 PM
alastairp
might install release-drafter then :)
2020-05-04 12501, 2020
15:32 PM
iliekcomputers
Heh, yeah :D
2020-05-04 12520, 2020
15:41 PM
shivam-kapila
ruaok: The Travis tests are passing. I am unable to run tests due to a different error
2020-05-04 12509, 2020
15:42 PM
shivam-kapila
Can you once run `./develop.sh timescale`
2020-05-04 12551, 2020
15:45 PM
BrainzGit
2020-05-04 12543, 2020
15:48 PM
yokel has quit
2020-05-04 12511, 2020
15:49 PM
yokel joined the channel
2020-05-04 12513, 2020
15:51 PM
ruaok
shivam-kapila: `psql: FATAL: password authentication failed for user "listenbrainz_ts"`
2020-05-04 12514, 2020
15:54 PM
shivam-kapila
2020-05-04 12504, 2020
15:55 PM
shivam-kapila
I guess you need to build timescale tables with listenbrainz_ts after dropping old ones
2020-05-04 12545, 2020
15:55 PM
shivam-kapila
Sorry the command is `./develop.sh manage init_ts_db -f`
2020-05-04 12558, 2020
15:55 PM
yvanzo
alastairp, bitmap: any clue about _reliably_ retrieving a PGP key in a Dockerfile?
2020-05-04 12526, 2020
15:56 PM
bitmap
I've just put them in the repo and COPY it in
2020-05-04 12504, 2020
15:57 PM
yvanzo
2020-05-04 12529, 2020
15:57 PM
ruaok
`FATAL: database "timescale_lb" does not exist`
2020-05-04 12543, 2020
15:57 PM
cloverfield has quit
2020-05-04 12547, 2020
15:57 PM
yvanzo
But it does not seem reliable enough, next step would be to query a different server at each attempt, might be overkill.
2020-05-04 12553, 2020
15:58 PM
yvanzo
bitmap: yup, but these ones are changed too frequently.
2020-05-04 12520, 2020
15:59 PM
bitmap
oh, the yarn one
2020-05-04 12524, 2020
15:59 PM
shivam-kapila
ruaok: Can you send the complete logs?
2020-05-04 12546, 2020
15:59 PM
bitmap
2020-05-04 12500, 2020
16:00 PM
ruaok
2020-05-04 12509, 2020
16:01 PM
cloverfield joined the channel
2020-05-04 12511, 2020
16:01 PM
yvanzo
bitmap: Thanks but it just uses another keyserver, which might be more reliable but the same error can occur as well. Will use that one and loop over servers on retry.
2020-05-04 12512, 2020
16:02 PM
bitmap
how often do the keyservers fail?
2020-05-04 12507, 2020
16:03 PM
yvanzo
2020-05-04 12530, 2020
16:03 PM
shivam-kapila
ruaok: Looks like it did what I wanted. Please run `./develop.sh manage init_ts_db --create-db`
2020-05-04 12551, 2020
16:03 PM
shivam-kapila
If it succeeds we have the new configs for timescale then
2020-05-04 12551, 2020
16:03 PM
alastairp
I recall that I had some weird issues with this keyserver on docker when building python images
2020-05-04 12504, 2020
16:04 PM
alastairp
but now I can't remember what the actual issue was and how I fixed it, sorry
2020-05-04 12515, 2020
16:04 PM
ruaok
2020-05-04 12520, 2020
16:04 PM
alastairp
it just seemed like it was broken and I went around in circles trying to fix it, then suddenly it was fine
2020-05-04 12503, 2020
16:05 PM
shivam-kapila
ruaok: Going good. Revert the drop_db file to listenbrainz_ts and run `/develop.sh manage init_ts_db -f\`
2020-05-04 12521, 2020
16:05 PM
Zastai|2 joined the channel
2020-05-04 12528, 2020
16:05 PM
shivam-kapila
Not the \ please
2020-05-04 12501, 2020
16:06 PM
ruaok
2020-05-04 12530, 2020
16:07 PM
shivam-kapila
Seems like you havent copied the config
2020-05-04 12532, 2020
16:07 PM
shivam-kapila
`cp listenbrainz/config.py.sample listenbrainz/config.py`
2020-05-04 12507, 2020
16:08 PM
shivam-kapila
Then try `/develop.sh manage init_ts_db -f` again
2020-05-04 12538, 2020
16:08 PM
ruaok
shit, you're right sorry. :(
2020-05-04 12505, 2020
16:09 PM
shivam-kapila
I remembered because I wasted 3 hours on that.
2020-05-04 12513, 2020
16:09 PM
Zastai has quit
2020-05-04 12518, 2020
16:09 PM
Zastai|2 is now known as Zastai
2020-05-04 12534, 2020
16:09 PM
cloverfield has quit
2020-05-04 12538, 2020
16:09 PM
shivam-kapila
Now either your tests will pass or you will get the messybrainz error I am getting
2020-05-04 12512, 2020
16:10 PM
ruaok
tests looking much better now.
2020-05-04 12524, 2020
16:10 PM
shivam-kapila
Do some pass?
2020-05-04 12557, 2020
16:10 PM
ruaok
looks good so far.
2020-05-04 12551, 2020
16:11 PM
ruaok
test.sh all passed.
2020-05-04 12510, 2020
16:12 PM
shivam-kapila
Nice. Now can you please help me. Mine are crashing :(
2020-05-04 12530, 2020
16:12 PM
ruaok
of course, turn about is fair play. gist me your error.
2020-05-04 12539, 2020
16:12 PM
cloverfield joined the channel
2020-05-04 12523, 2020
16:13 PM
shivam-kapila
2020-05-04 12532, 2020
16:15 PM
ruaok
the messybrainz repo is being merged (has merged) into the listenbrainz repo.
2020-05-04 12543, 2020
16:15 PM
ruaok
I wonder if this is related -- still, why am I not getting that?
2020-05-04 12503, 2020
16:16 PM
iliekcomputers
shivam-kapila: build you containers again
2020-05-04 12509, 2020
16:16 PM
iliekcomputers
The test ones
2020-05-04 12526, 2020
16:16 PM
iliekcomputers
The timescale branch needs to clone messybrainz while master doesn't
2020-05-04 12537, 2020
16:17 PM
ruaok
yeah, we're going to need to do another rebase before too long to take into account the messybrainz changes.
2020-05-04 12559, 2020
16:17 PM
ruaok
I'm just waiting for the new LB dump so I can finish the importer.
2020-05-04 12528, 2020
16:18 PM
shivam-kapila
iliekcomputers: How to rebuild test containers? I tried ./test.sh -d but I think I am wrong
2020-05-04 12546, 2020
16:18 PM
iliekcomputers
Not sure if we have a command for iy
2020-05-04 12512, 2020
16:19 PM
ruaok
shivam-kapila: try `docker ps --all` and see if there are lingering containers.
2020-05-04 12522, 2020
16:19 PM
ruaok
if you see anything LB related, nuke those containers.
2020-05-04 12540, 2020
16:19 PM
iliekcomputers
`docker-compose -f docker/docker-compose.test.yml -p listenbrainztest build`
2020-05-04 12555, 2020
16:21 PM
shivam-kapila
Thanks iliekcomputers. We might need a command `./test.sh -b` someday for this.
2020-05-04 12518, 2020
16:22 PM
yvanzo
2020-05-04 12507, 2020
16:23 PM
bitmap
maybe we can add a helper script to the base-image for that
2020-05-04 12509, 2020
16:23 PM
iliekcomputers
shivam-kapila: i'd be happy to take a pull request
2020-05-04 12510, 2020
16:23 PM
iliekcomputers
:)
2020-05-04 12524, 2020
16:23 PM
shivam-kapila
Okay I will make a PR
2020-05-04 12558, 2020
16:23 PM
alastairp
oh yeah, I added test.sh -b to my script
2020-05-04 12501, 2020
16:24 PM
yvanzo
There might be network issues depending on the Docker host too, so hkp://p80.pool.sks-keyservers.net:80 seems more reliable.
2020-05-04 12532, 2020
16:24 PM
alastairp
biggest reason it wasn't there originally is that ruaok was happy to just run ./test.sh without -u when we first wrote it. when doing a full test it'll build as part of the step
2020-05-04 12521, 2020
16:25 PM
alastairp
but if more people are doing -u / lots of tests / -d, then adding a build step might be nice. It's a bit opaque that this might be the error if you don't know how the infrastructure works though
2020-05-04 12522, 2020
16:25 PM
cloverfield has quit
2020-05-04 12552, 2020
16:26 PM
cloverfield joined the channel
2020-05-04 12512, 2020
16:27 PM
shivam-kapila
iliekcomputers: Created LB-564
2020-05-04 12513, 2020
16:27 PM
BrainzBot
2020-05-04 12537, 2020
16:27 PM
iliekcomputers
thanks
2020-05-04 12525, 2020
16:31 PM
ruaok
2020-05-04 12524, 2020
16:32 PM
alastairp
nope. did you share it to me?
2020-05-04 12527, 2020
16:32 PM
cloverfield has quit
2020-05-04 12526, 2020
16:33 PM
alastairp
will start reading it and adding some comments
2020-05-04 12511, 2020
16:34 PM
shivam-kapila
Seems like I dont have option to reopen PR. I will make new one for manage scripts.
2020-05-04 12537, 2020
16:34 PM
shivam-kapila
ruaok: Should I makke it on master? Since its not dependent on timescale?
2020-05-04 12505, 2020
16:35 PM
ruaok
sure.
2020-05-04 12505, 2020
16:37 PM
cloverfield joined the channel
2020-05-04 12553, 2020
16:40 PM
ruaok
alastairp: no posted it here earlier and pinged you.
2020-05-04 12538, 2020
16:41 PM
alastairp
ah, didn't see it, sorry!
2020-05-04 12549, 2020
16:41 PM
iliekcomputers
2020-05-04 12523, 2020
16:42 PM
shivam-kapila
iliekcomputers: Thanks for that :)
2020-05-04 12504, 2020
16:44 PM
iliekcomputers
can you reopen the PR now?
2020-05-04 12542, 2020
16:45 PM
ruaok
alastairp: tranquilo!
2020-05-04 12523, 2020
16:46 PM
cloverfield has quit
2020-05-04 12508, 2020
16:49 PM
cloverfield joined the channel
2020-05-04 12537, 2020
16:51 PM
iliekcomputers
2020-05-04 12537, 2020
16:51 PM
BrainzBot
LB-511: Inconsistent response when submitting playing-now listens
2020-05-04 12554, 2020
16:51 PM
iliekcomputers
