15:30 PM
ruaok
ok, hopefully our new gsoc slaves^H^H^H^H^H^Hstudents can make that too .:)
2020-05-05 12611, 2020
15:30 PM
ishaanshah[m]
sounds good to me!
2020-05-05 12607, 2020
15:31 PM
ruaok
and I will have a next version of this document ready by then.
2020-05-05 12638, 2020
15:56 PM
ishaanshah[m]
iliekcomputers: Hi!
2020-05-05 12648, 2020
15:56 PM
iliekcomputers
hey
2020-05-05 12623, 2020
15:58 PM
iliekcomputers
2020-05-05 12625, 2020
15:58 PM
BrainzBot
2020-05-05 12625, 2020
15:58 PM
BrainzBot
2020-05-05 12646, 2020
15:59 PM
iliekcomputers
i added LB-542, LB-540 and LB-557 for this week.
2020-05-05 12648, 2020
15:59 PM
BrainzBot
2020-05-05 12648, 2020
15:59 PM
BrainzBot
2020-05-05 12605, 2020
16:00 PM
iliekcomputers
though I think LB-557 will probably not finish this week.
2020-05-05 12615, 2020
16:00 PM
ishaanshah[m]
I have nearly completed 542
2020-05-05 12628, 2020
16:00 PM
iliekcomputers
oh
2020-05-05 12630, 2020
16:00 PM
iliekcomputers
cool
2020-05-05 12647, 2020
16:00 PM
ishaanshah[m]
Only one test is remaining, I was not sure how to proceed
2020-05-05 12603, 2020
16:01 PM
iliekcomputers
i estimated 2 days of work for that, do you think that's still reasonable?
2020-05-05 12607, 2020
16:01 PM
ishaanshah[m]
2020-05-05 12656, 2020
16:01 PM
ishaanshah[m]
For 557?
2020-05-05 12616, 2020
16:02 PM
iliekcomputers
for 542.
2020-05-05 12653, 2020
16:02 PM
ishaanshah[m]
Oh, I don't think I will need another day
2020-05-05 12639, 2020
16:03 PM
iliekcomputers
let's keep it at a minimum of 1, otherwise we'll get too granular. I'll put in an estimate of 1 for now.
2020-05-05 12601, 2020
16:04 PM
ishaanshah[m]
Ok, sure
2020-05-05 12621, 2020
16:04 PM
iliekcomputers
do the other tasks seem reasonable to you for this week? Is there something else you'd like to work on first?
2020-05-05 12601, 2020
16:05 PM
ishaanshah[m]
For 557 I should use nivo right?
2020-05-05 12626, 2020
16:05 PM
iliekcomputers
yeah, works for me.
2020-05-05 12647, 2020
16:06 PM
ishaanshah[m]
Ok, so I think that will 2 days, 3 at worst
2020-05-05 12612, 2020
16:07 PM
iliekcomputers
cool, let's be conservative and say 3 then.
2020-05-05 12622, 2020
16:07 PM
ishaanshah[m]
be*
2020-05-05 12610, 2020
16:08 PM
iliekcomputers
I think we should pull out the schema validation thing for now then.
2020-05-05 12616, 2020
16:08 PM
ishaanshah[m]
For enforcing the schema, are we gonna use protobuf or jsonschema?
2020-05-05 12619, 2020
16:08 PM
iliekcomputers
it won't finish in a day.
2020-05-05 12624, 2020
16:08 PM
iliekcomputers
not sure :D
2020-05-05 12636, 2020
16:08 PM
SomalRudra has quit
2020-05-05 12600, 2020
16:09 PM
ishaanshah[m]
Ok, I haven't worked with protobuf yet, I will spend some time and read about it
2020-05-05 12620, 2020
16:09 PM
iliekcomputers
sure, i've pulled it out for now.
2020-05-05 12623, 2020
16:09 PM
Chinmay3199 has quit
2020-05-05 12630, 2020
16:09 PM
iliekcomputers
we have around 4 days of work, that should be good for this week.
2020-05-05 12645, 2020
16:09 PM
iliekcomputers
2020-05-05 12646, 2020
16:09 PM
BrainzBot
LB-495: Fix Documentation error for validate token endpoint, 401 status code not mentioned
2020-05-05 12658, 2020
16:09 PM
ishaanshah[m]
Yes, maybe we could discuss how the UI will lool later if we get time
2020-05-05 12610, 2020
16:10 PM
ishaanshah[m]
look*
2020-05-05 12624, 2020
16:10 PM
iliekcomputers
yes! definitely
2020-05-05 12620, 2020
16:11 PM
ishaanshah[m]
One more thing, I needed some help with the API tests
2020-05-05 12641, 2020
16:11 PM
iliekcomputers
yeah, sure.
2020-05-05 12644, 2020
16:11 PM
iliekcomputers
what's up
2020-05-05 12603, 2020
16:12 PM
ishaanshah[m]
2020-05-05 12631, 2020
16:12 PM
ishaanshah[m]
I have added two tests, one to check if 404 is returned when user is not present
2020-05-05 12657, 2020
16:12 PM
ishaanshah[m]
And another one to check 404 is returned when stats haven't been calculated
2020-05-05 12602, 2020
16:13 PM
iliekcomputers
hmm
2020-05-05 12612, 2020
16:13 PM
iliekcomputers
i'm not sure if 404 makes sense for when the user does not have stats
2020-05-05 12642, 2020
16:13 PM
ishaanshah[m]
Yes, even I was not sure about that
2020-05-05 12649, 2020
16:13 PM
iliekcomputers
204 No Content, maybe.
2020-05-05 12614, 2020
16:14 PM
iliekcomputers
with an empty list of artists
2020-05-05 12632, 2020
16:14 PM
ishaanshah[m]
Yes, that makes more sense
2020-05-05 12635, 2020
16:14 PM
ishaanshah[m]
I will change that
2020-05-05 12658, 2020
16:14 PM
ishaanshah[m]
The only test remaining is for the valid case
2020-05-05 12622, 2020
16:15 PM
iliekcomputers
mhmm
2020-05-05 12638, 2020
16:15 PM
ishaanshah[m]
But I am not sure how we can add statistics in the db for the temporary user that we create
2020-05-05 12621, 2020
16:16 PM
iliekcomputers
2020-05-05 12627, 2020
16:16 PM
iliekcomputers
call this function ?
2020-05-05 12628, 2020
16:17 PM
iliekcomputers
in the test, I mean.
2020-05-05 12659, 2020
16:17 PM
iliekcomputers
`def test_stats: db_stats.insert_user_stats(mock_data); api_request; assert200; assertDataValid`
2020-05-05 12613, 2020
16:18 PM
ishaanshah[m]
Ohk, that will work, thanks
2020-05-05 12627, 2020
16:18 PM
iliekcomputers
awesome!
2020-05-05 12647, 2020
16:18 PM
ishaanshah[m]
I will have to call this test after the above 204 one
2020-05-05 12649, 2020
16:18 PM
v6lur has quit
2020-05-05 12608, 2020
16:19 PM
iliekcomputers
I'd say make them different tests
2020-05-05 12628, 2020
16:19 PM
iliekcomputers
there's a `tearDown` function which resets the database after every test
2020-05-05 12634, 2020
16:19 PM
ishaanshah[m]
Yes different test
2020-05-05 12637, 2020
16:19 PM
iliekcomputers
so they should work independent of each other
2020-05-05 12600, 2020
16:20 PM
iliekcomputers
the order of execution of tests should not matter
2020-05-05 12608, 2020
16:20 PM
ishaanshah[m]
Ok, so the tests are independant
2020-05-05 12616, 2020
16:20 PM
iliekcomputers
ideally yes
2020-05-05 12621, 2020
16:20 PM
iliekcomputers
if they're not, it's a bug :)
2020-05-05 12654, 2020
16:20 PM
ishaanshah[m]
:D
2020-05-05 12613, 2020
16:21 PM
ishaanshah[m]
I will make the 204 change and add this test
2020-05-05 12617, 2020
16:21 PM
ishaanshah[m]
tommorow
2020-05-05 12626, 2020
16:21 PM
iliekcomputers
ok, awesome. tag me on the PR when you want me to look at it.
2020-05-05 12604, 2020
16:22 PM
ishaanshah[m]
Ya sure, thanks 🙂
2020-05-05 12641, 2020
16:22 PM
iliekcomputers
i added LB-495 to the sprint, it's something that we should get done anyways, and should be only a few minutes worth of work
2020-05-05 12641, 2020
16:22 PM
BrainzBot
2020-05-05 12630, 2020
16:23 PM
KindOne has quit
2020-05-05 12619, 2020
16:24 PM
ishaanshah[m]
That should be an easy fix. I will do that
2020-05-05 12642, 2020
16:24 PM
iliekcomputers
cool! thanks!
2020-05-05 12639, 2020
16:26 PM
Zastai|2 is now known as Zastai
2020-05-05 12643, 2020
16:27 PM
Zastai
Freso: sorry, didn't see your mention til now. not sure what it's about though; I'm not connected to Kodi at all. Maybe you meant zas?
2020-05-05 12608, 2020
16:32 PM
jmp_music has quit
2020-05-05 12614, 2020
16:38 PM
alastairp
can someone give me push permissions to metabrainz/jenkins? zas, yvanzo?
2020-05-05 12609, 2020
16:40 PM
zas
alastairp: invite sent
2020-05-05 12639, 2020
16:41 PM
alastairp
zas: that works, thanks
2020-05-05 12614, 2020
16:42 PM
Lotheric_ joined the channel
2020-05-05 12601, 2020
16:44 PM
Lotheric has quit
2020-05-05 12637, 2020
16:49 PM
alastairp
restarting jenkins
2020-05-05 12604, 2020
16:52 PM
alastairp
up
2020-05-05 12653, 2020
16:52 PM
ruaok
Zastai: all good -- no worries. I know what freso meant.
2020-05-05 12617, 2020
16:53 PM
KindOne joined the channel
2020-05-05 12632, 2020
17:00 PM
SomalRudra joined the channel
2020-05-05 12603, 2020
17:23 PM
SomalRudra has quit
2020-05-05 12652, 2020
17:30 PM
shivam-kapila
> I would propose I hour before the normal meeting time on monday to hold this meeting. iliekcomputers, shivam-kapila, ishaanshah[m], alastairp, Mr_Monkey ?
2020-05-05 12652, 2020
17:30 PM
shivam-kapila
Works for me.
2020-05-05 12630, 2020
17:31 PM
shivam-kapila
The current list of tools that are planned for LB is exciting me. I will sure like to pop in.
2020-05-05 12606, 2020
17:43 PM
Cyna
reosarevok: do give me the green light if the PR is fine... I'll start working on the other ones then. thanks
2020-05-05 12652, 2020
17:43 PM
Cyna
P.S do comment on the PR as I might get logged out from IRCCloud
2020-05-05 12623, 2020
17:44 PM
Zastai
I've seen some stuff come past about MB switching to PostgreSQL 12. What is the timeframe on that requirement going into production? Asking because I use Debian, which is on PG 11, and I'm not sure they'd change that before the next distro release (bullseye, next year).
2020-05-05 12624, 2020
17:50 PM
yvanzo
2020-05-05 12634, 2020
17:51 PM
yvanzo
PG12 features won’t be used before June, 18 at least.
2020-05-05 12621, 2020
17:53 PM
yvanzo
2020-05-05 12628, 2020
17:53 PM
Zastai
ah ok they have an APT repository, so upgrading from 11 to 12 should be easy enough.
2020-05-05 12604, 2020
17:55 PM
ruaok
lol. 13k pages affected.
2020-05-05 12651, 2020
17:56 PM
zas
yes, soft 404
2020-05-05 12659, 2020
17:56 PM
zas
I checked few, and ... well, they just work
2020-05-05 12617, 2020
17:57 PM
zas
that said, Google isn't very clear about what's a "soft 404" for them
2020-05-05 12640, 2020
17:57 PM
zas
2020-05-05 12640, 2020
17:58 PM
zas
2020-05-05 12639, 2020
18:16 PM
BrainzGit
2020-05-05 12641, 2020
18:16 PM
BrainzBot
2020-05-05 12650, 2020
18:16 PM
reosarevok
Sorry that it took more than two days this time, alastairp :p
2020-05-05 12638, 2020
18:20 PM
bitmap
huh. admin/sql/updates/20140130-remove-page-index.sql exists but I don't think it was ever run in production...
2020-05-05 12617, 2020
18:21 PM
bitmap
those indexes still exist on floyd but are completely unused, guess we should finally run that
2020-05-05 12623, 2020
18:21 PM
Zastai
is that collaborator info queryable via ws, btw?
2020-05-05 12652, 2020
18:33 PM
bitmap
I don't think so
2020-05-05 12638, 2020
18:34 PM
bitmap
we use the info for fetching user collections and authorizing submissions, but don't think we return a list of collaborators as part of any collection response
2020-05-05 12659, 2020
18:38 PM
SomalRudra joined the channel
2020-05-05 12621, 2020
18:40 PM
Zastai
which reminds me: the MB OAuth2 has scopes for "see email" and "see profile", but there do not seem to be WS endpoints for getting that information. are those scopes of any real use?
2020-05-05 12657, 2020
18:44 PM
CatQuest
2020-05-05 12605, 2020
18:46 PM
CatQuest
maybe those are pages that the mbid redirect becasue of merges? idk
2020-05-05 12644, 2020
18:47 PM
CatQuest
2020-05-05 12653, 2020
18:47 PM
CatQuest
on option: ""Google falsely marks a page as ‘seems to be a 404’ while there is nothing wrong with the page.
2020-05-05 12614, 2020
18:50 PM
CatQuest
(sorry if you know these already)
2020-05-05 12646, 2020
18:50 PM
Zastai
or could those have been accessed during that weekend where one of the nodes was down, and some requests simply got no answer?
2020-05-05 12645, 2020
18:52 PM
KindTwo joined the channel
2020-05-05 12614, 2020
18:54 PM
KindOne has quit
2020-05-05 12622, 2020
18:57 PM
CatQuest
ooh yea that sounds not unlikly
2020-05-05 12645, 2020
19:02 PM
KindOne joined the channel
2020-05-05 12623, 2020
19:03 PM
KindTwo has quit
2020-05-05 12652, 2020
19:07 PM
SomalRudra_ joined the channel
2020-05-05 12633, 2020
19:08 PM
SomalRudra has quit
2020-05-05 12633, 2020
19:08 PM
SomalRudra_ is now known as SomalRudra
2020-05-05 12623, 2020
19:18 PM
KindOne has quit
2020-05-05 12607, 2020
19:20 PM
KindOne joined the channel
2020-05-05 12629, 2020
19:22 PM
v6lur joined the channel
2020-05-05 12657, 2020
20:06 PM
Zastai|2 joined the channel
2020-05-05 12614, 2020
20:10 PM
Zastai has quit
2020-05-05 12611, 2020
20:11 PM
Cyna has quit
2020-05-05 12623, 2020
20:11 PM
thomasross has quit
2020-05-05 12653, 2020
20:11 PM
thomasross joined the channel
2020-05-05 12600, 2020
20:21 PM
adhawkins has quit
2020-05-05 12635, 2020
20:25 PM
adhawkins joined the channel
2020-05-05 12612, 2020
20:29 PM
Lotheric joined the channel
