#metabrainz

reosarevok: bitmap : made the changes you requested for.

tests are failing maybe due to change in reference of edit artist detail. If you have time do check the CI for more info. Thanks

iliekcomputers: Hi, I have completed the test and made the 204 change

The PR is ready for review, please have a look when free

For LB-495, I couldn't find any code which would raise 401 error, maybe I missed something, can you have a look?

LB-495: Fix Documentation error for validate token endpoint, 401 status code not mentioned https://tickets.metabrainz.org/browse/LB-495

[listenbrainz-server] ishaanshah opened pull request #835 (master…legacy_lastfm): [LB-566] - Remove legacy LastFM importer from codebase https://github.com/metabrainz/listenbrainz-serv...

LB-566: Remove legacy LastFM importer from codebase https://tickets.metabrainz.org/browse/LB-566

Cyna[m]: fixed the Perl tests

Thanks

Morning!

Morning shivam-kapila :)

Morning Cyna[m] :)

Mornin'!

ishaanshah[m]: can you document the json that the endpoint returns

I have done that

For the validate-token endpoint, sorry I wasn't clear

Ok, ya sure

But isnt that endpoint a security threat

I mean i can write script to generate a bunch of random tokens and send it to this endpoint

If I hit a valid one, I get the users username

The probability of you generating a valid token is very low

Our tokens are uuids and two scripts generating the same uuid is basically impossible. Plus we rate limit the endpoint.

I don't think there's a threat here.

Reviewed the stats API endpoint pr.

Morning 🌞

Thanks, I will have a look in the afternoon

Mr_Monkey: Hi.

Hi !

How do we proceed for GSOC project?

I was afk for last week, had some college stuff. Couldn't work on the API pr. I am thinking of completing it first. It should not take more time

What do you think?

bitmap: that fixed lock file indeed, thanks.

prabal: I think it would be great to put the last nail in that PR's coffin :) And after that, depending on how you feel about it, you could get started on the GSOC project (even though we're technically in the bonding period), or tie some other loose ends (I'm thinking about the revision page for example).

reosarevok:

Green light on PR ?

ishaanshah[m]: can you add the scraper PR to the jira board too, it's easier to track stuff being done then.

alastairp: https://gist.github.com/mayhem/f898630ed0157f5c...

I was delving a little deeper into the framework concept. trying to keep things super simple

After some discussion in private, prabal and I decided it would be best to start the GSOC coding project sooner rather than later, in case exams are moved to the summer, thus taking some time away from the coding period. Writing this here in case it's useful for other participants/mentors

ruaok: cool. I'm busy until lunch, but will take a look at it this afternoon

k

btw, how's our spark-fu? does this look useful>

spark fu could use more love, but a lot of spark books are outdated the second they go to print.

yeah, I bet

Yes, my college is planning to have exams on mid-July mostly. yvanzo should I start early as well?

I just received notice from college that Exams may be held on End of July

The same is the case throughout india about exams

diru1100: sure, better sooner than later!

Except IIITH

[musicbrainz-server] yvanzo opened pull request #1497 (master…mbs-10803-metaaal): MBS-10803: Fix allowing Metal Archives artist URLs https://github.com/metabrainz/musicbrainz-serve...

MBS-10803: Cannot link to https://www.metal-archives.com/artists/<arti...; https://tickets.metabrainz.org/browse/MBS-10803

IIITH semester over right?

ishaanshah[m]: Is it true?

Yes

Grades are due on 9th

yvanzo: I'm getting a new yarn.lock file every time I compile resources - do you get the same and do you know what that's about?

(wondering if it's expected but we forgot to push the updated yarn.lock or if it's weird :D )

reosarevok: I get that almost everytime while create PRs

At least it's not just me then :D

iliekcomputers: Hi, I cannot add stories to the board as I don't have schedule permissions

also Cyna[m]: will look at your stuff again later, found a regression I caused so trying to fix that first :)

huh, that's weird, i'll look into that today

reosarevok: with latest master? since which commit?

The yarn thing? I dunno, a while ago

Few days

reosarevok: yes, should be fixed now

Thanks!

reosarevok: For me, that started with https://github.com/metabrainz/musicbrainz-serve...

And stopped with https://github.com/metabrainz/musicbrainz-serve...

Oh, ok, let's see

ishaanshah[m]: Should I also change the frontend-test.sh to build everytime you run them?

[musicbrainz-docker] yvanzo opened pull request #145 (mbvm-38-dev…recv-keys): Try reaching different PGP servers/pools if needed https://github.com/metabrainz/musicbrainz-docke...

shivam-kapila: are you changing the test scripts?

can you merge the 4(!) we have now into one?

with subcommands

I am changing them

You mean to merge test.sh, integration-test.sh and frontend-test.sh?

also spark_test.sh. I missed it before?

yes

Okay. I will do that.

shivam-kapila: I am not sure about that, because we don't have -u functionality in frontend test

iliekcomputers: what do you think about this?

I guess the conflict wil be removed in the merge iliekcomputers suggested

ishaanshah[m]: can you add stuff to the board now?

Yes I can, thanks :D

cool

Can you merge the lastFM PR

I would like to move a card to Done :P

[listenbrainz-server] shivam-kapila reopened pull request #762 (timescale…fix-db-scripts): LB-501: Fix DB setup scripts in manage.py https://github.com/metabrainz/listenbrainz-serv...

LB-501: Fix DB setup scripts in manage.py https://tickets.metabrainz.org/browse/LB-501

iliekcomputers: Hi, it seems that there is no point in returning json with 204

I tried sending a request with Postman but got an empty response

I also tried sending a request through javascript console

but response.json() errors out

Similar thing happens in the python tests

The first one is normal response and the second one is 204 response

can you comment that on github and leave it as it is for now, seems like we can't return data for 204, so should be okay, but I'll take a look once

>The 204 response MUST NOT include a message-body and thus is always terminated by the first empty line after the header fields.

Ok, sure

shivam-kapila: i think you can stop the task about the artist chart bugs, ishaanshah[m] is working on migrating it to react, we should probably just fix it there, otherwise work will be duplicated.

if you have something, push it and maybe ishaanshah[m] can merge it with his branch

I am done with reset stats on delete

iliekcomputers: I'm wondering what we should call the syswiki document for how to deploy AB/LB

oh yeah, that sounds like a seperate pr, i was talking about the bug in the artist chart specifically

PythonBrainzReleaseProcess?

(the MB one is MusicBrainzServerReleaseProcess)

sorry for the late notice on it, totally slipped my mind until i saw a jira email

iliekcomputers: Actually that ticket had two subparts. 1. is done. 2. the artist chart bugs in not yet left

alastairp: sgtm

I've started using 'pythonbrainz' when referring to the python/flask-based projects, I wonder if it's a good term or not :)