#metabrainz

/

      • iliekcomputers
        i find that github is a bad place to keep syswiki in general
      • 2020-05-06 12720, 2020

      • iliekcomputers
        the search isn't very good
      • 2020-05-06 12744, 2020

      • iliekcomputers
        alastairp: i use that too, happy to keep using it until we come up with something better
      • 2020-05-06 12757, 2020

      • iliekcomputers
        shivam-kapila: right, i'd say stop work on 2 if you haven't already.
      • 2020-05-06 12752, 2020

      • BrainzGit
        [guidelines] alastair closed pull request #12 (master…deployment-guidelines): Add deployment guidelines https://github.com/metabrainz/guidelines/pull/12
      • 2020-05-06 12737, 2020

      • alastairp
        iliekcomputers: did you update pep8speaks on LB to change the line length?
      • 2020-05-06 12745, 2020

      • iliekcomputers
        yes
      • 2020-05-06 12705, 2020

      • iliekcomputers
        there should be a pep8speaks file in listenbrainz-server
      • 2020-05-06 12707, 2020

      • alastairp
        ah, it's a hidden file
      • 2020-05-06 12723, 2020

      • alastairp
        got it
      • 2020-05-06 12738, 2020

      • alastairp
        should we put this file somewhere?
      • 2020-05-06 12745, 2020

      • alastairp
        I mean, should there be a master version in a repository somewhere that projects can copy if they want it (and that we can use as the canonical version if we want to make improvements)
      • 2020-05-06 12751, 2020

      • iliekcomputers
        there is a .github repo we could keep it in probably?
      • 2020-05-06 12700, 2020

      • iliekcomputers
        not sure what the best place for it is
      • 2020-05-06 12727, 2020

      • alastairp
        yeah, .github doesn't seem quite right - because it's for python projects only
      • 2020-05-06 12730, 2020

      • alastairp
        BU?
      • 2020-05-06 12705, 2020

      • alastairp
        I wondered if we should have a place for test.sh too
      • 2020-05-06 12741, 2020

      • ruaok nudges alastairp https://gist.github.com/mayhem/f898630ed0157f5c498ec1e14a80cb30
      • 2020-05-06 12715, 2020

      • alastairp
        yeah, I have it open. I'm finishing some other stuff that I had open before I get to it
      • 2020-05-06 12720, 2020

      • ruaok
        k
      • 2020-05-06 12757, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo opened pull request #1498 (master…mbs-10737-session-place): MBS-10737: Allow The Session place URLs https://github.com/metabrainz/musicbrainz-server/…
      • 2020-05-06 12757, 2020

      • BrainzBot
      • 2020-05-06 12741, 2020

      • yvanzo
        alastairp: there is a feature called “template repository” in github
      • 2020-05-06 12731, 2020

      • alastairp
        yvanzo: so you can say "make a new pythony repository", and it copies the existing files into the new one?
      • 2020-05-06 12708, 2020

      • alastairp
        that looks useful. It doesn't help us to _update_ existing repositories, but I guess we could use the same repo for that purpose too - if we make a change, just copy that changed file back into the other repos too
      • 2020-05-06 12709, 2020

      • yvanzo
        I guess so, never used it though.
      • 2020-05-06 12729, 2020

      • yvanzo
        Yes, it doesn't help updating existing repos.
      • 2020-05-06 12752, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1499 (master…MBS-10811): MBS-10811: Convert historic Edit Relationship edit to React https://github.com/metabrainz/musicbrainz-server/…
      • 2020-05-06 12753, 2020

      • BrainzBot
        MBS-10811: Convert historic Edit Relationship edit to React https://tickets.metabrainz.org/browse/MBS-10811
      • 2020-05-06 12708, 2020

      • reosarevok
        yvanzo: this should fix that crash you found ^
      • 2020-05-06 12754, 2020

      • yvanzo
        alastairp: you can still use template repo as a reference and do manual updates.
      • 2020-05-06 12710, 2020

      • alastairp
        yeah, that's probably a good idea
      • 2020-05-06 12718, 2020

      • yvanzo
        reosarevok: thanks!
      • 2020-05-06 12714, 2020

      • reosarevok
        It's on master so it can be reviewed as-is, if you want :) Given the regression isn't on beta yet, it would be good to get this in
      • 2020-05-06 12737, 2020

      • ruaok
        Freso: can you please accept the suggested edits on the Feb board meeting minutes? I need to send out the agenda soon.
      • 2020-05-06 12753, 2020

      • ruaok
      • 2020-05-06 12735, 2020

      • BrainzGit
        [listenbrainz-server] shivam-kapila opened pull request #836 (master…fix-user-stats): LB-556: Fix user stats on deleting listens https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-06 12735, 2020

      • BrainzBot
        LB-556: Reset user stats when a user deletes their listens https://tickets.metabrainz.org/browse/LB-556
      • 2020-05-06 12724, 2020

      • reosarevok
        Oh, forgot flow types, damn
      • 2020-05-06 12724, 2020

      • shivam-kapila
        iliekcomputers: I have make reset stats PR
      • 2020-05-06 12727, 2020

      • reosarevok
        Fixed
      • 2020-05-06 12725, 2020

      • yvanzo
        did that fix placeholders too?
      • 2020-05-06 12712, 2020

      • reosarevok
        yvanzo: what placeholders?
      • 2020-05-06 12726, 2020

      • reosarevok
        Or is that to alastairp?
      • 2020-05-06 12736, 2020

      • yvanzo
        reosarevok: {additional}, see comment to the PR.
      • 2020-05-06 12706, 2020

      • supersandro20000 has quit
      • 2020-05-06 12730, 2020

      • supersandro2000 joined the channel
      • 2020-05-06 12736, 2020

      • Chinmay3199 has quit
      • 2020-05-06 12706, 2020

      • Lotheric_ has quit
      • 2020-05-06 12719, 2020

      • Lotheric joined the channel
      • 2020-05-06 12714, 2020

      • v6lur has quit
      • 2020-05-06 12756, 2020

      • reosarevok
        Oh, I'll check
      • 2020-05-06 12709, 2020

      • BrainzGit
        [listenbrainz-server] shivam-kapila opened pull request #837 (master…merge-test-scripts): LB:567 Merge test scripts https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-06 12754, 2020

      • iliekcomputers
        shivam-kapila: protip: use `git add -p` instead of `git add .`
      • 2020-05-06 12729, 2020

      • shivam-kapila
        iliekcomputers: Oh thanks for that tip. I didnt remember that :)
      • 2020-05-06 12709, 2020

      • shivam-kapila
        The test scripts are merged into one file. I have tested each case too. Please review when free.
      • 2020-05-06 12704, 2020

      • ruaok
        we have a new supporter with an open source player: https://volumio.org/discover-music-myvolumio-late…
      • 2020-05-06 12748, 2020

      • shivam-kapila
        ruaok: Just curious. How is timescale? :)
      • 2020-05-06 12751, 2020

      • Freso
        "Last but not least, we have to thank Wikipedia and Music Brainz (to which we are proud to be Supporters) for their amazing collective work over the years. The contribution of those 2 projects to mankind wisdom and access to information is invaluable. Without them, the work we’ve done on this feature would not simply be possible." Nice.
      • 2020-05-06 12734, 2020

      • alastairp
        ruaok: hi. I have a small essay with feedback on your thing
      • 2020-05-06 12746, 2020

      • alastairp
        gist doesn't let me add comments to a line, how do you want it?
      • 2020-05-06 12704, 2020

      • alastairp
        comment on the gist, another gist, pasted here, gdoc?
      • 2020-05-06 12729, 2020

      • iliekcomputers
        make a gdoc please
      • 2020-05-06 12756, 2020

      • iliekcomputers
        gists will be hard to track
      • 2020-05-06 12757, 2020

      • diru1100
        I was seeing videos of metabrainz in youtube, the introductory video is cool, the fact the y'all branched out from MB to other projects since 2000 is awesome. Do new project ideas come during meetings or at the annual summit?
      • 2020-05-06 12722, 2020

      • alastairp
      • 2020-05-06 12749, 2020

      • alastairp
        should be open to all with link + comment perms
      • 2020-05-06 12752, 2020

      • iliekcomputers
        thanks alastairp
      • 2020-05-06 12710, 2020

      • iliekcomputers
        i wonder if we can make a shared MeB drive folder to put these docs in
      • 2020-05-06 12724, 2020

      • alastairp
        yeah, it's getting to that time
      • 2020-05-06 12743, 2020

      • alastairp
        oh, interesting. meb google org doesn't have "Shared drives". Maybe that's an enterprise feature that we have at UPF
      • 2020-05-06 12759, 2020

      • iliekcomputers
        oh
      • 2020-05-06 12724, 2020

      • alastairp
        I mean, nothing to stop someone from creating a drive and then sharing it, but that's fraught with so much difficulty when you try and work out what happens when the user who created the folder is deleted :/
      • 2020-05-06 12729, 2020

      • ishaanshah[m]
        iliekcomputers: Hi, is this a good time for our meeting?
      • 2020-05-06 12746, 2020

      • iliekcomputers
        ishaanshah[m]: hey, sorry about that, can we push it 15 min?
      • 2020-05-06 12705, 2020

      • ishaanshah[m]
        Sure, no problem
      • 2020-05-06 12718, 2020

      • iliekcomputers
        thanks!
      • 2020-05-06 12733, 2020

      • ruaok
        alastairp: thanks for the feedback. I'll respond later.
      • 2020-05-06 12748, 2020

      • ruaok
        shivam-kapila: doing test imports for duplicate removal right now.
      • 2020-05-06 12751, 2020

      • ruaok goes afk
      • 2020-05-06 12756, 2020

      • alastairp
        great, talk tomorrow
      • 2020-05-06 12728, 2020

      • alastairp
        ruaok: sharing it directly to your email too, just so that you have a link and don't have to go digging through irc history
      • 2020-05-06 12708, 2020

      • shivam-kapila
        ruaok: Thanks for the info :)
      • 2020-05-06 12736, 2020

      • kori joined the channel
      • 2020-05-06 12737, 2020

      • kori has quit
      • 2020-05-06 12737, 2020

      • kori joined the channel
      • 2020-05-06 12711, 2020

      • iliekcomputers
        ishaanshah[m]: hey, hi
      • 2020-05-06 12703, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #762 (master…fix-db-scripts): LB-501: Fix DB setup scripts in manage.py https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-06 12703, 2020

      • BrainzBot
        LB-501: Fix DB setup scripts in manage.py https://tickets.metabrainz.org/browse/LB-501
      • 2020-05-06 12729, 2020

      • ishaanshah[m]
        iliekcomputers: HiQ
      • 2020-05-06 12736, 2020

      • ishaanshah[m]
        Hi*
      • 2020-05-06 12753, 2020

      • iliekcomputers
        yo!
      • 2020-05-06 12706, 2020

      • ishaanshah[m]
        I have addressed most of your comments on the PR
      • 2020-05-06 12707, 2020

      • iliekcomputers
        do you have anything that's blocking you?
      • 2020-05-06 12714, 2020

      • iliekcomputers
        anything that you want me to look at?
      • 2020-05-06 12744, 2020

      • ishaanshah[m]
        The endpoint PR is almost ready
      • 2020-05-06 12712, 2020

      • iliekcomputers
        awesome!
      • 2020-05-06 12714, 2020

      • ishaanshah[m]
        Where should we add the statsistic JSON format
      • 2020-05-06 12719, 2020

      • iliekcomputers
        i'll take a look tomorrow
      • 2020-05-06 12744, 2020

      • ishaanshah[m]
        That is the only part remaining
      • 2020-05-06 12745, 2020

      • iliekcomputers
        ishaanshah[m]: i think we can just put it in the endpoint docstring
      • 2020-05-06 12721, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #835 (master…legacy_lastfm): LB-566: Remove legacy LastFM importer from codebase https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-06 12721, 2020

      • BrainzBot
        LB-566: Remove legacy LastFM importer from codebase https://tickets.metabrainz.org/browse/LB-566
      • 2020-05-06 12744, 2020

      • iliekcomputers
        does that sound reasonable to you?
      • 2020-05-06 12709, 2020

      • ishaanshah[m]
        I am not sure, because then we can't add the example response in it
      • 2020-05-06 12726, 2020

      • iliekcomputers
        I don't think I understand
      • 2020-05-06 12755, 2020

      • ishaanshah[m]
      • 2020-05-06 12720, 2020

      • ishaanshah[m]
        I have written the general format as well as a specific example of the response
      • 2020-05-06 12731, 2020

      • iliekcomputers
        right, i don't think we need the example
      • 2020-05-06 12756, 2020

      • iliekcomputers
        or actually
      • 2020-05-06 12721, 2020

      • ishaanshah[m]
        Should we create another page for statistic jsons
      • 2020-05-06 12721, 2020

      • iliekcomputers
        maybe we put in the example with comments on the specific fields
      • 2020-05-06 12728, 2020

      • ishaanshah[m]
        Similar to listen json
      • 2020-05-06 12752, 2020

      • ishaanshah[m]
        Because we will have a lot of endpoints soon enough
      • 2020-05-06 12705, 2020

      • ishaanshah[m]
        which will blow up the API endpoint page
      • 2020-05-06 12713, 2020

      • iliekcomputers
        yeah.
      • 2020-05-06 12730, 2020

      • iliekcomputers
        i'm thinking we'll probably move the stats endpoint docs to its own page eventualy
      • 2020-05-06 12752, 2020

      • iliekcomputers
        i'm not totally convinced about divorcing the response format from the endpoint docs
      • 2020-05-06 12711, 2020

      • ishaanshah[m]
        Hmm
      • 2020-05-06 12714, 2020

      • iliekcomputers
        with the listen page, it made sense because there was a lot to it, with the stats there's just gonna be a specific format
      • 2020-05-06 12727, 2020

      • ishaanshah[m]
        maybe we can do something similar to lastFM
      • 2020-05-06 12731, 2020

      • ishaanshah[m]
        API documentation
      • 2020-05-06 12745, 2020

      • ishaanshah[m]
        they provide an example response link with a dummy user
      • 2020-05-06 12701, 2020

      • ishaanshah[m]
        As it we are planning to have one right?
      • 2020-05-06 12707, 2020

      • iliekcomputers
      • 2020-05-06 12749, 2020

      • iliekcomputers
        there's definitely many ways to do it
      • 2020-05-06 12718, 2020

      • iliekcomputers
        for now, i'd just put it in the endpoint docstring
      • 2020-05-06 12726, 2020

      • iliekcomputers
        this is really orthogonal to our project
      • 2020-05-06 12730, 2020

      • ishaanshah[m]
        Yep, maybe I will add it to the docstring
      • 2020-05-06 12749, 2020

      • ishaanshah[m]
        And may open a ticket for the docs
      • 2020-05-06 12755, 2020

      • ishaanshah[m]
        maybe*
      • 2020-05-06 12703, 2020

      • iliekcomputers
        yes, that sounds reasonable
      • 2020-05-06 12740, 2020

      • ishaanshah[m]
        Other than that I spent some time working with the React Port this morning
      • 2020-05-06 12740, 2020

      • iliekcomputers
        once we have an idea of the endpoints we'll be writing it'll probably be easier to reason about this
      • 2020-05-06 12734, 2020

      • iliekcomputers
        great!
      • 2020-05-06 12754, 2020

      • cloverfield has quit
      • 2020-05-06 12703, 2020

      • ishaanshah[m]
        My target for tomorrow is get the graph to work, fingers crossed
      • 2020-05-06 12727, 2020

      • iliekcomputers
        great, that sounds awesome!
      • 2020-05-06 12738, 2020

      • iliekcomputers
        could you also keep https://tickets.metabrainz.org/browse/LB-547 in mind while you work on it
      • 2020-05-06 12739, 2020

      • BrainzBot
        LB-547: Artist chart bugs
      • 2020-05-06 12755, 2020

      • iliekcomputers
        we show duplicates in the chart (different msids probably, but we don't surface that data)
      • 2020-05-06 12718, 2020

      • iliekcomputers
        so it might be best to just group artists with the same name together and see if people come back to us with feedback
      • 2020-05-06 12743, 2020

      • ishaanshah[m]
        Hmm, right now I will just convert everything to lower case and compare
      • 2020-05-06 12753, 2020

      • iliekcomputers
        awesome, sgtm
      • 2020-05-06 12721, 2020

      • ishaanshah[m]
        But we might need to figure out how to deal with artist names having feat.
      • 2020-05-06 12724, 2020

      • cloverfield joined the channel
      • 2020-05-06 12741, 2020

      • iliekcomputers
        i would not try to solve that problem in this ticket
      • 2020-05-06 12747, 2020

      • ishaanshah[m]
        or similar things
      • 2020-05-06 12753, 2020

      • iliekcomputers
        that seems a rabbithole we should not jump into right now
      • 2020-05-06 12717, 2020

      • ishaanshah[m]
        Ya ya, not in this task, I was just mentioning it