0:17 AM
supersandro2000 has quit
2020-05-16 13750, 2020
0:17 AM
supersandro20002 joined the channel
2020-05-16 13751, 2020
0:34 AM
iliekcomputers
Lotheric: that's the spotify player being noisy, are you opted into the Spotify integration? If not, it should not be there.
2020-05-16 13738, 2020
0:53 AM
arcade_droid has quit
2020-05-16 13704, 2020
0:54 AM
zarcade_droid joined the channel
2020-05-16 13707, 2020
1:02 AM
zarcade_droid is now known as arcade_droid
2020-05-16 13708, 2020
1:05 AM
arcade_droid is now known as zarcade_droid
2020-05-16 13713, 2020
1:11 AM
Lotheric
I linked my account, yeha
2020-05-16 13701, 2020
1:14 AM
Lotheric
ok got it
2020-05-16 13713, 2020
1:14 AM
Lotheric
unlinked myself and relinked using both play and record
2020-05-16 13719, 2020
1:14 AM
Lotheric
the message is gone
2020-05-16 13720, 2020
1:14 AM
Lotheric
:)
2020-05-16 13726, 2020
1:14 AM
Lotheric
thanks
2020-05-16 13757, 2020
1:43 AM
Chinmay3199 joined the channel
2020-05-16 13745, 2020
2:01 AM
zarcade_droid has quit
2020-05-16 13708, 2020
2:02 AM
zarcade_droid joined the channel
2020-05-16 13714, 2020
2:07 AM
m00n
so, is it a standard/convention that tags begin with a lower letter?
2020-05-16 13741, 2020
2:07 AM
m00n
and if yes, is it possible to change the name of a tag without changing the value across a selection?
2020-05-16 13725, 2020
2:09 AM
m00n
im adding "book" and "series" tags to some mp3s
2020-05-16 13727, 2020
2:10 AM
m00n
in the tag list panel picard lists Artist as being capitalized, but then the tag itself is lower case. However if i create a custom tag it appears in the list panel verbatim.
2020-05-16 13748, 2020
2:10 AM
m00n
which is what confused me
2020-05-16 13755, 2020
2:15 AM
zarcade_droid is now known as arcade_droid
2020-05-16 13731, 2020
2:51 AM
arcade_droid is now known as zarcade_droid
2020-05-16 13734, 2020
2:51 AM
zarcade_droid is now known as arcade_droid
2020-05-16 13742, 2020
3:24 AM
supersandro20002 has quit
2020-05-16 13758, 2020
3:24 AM
supersandro2000 joined the channel
2020-05-16 13730, 2020
3:34 AM
arcade_droid has quit
2020-05-16 13730, 2020
4:20 AM
m00n
i figured it out
2020-05-16 13723, 2020
4:25 AM
supersandro2000 has quit
2020-05-16 13736, 2020
4:25 AM
supersandro2000 joined the channel
2020-05-16 13758, 2020
5:16 AM
m00n has quit
2020-05-16 13752, 2020
5:17 AM
m00n joined the channel
2020-05-16 13705, 2020
5:18 AM
BrainzGit
2020-05-16 13745, 2020
5:23 AM
BrainzGit
2020-05-16 13745, 2020
5:23 AM
BrainzBot
2020-05-16 13734, 2020
5:25 AM
supersandro2000 has quit
2020-05-16 13746, 2020
5:25 AM
supersandro2000 joined the channel
2020-05-16 13712, 2020
5:40 AM
ishaanshah[m]
iliekcomputers: can have a look once before I update the tests?
2020-05-16 13733, 2020
5:41 AM
BrainzGit
2020-05-16 13736, 2020
6:04 AM
BrainzGit
2020-05-16 13744, 2020
6:26 AM
supersandro2000 has quit
2020-05-16 13757, 2020
6:26 AM
supersandro2000 joined the channel
2020-05-16 13754, 2020
6:33 AM
mzfr joined the channel
2020-05-16 13752, 2020
7:33 AM
diru1100
Mo''in'!
2020-05-16 13706, 2020
8:20 AM
v6lur joined the channel
2020-05-16 13754, 2020
8:47 AM
iliekcomputers
ruaok: morning!
2020-05-16 13745, 2020
8:48 AM
iliekcomputers
I have two small pull requests on LB that I want to merge today. Will you have time to take a look?
2020-05-16 13720, 2020
8:49 AM
iliekcomputers
ishaanshah[m]: hey! I'll look at your PR soon-ish.
2020-05-16 13701, 2020
9:05 AM
Gazooo has quit
2020-05-16 13741, 2020
9:06 AM
Gazooo joined the channel
2020-05-16 13726, 2020
9:07 AM
ruaok
iliekcomputers: can do. More urgent then then next couple of hours?
2020-05-16 13731, 2020
9:08 AM
iliekcomputers
Nah, not that urgent. Just want to deploy them to cron today.
2020-05-16 13702, 2020
9:09 AM
ruaok
K
2020-05-16 13743, 2020
9:09 AM
iliekcomputers
Thanks!
2020-05-16 13710, 2020
9:16 AM
ruaok
done!
2020-05-16 13736, 2020
9:16 AM
BrainzGit
2020-05-16 13730, 2020
9:18 AM
BrainzGit
2020-05-16 13746, 2020
9:18 AM
BrainzGit
2020-05-16 13747, 2020
9:18 AM
BrainzBot
2020-05-16 13705, 2020
9:19 AM
iliekcomputers
Thanks ruaok
2020-05-16 13713, 2020
9:30 AM
shivam-kapila
Morning!!
2020-05-16 13741, 2020
9:33 AM
Chinmay3199 has quit
2020-05-16 13720, 2020
9:34 AM
Mr_Monkey is so into working on BrainzPlayer he didn't realise it's Saturday…
2020-05-16 13748, 2020
9:37 AM
Mr_Monkey
Where did the week go?
2020-05-16 13736, 2020
9:40 AM
iliekcomputers
ishaanshah[m]: i've commented on your PR. I think it'd be a good idea for us to catch up once when you get the time.
2020-05-16 13718, 2020
10:13 AM
v6lur has quit
2020-05-16 13757, 2020
11:03 AM
ruaok
Mr_Monkey: my week exactly!
2020-05-16 13721, 2020
11:04 AM
ishaanshah[m]
iliekcomputers hey, I am around
2020-05-16 13722, 2020
11:34 AM
v6lur joined the channel
2020-05-16 13708, 2020
11:38 AM
iliekcomputers
ishaanshah[m]: hey
2020-05-16 13725, 2020
11:38 AM
ishaanshah[m]
hi
2020-05-16 13718, 2020
11:39 AM
iliekcomputers
did you see my comments on the PR?
2020-05-16 13730, 2020
11:39 AM
ishaanshah[m]
Yes
2020-05-16 13754, 2020
11:39 AM
ishaanshah[m]
I agree with all of them, I will make the changes tomorrow
2020-05-16 13722, 2020
11:40 AM
ishaanshah[m]
Are the listens in parquet files sorted in ascending order?
2020-05-16 13733, 2020
11:40 AM
iliekcomputers
i don't think so.
2020-05-16 13736, 2020
11:40 AM
ishaanshah[m]
wrt to listened at
2020-05-16 13702, 2020
11:41 AM
_lucifer
ruaok: does meb have an organization google cloud account?
2020-05-16 13703, 2020
11:41 AM
iliekcomputers
you'll have to do a max operation first, i guess.
2020-05-16 13715, 2020
11:41 AM
ishaanshah[m]
Oh, can we do that
2020-05-16 13718, 2020
11:41 AM
ruaok
_lucifer: yes
2020-05-16 13741, 2020
11:41 AM
iliekcomputers
ishaanshah[m]: yeah, i'd just load the latest month parquet file and find the max for listened_at
2020-05-16 13753, 2020
11:41 AM
iliekcomputers
2020-05-16 13758, 2020
11:41 AM
ishaanshah[m]
Because where queries will simple because of that
2020-05-16 13708, 2020
11:42 AM
iliekcomputers
this is scala, but there should be an equivalent.
2020-05-16 13720, 2020
11:42 AM
ishaanshah[m]
I was asking for the where queries, min max should be fine
2020-05-16 13748, 2020
11:42 AM
iliekcomputers
i don't understand the question.
2020-05-16 13726, 2020
11:43 AM
ishaanshah[m]
Just a optimisation I though, not necessary to be done right now
2020-05-16 13712, 2020
11:44 AM
ishaanshah[m]
I mean if we could tell spark that listens are in ascending order the where queries would just binary search ig
2020-05-16 13723, 2020
11:44 AM
iliekcomputers
oh
2020-05-16 13726, 2020
11:44 AM
iliekcomputers
yeah.
2020-05-16 13737, 2020
11:44 AM
iliekcomputers
the sort would be really expensive though
2020-05-16 13714, 2020
11:45 AM
ishaanshah[m]
Yeah, Ig we will have to modify the export to do that
2020-05-16 13744, 2020
11:45 AM
iliekcomputers
hmm
2020-05-16 13757, 2020
11:45 AM
iliekcomputers
the dump process is almost insanely inefficient rn
2020-05-16 13743, 2020
11:46 AM
ishaanshah[m]
It's an optimisation, maybe we should look at it after we setup a proper pipeline
2020-05-16 13705, 2020
11:47 AM
iliekcomputers
yeah, true.
2020-05-16 13713, 2020
11:47 AM
ishaanshah[m]
I will open a ticket for it
2020-05-16 13759, 2020
11:47 AM
iliekcomputers
cool, thx!
2020-05-16 13755, 2020
11:49 AM
ishaanshah[m]
Other than that you had some things in mind to discuss?
2020-05-16 13712, 2020
11:51 AM
iliekcomputers
nah, just wanted to make sure we're aligned on the stats calculation comments I had.
2020-05-16 13702, 2020
11:52 AM
ishaanshah[m]
Oh, I agree with the seperation part
2020-05-16 13735, 2020
11:52 AM
iliekcomputers
for the interval of calculation specifically.
2020-05-16 13740, 2020
11:52 AM
ishaanshah[m]
Its better to have different commands, because we will have a lot more stats now
2020-05-16 13707, 2020
11:53 AM
iliekcomputers
we should find the sunday before the latest listen and then calculate stats for that interval
2020-05-16 13723, 2020
11:53 AM
iliekcomputers
or the 1st of the month before the latest listen and then stats for that interval
2020-05-16 13718, 2020
11:54 AM
ishaanshah[m]
But wouldn't that make the graphs static for the whole month
2020-05-16 13751, 2020
11:54 AM
iliekcomputers
sorry, i'm not clear i guess.
2020-05-16 13700, 2020
11:55 AM
iliekcomputers
suppose the latest listen is from May 16
2020-05-16 13710, 2020
11:55 AM
iliekcomputers
then the calculation should be from May 1 to May 16
2020-05-16 13755, 2020
11:55 AM
ishaanshah[m]
That wouldn't exactly be last month right
2020-05-16 13708, 2020
11:56 AM
iliekcomputers
yeah.
2020-05-16 13709, 2020
11:56 AM
ishaanshah[m]
I was thinking if 16th may is the latest listen
2020-05-16 13719, 2020
11:56 AM
ishaanshah[m]
Last week = 9th-16
2020-05-16 13731, 2020
11:56 AM
ishaanshah[m]
Month = 16th april - 16th may
2020-05-16 13755, 2020
11:56 AM
iliekcomputers
hmm.
2020-05-16 13723, 2020
11:57 AM
ishaanshah[m]
Thats what we are doing right now
2020-05-16 13737, 2020
11:57 AM
ishaanshah[m]
I mean the PR
2020-05-16 13702, 2020
11:59 AM
iliekcomputers
i think the stats would be more useful if they're for a particular month vs a more-or-less random range.
2020-05-16 13717, 2020
11:59 AM
iliekcomputers
like stats for the month of May vs stats for half of April + half of May
2020-05-16 13753, 2020
11:59 AM
iliekcomputers
i'd say go with what I said for now, we'll change it if people want something different.
2020-05-16 13759, 2020
11:59 AM
iliekcomputers
should be easy enough to change.
2020-05-16 13715, 2020
12:00 PM
ishaanshah[m]
Yep, Yep
2020-05-16 13730, 2020
12:00 PM
ishaanshah[m]
What about week and year
2020-05-16 13709, 2020
12:01 PM
iliekcomputers
same concept for week to week, like Sunday to Sunday, we could show it on the site as stats for the week of May 11.
2020-05-16 13709, 2020
12:01 PM
ishaanshah[m]
should week be sunday to sunday too?
2020-05-16 13719, 2020
12:01 PM
iliekcomputers
and for year to year, stats for 2020
2020-05-16 13729, 2020
12:01 PM
iliekcomputers
vs stats for may 2019 to may 2020
2020-05-16 13737, 2020
12:01 PM
ishaanshah[m]
Hmm
2020-05-16 13703, 2020
12:02 PM
ishaanshah[m]
That eliminates the need of where queries :D
2020-05-16 13736, 2020
12:02 PM
iliekcomputers
heh
2020-05-16 13742, 2020
12:02 PM
ishaanshah[m]
So we speed up the pipeline 🎉
2020-05-16 13753, 2020
12:04 PM
ishaanshah[m]
Another thing, I think we should look into more columns in db after some time
2020-05-16 13711, 2020
12:05 PM
ishaanshah[m]
When we know more about the stats we are gonna calculate
2020-05-16 13731, 2020
12:05 PM
iliekcomputers
yeah, seeing the changes in the sql in the PR, i think more columns will be needed.
2020-05-16 13732, 2020
12:06 PM
ishaanshah[m]
Yeah, the query has become really complex and hard to understand
2020-05-16 13700, 2020
12:08 PM
iliekcomputers
true
2020-05-16 13724, 2020
12:08 PM
ishaanshah[m]
Also does PR #853 mean we will have a MB database on LB now?
2020-05-16 13701, 2020
12:09 PM
iliekcomputers
we have a connection in prod.
2020-05-16 13709, 2020
12:09 PM
iliekcomputers
on the dev env we don't
2020-05-16 13732, 2020
12:09 PM
ishaanshah[m]
So we can make direct db calls to MB
2020-05-16 13751, 2020
12:09 PM
iliekcomputers
in LB we can, in spark rn, we can't
2020-05-16 13702, 2020
12:10 PM
ishaanshah[m]
Oh, noice
2020-05-16 13730, 2020
12:10 PM
ishaanshah[m]
I was gonna need that for some of the stats :D
2020-05-16 13753, 2020
12:13 PM
ishaanshah[m]
Anyways, I will make the changes you asked and update the tests :)
2020-05-16 13708, 2020
12:14 PM
iliekcomputers
awesome, thanks!
2020-05-16 13719, 2020
12:51 PM
yvanzo
reosarevok: thanks, published!
2020-05-16 13735, 2020
12:51 PM
_lucifer
ruaok: can you set up a google cloud project for me with editor access
2020-05-16 13721, 2020
12:52 PM
_lucifer
i want to connect with firebase test lab
2020-05-16 13702, 2020
12:53 PM
_lucifer
it requires the project billing to be enabled but i do not intend to exceed the free quota