#metabrainz

/

      • supersandro2000 has quit
      • 2020-05-16 13750, 2020

      • supersandro20002 joined the channel
      • 2020-05-16 13751, 2020

      • iliekcomputers
        Lotheric: that's the spotify player being noisy, are you opted into the Spotify integration? If not, it should not be there.
      • 2020-05-16 13738, 2020

      • arcade_droid has quit
      • 2020-05-16 13704, 2020

      • zarcade_droid joined the channel
      • 2020-05-16 13707, 2020

      • zarcade_droid is now known as arcade_droid
      • 2020-05-16 13708, 2020

      • arcade_droid is now known as zarcade_droid
      • 2020-05-16 13713, 2020

      • Lotheric
        I linked my account, yeha
      • 2020-05-16 13701, 2020

      • Lotheric
        ok got it
      • 2020-05-16 13713, 2020

      • Lotheric
        unlinked myself and relinked using both play and record
      • 2020-05-16 13719, 2020

      • Lotheric
        the message is gone
      • 2020-05-16 13720, 2020

      • Lotheric
        :)
      • 2020-05-16 13726, 2020

      • Lotheric
        thanks
      • 2020-05-16 13757, 2020

      • Chinmay3199 joined the channel
      • 2020-05-16 13745, 2020

      • zarcade_droid has quit
      • 2020-05-16 13708, 2020

      • zarcade_droid joined the channel
      • 2020-05-16 13714, 2020

      • m00n
        so, is it a standard/convention that tags begin with a lower letter?
      • 2020-05-16 13741, 2020

      • m00n
        and if yes, is it possible to change the name of a tag without changing the value across a selection?
      • 2020-05-16 13725, 2020

      • m00n
        im adding "book" and "series" tags to some mp3s
      • 2020-05-16 13727, 2020

      • m00n
        in the tag list panel picard lists Artist as being capitalized, but then the tag itself is lower case. However if i create a custom tag it appears in the list panel verbatim.
      • 2020-05-16 13748, 2020

      • m00n
        which is what confused me
      • 2020-05-16 13755, 2020

      • zarcade_droid is now known as arcade_droid
      • 2020-05-16 13731, 2020

      • arcade_droid is now known as zarcade_droid
      • 2020-05-16 13734, 2020

      • zarcade_droid is now known as arcade_droid
      • 2020-05-16 13742, 2020

      • supersandro20002 has quit
      • 2020-05-16 13758, 2020

      • supersandro2000 joined the channel
      • 2020-05-16 13730, 2020

      • arcade_droid has quit
      • 2020-05-16 13730, 2020

      • m00n
        i figured it out
      • 2020-05-16 13723, 2020

      • supersandro2000 has quit
      • 2020-05-16 13736, 2020

      • supersandro2000 joined the channel
      • 2020-05-16 13758, 2020

      • m00n has quit
      • 2020-05-16 13752, 2020

      • m00n joined the channel
      • 2020-05-16 13705, 2020

      • BrainzGit
        [listenbrainz-server] vansika merged pull request #852 (vansika/candidate-recordings…candidate-set-for-all): Generate candidate sets for all users at once. https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-16 13745, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #856 (master…time_range_spark): LB-575: Add support for more time ranges for "Top Artists" (Spark and DB Insert) https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-16 13745, 2020

      • BrainzBot
        LB-575: Add support for more time ranges for "Top Artists" https://tickets.metabrainz.org/browse/LB-575
      • 2020-05-16 13734, 2020

      • supersandro2000 has quit
      • 2020-05-16 13746, 2020

      • supersandro2000 joined the channel
      • 2020-05-16 13712, 2020

      • ishaanshah[m]
        iliekcomputers: can have a look once before I update the tests?
      • 2020-05-16 13733, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #857 (vansika/candidate-recordings…dataframe-doc): update documentation in create_dataframes https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-16 13736, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #858 (master…update-recommendation-schema): update recommendation schema to use recording mbid https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-16 13744, 2020

      • supersandro2000 has quit
      • 2020-05-16 13757, 2020

      • supersandro2000 joined the channel
      • 2020-05-16 13754, 2020

      • mzfr joined the channel
      • 2020-05-16 13752, 2020

      • diru1100
        Mo''in'!
      • 2020-05-16 13706, 2020

      • v6lur joined the channel
      • 2020-05-16 13754, 2020

      • iliekcomputers
        ruaok: morning!
      • 2020-05-16 13745, 2020

      • iliekcomputers
        I have two small pull requests on LB that I want to merge today. Will you have time to take a look?
      • 2020-05-16 13720, 2020

      • iliekcomputers
        ishaanshah[m]: hey! I'll look at your PR soon-ish.
      • 2020-05-16 13701, 2020

      • Gazooo has quit
      • 2020-05-16 13741, 2020

      • Gazooo joined the channel
      • 2020-05-16 13726, 2020

      • ruaok
        iliekcomputers: can do. More urgent then then next couple of hours?
      • 2020-05-16 13731, 2020

      • iliekcomputers
        Nah, not that urgent. Just want to deploy them to cron today.
      • 2020-05-16 13702, 2020

      • ruaok
        K
      • 2020-05-16 13743, 2020

      • iliekcomputers
        Thanks!
      • 2020-05-16 13710, 2020

      • ruaok
        done!
      • 2020-05-16 13736, 2020

      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #853 (master…artist-relations): Add artist/artist_credit relations https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-16 13730, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #854 (master…param/better-notification-emails-for-dumps): Improve dump creation notification email subject https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-16 13746, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #855 (master…param/delete-old-dumps-from-temp-dir): LB-588: Remove old dumps from the /mnt/dumps as well https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-16 13747, 2020

      • BrainzBot
        LB-588: Remove old dumps from /mnt/dumps/tmp/archives https://tickets.metabrainz.org/browse/LB-588
      • 2020-05-16 13705, 2020

      • iliekcomputers
        Thanks ruaok
      • 2020-05-16 13713, 2020

      • shivam-kapila
        Morning!!
      • 2020-05-16 13741, 2020

      • Chinmay3199 has quit
      • 2020-05-16 13720, 2020

      • Mr_Monkey is so into working on BrainzPlayer he didn't realise it's Saturday…
      • 2020-05-16 13748, 2020

      • Mr_Monkey
        Where did the week go?
      • 2020-05-16 13736, 2020

      • iliekcomputers
        ishaanshah[m]: i've commented on your PR. I think it'd be a good idea for us to catch up once when you get the time.
      • 2020-05-16 13718, 2020

      • v6lur has quit
      • 2020-05-16 13757, 2020

      • ruaok
        Mr_Monkey: my week exactly!
      • 2020-05-16 13721, 2020

      • ishaanshah[m]
        iliekcomputers hey, I am around
      • 2020-05-16 13722, 2020

      • v6lur joined the channel
      • 2020-05-16 13708, 2020

      • iliekcomputers
        ishaanshah[m]: hey
      • 2020-05-16 13725, 2020

      • ishaanshah[m]
        hi
      • 2020-05-16 13718, 2020

      • iliekcomputers
        did you see my comments on the PR?
      • 2020-05-16 13730, 2020

      • ishaanshah[m]
        Yes
      • 2020-05-16 13754, 2020

      • ishaanshah[m]
        I agree with all of them, I will make the changes tomorrow
      • 2020-05-16 13722, 2020

      • ishaanshah[m]
        Are the listens in parquet files sorted in ascending order?
      • 2020-05-16 13733, 2020

      • iliekcomputers
        i don't think so.
      • 2020-05-16 13736, 2020

      • ishaanshah[m]
        wrt to listened at
      • 2020-05-16 13702, 2020

      • _lucifer
        ruaok: does meb have an organization google cloud account?
      • 2020-05-16 13703, 2020

      • iliekcomputers
        you'll have to do a max operation first, i guess.
      • 2020-05-16 13715, 2020

      • ishaanshah[m]
        Oh, can we do that
      • 2020-05-16 13718, 2020

      • ruaok
        _lucifer: yes
      • 2020-05-16 13741, 2020

      • iliekcomputers
        ishaanshah[m]: yeah, i'd just load the latest month parquet file and find the max for listened_at
      • 2020-05-16 13753, 2020

      • iliekcomputers
      • 2020-05-16 13758, 2020

      • ishaanshah[m]
        Because where queries will simple because of that
      • 2020-05-16 13708, 2020

      • iliekcomputers
        this is scala, but there should be an equivalent.
      • 2020-05-16 13720, 2020

      • ishaanshah[m]
        I was asking for the where queries, min max should be fine
      • 2020-05-16 13748, 2020

      • iliekcomputers
        i don't understand the question.
      • 2020-05-16 13726, 2020

      • ishaanshah[m]
        Just a optimisation I though, not necessary to be done right now
      • 2020-05-16 13712, 2020

      • ishaanshah[m]
        I mean if we could tell spark that listens are in ascending order the where queries would just binary search ig
      • 2020-05-16 13723, 2020

      • iliekcomputers
        oh
      • 2020-05-16 13726, 2020

      • iliekcomputers
        yeah.
      • 2020-05-16 13737, 2020

      • iliekcomputers
        the sort would be really expensive though
      • 2020-05-16 13714, 2020

      • ishaanshah[m]
        Yeah, Ig we will have to modify the export to do that
      • 2020-05-16 13744, 2020

      • iliekcomputers
        hmm
      • 2020-05-16 13757, 2020

      • iliekcomputers
        the dump process is almost insanely inefficient rn
      • 2020-05-16 13743, 2020

      • ishaanshah[m]
        It's an optimisation, maybe we should look at it after we setup a proper pipeline
      • 2020-05-16 13705, 2020

      • iliekcomputers
        yeah, true.
      • 2020-05-16 13713, 2020

      • ishaanshah[m]
        I will open a ticket for it
      • 2020-05-16 13759, 2020

      • iliekcomputers
        cool, thx!
      • 2020-05-16 13755, 2020

      • ishaanshah[m]
        Other than that you had some things in mind to discuss?
      • 2020-05-16 13712, 2020

      • iliekcomputers
        nah, just wanted to make sure we're aligned on the stats calculation comments I had.
      • 2020-05-16 13702, 2020

      • ishaanshah[m]
        Oh, I agree with the seperation part
      • 2020-05-16 13735, 2020

      • iliekcomputers
        for the interval of calculation specifically.
      • 2020-05-16 13740, 2020

      • ishaanshah[m]
        Its better to have different commands, because we will have a lot more stats now
      • 2020-05-16 13707, 2020

      • iliekcomputers
        we should find the sunday before the latest listen and then calculate stats for that interval
      • 2020-05-16 13723, 2020

      • iliekcomputers
        or the 1st of the month before the latest listen and then stats for that interval
      • 2020-05-16 13718, 2020

      • ishaanshah[m]
        But wouldn't that make the graphs static for the whole month
      • 2020-05-16 13751, 2020

      • iliekcomputers
        sorry, i'm not clear i guess.
      • 2020-05-16 13700, 2020

      • iliekcomputers
        suppose the latest listen is from May 16
      • 2020-05-16 13710, 2020

      • iliekcomputers
        then the calculation should be from May 1 to May 16
      • 2020-05-16 13755, 2020

      • ishaanshah[m]
        That wouldn't exactly be last month right
      • 2020-05-16 13708, 2020

      • iliekcomputers
        yeah.
      • 2020-05-16 13709, 2020

      • ishaanshah[m]
        I was thinking if 16th may is the latest listen
      • 2020-05-16 13719, 2020

      • ishaanshah[m]
        Last week = 9th-16
      • 2020-05-16 13731, 2020

      • ishaanshah[m]
        Month = 16th april - 16th may
      • 2020-05-16 13755, 2020

      • iliekcomputers
        hmm.
      • 2020-05-16 13723, 2020

      • ishaanshah[m]
        Thats what we are doing right now
      • 2020-05-16 13737, 2020

      • ishaanshah[m]
        I mean the PR
      • 2020-05-16 13702, 2020

      • iliekcomputers
        i think the stats would be more useful if they're for a particular month vs a more-or-less random range.
      • 2020-05-16 13717, 2020

      • iliekcomputers
        like stats for the month of May vs stats for half of April + half of May
      • 2020-05-16 13753, 2020

      • iliekcomputers
        i'd say go with what I said for now, we'll change it if people want something different.
      • 2020-05-16 13759, 2020

      • iliekcomputers
        should be easy enough to change.
      • 2020-05-16 13715, 2020

      • ishaanshah[m]
        Yep, Yep
      • 2020-05-16 13730, 2020

      • ishaanshah[m]
        What about week and year
      • 2020-05-16 13709, 2020

      • iliekcomputers
        same concept for week to week, like Sunday to Sunday, we could show it on the site as stats for the week of May 11.
      • 2020-05-16 13709, 2020

      • ishaanshah[m]
        should week be sunday to sunday too?
      • 2020-05-16 13719, 2020

      • iliekcomputers
        and for year to year, stats for 2020
      • 2020-05-16 13729, 2020

      • iliekcomputers
        vs stats for may 2019 to may 2020
      • 2020-05-16 13737, 2020

      • ishaanshah[m]
        Hmm
      • 2020-05-16 13703, 2020

      • ishaanshah[m]
        That eliminates the need of where queries :D
      • 2020-05-16 13736, 2020

      • iliekcomputers
        heh
      • 2020-05-16 13742, 2020

      • ishaanshah[m]
        So we speed up the pipeline 🎉
      • 2020-05-16 13753, 2020

      • ishaanshah[m]
        Another thing, I think we should look into more columns in db after some time
      • 2020-05-16 13711, 2020

      • ishaanshah[m]
        When we know more about the stats we are gonna calculate
      • 2020-05-16 13731, 2020

      • iliekcomputers
        yeah, seeing the changes in the sql in the PR, i think more columns will be needed.
      • 2020-05-16 13732, 2020

      • ishaanshah[m]
        Yeah, the query has become really complex and hard to understand
      • 2020-05-16 13700, 2020

      • iliekcomputers
        true
      • 2020-05-16 13724, 2020

      • ishaanshah[m]
        Also does PR #853 mean we will have a MB database on LB now?
      • 2020-05-16 13701, 2020

      • iliekcomputers
        we have a connection in prod.
      • 2020-05-16 13709, 2020

      • iliekcomputers
        on the dev env we don't
      • 2020-05-16 13732, 2020

      • ishaanshah[m]
        So we can make direct db calls to MB
      • 2020-05-16 13751, 2020

      • iliekcomputers
        in LB we can, in spark rn, we can't
      • 2020-05-16 13702, 2020

      • ishaanshah[m]
        Oh, noice
      • 2020-05-16 13730, 2020

      • ishaanshah[m]
        I was gonna need that for some of the stats :D
      • 2020-05-16 13753, 2020

      • ishaanshah[m]
        Anyways, I will make the changes you asked and update the tests :)
      • 2020-05-16 13708, 2020

      • iliekcomputers
        awesome, thanks!
      • 2020-05-16 13719, 2020

      • yvanzo
        reosarevok: thanks, published!
      • 2020-05-16 13735, 2020

      • _lucifer
        ruaok: can you set up a google cloud project for me with editor access
      • 2020-05-16 13721, 2020

      • _lucifer
        i want to connect with firebase test lab
      • 2020-05-16 13702, 2020

      • _lucifer
        it requires the project billing to be enabled but i do not intend to exceed the free quota