#metabrainz

/

      • iliekcomputers
        shivam-kapila: yeah
      • 2020-05-17 13854, 2020

      • shivam-kapila
        vs is just something that easily ready to go
      • 2020-05-17 13807, 2020

      • ishaanshah[m]
      • 2020-05-17 13809, 2020

      • shivam-kapila
        20.04 is awesome. Much faster than 19.10
      • 2020-05-17 13831, 2020

      • ishaanshah[m]
        iliekcomputers: ^ If you ever wanna switch back, this might help :D
      • 2020-05-17 13831, 2020

      • iliekcomputers
        ruaok: for CB, the PR should probably be on the production branch.
      • 2020-05-17 13840, 2020

      • iliekcomputers
        > This branch is 10 commits ahead, 119 commits behind master.
      • 2020-05-17 13802, 2020

      • ruaok
        k
      • 2020-05-17 13828, 2020

      • ruaok
        not having much luck with it yet.
      • 2020-05-17 13839, 2020

      • ruaok
        it is setup quite a bit differently from Meb.
      • 2020-05-17 13811, 2020

      • sumedh has quit
      • 2020-05-17 13845, 2020

      • sumedh joined the channel
      • 2020-05-17 13821, 2020

      • v6lur joined the channel
      • 2020-05-17 13859, 2020

      • sumedh has quit
      • 2020-05-17 13800, 2020

      • pristine__
        ruaok: did you get the chance to have a look at my comment on #858?
      • 2020-05-17 13814, 2020

      • ruaok
        no, not yet.
      • 2020-05-17 13840, 2020

      • sumedh joined the channel
      • 2020-05-17 13816, 2020

      • v6lur has quit
      • 2020-05-17 13824, 2020

      • v6lur_ joined the channel
      • 2020-05-17 13823, 2020

      • shivam-kapila
        ruaok: What problem were you facing with the psql thing?
      • 2020-05-17 13813, 2020

      • shivam-kapila
        I followed the steps:
      • 2020-05-17 13813, 2020

      • shivam-kapila
        1. Copy configs
      • 2020-05-17 13813, 2020

      • shivam-kapila
        2. Update dockerfile
      • 2020-05-17 13813, 2020

      • shivam-kapila
        3. ./develop.sh build
      • 2020-05-17 13813, 2020

      • shivam-kapila
        4. Remove old image
      • 2020-05-17 13814, 2020

      • shivam-kapila
        5. ./develop.sh psql
      • 2020-05-17 13814, 2020

      • shivam-kapila
        Its working for me
      • 2020-05-17 13844, 2020

      • iliekcomputers
        shivam-kapila: can you open a PR?
      • 2020-05-17 13844, 2020

      • shivam-kapila
      • 2020-05-17 13854, 2020

      • iliekcomputers
        Freso: ^
      • 2020-05-17 13856, 2020

      • BrainzGit
        [listenbrainz-server] shivam-kapila opened pull request #861 (master…upgrade-postgresql_client): LB-591: Upgrade postgresql-client to 12 from 9.5 https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-17 13857, 2020

      • BrainzBot
        LB-591: Upgrade the postgresql client to 12 from 9.5 https://tickets.metabrainz.org/browse/LB-591
      • 2020-05-17 13845, 2020

      • iliekcomputers
      • 2020-05-17 13857, 2020

      • iliekcomputers
        if we set this to `listenbrainz`, would it work?
      • 2020-05-17 13803, 2020

      • iliekcomputers
        about the URL, i don't like the duplication of the variable, if we want to change it's value we'll have to remember to do it in the two places, but i guess that's true anyways.
      • 2020-05-17 13812, 2020

      • iliekcomputers
        ok, let's keep the url.
      • 2020-05-17 13821, 2020

      • shivam-kapila
        I guess this is for the default user postgres not the user `listenbrainz` we create
      • 2020-05-17 13845, 2020

      • iliekcomputers
        what is?
      • 2020-05-17 13813, 2020

      • shivam-kapila
      • 2020-05-17 13819, 2020

      • shivam-kapila
        The link you pointed out
      • 2020-05-17 13833, 2020

      • shivam-kapila
        I have updated the user in the URL though
      • 2020-05-17 13805, 2020

      • iliekcomputers
        The user we want when we run develop.sh psql is listenbrainz
      • 2020-05-17 13816, 2020

      • shivam-kapila
        Yes I pushed that
      • 2020-05-17 13812, 2020

      • iliekcomputers
        K
      • 2020-05-17 13815, 2020

      • ruaok
        iliekcomputers: the test for CB are... uhm. special.
      • 2020-05-17 13831, 2020

      • ruaok
        they keep failing with different errors and sometimes they work.
      • 2020-05-17 13847, 2020

      • ruaok
        I have reason to believe that CB will be fine for the upgrade...
      • 2020-05-17 13855, 2020

      • ruaok
        but convinced I am not.
      • 2020-05-17 13823, 2020

      • shivam-kapila
        iliekcomputers: I couldn't understand why you want to change this https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-17 13823, 2020

      • shivam-kapila
        to `listenbrainz`
      • 2020-05-17 13824, 2020

      • ruaok
        pristine__: re your comment on that PR. let's not worry about it right now -- the new recommendation stuff changes our older plans.
      • 2020-05-17 13827, 2020

      • shivam-kapila
        iliekcomputers: I got it with your comment
      • 2020-05-17 13844, 2020

      • shivam-kapila
        Sorry for the inconvenience
      • 2020-05-17 13804, 2020

      • iliekcomputers
        shivam-kapila: let's just leave it. I'm happy with the url
      • 2020-05-17 13818, 2020

      • shivam-kapila
        Ok thanks :)
      • 2020-05-17 13837, 2020

      • iliekcomputers
        Can you change the name of the var to postgres_lb_uri? The admin part is misleading
      • 2020-05-17 13805, 2020

      • iliekcomputers
        ruaok: can you push the changes to a PR? A clean Jenkins build might run better
      • 2020-05-17 13854, 2020

      • shivam-kapila
        iliekcomputers: My bad. Updated
      • 2020-05-17 13801, 2020

      • pristine__
        ruaok: well, I still feel JSONB is a good option but I am okay to move forward.
      • 2020-05-17 13842, 2020

      • BrainzGit
        [listenbrainz-server] vansika merged pull request #858 (master…update-recommendation-schema): update recommendation schema to use recording mbid https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-17 13844, 2020

      • iliekcomputers
        pristine__: the schema change PR you just merged.
      • 2020-05-17 13852, 2020

      • iliekcomputers
        have the original changes been applied in production?
      • 2020-05-17 13835, 2020

      • iliekcomputers
        also, can you revert the change to the old schema change script? this could get confusing to release otherwise
      • 2020-05-17 13808, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #861 (master…upgrade-postgresql_client): LB-591: Upgrade postgresql-client to 12 from 9.5 https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-17 13809, 2020

      • BrainzBot
        LB-591: Upgrade the postgresql client to 12 from 9.5 https://tickets.metabrainz.org/browse/LB-591
      • 2020-05-17 13813, 2020

      • shivam-kapila
        30033
      • 2020-05-17 13858, 2020

      • Freso
        shivam-kapila: Why do you think Sigyn thinks you’re a bot? Didn’t it just warn you that you’re displaying spammy/botty behaviour? (And posting 7 messages in <1 second is just that.)
      • 2020-05-17 13816, 2020

      • shivam-kapila
        Yes it did the same. I will keep it in mind the next time I paste messages. Thanks Freso
      • 2020-05-17 13824, 2020

      • Freso
        No worries. It shouldn’t kill you for a one-off thing like this, but if you do it repeatedly in a short timeframe it might do something. It does measure the amount of time you’ve been in the channel as one of its counter measures, so I wouldn’t generally worry too much about it.
      • 2020-05-17 13843, 2020

      • Freso
        *counter metrics
      • 2020-05-17 13804, 2020

      • ruaok
        iliekcomputers: postgres-12 on the CB repo
      • 2020-05-17 13830, 2020

      • ruaok
        pristine__: yep, you're likely right about the JSONB change, but we may not need it. we won't need it soon.
      • 2020-05-17 13814, 2020

      • Chinmay3199 joined the channel
      • 2020-05-17 13813, 2020

      • ruaok
        Mr_Monkey: how about you, have you done any pg12 prep?
      • 2020-05-17 13846, 2020

      • Mr_Monkey
        Hm, not at all. I hadn't thought about that.
      • 2020-05-17 13853, 2020

      • Mr_Monkey
        Well top of the pile, then.
      • 2020-05-17 13833, 2020

      • Mr_Monkey
        Thanks for the nudge
      • 2020-05-17 13849, 2020

      • ruaok
        Yeah, me neither, oops.
      • 2020-05-17 13815, 2020

      • ruaok
        See if your tests pass with pg12, that should do the trick.
      • 2020-05-17 13830, 2020

      • bitmap
        ruaok: zas: yvanzo: yo, what time should we aim to do the upgrade tomorrow? maybe now-ish around 15utc or earlier?
      • 2020-05-17 13850, 2020

      • zas
        fine for me
      • 2020-05-17 13845, 2020

      • ruaok
        Nowish is good.
      • 2020-05-17 13842, 2020

      • bitmap
        worksforme too, I'll be here earlier to prep some stuff
      • 2020-05-17 13852, 2020

      • sumedh has quit
      • 2020-05-17 13832, 2020

      • sumedh joined the channel
      • 2020-05-17 13838, 2020

      • _lucifer
        hi ruaok, did you see my message from yesterday?
      • 2020-05-17 13834, 2020

      • sumedh has quit
      • 2020-05-17 13843, 2020

      • supersandro20006 has quit
      • 2020-05-17 13805, 2020

      • supersandro2000 joined the channel
      • 2020-05-17 13841, 2020

      • sumedh joined the channel
      • 2020-05-17 13809, 2020

      • shivam-kapila finally got the spotify trial thing to work
      • 2020-05-17 13825, 2020

      • ishaanshah[m]
        shivam-kapila you can get srudent for 60/month
      • 2020-05-17 13858, 2020

      • diru1100
        It's open to everyone now ig 50% off
      • 2020-05-17 13829, 2020

      • ishaanshah[m]
        Aw man I just bought premium day before yesterday 😢
      • 2020-05-17 13845, 2020

      • shivam-kapila
        The offer came some days before
      • 2020-05-17 13855, 2020

      • shivam-kapila
        I guess a week ago
      • 2020-05-17 13839, 2020

      • shivam-kapila
        Not you wont get 50% on student too. The normal plan is slashed too 699 which is almost same to that of student plan
      • 2020-05-17 13819, 2020

      • ishaanshah[m]
        Oh I see
      • 2020-05-17 13843, 2020

      • mzfr has quit
      • 2020-05-17 13852, 2020

      • supersandro2000 has quit
      • 2020-05-17 13805, 2020

      • supersandro2000 joined the channel
      • 2020-05-17 13841, 2020

      • chaban
        Long error message is long: MBS-10833
      • 2020-05-17 13842, 2020

      • BrainzBot
        MBS-10833: ISE when trying to load "Wikipedia page" edit https://tickets.metabrainz.org/browse/MBS-10833
      • 2020-05-17 13806, 2020

      • navap
        Speaking of ISEs... should I report this as something specific to me, or is there a more generic cause I can put in the ticket? https://musicbrainz.org/user/navap/edits/cancelled
      • 2020-05-17 13855, 2020

      • chaban
        Heh, saw that too. But didn't report it yet
      • 2020-05-17 13821, 2020

      • chaban
        Or isn't that caused by the same thing? https://musicbrainz.org/edit/12571536
      • 2020-05-17 13817, 2020

      • navap
        Not sure... but I think that edit is related to this ISE https://musicbrainz.org/url/4a5cfea2-42b5-40f3-90…
      • 2020-05-17 13832, 2020

      • navap
        I'll leave those ISE in your more capable hands :) I'm not sure what/if there is a connection between all those different ISEs
      • 2020-05-17 13853, 2020

      • supersandro2000 has quit
      • 2020-05-17 13809, 2020

      • supersandro2000 joined the channel
      • 2020-05-17 13810, 2020

      • navap
        I do wonder why the ▾ symbol gets all messed up on the ISE pages
      • 2020-05-17 13825, 2020

      • chaban
        I'm suspecting it's React conversion related. reosarevok :D
      • 2020-05-17 13810, 2020

      • reosarevok
        chaban: I think bitmap has a branch that fixes that, we should look at it after the postgres 12 change :)
      • 2020-05-17 13826, 2020

      • chaban
      • 2020-05-17 13827, 2020

      • BrainzBot
        MBS-10281: Improper encoding of ISE pages
      • 2020-05-17 13849, 2020

      • reosarevok
        Yeah. It's the header, and his branch converting it to use bootstrap fixes it IIRC
      • 2020-05-17 13835, 2020

      • yvanzo
        will be there too
      • 2020-05-17 13827, 2020

      • navap
        Given that it's been two years, I highly doubt we are actually able to recover chat logs from 2018. I'm closing OTHER-331 unless someone says otherwise
      • 2020-05-17 13828, 2020

      • BrainzBot
        OTHER-331: Restore chat logs about 2018-06-06 https://tickets.metabrainz.org/browse/OTHER-331
      • 2020-05-17 13853, 2020

      • yvanzo
        navap: I don’t recall who, but there used to be someone capable of doing this.
      • 2020-05-17 13835, 2020

      • navap
        But that would require the logs to exist right? I suppose if they don't exist on the MB bot side anyone in the channel could provide their own saved logs
      • 2020-05-17 13846, 2020

      • rdswift
        I've recovered a few, but I can only go back a week.
      • 2020-05-17 13836, 2020

      • yvanzo
        I have no idea how this bot work, so I won't interfere.
      • 2020-05-17 13816, 2020

      • rdswift
        I provided the missing parts to Leo_Verto, and he took care of adding them to the logs.
      • 2020-05-17 13815, 2020

      • Leo_Verto
        uh, let me check, I should still have that somewhere
      • 2020-05-17 13801, 2020

      • Leo_Verto
        importing logs into BrainzBot is a major pain though, I really need to build a webinterface for that
      • 2020-05-17 13821, 2020

      • rdswift
        👍
      • 2020-05-17 13841, 2020

      • navap
        There's also OTHER-330 if you're going to poke around with old logs :)
      • 2020-05-17 13841, 2020

      • BrainzBot
        OTHER-330: Clean spam off chat logs https://tickets.metabrainz.org/browse/OTHER-330
      • 2020-05-17 13853, 2020

      • Leo_Verto
        I'm pretty sure I did that one, let me check
      • 2020-05-17 13846, 2020

      • navap
      • 2020-05-17 13803, 2020

      • navap
        I think it started near end of July
      • 2020-05-17 13828, 2020

      • Leo_Verto
        ah, I was looking at the 14th
      • 2020-05-17 13845, 2020

      • bitmap
        I have a backup of all the old logs from the perl logger if anybody needs them
      • 2020-05-17 13849, 2020

      • Leo_Verto
        Alright, finished 330. I guess I'd done #meb but not #mb
      • 2020-05-17 13853, 2020

      • shivam-kapila
        ishaanshah[m]: LB-593
      • 2020-05-17 13854, 2020

      • BrainzBot
        LB-593: Increased height of bars for fewer artists in Artists graphs https://tickets.metabrainz.org/browse/LB-593
      • 2020-05-17 13813, 2020

      • yvanzo
        Thanks Leo_Verto!
      • 2020-05-17 13817, 2020

      • Leo_Verto
        Okay, just for reference, the import script on nomo is /var/lib/botbotme/botbot/src/botbot/botbot/apps/logs/management/commands/import.py
      • 2020-05-17 13840, 2020

      • ishaanshah[m]
        shivam-kapila Yes I realised that, will try to get to it this week, thanks for the ticket
      • 2020-05-17 13807, 2020

      • MirandaKerr joined the channel
      • 2020-05-17 13848, 2020

      • MirandaKerr has quit
      • 2020-05-17 13828, 2020

      • somasis joined the channel
      • 2020-05-17 13816, 2020

      • somasis has quit
      • 2020-05-17 13841, 2020

      • somasis joined the channel
      • 2020-05-17 13800, 2020

      • Leo_Verto
        Turns out the BrainzBot upstream BotBotm.me has been EOL since 2018 https://lincolnloop.com/blog/saying-goodbye-botbo…
      • 2020-05-17 13840, 2020

      • m00n has quit
      • 2020-05-17 13835, 2020

      • bitmap
        time to resurrect MBChatLogger? :P
      • 2020-05-17 13854, 2020

      • m00n joined the channel
      • 2020-05-17 13815, 2020

      • Leo_Verto
        If you want to maintain that and port all the plugins :P