-
ruaok
given that we're not storing it into a hypertable, then it doesn't!
2020-05-19 14054, 2020
-
ruaok
good catch!
2020-05-19 14057, 2020
-
ruaok
let's do that shivam-kapila
2020-05-19 14007, 2020
-
shivam-kapila
Okay
2020-05-19 14008, 2020
-
iliekcomputers
🎉
2020-05-19 14013, 2020
-
ruaok
depend, not block in any case
2020-05-19 14043, 2020
-
ishaanshah[m]
iliekcomputers: Hi!
2020-05-19 14047, 2020
-
iliekcomputers
ishaanshah[m]: hey
2020-05-19 14050, 2020
-
iliekcomputers
give me 2 min
2020-05-19 14002, 2020
-
ishaanshah[m]
Yep, Yep sure
2020-05-19 14047, 2020
-
iliekcomputers
evening!
2020-05-19 14050, 2020
-
iliekcomputers
how was your day?
2020-05-19 14015, 2020
-
ishaanshah[m]
Went pretty well :D
2020-05-19 14037, 2020
-
ishaanshah[m]
The PR is nearly done
2020-05-19 14042, 2020
-
iliekcomputers
nice nice
2020-05-19 14055, 2020
-
ishaanshah[m]
Some tests remaining and some finishing touches
2020-05-19 14010, 2020
-
iliekcomputers
sounds great.
2020-05-19 14016, 2020
-
iliekcomputers
anything you need my help with?
2020-05-19 14022, 2020
-
ishaanshah[m]
I think we should be able to merge it by tomorrow night
2020-05-19 14032, 2020
-
iliekcomputers
++
2020-05-19 14032, 2020
-
ishaanshah[m]
Yeah, one thing
2020-05-19 14001, 2020
-
ishaanshah[m]
How do we patch a instance method in python
2020-05-19 14038, 2020
-
ishaanshah[m]
For ex, patch createOrReplaceTempView for df
2020-05-19 14049, 2020
-
ishaanshah[m]
2020-05-19 14059, 2020
-
iliekcomputers
suppose you have a class A with a method x
2020-05-19 14008, 2020
-
iliekcomputers
b = A()
2020-05-19 14013, 2020
-
iliekcomputers
b.x = MagicMock()
2020-05-19 14018, 2020
-
iliekcomputers
something like that
2020-05-19 14037, 2020
-
ishaanshah[m]
But what if I dont have access to b
2020-05-19 14018, 2020
-
ishaanshah[m]
2020-05-19 14030, 2020
-
ishaanshah[m]
Specifically I want to mock this line
2020-05-19 14053, 2020
-
iliekcomputers
2020-05-19 14058, 2020
-
iliekcomputers
ctrl + f "patch.object"
2020-05-19 14004, 2020
-
iliekcomputers
something like that might work
2020-05-19 14047, 2020
-
ishaanshah[m]
I did try that, but did not work
2020-05-19 14053, 2020
-
ishaanshah[m]
Maybe some error I made
2020-05-19 14000, 2020
-
ishaanshah[m]
I will try again
2020-05-19 14008, 2020
-
iliekcomputers
hmm, weird. i don't know of any other way.
2020-05-19 14018, 2020
-
ishaanshah[m]
The problem that I was getting was
2020-05-19 14030, 2020
-
ishaanshah[m]
according to the spark doc
2020-05-19 14048, 2020
-
iliekcomputers
you could mock filter_listens to return a MagicMock
2020-05-19 14000, 2020
-
ishaanshah[m]
createOrReplaceView is in the class pyspark.sql.DataFrame
2020-05-19 14003, 2020
-
iliekcomputers
and then assert on that MagicMock object
2020-05-19 14038, 2020
-
iliekcomputers mock_df = MagicMock()
2020-05-19 14043, 2020
-
iliekcomputers
whoops
2020-05-19 14047, 2020
-
iliekcomputers
mock_df = MagicMock()
2020-05-19 14055, 2020
-
iliekcomputers
filter_listens.return_value = mock_df
2020-05-19 14007, 2020
-
iliekcomputers
assert mock_df.createOrReplaceView is called
2020-05-19 14017, 2020
-
ishaanshah[m]
Oh
2020-05-19 14030, 2020
-
ishaanshah[m]
Nice
2020-05-19 14042, 2020
-
ishaanshah[m]
I will do that then
2020-05-19 14048, 2020
-
iliekcomputers
sgtm!
2020-05-19 14058, 2020
-
ishaanshah[m]
thanks :)
2020-05-19 14001, 2020
-
iliekcomputers
do you have anything else you wanna talk about?
2020-05-19 14006, 2020
-
iliekcomputers
or should we move to planning?
2020-05-19 14026, 2020
-
ishaanshah[m]
Yep we can move to planning
2020-05-19 14037, 2020
-
iliekcomputers
ok, awesome.
2020-05-19 14050, 2020
-
ishaanshah[m]
I have opened the tickets you asked
2020-05-19 14051, 2020
-
iliekcomputers
i think our priority this week should be to finish up the work we did this week
2020-05-19 14015, 2020
-
ishaanshah[m]
Yes, agreed
2020-05-19 14022, 2020
-
iliekcomputers
and pick up a small-ish task to keep you not bored, working on just one thing can get old
2020-05-19 14029, 2020
-
iliekcomputers
cool.
2020-05-19 14046, 2020
-
iliekcomputers clicks complete sprint
2020-05-19 14010, 2020
-
ishaanshah[m]
I was wondering if we could hold the frontend part for now
2020-05-19 14031, 2020
-
iliekcomputers
why?
2020-05-19 14041, 2020
-
ishaanshah[m]
Once we discuss and decide about how to proceed, I can start on the frontend
2020-05-19 14001, 2020
-
ishaanshah[m]
We can work on implementing the statistics and API endpoints
2020-05-19 14005, 2020
-
iliekcomputers
hmm.
2020-05-19 14021, 2020
-
ishaanshah[m]
As we have decided to use API endpoints
2020-05-19 14025, 2020
-
iliekcomputers
yeah, that sounds reasonable to me.
2020-05-19 14042, 2020
-
ishaanshah[m]
We can do frontend backlog in a week
2020-05-19 14015, 2020
-
iliekcomputers
we'll pull in the frontend thing next week for sure.
2020-05-19 14029, 2020
-
iliekcomputers
that way we have one thing that's already complete and in prod
2020-05-19 14035, 2020
-
iliekcomputers
one less thing to worry about.
2020-05-19 14041, 2020
-
iliekcomputers
but yeah, we can hold off this week.
2020-05-19 14051, 2020
-
iliekcomputers
k.
2020-05-19 14003, 2020
-
iliekcomputers
I propose that we close LB-575 after the PR you have gets merged.
2020-05-19 14004, 2020
-
BrainzBot
2020-05-19 14023, 2020
-
ishaanshah[m]
Yep
2020-05-19 14032, 2020
-
iliekcomputers
great
2020-05-19 14039, 2020
-
iliekcomputers
how many days of work do you think it is?
2020-05-19 14048, 2020
-
Gore joined the channel
2020-05-19 14049, 2020
-
ishaanshah[m]
I think another day for it should be fine
2020-05-19 14001, 2020
-
iliekcomputers
great, i'll change the estimate to 1
2020-05-19 14020, 2020
-
iliekcomputers
I've pulled in LB-595
2020-05-19 14021, 2020
-
BrainzBot
2020-05-19 14023, 2020
-
ishaanshah[m]
LB-595 is easy
2020-05-19 14033, 2020
-
ishaanshah[m]
2 days at max
2020-05-19 14043, 2020
-
iliekcomputers
sgtm.
2020-05-19 14004, 2020
-
iliekcomputers
i'm gonna take the schema validation one for myself.
2020-05-19 14008, 2020
-
iliekcomputers
if that's ok
2020-05-19 14023, 2020
-
ishaanshah[m]
Seeing, the updated SQL query, I think we dont neeed multiple columns
2020-05-19 14032, 2020
-
ishaanshah[m]
Yep sure
2020-05-19 14049, 2020
-
iliekcomputers
cool
2020-05-19 14053, 2020
-
iliekcomputers
so you're at 3 rn
2020-05-19 14000, 2020
-
iliekcomputers
we can pull in another 2 days worth of work.
2020-05-19 14007, 2020
-
iliekcomputers scrolls the backlog
2020-05-19 14036, 2020
-
iliekcomputers
there is LB-536 that might be interesting.
2020-05-19 14036, 2020
-
BrainzBot
2020-05-19 14052, 2020
-
iliekcomputers
or LB-593
2020-05-19 14053, 2020
-
BrainzBot
2020-05-19 14005, 2020
-
iliekcomputers
or we can start with stats for releases
2020-05-19 14029, 2020
-
ishaanshah[m]
I guess we should start with stats for releases
2020-05-19 14030, 2020
-
iliekcomputers
what do you think?
2020-05-19 14046, 2020
-
iliekcomputers
hmm
2020-05-19 14047, 2020
-
ishaanshah[m]
I can do LB-593 when I am bored
2020-05-19 14052, 2020
-
iliekcomputers
yeah, i think that makes sense.
2020-05-19 14001, 2020
-
iliekcomputers
you can also take LB-593 with one of the other graphs
2020-05-19 14009, 2020
-
ishaanshah[m]
Yeah
2020-05-19 14013, 2020
-
iliekcomputers
I think they'll all use the `Bar` component you made anyways.
2020-05-19 14017, 2020
-
iliekcomputers
cool.
2020-05-19 14032, 2020
-
iliekcomputers
I'll pull in LB-577
2020-05-19 14033, 2020
-
BrainzBot
2020-05-19 14041, 2020
-
iliekcomputers
but let's assume that it's only the spark and db work for now.
2020-05-19 14046, 2020
-
ishaanshah[m]
I think we should have a greater overview of the design system after Friday
2020-05-19 14049, 2020
-
iliekcomputers
not the endpoint or the frontend
2020-05-19 14013, 2020
-
ishaanshah[m]
I had a look at the link you sent
2020-05-19 14010, 2020
-
iliekcomputers
yeah. let's see how that goes.
2020-05-19 14025, 2020
-
iliekcomputers
does a 2 on the release ticket make sense?
2020-05-19 14050, 2020
-
ishaanshah[m]
I think it might need 3
2020-05-19 14054, 2020
-
ishaanshah[m]
But thats fine
2020-05-19 14020, 2020
-
iliekcomputers
i'll put in a 3. we'll just accept that it gets rolled over to next week.
2020-05-19 14032, 2020
-
ishaanshah[m]
Yep
2020-05-19 14056, 2020
-
iliekcomputers
the ticket is only for the spark + database work though
2020-05-19 14011, 2020
-
ishaanshah[m]
Yep, yep
2020-05-19 14017, 2020
-
iliekcomputers
(repeating for clarity, the 3 makes sense to me)
2020-05-19 14019, 2020
-
iliekcomputers
cool.
2020-05-19 14029, 2020
-
iliekcomputers
i think that should be enough for this week.
2020-05-19 14043, 2020
-
ishaanshah[m]
Yes sounds good
2020-05-19 14052, 2020
-
iliekcomputers
i'll try to get to recordings on friday, but let's see.
2020-05-19 14005, 2020
-
iliekcomputers
maybe we can ship all three of these before the coding period begins ;)
2020-05-19 14022, 2020
-
ishaanshah[m]
That would be awesome!
2020-05-19 14047, 2020
-
iliekcomputers
I'll actually bring that in LB-576 too
2020-05-19 14048, 2020
-
BrainzBot
2020-05-19 14056, 2020
-
iliekcomputers
(for me)
2020-05-19 14057, 2020
-
iliekcomputers
cool.
2020-05-19 14016, 2020
-
ishaanshah[m]
Yep
2020-05-19 14022, 2020
-
iliekcomputers clicks start sprint
2020-05-19 14035, 2020
-
ishaanshah[m]
🎉
2020-05-19 14036, 2020
-
iliekcomputers
go team
2020-05-19 14010, 2020
-
iliekcomputers
to clarify priority just once, LB-575 > LB-595 > LB-577
2020-05-19 14012, 2020
-
BrainzBot
2020-05-19 14012, 2020
-
BrainzBot
2020-05-19 14012, 2020
-
BrainzBot
2020-05-19 14036, 2020
-
ishaanshah[m]
Yep
2020-05-19 14059, 2020
-
ishaanshah[m]
I am hoping to get LB-575 done tommoeow 🤞
2020-05-19 14009, 2020
-
iliekcomputers excited
2020-05-19 14046, 2020
-
ishaanshah[m]
* ishaanshah is excited too
2020-05-19 14046, 2020
-
jmp_music has quit
2020-05-19 14047, 2020
-
Mr_Monkey just got rickrolled by the youtube search API o_O
