#metabrainz

/

      • ZaphodBeeblebrox
        omg
      • 2020-05-20 14145, 2020

      • ZaphodBeeblebrox
        759 air, fra orkestersuite nr.3
      • 2020-05-20 14149, 2020

      • ZaphodBeeblebrox
        thats.. that's mine
      • 2020-05-20 14128, 2020

      • alastairp
      • 2020-05-20 14142, 2020

      • alastairp
      • 2020-05-20 14149, 2020

      • alastairp
        ZaphodBeeblebrox: that was the data from AcoustciBrainz
      • 2020-05-20 14151, 2020

      • ZaphodBeeblebrox
        wait was that the thing we talked about yesterdayis?
      • 2020-05-20 14154, 2020

      • ZaphodBeeblebrox
        neat!
      • 2020-05-20 14101, 2020

      • alastairp
        you just reminded me with the Bach
      • 2020-05-20 14104, 2020

      • ZaphodBeeblebrox
        :D
      • 2020-05-20 14106, 2020

      • iliekcomputers
        I mean, I don't really dislike it, I just don't think it's worth the extra effort people who don't have pycharm (or similar) will have to put in
      • 2020-05-20 14117, 2020

      • alastairp
        the second slide is artists with the most duplicated tracks
      • 2020-05-20 14124, 2020

      • ZaphodBeeblebrox
        heh
      • 2020-05-20 14132, 2020

      • alastairp
        interesting that it's basically "the beatles and a bunch of classical composers"
      • 2020-05-20 14140, 2020

      • ZaphodBeeblebrox
        and once. bob dylan
      • 2020-05-20 14153, 2020

      • ZaphodBeeblebrox
        yea. classical has many different ways of writing the same movement
      • 2020-05-20 14155, 2020

      • alastairp
        which brings about an interesting point about the way that MB metadata is set up for classical
      • 2020-05-20 14157, 2020

      • ZaphodBeeblebrox
        (diff languages)
      • 2020-05-20 14116, 2020

      • alastairp
        because you typically have the composer as artist, even though the performing orchestra can be different
      • 2020-05-20 14122, 2020

      • ZaphodBeeblebrox
        for classicla we should msid for the recording
      • 2020-05-20 14141, 2020

      • ZaphodBeeblebrox
        oh yea. deff!
      • 2020-05-20 14100, 2020

      • alastairp
        yeah, there's plenty of other information there, and we can integrate it into the musicbrainz database to get specific information about which are the most common orchestras, for example
      • 2020-05-20 14117, 2020

      • alastairp
        but yeah, The Beatles - I'm Down
      • 2020-05-20 14122, 2020

      • alastairp
        I had never heard of it
      • 2020-05-20 14131, 2020

      • sumedh joined the channel
      • 2020-05-20 14138, 2020

      • ZaphodBeeblebrox
        i liek how octopus garden is above come together :D
      • 2020-05-20 14143, 2020

      • alastairp
        note that this was many years ago. I should do the stats again and see what's changed
      • 2020-05-20 14106, 2020

      • ZaphodBeeblebrox
        and she's so heavy isn't evne on there
      • 2020-05-20 14116, 2020

      • ZaphodBeeblebrox
        elanor rigby wich is the best song too
      • 2020-05-20 14120, 2020

      • ZaphodBeeblebrox
        :D
      • 2020-05-20 14143, 2020

      • ZaphodBeeblebrox
        even my mom (and ardent stones > beatles fan) thoguh ER was a great song
      • 2020-05-20 14117, 2020

      • ZaphodBeeblebrox
        oh man, "111342 inside the deku tree" that's me too I thikn :P
      • 2020-05-20 14155, 2020

      • Leo_Verto
        alastairp: PyCharm's made me a whitespace stickler too! Half of the BrainzBot update PR is fixing whitespace and using f-string literals :P
      • 2020-05-20 14134, 2020

      • sumedh has quit
      • 2020-05-20 14106, 2020

      • sumedh joined the channel
      • 2020-05-20 14132, 2020

      • sumedh has quit
      • 2020-05-20 14136, 2020

      • sumedh joined the channel
      • 2020-05-20 14116, 2020

      • BestSteve has quit
      • 2020-05-20 14138, 2020

      • sumedh has quit
      • 2020-05-20 14106, 2020

      • BestSteve joined the channel
      • 2020-05-20 14132, 2020

      • v6lur joined the channel
      • 2020-05-20 14153, 2020

      • shivam-kapila
        iliekcomputers: My yerterday's PR is not deployed. Right?
      • 2020-05-20 14114, 2020

      • iliekcomputers
        No
      • 2020-05-20 14141, 2020

      • iliekcomputers
        The releases on github is the source pc truth for what's deployed
      • 2020-05-20 14147, 2020

      • iliekcomputers
        *of
      • 2020-05-20 14111, 2020

      • shivam-kapila
        Just wanted to be double sure. Thanks
      • 2020-05-20 14101, 2020

      • MajorLurker has quit
      • 2020-05-20 14104, 2020

      • reosarevok
        yvanzo: when you have some time, don't forget to look into https://tickets.metabrainz.org/browse/MBS-10835 :)
      • 2020-05-20 14105, 2020

      • BrainzBot
        MBS-10835: Disallow creating new accounts with an e-mail already in use
      • 2020-05-20 14111, 2020

      • reosarevok
        (and give your opinions)
      • 2020-05-20 14108, 2020

      • reosarevok
        bitmap: when you have some time, don't forget to look into https://github.com/metabrainz/musicbrainz-server/… :)
      • 2020-05-20 14135, 2020

      • reosarevok
        (and give your opinions)
      • 2020-05-20 14148, 2020

      • reosarevok
        Code review in general would be appreciated, since given you were busy with the PG12 things a lot of PRs have been reviewed by yvanzo already but not you yet
      • 2020-05-20 14133, 2020

      • somasis has quit
      • 2020-05-20 14106, 2020

      • ruaok
        moooin!
      • 2020-05-20 14138, 2020

      • ruaok
        even our table naming is meta. hatin' on the lovehate name. 🤣
      • 2020-05-20 14127, 2020

      • zas
        mooin
      • 2020-05-20 14155, 2020

      • yvanzo
        reosarevok: thanks for having summarized it, that was too blurry on Monday.
      • 2020-05-20 14101, 2020

      • reosarevok
        np
      • 2020-05-20 14112, 2020

      • reosarevok
        yvanzo: found what was causing the react-table issue, working on improving it
      • 2020-05-20 14123, 2020

      • yvanzo
        thanks
      • 2020-05-20 14103, 2020

      • reosarevok
        (the current fix should fix the crashes but makes the last column appear every time, so changing it to check whether the column should appear at the table level rather than inside the column itself)
      • 2020-05-20 14103, 2020

      • shivam-kapila
        ruaok: morning! Whats your opinion on the table name thing?
      • 2020-05-20 14139, 2020

      • ruaok
        pick whichever you like -- everything under discussion is fine with me. just not rating. 😜
      • 2020-05-20 14122, 2020

      • shivam-kapila
        lol. okay :)
      • 2020-05-20 14134, 2020

      • ruaok
        shivam-kapila: I added two new continuous aggregates to get the timestamps of the user. the DB time spent loading the data for the profile page is now 50-60ms. that works ok, methinks.
      • 2020-05-20 14128, 2020

      • shivam-kapila
        Thats a sweep drop. Awesome
      • 2020-05-20 14104, 2020

      • ruaok
        I'll keep working on that today and see if I can get a new import going sometime today
      • 2020-05-20 14128, 2020

      • zas
        guys, I think we may need to check paco hardware, yesterday, under load, it seems to me the cpu temperature went a bit high, which is usually an hint about defective cpu fan (not like it is the first one). Nothing urgent, but we'll have to stop it and let Hetzner techs have a look.
      • 2020-05-20 14106, 2020

      • ruaok
        k, I have nothing on paco...
      • 2020-05-20 14130, 2020

      • yvanzo
        there is postgres-williams on paco
      • 2020-05-20 14152, 2020

      • zas
        and redis instances
      • 2020-05-20 14130, 2020

      • reosarevok
      • 2020-05-20 14154, 2020

      • zas
        yvanzo: it seems the high load was coming from pg, do you know what it was doing? https://stats.metabrainz.org/d/000000048/hetzner-…
      • 2020-05-20 14130, 2020

      • yvanzo
        zas: yes, I did some intensive tests regarding the shm issue.
      • 2020-05-20 14141, 2020

      • shivam-kapila
        ruaok: The tests are also done. I will first open a PR update the SQL parts then add tests to the module PR.
      • 2020-05-20 14151, 2020

      • ruaok
        k
      • 2020-05-20 14147, 2020

      • reosarevok
        yvanzo: I think I'm done with that, do check if you agree with the changes though!
      • 2020-05-20 14149, 2020

      • zas
        ok, thanks, it means it is unlikely to happen on regurlar basis (not a cron job), I'll do in-depth checks to see if we need stop and hardware check paco
      • 2020-05-20 14152, 2020

      • reosarevok
        (re: react-table)
      • 2020-05-20 14101, 2020

      • Gazooo has quit
      • 2020-05-20 14103, 2020

      • yvanzo
        zas: I just checked the curves, it seems to better match json-dump cron job. Next time it run again is on Saturday.
      • 2020-05-20 14143, 2020

      • Gazooo joined the channel
      • 2020-05-20 14109, 2020

      • zas
        ok, then we'll see
      • 2020-05-20 14153, 2020

      • BrainzGit
        [listenbrainz-server] shivam-kapila opened pull request #868 (master…change-lovehate-to-feedback): Change lovehate to feedback https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-20 14137, 2020

      • shivam-kapila
        ruaok: I will push the tests after lunch :)
      • 2020-05-20 14138, 2020

      • reosarevok
        Well whoops
      • 2020-05-20 14141, 2020

      • reosarevok
      • 2020-05-20 14149, 2020

      • reosarevok
        yvanzo: ^ prod editing :/
      • 2020-05-20 14122, 2020

      • yvanzo
        yes, that's the issue requiring to stop db
      • 2020-05-20 14129, 2020

      • reosarevok
        A refresh worked, but yeah, we really need to improve this soon if it's not just reports
      • 2020-05-20 14158, 2020

      • zas
        yvanzo: https://stackoverflow.com/questions/55803015/goog… led me to another interesting page
      • 2020-05-20 14101, 2020

      • zas
      • 2020-05-20 14136, 2020

      • zas
        ^^we use SSDs, what are the current values for ‘random_page_cost’ and ‘seq_page_cost’ ?
      • 2020-05-20 14103, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1522 (master…MBS-10839): MBS-10839: Add merge button to recording list in artist overview https://github.com/metabrainz/musicbrainz-server/…
      • 2020-05-20 14105, 2020

      • BrainzBot
        MBS-10839: "Add selected recordings for merging" missing in standalone-only overview https://tickets.metabrainz.org/browse/MBS-10839
      • 2020-05-20 14126, 2020

      • yvanzo
        zas: thanks, that explains why this issue did not occur with 9.5.
      • 2020-05-20 14101, 2020

      • ephemer0l_ has quit
      • 2020-05-20 14156, 2020

      • yvanzo
        reosarevok: GH won't let me approve my own PR but I agree with the changes, thanks!
      • 2020-05-20 14104, 2020

      • reosarevok
        :) np!
      • 2020-05-20 14122, 2020

      • jmp_music joined the channel
      • 2020-05-20 14114, 2020

      • ruaok
        yvanzo: LB is getting these errors sporadically `ERROR: pgbouncer cannot connect to server `
      • 2020-05-20 14122, 2020

      • ruaok
        is this on your radar?
      • 2020-05-20 14115, 2020

      • yvanzo
        no
      • 2020-05-20 14140, 2020

      • yvanzo
        will check mbs logs too
      • 2020-05-20 14102, 2020

      • ruaok
        thx
      • 2020-05-20 14103, 2020

      • yvanzo
        ruaok: same error with MB, still current
      • 2020-05-20 14140, 2020

      • yvanzo
        zas: rand_page_cost is set to 1 already (for master/slave only), seq_page_cost uses default value 1.
      • 2020-05-20 14125, 2020

      • zas
        So, according to https://www.postgresql.org/docs/current/runtime-c…, since whole DB fits in memory, we're fine with those values
      • 2020-05-20 14117, 2020

      • zas
        so shm size errors are not related to this, pg still needs space for some queries
      • 2020-05-20 14104, 2020

      • Gore has quit
      • 2020-05-20 14109, 2020

      • zas
        btw, I'm referring to this tip: "Although the system will let you set random_page_cost to less than seq_page_cost, it is not physically sensible to do so. However, setting them equal makes sense if the database is entirely cached in RAM, since in that case there is no penalty for touching pages out of sequence. Also, in a heavily-cached database you should lower both values relative to the CPU parameters, since the cost
      • 2020-05-20 14110, 2020

      • zas
        of fetching a page already in RAM is much smaller than it would normally be."
      • 2020-05-20 14119, 2020

      • Gore joined the channel
      • 2020-05-20 14132, 2020

      • zas
      • 2020-05-20 14102, 2020

      • shivam-kapila
        ruaok: I have modified the module PR. Tests are pushed. Please have a look when free.
      • 2020-05-20 14122, 2020

      • shivam-kapila
        Also let me know when you are free to discuss the work for the next day
      • 2020-05-20 14146, 2020

      • pristine__
        Is there a way to change col type from uuid to jsonb? ( I guess no)
      • 2020-05-20 14151, 2020

      • alastairp
        in a single sql query? probably - you could turn it into a string, and then turn it into some json, and then change the type to jsonb
      • 2020-05-20 14102, 2020

      • alastairp
        is there data in the table that you want to keep?
      • 2020-05-20 14104, 2020

      • pristine__
        alastairp: no. No data in the table.
      • 2020-05-20 14116, 2020

      • pristine__
        I was thinking to drop the col
      • 2020-05-20 14110, 2020

      • pristine__
        And add with the new data type
      • 2020-05-20 14132, 2020

      • pristine__
        Is it a good way?
      • 2020-05-20 14123, 2020

      • BestSteve has quit
      • 2020-05-20 14152, 2020

      • BestSteve joined the channel
      • 2020-05-20 14103, 2020

      • ZaphodBeeblebrox
        reosarevok: wtf is that youtube XD
      • 2020-05-20 14158, 2020

      • ephemer0l_ joined the channel
      • 2020-05-20 14110, 2020

      • alastairp
        pristine__: sure, if you're completely sure that there's no data, you might be able to just change the type. Note that in postgres you can use `ALTER COLUMN column_name TYPE new_data_type USING expression;`, where USING allows you to cast the object to a new type. For example you may need to cast the uuid type to text or something for it to fit in the jsonb type
      • 2020-05-20 14101, 2020

      • pristine__
        Oh right. Earlier I was directly casting to jsonb.
      • 2020-05-20 14114, 2020

      • pristine__
        Thanks
      • 2020-05-20 14154, 2020

      • ishaanshah[m]
        are there any special steps need to be taken to get the db to work after pg update?
      • 2020-05-20 14102, 2020

      • ishaanshah[m]
        needed*
      • 2020-05-20 14114, 2020

      • shivam-kapila
        What error are you noticing?
      • 2020-05-20 14130, 2020

      • shivam-kapila
        try removing the listenbrainz_postgres volume
      • 2020-05-20 14136, 2020

      • ishaanshah[m]
        Temporary failure in name resolution
      • 2020-05-20 14144, 2020

      • shivam-kapila
        and then ./develop.sh build
      • 2020-05-20 14100, 2020

      • ishaanshah[m]
        Do I need to update the config file?
      • 2020-05-20 14109, 2020

      • shivam-kapila
        yesss
      • 2020-05-20 14123, 2020

      • shivam-kapila
        the urls were changed
      • 2020-05-20 14130, 2020

      • ishaanshah[m]
        Ah
      • 2020-05-20 14101, 2020

      • ishaanshah[m]
        > try removing the listenbrainz_postgres volume
      • 2020-05-20 14110, 2020

      • ishaanshah[m]
        This worked thanks
      • 2020-05-20 14111, 2020

      • shivam-kapila
        You can also remove the residual postgres 9.5.3 image if you like. Might free up some memory :)
      • 2020-05-20 14138, 2020

      • ishaanshah[m]
        Yep, will do
      • 2020-05-20 14147, 2020

      • reosarevok
        ZaphodBeeblebrox: it's some old Spanish song that became a meme because it had a rhythm that fit Beyonce's dance or something
      • 2020-05-20 14155, 2020

      • reosarevok
        I dunno, I just think it's a catchy song anyway :D
      • 2020-05-20 14124, 2020

      • ZaphodBeeblebrox
        yes. i cant get it outa my head :PPP
      • 2020-05-20 14147, 2020

      • ZaphodBeeblebrox
        but I hadnt seen either of them before os i at first hught that this was the video for the song :P
      • 2020-05-20 14129, 2020

      • Lotheric_ has quit